34602 2010-02-04 10:08:02 -0800 [GTK] Crashes when an invalid hostname is pre-fetched 2010-02-04 11:29:31 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC Linux RESOLVED FIXED http://bloggerimkino.ch/wordpress/ Gtk, Soup P2 Normal --- 1 gustavo webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 187847 0 gustavo 2010-02-04 10:08:02 -0800 This is the console output: (DumpRenderTree:19566): libsoup-CRITICAL **: soup_uri_host_hash: assertion `uri != NULL && uri->host != NULL' failed (DumpRenderTree:19566): libsoup-CRITICAL **: soup_uri_copy_host: assertion `uri != NULL' failed A snippet of the trace: #0 0x00007ffff14536a5 in ?? () from /usr/lib/libsoup-2.4.so.1 #1 0x00007ffff145373a in soup_session_prepare_for_uri () from /usr/lib/libsoup-2.4.so.1 #2 0x00007ffff6948ce9 in WebCore::prefetchDNS (hostname=...) at ../../WebCore/platform/network/soup/DNSSoup.cpp:46 #3 0x00007ffff637890d in WebCore::HTMLAnchorElement::parseMappedAttribute ( this=0xa391e0, attr=0xa49890) at ../../WebCore/html/HTMLAnchorElement.cpp:282 #4 0x00007ffff62bdac6 in WebCore::StyledElement::attributeChanged ( this=0xa391e0, attr=0xa49890, preserveDecls=false) at ../../WebCore/dom/StyledElement.cpp:190 The problem is SoupURI will give you a NULL URI if it is given an invalid URI, which is the case here. 187855 1 48155 gustavo 2010-02-04 10:38:06 -0800 Created attachment 48155 avoid crash 187857 2 webkit.review.bot 2010-02-04 10:43:02 -0800 Attachment 48155 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/network/soup/DNSSoup.cpp:41: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 187862 3 48155 xan.lopez 2010-02-04 10:56:25 -0800 Comment on attachment 48155 avoid crash I am Xan Lopez and I approve this patch. 187865 4 gustavo 2010-02-04 10:58:12 -0800 (In reply to comment #2) > Attachment 48155 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebCore/platform/network/soup/DNSSoup.cpp:41: Use 0 instead of NULL. > [readability/null] [4] > Total errors found: 1 False-positive, reported here: https://bugs.webkit.org/show_bug.cgi?id=34605 187874 5 48155 commit-queue 2010-02-04 11:29:25 -0800 Comment on attachment 48155 avoid crash Clearing flags on attachment: 48155 Committed r54359: <http://trac.webkit.org/changeset/54359> 187875 6 commit-queue 2010-02-04 11:29:31 -0800 All reviewed patches have been landed. Closing bug. 48155 2010-02-04 10:38:06 -0800 2010-02-04 11:29:24 -0800 avoid crash 0001-Null-check-the-SoupURI-when-prefetching-DNS.patch text/plain 4806 gustavo RnJvbSAxMjNiYjA1MWFiOWNmZjgwN2NjNWYxODI0N2E4MmRlYTFhODY0MmQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFRodSwgNCBGZWIgMjAxMCAxNjozNToxMSAtMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE51 bGwtY2hlY2sgdGhlIFNvdXBVUkkgd2hlbiBwcmVmZXRjaGluZyBETlMKCi0tLQogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysr KysKIC4uLi90ZXN0cy9taXNjL2Rucy1wcmVmZXRjaC1jb250cm9sLWV4cGVjdGVkLnR4dCAgIHwg ICAgMiArLQogLi4uL2h0dHAvdGVzdHMvbWlzYy9kbnMtcHJlZmV0Y2gtY29udHJvbC5odG1sICAg ICAgfCAgICA3ICsrKysrKysKIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvRE5TU291cC5jcHAgICAgICAgICAgfCAgIDEzICsrKysrKysrLS0tLS0KIDUgZmlsZXMg Y2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzNhODc3 ZC4uNmFkYjk0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAyLTA0ICBHdXN0YXZvIE5v cm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIENyYXNoZXMgd2hl biBhbiBpbnZhbGlkIGhvc3RuYW1lIGlzIHByZS1mZXRjaGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDYwMgorCisgICAgICAgICogaHR0cC90ZXN0 cy9taXNjL2Rucy1wcmVmZXRjaC1jb250cm9sLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRw L3Rlc3RzL21pc2MvZG5zLXByZWZldGNoLWNvbnRyb2wuaHRtbDogQWRkIGJyb2tlbiBob3N0bmFt ZSB0ZXN0IGNhc2UuCisKIDIwMTAtMDItMDQgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBbUXRdIGZhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWZyYW1l LWxpZmVjeWNsZS5odG1sIGZhaWxlZCBvbiBRdCBCb3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvbWlzYy9kbnMtcHJlZmV0Y2gtY29udHJvbC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZG5zLXByZWZldGNoLWNvbnRyb2wtZXhwZWN0ZWQudHh0 CmluZGV4IGY1YWI4YjEuLmYxNmFmYTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbWlzYy9kbnMtcHJlZmV0Y2gtY29udHJvbC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9taXNjL2Rucy1wcmVmZXRjaC1jb250cm9sLWV4cGVjdGVkLnR4dApAQCAt Miw3ICsyLDcgQEAgVGhpcyBpcyBhIHRlc3Qgb2YgRE5TIHByZWZldGNoIGNvbnRyb2wuIEl0J3Mg Y29uc2lkZXJlZCBhIHBhc3MgaWYgaXQgZG9lc24ndCBjcmEKIAogVGhlIGZvbGxvd2luZyBmcmFt ZXMgY29udGFpbiBsaW5rcyB0aGF0IGFyZSBleHBlY3RlZCB0byB0cmlnZ2VyIGEgRE5TIHByZWZl dGNoLgogCi0gICAgICAgICAgICAKKyAgICAgICAgICAgICAgCiBUaGUgZm9sbG93aW5nIGZyYW1l cyBjb250YWluIGxpbmtzIHRoYXQgYXJlIG5vdCBleHBlY3RlZCB0byBjYXVzZSBhIEROUyBwcmVm ZXRjaC4KIAogICAgICAgICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9t aXNjL2Rucy1wcmVmZXRjaC1jb250cm9sLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21p c2MvZG5zLXByZWZldGNoLWNvbnRyb2wuaHRtbAppbmRleCBiMjRiNDc3Li5hZDQyYzQyIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZG5zLXByZWZldGNoLWNvbnRyb2wu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZG5zLXByZWZldGNoLWNvbnRy b2wuaHRtbApAQCAtMjQsNiArMjQsMTIgQEAKICAgICAgICAgY29udGVudHMgKz0gIjxhIGhyZWY9 JyIgKyBzY2hlbWUgKyAiLy8iICsgaG9zdCArICInPiIgKyBob3N0ICsgIjwvYT4iOwogICAgICAg ICBlbWl0RnJhbWVXaXRoQ29udGVudHMoY29udGVudHMpOwogICAgIH0KKyAgICBmdW5jdGlvbiBl bWl0RnJhbWVGb3JIb3N0KGhvc3QpIAorICAgIHsKKyAgICAgICAgdmFyIGNvbnRlbnRzID0gIjxt ZXRhIGh0dHAtZXF1aXY9J3gtZG5zLXByZWZldGNoLWNvbnRyb2wnIGNvbnRlbnQ9J29uJz4iOwor ICAgICAgICBjb250ZW50cyArPSAiPGEgaHJlZj0naHR0cDoiICsgIi8vIiArIGhvc3QgKyAiJz4i ICsgaG9zdCArICI8L2E+IjsKKyAgICAgICAgZW1pdEZyYW1lV2l0aENvbnRlbnRzKGNvbnRlbnRz KTsKKyAgICB9CiAgICAgZnVuY3Rpb24gZW1pdEZyYW1lRm9yTWFudWFsRE5TUHJlZmV0Y2goZG5z UHJlZmV0Y2hDb250cm9sKSAKICAgICB7CiAgICAgICAgIHZhciBob3N0ID0gZ2V0UmFuZG9tSG9z dCgpOwpAQCAtNDYsNiArNTIsNyBAQCBhIG1hbnVhbCB0ZXN0IG9mIEROUyBwcmVmZXRjaCB1c2lu ZyBhIG5ldHdvcmtpbmcgbW9uaXRvcmluZyB0b29sLjwvcD4KICAgPHNjcmlwdD5lbWl0RnJhbWVG b3JTY2hlbWUoImh0dHA6Iik8L3NjcmlwdD4KICAgPHNjcmlwdD5lbWl0RnJhbWVGb3JTY2hlbWUo Imh0dHBzOiIpPC9zY3JpcHQ+CiAgIDxzY3JpcHQ+ZW1pdEZyYW1lRm9yU2NoZW1lKCJmdHA6Iik8 L3NjcmlwdD4KKyAgPHNjcmlwdD5lbWl0RnJhbWVGb3JIb3N0KCIlIik8L3NjcmlwdD4KICAgPGlm cmFtZSBzcmM9InJlc291cmNlcy9kbnMtcHJlZmV0Y2gtY29udHJvbC5waHAiPjwvaWZyYW1lPgog ICA8aWZyYW1lIHNyYz0icmVzb3VyY2VzL2Rucy1wcmVmZXRjaC1jb250cm9sLnBocD92YWx1ZT1v biI+PC9pZnJhbWU+CiAgIDxpZnJhbWUgc3JjPSJodHRwczovLzEyNy4wLjAuMTo4NDQzL21pc2Mv cmVzb3VyY2VzL2Rucy1wcmVmZXRjaC1jb250cm9sLnBocD92YWx1ZT1vbiI+PC9pZnJhbWU+CmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGYz MDE1YTAuLjRhNTBkMjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDQgIEd1c3Rhdm8gTm9yb25o YSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ3Jhc2hlcyB3aGVuIGFu IGludmFsaWQgaG9zdG5hbWUgaXMgcHJlLWZldGNoZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NjAyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvRE5TU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwcmVmZXRjaEROUyk6IE5V TEwtY2hlY2sgdGhlIFNvdXBVUkkgdGhhdCBpcyBjcmVhdGVkCisgICAgICAgIGZyb20gdGhlIGhv c3RuYW1lOyB0aGF0IHdpbGwgaGFwcGVuIGZvciBpbnZhbGlkIGhvc3RuYW1lcy4KKwogMjAxMC0w Mi0wNCAgTm8nYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5YXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9ETlNTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL0ROU1NvdXAuY3BwCmluZGV4IGNlNTUxNDMuLmRmMGQyMGEgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0ROU1NvdXAuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL0ROU1NvdXAuY3BwCkBAIC0yOCwxOCArMjgsMjEgQEAKICNpbmNsdWRl ICJETlMuaCIKIAogI2luY2x1ZGUgIkNTdHJpbmcuaCIKKyNpbmNsdWRlICJHT3duUHRyR3RrLmgi CiAjaW5jbHVkZSAiUmVzb3VyY2VIYW5kbGUuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2 b2lkIHByZWZldGNoRE5TKGNvbnN0IFN0cmluZyYgaG9zdG5hbWUpCiB7Ci0gICAgI2lmZGVmIEhB VkVfTElCU09VUF8yXzI5XzMKKyNpZmRlZiBIQVZFX0xJQlNPVVBfMl8yOV8zCiAgICAgU3RyaW5n IHVyaSA9ICJodHRwOi8vIitob3N0bmFtZTsKLSAgICBTb3VwVVJJKiBzb3VwVXJpID0gc291cF91 cmlfbmV3KHVyaS51dGY4KCkuZGF0YSgpKTsKLSAgICBzb3VwX3Nlc3Npb25fcHJlcGFyZV9mb3Jf dXJpKFJlc291cmNlSGFuZGxlOjpkZWZhdWx0U2Vzc2lvbigpLCBzb3VwVXJpKTsKLSAgICBzb3Vw X3VyaV9mcmVlKHNvdXBVcmkpOwotICAgICNlbmRpZgorICAgIEdPd25QdHI8U291cFVSST4gc291 cFVSSShzb3VwX3VyaV9uZXcodXJpLnV0ZjgoKS5kYXRhKCkpKTsKKyAgICAvLyBXZSBtYXkgZ2V0 IGludmFsaWQgaG9zdG5hbWVzLCBzbyBOVUxMLWNoZWNrIGhlcmUuCisgICAgaWYgKCFzb3VwVVJJ KQorICAgICAgICByZXR1cm47CisgICAgc291cF9zZXNzaW9uX3ByZXBhcmVfZm9yX3VyaShSZXNv dXJjZUhhbmRsZTo6ZGVmYXVsdFNlc3Npb24oKSwgc291cFVSSS5nZXQoKSk7CisjZW5kaWYKIH0K IAogfQotLSAKMS42LjYuMQoK