34597 2010-02-04 08:57:45 -0800 [Qt] Build break in QtWebkit on Symbian 2010-02-05 06:10:38 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Critical --- 0 s.mathur webkit-unassigned hausmann yael oldest_to_newest 187823 0 s.mathur 2010-02-04 08:57:45 -0800 r53955 causes build break in QtWebkit/Symbian. Notice the change from OS(SYMBIAN) to PLATFORM(SYMBIAN). It seems it is unrelated to the GTK2-related theme of Bug 18831 : https://bugs.webkit.org/attachment.cgi?id=47166&action=diff#a/WebCore/plugins/PluginView.h_sec3 Error message is for WebCore\plugins\symbian\PluginViewSymbian.cpp Error: #20: identifier "setNPWindowIfNeeded" is undefined setNPWindowIfNeeded(); 187965 1 48177 s.mathur 2010-02-04 15:27:48 -0800 Created attachment 48177 Fixing erroneous removal of OS(SYMBIAN) Fixing erroneous removal of OS(SYMBIAN). 188006 2 48177 ariya.hidayat 2010-02-04 16:43:24 -0800 Comment on attachment 48177 Fixing erroneous removal of OS(SYMBIAN) LGTM. 188124 3 48177 hausmann 2010-02-05 02:28:52 -0800 Comment on attachment 48177 Fixing erroneous removal of OS(SYMBIAN) I agree that this is a no-brainer :) > + No new tests. (OOPS!) But please remove this line when landing :) 188169 4 hausmann 2010-02-05 06:10:38 -0800 Committed r54422: <http://trac.webkit.org/changeset/54422> 48177 2010-02-04 15:27:48 -0800 2010-02-05 02:28:52 -0800 Fixing erroneous removal of OS(SYMBIAN) 34597.patch text/plain 978 s.mathur SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDU0Mzc1KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMi0wNCAgU2lkZGhhcnRoIE1hdGh1ciAgPHNpZGRoYXJ0 aC5tYXRodXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gQnVpbGQgYnJlYWsgaW4gUXRXZWJraXQgb24gU3ltYmlhbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ1OTcKKworICAg ICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmll dy5oOgorCiAyMDEwLTAyLTA0ICBDaHJpc3RpYW4gRHl3YW4gIDxjaHJpc3RpYW5AdHdvdG9hc3Rz LmRlPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KSW5kZXg6IFdlYkNvcmUvcGx1 Z2lucy9QbHVnaW5WaWV3LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2lu Vmlldy5oCShyZXZpc2lvbiA1NDI0MSkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgJ KHdvcmtpbmcgY29weSkKQEAgLTMyNiw3ICszMjYsNyBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAK LSNpZiBkZWZpbmVkKFhQX1VOSVgpIHx8IFBMQVRGT1JNKFNZTUJJQU4pCisjaWYgZGVmaW5lZChY UF9VTklYKSB8fCBPUyhTWU1CSUFOKQogICAgICAgICB2b2lkIHNldE5QV2luZG93SWZOZWVkZWQo KTsKICNlbGlmIGRlZmluZWQoWFBfTUFDT1NYKQogICAgICAgICBOUF9DR0NvbnRleHQgbV9ucENn Q29udGV4dDsK