34567 2010-02-04 02:03:16 -0800 [Chromium][Mac] Clean up special utf-8 tag in clipboard code 2010-02-08 18:48:55 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kinuko webkit-unassigned avi commit-queue oldest_to_newest 187688 0 kinuko 2010-02-04 02:03:16 -0800 On Mac we need to explicitly specify charset=utf-8 when exporting HTML for the clipboard or drag/drop. To work around this we prepend special meta tags to force utf-8 charset. see https://bugs.webkit.org/show_bug.cgi?id=27262 (Safari doesn't have this problem because it exports web pages as WebArchive format.) Because this can happen in other places (like omnibox) in chromium Mac, I put a change in chromium code rather than having the workaround in WebKit port: http://src.chromium.org/viewvc/chrome/trunk/src/app/clipboard/clipboard_mac.mm?r1=37955&r2=37954&pathrev=37955 So that we no longer need the workaround in WebKit separately. Let's clean up them. 188070 1 48199 kinuko 2010-02-04 22:02:27 -0800 Created attachment 48199 Patch 188851 2 48199 commit-queue 2010-02-08 18:48:50 -0800 Comment on attachment 48199 Patch Clearing flags on attachment: 48199 Committed r54523: <http://trac.webkit.org/changeset/54523> 188852 3 commit-queue 2010-02-08 18:48:55 -0800 All reviewed patches have been landed. Closing bug. 48199 2010-02-04 22:02:27 -0800 2010-02-08 18:48:49 -0800 Patch bug-34567-20100205150225.patch text/plain 3070 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGY5NWFmYS4uNjljOWE4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wMi0wNCAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHNwZWNpYWwgdXRmLTggdGFnIGZyb20gQ2hyb21pdW0g Y2lscGJvYXJkIGNvZGUgYmVjYXVzZQorICAgICAgICB3ZSBub3cgaGF2ZSB0aGUgY29ycmVzcG9u ZGluZyBjb2RlIGluIGdlbmVyaWMgY2xpcGJvYXJkIGZyYW1ld29yaworICAgICAgICBjb2RlIGlu IGNocm9taXVtIChzaW5jZSBpdCdzIG5lZWRlZCBieSBvdGhlciBwbGFjZXMgdGhhbiBpbiBXZWIK KyAgICAgICAgcGFnZSByZW5kZXJpbmcpIGFuZCBubyBsb25nZXIgbmVlZCB0aGUgc2VwYXJhdGUg d29ya2Fyb3VuZCBjb2RlIGluCisgICAgICAgIFdlYktpdC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NTY3CisKKyAgICAgICAgVGVzdDogKGZvciBy ZWdyZXNzaW9uKSBlZGl0aW5nL3Bhc3RlYm9hcmQKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL0NsaXBib2FyZENocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZENo cm9taXVtOjp3cml0ZVJhbmdlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9QYXN0ZWJv YXJkQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6d3JpdGVTZWxl Y3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6ZG9jdW1lbnRGcmFnbWVudCk6 CisKIDIwMTAtMDItMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCmluZGV4IDMyZjdkNTAuLjZhNDYzYTEg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0u Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3Bw CkBAIC0zNjMsOSArMzYzLDYgQEAgdm9pZCBDbGlwYm9hcmRDaHJvbWl1bTo6d3JpdGVSYW5nZShS YW5nZSogc2VsZWN0ZWRSYW5nZSwgRnJhbWUqIGZyYW1lKQogCiAgICAgbV9kYXRhT2JqZWN0LT50 ZXh0SHRtbCA9IGNyZWF0ZU1hcmt1cChzZWxlY3RlZFJhbmdlLCAwLAogICAgICAgICBBbm5vdGF0 ZUZvckludGVyY2hhbmdlKTsKLSNpZiBPUyhEQVJXSU4pCi0gICAgbV9kYXRhT2JqZWN0LT50ZXh0 SHRtbCA9IFN0cmluZygiPG1ldGEgY2hhcnNldD0ndXRmLTgnIGlkPSd3ZWJraXQtaW50ZXJjaGFu Z2UtY2hhcnNldCc+IikgKyBtX2RhdGFPYmplY3QtPnRleHRIdG1sOwotI2VuZGlmCiAgICAgbV9k YXRhT2JqZWN0LT5odG1sQmFzZVVybCA9IGZyYW1lLT5kb2N1bWVudCgpLT51cmwoKTsKIAogICAg IFN0cmluZyBzdHIgPSBmcmFtZS0+c2VsZWN0ZWRUZXh0KCk7CmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRDaHJvbWl1bS5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRDaHJvbWl1bS5jcHAKaW5kZXggM2IzYWVhNi4uZDRmOWEy NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QYXN0ZWJvYXJkQ2hyb21p dW0uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGFzdGVib2FyZENocm9taXVt LmNwcApAQCAtODIsOSArODIsNiBAQCB2b2lkIFBhc3RlYm9hcmQ6OnNldFNlbGVjdGlvbk1vZGUo Ym9vbCBzZWxlY3Rpb25Nb2RlKQogdm9pZCBQYXN0ZWJvYXJkOjp3cml0ZVNlbGVjdGlvbihSYW5n ZSogc2VsZWN0ZWRSYW5nZSwgYm9vbCBjYW5TbWFydENvcHlPckRlbGV0ZSwgRnJhbWUqIGZyYW1l KQogewogICAgIFN0cmluZyBodG1sID0gY3JlYXRlTWFya3VwKHNlbGVjdGVkUmFuZ2UsIDAsIEFu bm90YXRlRm9ySW50ZXJjaGFuZ2UpOwotI2lmIE9TKERBUldJTikKLSAgICBodG1sID0gU3RyaW5n KCI8bWV0YSBjaGFyc2V0PSd1dGYtOCcgaWQ9J3dlYmtpdC1pbnRlcmNoYW5nZS1jaGFyc2V0Jz4i KSArIGh0bWw7Ci0jZW5kaWYKICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKICAgICBLVVJMIHVy bCA9IHNlbGVjdGVkUmFuZ2UtPnN0YXJ0Q29udGFpbmVyKGVjKS0+ZG9jdW1lbnQoKS0+dXJsKCk7 CiAgICAgU3RyaW5nIHBsYWluVGV4dCA9IGZyYW1lLT5zZWxlY3RlZFRleHQoKTsKQEAgLTE3MCwx MSArMTY3LDYgQEAgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBQYXN0ZWJvYXJkOjpkb2N1 bWVudEZyYWdtZW50KEZyYW1lKiBmcmFtZSwgUGFzc1JlZlAKICAgICAgICAgU3RyaW5nIG1hcmt1 cDsKICAgICAgICAgS1VSTCBzcmNVUkw7CiAgICAgICAgIENocm9taXVtQnJpZGdlOjpjbGlwYm9h cmRSZWFkSFRNTChidWZmZXIsICZtYXJrdXAsICZzcmNVUkwpOwotI2lmIE9TKERBUldJTikKLSAg ICAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIGZvcmNlVXRmOFN0cmluZywg KCI8bWV0YSBjaGFyc2V0PSd1dGYtOCcgaWQ9J3dlYmtpdC1pbnRlcmNoYW5nZS1jaGFyc2V0Jz4i KSk7Ci0gICAgICAgIGlmIChtYXJrdXAuc3RhcnRzV2l0aChmb3JjZVV0ZjhTdHJpbmcpKQotICAg ICAgICAgICAgbWFya3VwID0gbWFya3VwLnN1YnN0cmluZyhmb3JjZVV0ZjhTdHJpbmcubGVuZ3Ro KCkpOwotI2VuZGlmCiAKICAgICAgICAgUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50 ID0KICAgICAgICAgICAgIGNyZWF0ZUZyYWdtZW50RnJvbU1hcmt1cChmcmFtZS0+ZG9jdW1lbnQo KSwgbWFya3VwLCBzcmNVUkwsIEZyYWdtZW50U2NyaXB0aW5nTm90QWxsb3dlZCk7Cg==