34563 2010-02-03 23:23:06 -0800 websocket/tests/close-on-unload.html failed on Mac Tiger 2010-02-04 21:59:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.3 RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned oldest_to_newest 187644 0 ukai 2010-02-03 23:23:06 -0800 since r54319, websocket/tests/close-on-unload.html failed on Mac Tiger. This is because python is old on the platform (no set() available) http://build.webkit.org/results/Tiger%20Intel%20Release/r54323%20(8478)/pywebsocket_log.txt 187677 1 48115 ukai 2010-02-04 01:18:58 -0800 Created attachment 48115 Patch 187730 2 48115 hamaji 2010-02-04 04:07:31 -0800 Comment on attachment 48115 Patch Looks good except for a few nitpicks. > -connections = set() > +connections = {} I'd comment why we don't use set() here so people don't make this fail again. > + for ws in connections.keys(): I slightly prefer iterkeys() but it's OK as is. 188069 3 ukai 2010-02-04 21:59:57 -0800 Committed r54404: <http://trac.webkit.org/changeset/54404> 48115 2010-02-04 01:18:58 -0800 2010-02-04 04:07:45 -0800 Patch bug-34563-20100204181856.patch text/plain 2259 ukai ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MjQ1NGI0Li5mM2NiOTNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDIt MDQgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Vic29ja2V0L3Rlc3RzL2Nsb3NlLW9u LXVubG9hZC5odG1sIGZhaWxlZCBvbiBNYWMgVGlnZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NTYzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMt dGlnZXIvU2tpcHBlZDogcmVtb3ZlIHdlYnNvY2tldC90ZXN0cy9jbG9zZS1vbi11bmxvYWQqLmh0 bWwKKyAgICAgICAgKiB3ZWJzb2NrZXQvdGVzdHMvY2xvc2Utb24tdW5sb2FkX3dzaC5weTogdXNl IGRpY3QgaW5zdGVhZCBvZiBzZXQuCisKIDIwMTAtMDItMDMgIEZ1bWl0b3NoaSBVa2FpICA8dWth aUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBmaXguCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtdGlnZXIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy10aWdlci9Ta2lwcGVkCmluZGV4IGRhMWRhMzguLjQ4ODMzYmUgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkCkBAIC0xMDYsOCArMTA2LDMgQEAgc3ZnL2N1c3Rv bS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnCiAjIEZhaWxzIG9uIE1hYwogIyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQzMzEKIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8t cmVmZXJlci5odG1sCi0KLSMgRmFpbHMgb24gTWFjIFRpZ2VyCi0jIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDU2Mwotd2Vic29ja2V0L3Rlc3RzL2Nsb3NlLW9uLXVu bG9hZC5odG1sCi13ZWJzb2NrZXQvdGVzdHMvY2xvc2Utb24tbmF2aWdhdGUtbmV3LWxvY2F0aW9u Lmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9jbG9zZS1vbi11 bmxvYWRfd3NoLnB5IGIvTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL2Nsb3NlLW9uLXVubG9h ZF93c2gucHkKaW5kZXggZTg5MzlmYy4uNGYyYTkyOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv d2Vic29ja2V0L3Rlc3RzL2Nsb3NlLW9uLXVubG9hZF93c2gucHkKKysrIGIvTGF5b3V0VGVzdHMv d2Vic29ja2V0L3Rlc3RzL2Nsb3NlLW9uLXVubG9hZF93c2gucHkKQEAgLTMwLDcgKzMwLDcgQEAK IAogZnJvbSBtb2RfcHl3ZWJzb2NrZXQgaW1wb3J0IG1zZ3V0aWwKIAotY29ubmVjdGlvbnMgPSBz ZXQoKQorY29ubmVjdGlvbnMgPSB7fQogCiBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hh a2UocmVxdWVzdCk6CiAgICAgcGFzcyAgIyBBbHdheXMgYWNjZXB0LgpAQCAtMzgsNyArMzgsNyBA QCBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVxdWVzdCk6CiAKIGRlZiB3ZWJf c29ja2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6CiAgICAgZ2xvYmFsIGNvbm5lY3Rpb25zCi0g ICAgY29ubmVjdGlvbnMuYWRkKHJlcXVlc3QpCisgICAgY29ubmVjdGlvbnNbcmVxdWVzdF0gPSBU cnVlCiAgICAgc29ja2V0TmFtZSA9IE5vbmUKICAgICB0cnk6CiAgICAgICAgIHNvY2tldE5hbWUg PSBtc2d1dGlsLnJlY2VpdmVfbWVzc2FnZShyZXF1ZXN0KQpAQCAtNDgsNyArNDgsNyBAQCBkZWYg d2ViX3NvY2tldF90cmFuc2Zlcl9kYXRhKHJlcXVlc3QpOgogICAgICAgICBzb2NrZXROYW1lID0g c29ja2V0TmFtZSArICc6IHJlY2VpdmUgbmV4dCBtZXNzYWdlJwogICAgIGZpbmFsbHk6CiAgICAg ICAgICMgcmVxdWVzdCBpcyBjbG9zZWQuIG5vdGlmeSB0aGlzIHNvY2tldE5hbWUgdG8gb3RoZXIg d2ViIHNvY2tldHMuCi0gICAgICAgIGNvbm5lY3Rpb25zLnJlbW92ZShyZXF1ZXN0KQotICAgICAg ICBmb3Igd3MgaW4gY29ubmVjdGlvbnM6CisgICAgICAgIGRlbCBjb25uZWN0aW9uc1tyZXF1ZXN0 XQorICAgICAgICBmb3Igd3MgaW4gY29ubmVjdGlvbnMua2V5cygpOgogICAgICAgICAgICAgbXNn dXRpbC5zZW5kX21lc3NhZ2Uod3MsIHNvY2tldE5hbWUpCiAK