34559 2010-02-03 21:28:01 -0800 [Qt] Unnecessary QBrush construction for doing a solid fill 2010-02-04 09:44:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 ariya.hidayat webkit-unassigned oldest_to_newest 187623 0 48097 ariya.hidayat 2010-02-03 21:28:01 -0800 Created attachment 48097 Patch Setting the fill to a solid color forces a construction of QBrush (which is expensive). 187628 1 48101 ariya.hidayat 2010-02-03 21:38:34 -0800 Created attachment 48101 Patch 187700 2 48101 hausmann 2010-02-04 02:35:17 -0800 Comment on attachment 48101 Patch Good idea! :) 187835 3 ariya.hidayat 2010-02-04 09:44:06 -0800 Manually committed r54347: in http://trac.webkit.org/changeset/54347 48097 2010-02-03 21:28:01 -0800 2010-02-03 21:38:31 -0800 Patch 20100203212800.patch text/plain 613 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0 UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5j cHAKaW5kZXggOTA0NjQ0OS4uOTM4ZDdiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKQEAgLTEyNzAsNyArMTI3MCw4IEBAIHZv aWQgR3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybUZpbGxDb2xvcihjb25zdCBDb2xvciYgY29s b3IsIENvbG9yU3BhY2UgY29sb3JTCiB7CiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKICAg ICAgICAgcmV0dXJuOwotICAgIG1fZGF0YS0+cCgpLT5zZXRCcnVzaChRQnJ1c2goY29sb3IpKTsK KyAgICBtX2RhdGEtPnNvbGlkQ29sb3Iuc2V0Q29sb3IoY29sb3IpOworICAgIG1fZGF0YS0+cCgp LT5zZXRCcnVzaChtX2RhdGEtPnNvbGlkQ29sb3IpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6c2V0UGxhdGZvcm1TaG91bGRBbnRpYWxpYXMoYm9vbCBlbmFibGUpCg== 48101 2010-02-03 21:38:34 -0800 2010-02-04 02:35:17 -0800 Patch bug-34559-20100203213833.patch text/plain 1325 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGY5NWFmYS4uZDVmYTkyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMi0wMyAgQXJpeWEgSGlkYXlh dCAgPGFyaXlhLmhpZGF5YXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVW5uZWNlc3NhcnkgUUJydXNoIGNvbnN0cnVjdGlv biBmb3IgZG9pbmcgYSBzb2xpZCBmaWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNDU1OQorCisgICAgICAgIFVzZSB0aGUgc2ltaWxhciB0cmljayBs aWtlIHIzNzQyMSwgaS5lLiB1c2UgdGhlIHNwZWNpYWwgYnJ1c2ggZm9yCisgICAgICAgIHNvbGlk IGNvbG9yIHRvIGF2b2lkIGNyZWF0ZSBRQnJ1c2ggYWdhaW4gYW5kIGFnYWluLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybUZpbGxDb2xvcik6CisKIDIwMTAt MDItMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCmluZGV4IDkwNDY0NDkuLjkzOGQ3YjIgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQu Y3BwCkBAIC0xMjcwLDcgKzEyNzAsOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZv cm1GaWxsQ29sb3IoY29uc3QgQ29sb3ImIGNvbG9yLCBDb2xvclNwYWNlIGNvbG9yUwogewogICAg IGlmIChwYWludGluZ0Rpc2FibGVkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICBtX2RhdGEtPnAo KS0+c2V0QnJ1c2goUUJydXNoKGNvbG9yKSk7CisgICAgbV9kYXRhLT5zb2xpZENvbG9yLnNldENv bG9yKGNvbG9yKTsKKyAgICBtX2RhdGEtPnAoKS0+c2V0QnJ1c2gobV9kYXRhLT5zb2xpZENvbG9y KTsKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldFBsYXRmb3JtU2hvdWxkQW50aWFsaWFz KGJvb2wgZW5hYmxlKQo=