34542 2010-02-03 15:17:45 -0800 wx port: client cannot interrupt or modify new windows 2010-02-03 16:16:12 -0800 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned kevino webkit.review.bot oldest_to_newest 187518 0 48069 kevinwatters 2010-02-03 15:17:45 -0800 Created attachment 48069 fires a wx event in createWindow ChomeClient's createWindow has a FIXME about firing an veto-able event. 187521 1 webkit.review.bot 2010-02-03 15:24:12 -0800 Attachment 48069 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/wx/WebView.h:307: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 187532 2 kevino 2010-02-03 16:16:12 -0800 Landed in r54309, thanks! 48069 2010-02-03 15:17:45 -0800 2010-02-03 15:26:44 -0800 fires a wx event in createWindow windowfeatures.patch text/plain 4891 kevinwatters SW5kZXg6IFdlYktpdC93eC9XZWJLaXRTdXBwb3J0L0Nocm9tZUNsaWVudFd4LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRXeC5jcHAJKHJldmlz aW9uIDU0MjkxKQorKysgV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvQ2hyb21lQ2xpZW50V3guY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSAiRnJhbWVMb2FkUmVx dWVzdC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1T dHJpbmcuaCIKKyNpbmNsdWRlICJXaW5kb3dGZWF0dXJlcy5oIgogCiAjaW5jbHVkZSA8c3RkaW8u aD4KIApAQCAtNTMsNiArNTQsMjEgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCit3eFdlYktp dFdpbmRvd0ZlYXR1cmVzIHdrRmVhdHVyZXNmb3JXaW5kb3dGZWF0dXJlcyhjb25zdCBXaW5kb3dG ZWF0dXJlcyYgZmVhdHVyZXMpCit7CisgICAgd3hXZWJLaXRXaW5kb3dGZWF0dXJlcyB3a0ZlYXR1 cmVzOworICAgIHdrRmVhdHVyZXMubWVudUJhclZpc2libGUgPSBmZWF0dXJlcy5tZW51QmFyVmlz aWJsZTsKKyAgICB3a0ZlYXR1cmVzLnN0YXR1c0JhclZpc2libGUgPSBmZWF0dXJlcy5zdGF0dXNC YXJWaXNpYmxlOworICAgIHdrRmVhdHVyZXMudG9vbEJhclZpc2libGUgPSBmZWF0dXJlcy50b29s QmFyVmlzaWJsZTsKKyAgICB3a0ZlYXR1cmVzLmxvY2F0aW9uQmFyVmlzaWJsZSA9IGZlYXR1cmVz LmxvY2F0aW9uQmFyVmlzaWJsZTsKKyAgICB3a0ZlYXR1cmVzLnNjcm9sbGJhcnNWaXNpYmxlID0g ZmVhdHVyZXMuc2Nyb2xsYmFyc1Zpc2libGU7CisgICAgd2tGZWF0dXJlcy5yZXNpemFibGUgPSBm ZWF0dXJlcy5yZXNpemFibGU7CisgICAgd2tGZWF0dXJlcy5mdWxsc2NyZWVuID0gZmVhdHVyZXMu ZnVsbHNjcmVlbjsKKyAgICB3a0ZlYXR1cmVzLmRpYWxvZyA9IGZlYXR1cmVzLmRpYWxvZzsKKyAg ICAKKyAgICByZXR1cm4gd2tGZWF0dXJlczsKK30KKwogQ2hyb21lQ2xpZW50V3g6OkNocm9tZUNs aWVudFd4KHd4V2ViVmlldyogd2ViVmlldykKIHsKICAgICBtX3dlYlZpZXcgPSB3ZWJWaWV3OwpA QCAtMTE1LDIyICsxMzEsMjEgQEAKIHsKIH0KIAotUGFnZSogQ2hyb21lQ2xpZW50V3g6OmNyZWF0 ZVdpbmRvdyhGcmFtZSosIGNvbnN0IEZyYW1lTG9hZFJlcXVlc3QmIHJlcXVlc3QsIGNvbnN0IFdp bmRvd0ZlYXR1cmVzJikKK1BhZ2UqIENocm9tZUNsaWVudFd4OjpjcmVhdGVXaW5kb3coRnJhbWUq LCBjb25zdCBGcmFtZUxvYWRSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBXaW5kb3dGZWF0dXJlcyYg ZmVhdHVyZXMpCiB7Ci0KLSAgICAvLyBGSVhNRTogQ3JlYXRlIGEgRVZUX1dFQktJVF9ORVdfV0lO RE9XIGV2ZW50LCBhbmQgb25seSBydW4gdGhpcyBjb2RlCi0gICAgLy8gd2hlbiB0aGF0IGV2ZW50 IGlzIG5vdCBoYW5kbGVkLgotICAgIAogICAgIFBhZ2UqIG15UGFnZSA9IDA7Ci0gICAgd3hXZWJC cm93c2VyU2hlbGwqIG5ld0ZyYW1lID0gbmV3IHd4V2ViQnJvd3NlclNoZWxsKHd4VGhlQXBwLT5H ZXRBcHBOYW1lKCkpOworICAgIHd4V2ViVmlld05ld1dpbmRvd0V2ZW50IHdrRXZlbnQobV93ZWJW aWV3KTsKKyAgICB3a0V2ZW50LlNldFVSTChyZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLnVybCgp LnN0cmluZygpKTsKICAgICAKLSAgICBpZiAobmV3RnJhbWUtPndlYnZpZXcpIHsKLSAgICAgICAg bmV3RnJhbWUtPndlYnZpZXctPkxvYWRVUkwocmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS51cmwo KS5zdHJpbmcoKSk7Ci0gICAgICAgIG5ld0ZyYW1lLT5TaG93KHRydWUpOwotCi0gICAgICAgIFdl YlZpZXdQcml2YXRlKiBpbXBsID0gbmV3RnJhbWUtPndlYnZpZXctPm1faW1wbDsKLSAgICAgICAg aWYgKGltcGwpCi0gICAgICAgICAgICBteVBhZ2UgPSBpbXBsLT5wYWdlOworICAgIHd4V2ViS2l0 V2luZG93RmVhdHVyZXMgd2tGZWF0dXJlcyA9IHdrRmVhdHVyZXNmb3JXaW5kb3dGZWF0dXJlcyhm ZWF0dXJlcyk7CisgICAgd2tFdmVudC5TZXRXaW5kb3dGZWF0dXJlcyh3a0ZlYXR1cmVzKTsKKyAg ICAKKyAgICBpZiAobV93ZWJWaWV3LT5HZXRFdmVudEhhbmRsZXIoKS0+UHJvY2Vzc0V2ZW50KHdr RXZlbnQpKSB7CisgICAgICAgIGlmICh3eFdlYlZpZXcqIHdlYlZpZXcgPSB3a0V2ZW50LkdldFdl YlZpZXcoKSkgeworICAgICAgICAgICAgV2ViVmlld1ByaXZhdGUqIGltcGwgPSB3ZWJWaWV3LT5t X2ltcGw7CisgICAgICAgICAgICBpZiAoaW1wbCkKKyAgICAgICAgICAgICAgICBteVBhZ2UgPSBp bXBsLT5wYWdlOworICAgICAgICB9CiAgICAgfQogICAgIAogICAgIHJldHVybiBteVBhZ2U7Cklu ZGV4OiBXZWJLaXQvd3gvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93eC9DaGFuZ2VM b2cJKHJldmlzaW9uIDU0MjkyKQorKysgV2ViS2l0L3d4L0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTAyLTAzICBLZXZpbiBXYXR0ZXJzICA8a2V2aW53YXR0 ZXJzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgd3hXZWJLaXRXaW5kb3dGZWF0dXJlcyBhbmQgaGF2ZSBjcmVhdGVXaW5kb3cg c2VuZCBhIG5vdGlmaWNhdGlvbiBmb3IgCisgICAgICAgIGNsaWVudHMgdG8gaGFuZGxlLgorCisg ICAgICAgICogV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRXeC5jcHA6CisgICAgICAgIChXZWJD b3JlOjp3a0ZlYXR1cmVzZm9yV2luZG93RmVhdHVyZXMpOgorICAgICAgICAoV2ViQ29yZTo6Q2hy b21lQ2xpZW50V3g6OmNyZWF0ZVdpbmRvdyk6CisgICAgICAgICogV2ViVmlldy5oOgorCiAyMDEw LTAxLTI3ICBLZXZpbiBXYXR0ZXJzICA8a2V2aW53YXR0ZXJzQGdtYWlsLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBLZXZpbiBPbGxpdmllci4KSW5kZXg6IFdlYktpdC93eC9XZWJWaWV3LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L3d4L1dlYlZpZXcuaAkocmV2aXNpb24gNTQyOTEpCisrKyBX ZWJLaXQvd3gvV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMDMsNyArMjAzLDYgQEAKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgd3hTdHJpbmcmIHBhc3N3b3JkID0gd3hF bXB0eVN0cmluZyk7CiAKICAgICB3eFdlYlNldHRpbmdzIEdldFdlYlNldHRpbmdzKCk7Ci0KICAg ICB3eFdlYktpdFBhcnNlTW9kZSBHZXRQYXJzZU1vZGUoKSBjb25zdDsKIAogcHJvdGVjdGVkOgpA QCAtMzA0LDYgKzMwMywzMCBAQAogICAgIHd4U3RyaW5nIG1fdXJsOwogfTsKIAorY2xhc3MgV1hE TExJTVBFWFBfV0VCS0lUIHd4V2ViS2l0V2luZG93RmVhdHVyZXMKK3sKK3B1YmxpYzoKKyAgICB3 eFdlYktpdFdpbmRvd0ZlYXR1cmVzKCkKKyAgICAgICAgOiBtZW51QmFyVmlzaWJsZSh0cnVlKQor ICAgICAgICAsIHN0YXR1c0JhclZpc2libGUodHJ1ZSkKKyAgICAgICAgLCB0b29sQmFyVmlzaWJs ZSh0cnVlKQorICAgICAgICAsIGxvY2F0aW9uQmFyVmlzaWJsZSh0cnVlKQorICAgICAgICAsIHNj cm9sbGJhcnNWaXNpYmxlKHRydWUpCisgICAgICAgICwgcmVzaXphYmxlKHRydWUpCisgICAgICAg ICwgZnVsbHNjcmVlbihmYWxzZSkKKyAgICAgICAgLCBkaWFsb2coZmFsc2UpCisgICAgeyB9CisK KyAgICBib29sIG1lbnVCYXJWaXNpYmxlOworICAgIGJvb2wgc3RhdHVzQmFyVmlzaWJsZTsKKyAg ICBib29sIHRvb2xCYXJWaXNpYmxlOworICAgIGJvb2wgbG9jYXRpb25CYXJWaXNpYmxlOworICAg IGJvb2wgc2Nyb2xsYmFyc1Zpc2libGU7CisgICAgYm9vbCByZXNpemFibGU7CisgICAgYm9vbCBm dWxsc2NyZWVuOworICAgIGJvb2wgZGlhbG9nOworfTsKKwogY2xhc3MgV1hETExJTVBFWFBfV0VC S0lUIHd4V2ViVmlld05ld1dpbmRvd0V2ZW50IDogcHVibGljIHd4Q29tbWFuZEV2ZW50CiB7CiAj aWZuZGVmIFNXSUcKQEAgLTMxNSwxMSArMzM4LDE3IEBACiAgICAgdm9pZCBTZXRVUkwoY29uc3Qg d3hTdHJpbmcmIHVybCkgeyBtX3VybCA9IHVybDsgfQogICAgIHd4U3RyaW5nIEdldFRhcmdldE5h bWUoKSBjb25zdCB7IHJldHVybiBtX3RhcmdldE5hbWU7IH0KICAgICB2b2lkIFNldFRhcmdldE5h bWUoY29uc3Qgd3hTdHJpbmcmIG5hbWUpIHsgbV90YXJnZXROYW1lID0gbmFtZTsgfQorICAgIHd4 V2ViVmlldyogR2V0V2ViVmlldygpIHsgcmV0dXJuIG1fd2ViVmlldzsgfQorICAgIHZvaWQgU2V0 V2ViVmlldyh3eFdlYlZpZXcqIHdlYlZpZXcpIHsgbV93ZWJWaWV3ID0gd2ViVmlldzsgfQorICAg IHd4V2ViS2l0V2luZG93RmVhdHVyZXMgR2V0V2luZG93RmVhdHVyZXMoKSB7IHJldHVybiBtX2Zl YXR1cmVzOyB9CisgICAgdm9pZCBTZXRXaW5kb3dGZWF0dXJlcyh3eFdlYktpdFdpbmRvd0ZlYXR1 cmVzIGZlYXR1cmVzKSB7IG1fZmVhdHVyZXMgPSBmZWF0dXJlczsgfQogCiAgICAgd3hXZWJWaWV3 TmV3V2luZG93RXZlbnQoIHd4V2luZG93KiB3aW4gPSBzdGF0aWNfY2FzdDx3eFdpbmRvdyo+KE5V TEwpKTsKICAgICB3eEV2ZW50ICpDbG9uZSh2b2lkKSBjb25zdCB7IHJldHVybiBuZXcgd3hXZWJW aWV3TmV3V2luZG93RXZlbnQoKnRoaXMpOyB9CiAKIHByaXZhdGU6CisgICAgd3hXZWJWaWV3KiBt X3dlYlZpZXc7CisgICAgd3hXZWJLaXRXaW5kb3dGZWF0dXJlcyBtX2ZlYXR1cmVzOwogICAgIHd4 U3RyaW5nIG1fdXJsOwogICAgIHd4U3RyaW5nIG1fdGFyZ2V0TmFtZTsKIH07Cg==