34528 2010-02-03 07:26:22 -0800 WebCore/platform/graphics/GlyphPageTreeNode.cpp needs to #include stdio.h in debug build 2010-02-22 16:55:45 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 0 superstippi webkit-unassigned commit-queue eric oldest_to_newest 187349 0 superstippi 2010-02-03 07:26:22 -0800 As in summary. 187350 1 48026 superstippi 2010-02-03 07:28:31 -0800 Created attachment 48026 Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined. 187415 2 48026 darin 2010-02-03 10:00:45 -0800 Comment on attachment 48026 Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined. Thanks. This is fine but: 1) No real need to put the ifdef around the include. An unconditional include of <stdio.h> would be fine. 2) Need a change log. review- because of the lack of change log 191491 3 48985 superstippi 2010-02-18 01:42:31 -0800 Created attachment 48985 Revised patch with changelog. Replaces previous patch and fixes the issues pointed out. 192579 4 eric 2010-02-22 13:05:14 -0800 What platform were you building on that saw this error? 192585 5 superstippi 2010-02-22 13:12:08 -0800 I was using Haiku. We use a jam based build system. It's setup such that when NDEBUG is exported in the environment, it passes -DNDEBUG=1 to CC and C++ flags. BTW. Using the Haiku WebKit browser to post this comment! :-D 192701 6 48985 commit-queue 2010-02-22 16:55:40 -0800 Comment on attachment 48985 Revised patch with changelog. Clearing flags on attachment: 48985 Committed r55113: <http://trac.webkit.org/changeset/55113> 192702 7 commit-queue 2010-02-22 16:55:45 -0800 All reviewed patches have been landed. Closing bug. 48026 2010-02-03 07:28:31 -0800 2010-02-18 01:42:31 -0800 Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined. proposed_patch.diff text/plain 441 superstippi SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhQYWdlVHJlZU5vZGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhQYWdlVHJlZU5vZGUu Y3BwCShyZXZpc2lvbiA1NDI3NSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhQ YWdlVHJlZU5vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw5IEBACiAjaW5jbHVk ZSAiU2VnbWVudGVkRm9udERhdGEuaCIKICNpbmNsdWRlICJTaW1wbGVGb250RGF0YS5oIgogI2lu Y2x1ZGUgPHd0Zi91bmljb2RlL1VuaWNvZGUuaD4KKyNpZm5kZWYgTkRFQlVHCisjaW5jbHVkZSA8 c3RkaW8uaD4KKyNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK 48985 2010-02-18 01:42:31 -0800 2010-02-22 16:55:40 -0800 Revised patch with changelog. ndebug.diff text/plain 1097 superstippi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDk0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMTggIFN0ZXBoYW4gQcOfbXVzICA8c3VwZXJzdGlwcGlA Z214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJ1aWxkIGZpeCBmb3IgZGVidWcgYnVpbGRzIG9mIEdseXBoUGFnZVRyZWVOb2RlLmNwcAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ1MjgKKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvR2x5cGhQYWdlVHJlZU5vZGUuY3BwOgorICAgICAgICAgICAgaW5jbHVkZSA8c3RkaW8u aD4gc2luY2UgcHJpbnRmKCkgaXMgdXNlZCBpZiBOREVCVUcgaXMgbm90IGRlZmluZWQuCisKIDIw MTAtMDItMTggIFdpbGxpYW0gQ2hhbiAgPHdpbGxjaGFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HbHlwaFBhZ2VUcmVlTm9kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HbHlwaFBhZ2VUcmVlTm9kZS5jcHAJKHJldmlzaW9uIDU0OTMyKQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HbHlwaFBhZ2VUcmVlTm9kZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRlICJDaGFyYWN0ZXJOYW1lcy5oIgogI2luY2x1ZGUg IlNlZ21lbnRlZEZvbnREYXRhLmgiCiAjaW5jbHVkZSAiU2ltcGxlRm9udERhdGEuaCIKKyNpbmNs dWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL1VuaWNvZGUuaD4KIAogbmFtZXNw YWNlIFdlYkNvcmUgewo=