34524 2010-02-03 05:53:53 -0800 [Chromium] Writing Direction context menu for OS X 2010-02-04 12:11:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 playmobil webkit-unassigned commit-queue fishd levin webkit.review.bot yaar oldest_to_newest 187328 0 playmobil 2010-02-03 05:53:53 -0800 [Chromium] Writing Direction context menu for OS X 187330 1 playmobil 2010-02-03 06:00:09 -0800 Windows uses a keyboard shortcut to allow users to toggle RTL/LTR alignment of text input fields, on OS X the convention is to use a context menu. This is the WebKit side of the change needed to add said menu in Chromium. The reason for using an enabled/checked bitfield rather than passing the current writing direction and having the browser process figure out which menu items to enable/disable is because this is closer to the way the same task is handled in WebKit's core context menu code - WebKit/WebCore/platform/ContextMenu.cpp. Since the ultimate intention is to rely on that code, it seems to make sense to match the way the code there works as closely as possible. 187332 2 48020 playmobil 2010-02-03 06:15:08 -0800 Created attachment 48020 patch 187333 3 webkit.review.bot 2010-02-03 06:17:46 -0800 Attachment 48020 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/ContextMenuClientImpl.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/src/ContextMenuClientImpl.cpp:220: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style. 187335 4 48021 playmobil 2010-02-03 06:23:37 -0800 Created attachment 48021 patch Fix style - I think the error about header order is erroneous, if not I'd be grateful if someone could point out what to change. 187337 5 webkit.review.bot 2010-02-03 06:28:57 -0800 Attachment 48021 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/ContextMenuClientImpl.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 187345 6 levin 2010-02-03 07:13:47 -0800 (In reply to comment #4) > I think the error about header order is erroneous, if not I'd be > grateful if someone could point out what to change. WebKit sorts headers in a case sensitive manner and ascii('S') < ascii('o'), so the headers should be ordered llke this: #include "CSSPropertyNames.h" #include "CSSStyleDeclaration.h" #include "ContextMenu.h" Two other nits: You have a two space indent instead of four on the contents of the enum in WebContextMenuData.h I Am Not Sure Why The Comment Is Written Like This as opposed to a normal sentence capitalization. "// Writing Direction Context Menu." 187477 7 48061 playmobil 2010-02-03 12:45:12 -0800 Created attachment 48061 Fix style issues David: could you take another look please 187515 8 48061 levin 2010-02-03 14:45:52 -0800 Comment on attachment 48061 Fix style issues > diff --git a/WebKit/chromium/public/WebContextMenuData.h b/WebKit/chromium/public/WebContextMenuData.h Should there be a "#if OS(DARWIN)" around this? > + enum CheckableMenuItemFlags { > + CheckableMenuItemDisabled = 0x0, > + CheckableMenuItemEnabled = 0x1, > + CheckableMenuItemChecked = 0x2, > + }; > + > + // Writing direction menu items. > + // Currently only used on OS X. > + int writingDirectionDefault; > + int writingDirectionLeftToRight; > + int writingDirectionRightToLeft; 187517 9 playmobil 2010-02-03 14:51:04 -0800 This is a public header so to the best of my knowledge I can't include config.h, the #ifdef doesn't really matter here. If you grep WebKit/chromium/public , none of the headers in there use OS() or PLATFORM() macros - I'm guessing, for similar reasons... 187665 10 48061 commit-queue 2010-02-04 00:41:57 -0800 Comment on attachment 48061 Fix style issues Clearing flags on attachment: 48061 Committed r54331: <http://trac.webkit.org/changeset/54331> 187666 11 commit-queue 2010-02-04 00:42:07 -0800 All reviewed patches have been landed. Closing bug. 187705 12 48061 fishd 2010-02-04 02:46:15 -0800 Comment on attachment 48061 Fix style issues > +++ b/WebKit/chromium/public/WebContextMenuData.h ... > + enum CheckableMenuItemFlags { > + CheckableMenuItemDisabled = 0x0, > + CheckableMenuItemEnabled = 0x1, > + CheckableMenuItemChecked = 0x2, > + }; > + > + // Writing direction menu items. > + // Currently only used on OS X. > + int writingDirectionDefault; > + int writingDirectionLeftToRight; > + int writingDirectionRightToLeft; reading this header file, it is not obvious that writingDirection* values are unions of the CheckableMenuItem* values. A comment seems at least warranted. 187731 13 48132 playmobil 2010-02-04 04:16:17 -0800 Created attachment 48132 Better document possible values for writing direction variables. 187732 14 playmobil 2010-02-04 04:17:12 -0800 Reopening to fix Darin's comment. 187881 15 48132 fishd 2010-02-04 11:37:49 -0800 Comment on attachment 48132 Better document possible values for writing direction variables. R=me, thanks! 187891 16 48132 commit-queue 2010-02-04 12:10:51 -0800 Comment on attachment 48132 Better document possible values for writing direction variables. Clearing flags on attachment: 48132 Committed r54363: <http://trac.webkit.org/changeset/54363> 187893 17 commit-queue 2010-02-04 12:11:00 -0800 All reviewed patches have been landed. Closing bug. 48020 2010-02-03 06:15:08 -0800 2010-02-03 06:23:37 -0800 patch webkit_side.patch text/plain 3369 playmobil Y29tbWl0IDViMzQ1YmY4MjkxYzc0NWEwMjA0YzYwNTdhNjE2ZDhlZjlmNTIyODUKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxwbGF5bW9iaWxAem9hbC50bHYuY29ycC5nb29nbGUuY29tPgpEYXRl OiAgIFdlZCBGZWIgMyAxNjowNDoxOSAyMDEwICswMjAwCgogICAgV2ViS2l0IHNpZGUgb2YgIldy aXRpbmcgRGlyZWN0aW9uIiBjb250ZXh0IG1lbnUgb24gT1MgWC4KCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAy ZTcyYzYwLi43ZDVjNDZmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisr KyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0w MyAgSmVyZW15IE1vc2tvdmljaCAgPGplcmVteUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBXZWJLaXQgc2lk ZSBvZiAiV3JpdGluZyBkaXJlY3Rpb24iIGNvbnRleHQgbWVudSBvbiBPUyBYLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ1MjQKKworICAgICAgICAq IHB1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4 dE1lbnVEYXRhOjopOgorICAgICAgICAqIHNyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVudUNsaWVudEltcGw6OmdldEN1c3RvbU1lbnVGcm9t RGVmYXVsdEl0ZW1zKToKKwogMjAxMC0wMi0wMiAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmggYi9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCmluZGV4IGI0YWNiMWMu LmI4NTYzM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1l bnVEYXRhLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEu aApAQCAtOTcsNiArOTcsMTggQEAgc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YSB7CiAgICAgLy8g V2hldGhlciBjb250ZXh0IGlzIGVkaXRhYmxlLgogICAgIGJvb2wgaXNFZGl0YWJsZTsKIAorICAg IGVudW0gQ2hlY2thYmxlTWVudUl0ZW1GbGFncyB7CisgICAgICBDaGVja2FibGVNZW51SXRlbURp c2FibGVkID0gMHgwLAorICAgICAgQ2hlY2thYmxlTWVudUl0ZW1FbmFibGVkID0gMHgxLAorICAg ICAgQ2hlY2thYmxlTWVudUl0ZW1DaGVja2VkID0gMHgyLAorICAgIH07CisKKyAgICAvLyBXcml0 aW5nIGRpcmVjdGlvbiBtZW51IGl0ZW1zLgorICAgIC8vIEN1cnJlbnRseSBvbmx5IHVzZWQgb24g T1MgWC4KKyAgICBpbnQgd3JpdGluZ0RpcmVjdGlvbkRlZmF1bHQ7CisgICAgaW50IHdyaXRpbmdE aXJlY3Rpb25MZWZ0VG9SaWdodDsKKyAgICBpbnQgd3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0 OworCiAgICAgZW51bSBFZGl0RmxhZ3MgewogICAgICAgICBDYW5Eb05vbmUgPSAweDAsCiAgICAg ICAgIENhblVuZG8gPSAweDEsCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRl eHRNZW51Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xp ZW50SW1wbC5jcHAKaW5kZXggZWI2YTZjMC4uZjYxMWFlYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2No cm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcApAQCAtMzIsNiArMzIsOCBAQAogI2luY2x1 ZGUgIkNvbnRleHRNZW51Q2xpZW50SW1wbC5oIgogCiAjaW5jbHVkZSAiQ29udGV4dE1lbnUuaCIK KyNpbmNsdWRlICJDU1NQcm9wZXJ0eU5hbWVzLmgiCisjaW5jbHVkZSAiQ1NTU3R5bGVEZWNsYXJh dGlvbi5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIu aCIKICNpbmNsdWRlICJFZGl0b3IuaCIKQEAgLTIwMSw2ICsyMDMsMjIgQEAgUGxhdGZvcm1NZW51 RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1 bHRJdGVtcygKICAgICAgICAgfQogICAgIH0KIAorI2lmIE9TKERBUldJTikKKyAgICAvLyBXcml0 aW5nIERpcmVjdGlvbiBDb250ZXh0IE1lbnUuCisgICAgZGF0YS53cml0aW5nRGlyZWN0aW9uRGVm YXVsdCA9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hlY2thYmxlTWVudUl0ZW1EaXNhYmxlZDsKKyAg ICBkYXRhLndyaXRpbmdEaXJlY3Rpb25MZWZ0VG9SaWdodCA9IFdlYkNvbnRleHRNZW51RGF0YTo6 Q2hlY2thYmxlTWVudUl0ZW1FbmFibGVkOworICAgIGRhdGEud3JpdGluZ0RpcmVjdGlvblJpZ2h0 VG9MZWZ0ID0gV2ViQ29udGV4dE1lbnVEYXRhOjpDaGVja2FibGVNZW51SXRlbUVuYWJsZWQ7CisK KyAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKKyAgICBSZWZQdHI8Q1NTU3R5bGVEZWNsYXJhdGlv bj4gc3R5bGUgPSBzZWxlY3RlZEZyYW1lLT5kb2N1bWVudCgpLT5jcmVhdGVDU1NTdHlsZURlY2xh cmF0aW9uKCk7CisgICAgc3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5RGlyZWN0aW9uLCAi bHRyIiwgZmFsc2UsIGVjKTsKKyAgICBpZiAoc2VsZWN0ZWRGcmFtZS0+ZWRpdG9yKCktPnNlbGVj dGlvbkhhc1N0eWxlKHN0eWxlLmdldCgpKSAhPSBGYWxzZVRyaVN0YXRlKQorICAgICAgICBkYXRh LndyaXRpbmdEaXJlY3Rpb25MZWZ0VG9SaWdodCB8PSBXZWJDb250ZXh0TWVudURhdGE6OkNoZWNr YWJsZU1lbnVJdGVtQ2hlY2tlZDsKKyAgICBzdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlE aXJlY3Rpb24sICJydGwiLCBmYWxzZSwgZWMpOworICAgIGlmIChzZWxlY3RlZEZyYW1lLT5lZGl0 b3IoKS0+c2VsZWN0aW9uSGFzU3R5bGUoc3R5bGUuZ2V0KCkpICE9IEZhbHNlVHJpU3RhdGUpCisg ICAgICAgIGRhdGEud3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0IHw9IFdlYkNvbnRleHRNZW51 RGF0YTo6Q2hlY2thYmxlTWVudUl0ZW1DaGVja2VkOworI2VuZGlmICAvLyBPUyhEQVJXSU4pCisK ICAgICAvLyBOb3cgcmV0cmlldmUgdGhlIHNlY3VyaXR5IGluZm8uCiAgICAgRG9jdW1lbnRMb2Fk ZXIqIGRsID0gc2VsZWN0ZWRGcmFtZS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCk7CiAgICAg V2ViRGF0YVNvdXJjZSogZHMgPSBXZWJEYXRhU291cmNlSW1wbDo6ZnJvbURvY3VtZW50TG9hZGVy KGRsKTsK 48021 2010-02-03 06:23:37 -0800 2010-02-03 12:45:12 -0800 patch webkit_side.patch text/plain 3368 playmobil Y29tbWl0IDY1NWI0ZDZkNDUwYjAzZWM2MWVlNDk3ZDBjOGRkYjAxMmM4ODJiMzEKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxwbGF5bW9iaWxAem9hbC50bHYuY29ycC5nb29nbGUuY29tPgpEYXRl OiAgIFdlZCBGZWIgMyAxNjowNDoxOSAyMDEwICswMjAwCgogICAgV2ViS2l0IHNpZGUgb2YgIldy aXRpbmcgRGlyZWN0aW9uIiBjb250ZXh0IG1lbnUgb24gT1MgWC4KCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAy ZTcyYzYwLi43ZDVjNDZmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisr KyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0w MyAgSmVyZW15IE1vc2tvdmljaCAgPGplcmVteUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBXZWJLaXQgc2lk ZSBvZiAiV3JpdGluZyBkaXJlY3Rpb24iIGNvbnRleHQgbWVudSBvbiBPUyBYLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ1MjQKKworICAgICAgICAq IHB1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4 dE1lbnVEYXRhOjopOgorICAgICAgICAqIHNyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVudUNsaWVudEltcGw6OmdldEN1c3RvbU1lbnVGcm9t RGVmYXVsdEl0ZW1zKToKKwogMjAxMC0wMi0wMiAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmggYi9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCmluZGV4IGI0YWNiMWMu LmI4NTYzM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1l bnVEYXRhLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEu aApAQCAtOTcsNiArOTcsMTggQEAgc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YSB7CiAgICAgLy8g V2hldGhlciBjb250ZXh0IGlzIGVkaXRhYmxlLgogICAgIGJvb2wgaXNFZGl0YWJsZTsKIAorICAg IGVudW0gQ2hlY2thYmxlTWVudUl0ZW1GbGFncyB7CisgICAgICBDaGVja2FibGVNZW51SXRlbURp c2FibGVkID0gMHgwLAorICAgICAgQ2hlY2thYmxlTWVudUl0ZW1FbmFibGVkID0gMHgxLAorICAg ICAgQ2hlY2thYmxlTWVudUl0ZW1DaGVja2VkID0gMHgyLAorICAgIH07CisKKyAgICAvLyBXcml0 aW5nIGRpcmVjdGlvbiBtZW51IGl0ZW1zLgorICAgIC8vIEN1cnJlbnRseSBvbmx5IHVzZWQgb24g T1MgWC4KKyAgICBpbnQgd3JpdGluZ0RpcmVjdGlvbkRlZmF1bHQ7CisgICAgaW50IHdyaXRpbmdE aXJlY3Rpb25MZWZ0VG9SaWdodDsKKyAgICBpbnQgd3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0 OworCiAgICAgZW51bSBFZGl0RmxhZ3MgewogICAgICAgICBDYW5Eb05vbmUgPSAweDAsCiAgICAg ICAgIENhblVuZG8gPSAweDEsCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRl eHRNZW51Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xp ZW50SW1wbC5jcHAKaW5kZXggZWI2YTZjMC4uNWMyMzMzYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2No cm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcApAQCAtMzIsNiArMzIsOCBAQAogI2luY2x1 ZGUgIkNvbnRleHRNZW51Q2xpZW50SW1wbC5oIgogCiAjaW5jbHVkZSAiQ29udGV4dE1lbnUuaCIK KyNpbmNsdWRlICJDU1NQcm9wZXJ0eU5hbWVzLmgiCisjaW5jbHVkZSAiQ1NTU3R5bGVEZWNsYXJh dGlvbi5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIu aCIKICNpbmNsdWRlICJFZGl0b3IuaCIKQEAgLTIwMSw2ICsyMDMsMjIgQEAgUGxhdGZvcm1NZW51 RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1 bHRJdGVtcygKICAgICAgICAgfQogICAgIH0KIAorI2lmIE9TKERBUldJTikKKyAgICAvLyBXcml0 aW5nIERpcmVjdGlvbiBDb250ZXh0IE1lbnUuCisgICAgZGF0YS53cml0aW5nRGlyZWN0aW9uRGVm YXVsdCA9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hlY2thYmxlTWVudUl0ZW1EaXNhYmxlZDsKKyAg ICBkYXRhLndyaXRpbmdEaXJlY3Rpb25MZWZ0VG9SaWdodCA9IFdlYkNvbnRleHRNZW51RGF0YTo6 Q2hlY2thYmxlTWVudUl0ZW1FbmFibGVkOworICAgIGRhdGEud3JpdGluZ0RpcmVjdGlvblJpZ2h0 VG9MZWZ0ID0gV2ViQ29udGV4dE1lbnVEYXRhOjpDaGVja2FibGVNZW51SXRlbUVuYWJsZWQ7CisK KyAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKKyAgICBSZWZQdHI8Q1NTU3R5bGVEZWNsYXJhdGlv bj4gc3R5bGUgPSBzZWxlY3RlZEZyYW1lLT5kb2N1bWVudCgpLT5jcmVhdGVDU1NTdHlsZURlY2xh cmF0aW9uKCk7CisgICAgc3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5RGlyZWN0aW9uLCAi bHRyIiwgZmFsc2UsIGVjKTsKKyAgICBpZiAoc2VsZWN0ZWRGcmFtZS0+ZWRpdG9yKCktPnNlbGVj dGlvbkhhc1N0eWxlKHN0eWxlLmdldCgpKSAhPSBGYWxzZVRyaVN0YXRlKQorICAgICAgICBkYXRh LndyaXRpbmdEaXJlY3Rpb25MZWZ0VG9SaWdodCB8PSBXZWJDb250ZXh0TWVudURhdGE6OkNoZWNr YWJsZU1lbnVJdGVtQ2hlY2tlZDsKKyAgICBzdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlE aXJlY3Rpb24sICJydGwiLCBmYWxzZSwgZWMpOworICAgIGlmIChzZWxlY3RlZEZyYW1lLT5lZGl0 b3IoKS0+c2VsZWN0aW9uSGFzU3R5bGUoc3R5bGUuZ2V0KCkpICE9IEZhbHNlVHJpU3RhdGUpCisg ICAgICAgIGRhdGEud3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0IHw9IFdlYkNvbnRleHRNZW51 RGF0YTo6Q2hlY2thYmxlTWVudUl0ZW1DaGVja2VkOworI2VuZGlmIC8vIE9TKERBUldJTikKKwog ICAgIC8vIE5vdyByZXRyaWV2ZSB0aGUgc2VjdXJpdHkgaW5mby4KICAgICBEb2N1bWVudExvYWRl ciogZGwgPSBzZWxlY3RlZEZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKTsKICAgICBX ZWJEYXRhU291cmNlKiBkcyA9IFdlYkRhdGFTb3VyY2VJbXBsOjpmcm9tRG9jdW1lbnRMb2FkZXIo ZGwpOwo= 48061 2010-02-03 12:45:12 -0800 2010-02-04 02:46:15 -0800 Fix style issues webkit_side.patch text/plain 3353 playmobil Y29tbWl0IDVhMDczMzk2YTgwN2ViNTEyMDdjY2Y4MDZkOTgzNTVkNTRiMDMzZDQKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIFdlZCBGZWIgMyAy Mjo0NDoyNiAyMDEwICswMjAwCgogICAgW0Nocm9taXVtXSBXcml0aW5nIERpcmVjdGlvbiBjb250 ZXh0IG1lbnUgZm9yIE9TIFgKCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n IGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBiMWM1OTJiLi41ZjBiYzFmIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0wMyAgSmVyZW15IE1vc2tvdmljaCAg PGplcmVteUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBXZWJLaXQgc2lkZSBvZiAiV3JpdGluZyBkaXJlY3Rp b24iIGNvbnRleHQgbWVudSBvbiBPUyBYLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzQ1MjQKKworICAgICAgICAqIHB1YmxpYy9XZWJDb250ZXh0TWVu dURhdGEuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVEYXRhOjopOgorICAgICAg ICAqIHNyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb250 ZXh0TWVudUNsaWVudEltcGw6OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKToKKwogMjAx MC0wMi0wMyAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkNvbnRleHRNZW51RGF0YS5oCmluZGV4IGI0YWNiMWMuLjA0OWRhOWMgMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKKysrIGIvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaApAQCAtOTcsNiArOTcsMTggQEAg c3RydWN0IFdlYkNvbnRleHRNZW51RGF0YSB7CiAgICAgLy8gV2hldGhlciBjb250ZXh0IGlzIGVk aXRhYmxlLgogICAgIGJvb2wgaXNFZGl0YWJsZTsKIAorICAgIGVudW0gQ2hlY2thYmxlTWVudUl0 ZW1GbGFncyB7CisgICAgICAgIENoZWNrYWJsZU1lbnVJdGVtRGlzYWJsZWQgPSAweDAsCisgICAg ICAgIENoZWNrYWJsZU1lbnVJdGVtRW5hYmxlZCA9IDB4MSwKKyAgICAgICAgQ2hlY2thYmxlTWVu dUl0ZW1DaGVja2VkID0gMHgyLAorICAgIH07CisKKyAgICAvLyBXcml0aW5nIGRpcmVjdGlvbiBt ZW51IGl0ZW1zLgorICAgIC8vIEN1cnJlbnRseSBvbmx5IHVzZWQgb24gT1MgWC4KKyAgICBpbnQg d3JpdGluZ0RpcmVjdGlvbkRlZmF1bHQ7CisgICAgaW50IHdyaXRpbmdEaXJlY3Rpb25MZWZ0VG9S aWdodDsKKyAgICBpbnQgd3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0OworCiAgICAgZW51bSBF ZGl0RmxhZ3MgewogICAgICAgICBDYW5Eb05vbmUgPSAweDAsCiAgICAgICAgIENhblVuZG8gPSAw eDEsCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1w bC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKaW5k ZXggZWI2YTZjMC4uODQ3MjA4MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250 ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1l bnVDbGllbnRJbXBsLmNwcApAQCAtMzEsNiArMzEsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgIkNvbnRleHRNZW51Q2xpZW50SW1wbC5oIgogCisjaW5jbHVkZSAiQ1NTUHJvcGVy dHlOYW1lcy5oIgorI2luY2x1ZGUgIkNTU1N0eWxlRGVjbGFyYXRpb24uaCIKICNpbmNsdWRlICJD b250ZXh0TWVudS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRM b2FkZXIuaCIKQEAgLTIwMSw2ICsyMDMsMjIgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29u dGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKICAgICAg ICAgfQogICAgIH0KIAorI2lmIE9TKERBUldJTikKKyAgICAvLyBXcml0aW5nIGRpcmVjdGlvbiBj b250ZXh0IG1lbnUuCisgICAgZGF0YS53cml0aW5nRGlyZWN0aW9uRGVmYXVsdCA9IFdlYkNvbnRl eHRNZW51RGF0YTo6Q2hlY2thYmxlTWVudUl0ZW1EaXNhYmxlZDsKKyAgICBkYXRhLndyaXRpbmdE aXJlY3Rpb25MZWZ0VG9SaWdodCA9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hlY2thYmxlTWVudUl0 ZW1FbmFibGVkOworICAgIGRhdGEud3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0ID0gV2ViQ29u dGV4dE1lbnVEYXRhOjpDaGVja2FibGVNZW51SXRlbUVuYWJsZWQ7CisKKyAgICBFeGNlcHRpb25D b2RlIGVjID0gMDsKKyAgICBSZWZQdHI8Q1NTU3R5bGVEZWNsYXJhdGlvbj4gc3R5bGUgPSBzZWxl Y3RlZEZyYW1lLT5kb2N1bWVudCgpLT5jcmVhdGVDU1NTdHlsZURlY2xhcmF0aW9uKCk7CisgICAg c3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5RGlyZWN0aW9uLCAibHRyIiwgZmFsc2UsIGVj KTsKKyAgICBpZiAoc2VsZWN0ZWRGcmFtZS0+ZWRpdG9yKCktPnNlbGVjdGlvbkhhc1N0eWxlKHN0 eWxlLmdldCgpKSAhPSBGYWxzZVRyaVN0YXRlKQorICAgICAgICBkYXRhLndyaXRpbmdEaXJlY3Rp b25MZWZ0VG9SaWdodCB8PSBXZWJDb250ZXh0TWVudURhdGE6OkNoZWNrYWJsZU1lbnVJdGVtQ2hl Y2tlZDsKKyAgICBzdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlEaXJlY3Rpb24sICJydGwi LCBmYWxzZSwgZWMpOworICAgIGlmIChzZWxlY3RlZEZyYW1lLT5lZGl0b3IoKS0+c2VsZWN0aW9u SGFzU3R5bGUoc3R5bGUuZ2V0KCkpICE9IEZhbHNlVHJpU3RhdGUpCisgICAgICAgIGRhdGEud3Jp dGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0IHw9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hlY2thYmxl TWVudUl0ZW1DaGVja2VkOworI2VuZGlmIC8vIE9TKERBUldJTikKKwogICAgIC8vIE5vdyByZXRy aWV2ZSB0aGUgc2VjdXJpdHkgaW5mby4KICAgICBEb2N1bWVudExvYWRlciogZGwgPSBzZWxlY3Rl ZEZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKTsKICAgICBXZWJEYXRhU291cmNlKiBk cyA9IFdlYkRhdGFTb3VyY2VJbXBsOjpmcm9tRG9jdW1lbnRMb2FkZXIoZGwpOwo= 48132 2010-02-04 04:16:17 -0800 2010-02-04 12:10:51 -0800 Better document possible values for writing direction variables. webkit_side.patch text/plain 1364 playmobil Y29tbWl0IGE4ZDFlNmJlZTlhZTc5Zjg1ZTQ0YmY5MDNhNDYxZWNiZGJlM2QyNzAKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIFRodSBGZWIgNCAx NDoxMToyNyAyMDEwICswMjAwCgogICAgVXBkYXRlIGNvbW1lbnRzIHRvIGJldHRlciBkb2N1bWVu dCB0aGUgcG9zc2libGUgdmFsdWVzIG9mIHRoZSB3cml0aW5nIGRpcmVjdGlvbiBtZW51IHN0YXRl IHZhcmlhYmxlcy4KCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA1OGMzN2E4Li5hNzAwOTQ3IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wMi0wNCAgSmVyZW15IE1vc2tvdmljaCAgPGplcmVt eUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVXBkYXRlIGNvbW1lbnRzIHRvIGJldHRlciBkb2N1bWVudCB0aGUgcG9zc2libGUg dmFsdWVzIG9mIHRoZQorICAgICAgICB3cml0aW5nIGRpcmVjdGlvbiBtZW51IHN0YXRlIHZhcmlh Ymxlcy4KKworICAgICAgICAqIHB1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaDoKKwogMjAxMC0w Mi0wNCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLiBSZXZlcnQgNTQzMzMgd2hpY2ggYnJva2UgQ2hyb21pdW0gYnVpbGQuCmRpZmYg LS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oIGIvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaAppbmRleCAwNDlkYTljLi41 ZDY3MDQ2IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51 RGF0YS5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgK QEAgLTEwMyw3ICsxMDMsOCBAQCBzdHJ1Y3QgV2ViQ29udGV4dE1lbnVEYXRhIHsKICAgICAgICAg Q2hlY2thYmxlTWVudUl0ZW1DaGVja2VkID0gMHgyLAogICAgIH07CiAKLSAgICAvLyBXcml0aW5n IGRpcmVjdGlvbiBtZW51IGl0ZW1zLgorICAgIC8vIFdyaXRpbmcgZGlyZWN0aW9uIG1lbnUgaXRl bXMgLSB2YWx1ZXMgYXJlIHVuaW9ucyBvZgorICAgIC8vIENoZWNrYWJsZU1lbnVJdGVtRmxhZ3Mu CiAgICAgLy8gQ3VycmVudGx5IG9ubHkgdXNlZCBvbiBPUyBYLgogICAgIGludCB3cml0aW5nRGly ZWN0aW9uRGVmYXVsdDsKICAgICBpbnQgd3JpdGluZ0RpcmVjdGlvbkxlZnRUb1JpZ2h0Owo=