34519 2010-02-03 04:17:58 -0800 [Qt] Applications using QtWebKit fail to build if Qt was built with -no-script 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED DUPLICATE 52469 Qt, QtTriaged P3 Normal --- 1 bero webkit-unassigned benjamin eric hausmann kent.hansen webkit.review.bot oldest_to_newest 187311 0 bero 2010-02-03 04:17:58 -0800 If Qt was built with -no-script, applications using QtWebKit (which does work with -no-script) fail to build because qwebframe.h unconditionally does #include <QtScript/qscriptengine.h> (which doesn't exist in a -no-script build). 187313 1 48013 bero 2010-02-03 04:29:51 -0800 Created attachment 48013 Fix Attaching fix 187320 2 webkit.review.bot 2010-02-03 05:12:13 -0800 Attachment 48013 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/232341 187468 3 bero 2010-02-03 12:22:21 -0800 Not sure what's causing the build bot failure... The command line from its report shows -DBUILD_WEBKIT is on the command line, and the modification is in #if !defined(QT_NO_SCRIPT) && !defined(BUILD_WEBKIT) I only tested the patch for building inside of Qt rather than the separate webkit tree though 187535 4 eric 2010-02-03 16:18:07 -0800 This looks like it fails to build on the Qt Early Warning System (EWS) builder. 187706 5 48013 hausmann 2010-02-04 02:49:29 -0800 Comment on attachment 48013 Fix > +#if !defined(QT_NO_SCRIPT) && !defined(BUILD_WEBKIT) > void addToJavaScriptWindowObject(const QString &name, QObject *object, QScriptEngine::ValueOwnership ownership); > +#endif Why the check for BUILD_WEBKIT? Also the Qt EWS bot indicates that this breaks the build because there's the equivalent #ifdef missing in qwebframe.cpp. (Yay for the EWS :) 187710 6 bero 2010-02-04 03:03:03 -0800 The check for BUILD_WEBKIT is there because at build time (still talking about building QtWebKit inside the Qt tree, not about building it in the standalone tree), QtScript includes are available and the code can actually be built (that's also the reason for the absence of an equivalent ifdef in qwebframe.cpp -- at build time, QScriptEngine::ValueOwnership is availableand therefore it can be built). The thought behind allowing the 3-arg version of addToJavaScriptWindowObject to be built into the library even with -no-script was to try to preserve binary compatibility between versions built with -no-script and those built without -no-script -- but given the function is not very likely to actually work in -no-script mode, that may have been overly cautious. 198014 7 kent.hansen 2010-03-10 06:05:15 -0800 *** Bug 33104 has been marked as a duplicate of this bug. *** 227462 8 hausmann 2010-05-18 13:21:31 -0700 No update on this bug for a while. This isn't blocking the release anymore, but any patches will be welcomed for inclusion in the release branch :) 342312 9 benjamin 2011-01-30 09:06:55 -0800 *** This bug has been marked as a duplicate of bug 52469 *** 48013 2010-02-03 04:29:51 -0800 2010-06-11 12:48:17 -0700 Fix WebKit-bug34519.patch text/plain 1461 bero ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmggYi9XZWJLaXQvcXQvQXBpL3F3 ZWJmcmFtZS5oCmluZGV4IDI1ZjZjOWIuLjM5NmNmMmEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9B cGkvcXdlYmZyYW1lLmgKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuaApAQCAtMjUsNyAr MjUsOSBAQAogI2luY2x1ZGUgPFF0Q29yZS9xdXJsLmg+CiAjaW5jbHVkZSA8UXRDb3JlL3F2YXJp YW50Lmg+CiAjaW5jbHVkZSA8UXRHdWkvcWljb24uaD4KKyNpZiAhZGVmaW5lZChRVF9OT19TQ1JJ UFQpICYmICFkZWZpbmVkKEJVSUxEX1dFQktJVCkKICNpbmNsdWRlIDxRdFNjcmlwdC9xc2NyaXB0 ZW5naW5lLmg+CisjZW5kaWYKICNpbmNsdWRlIDxRdE5ldHdvcmsvcW5ldHdvcmthY2Nlc3NtYW5h Z2VyLmg+CiAjaW5jbHVkZSAicXdlYmtpdGdsb2JhbC5oIgogCkBAIC0xMjgsNyArMTMwLDkgQEAg cHVibGljOgogICAgIHZvaWQgc2V0Q29udGVudChjb25zdCBRQnl0ZUFycmF5ICZkYXRhLCBjb25z dCBRU3RyaW5nICZtaW1lVHlwZSA9IFFTdHJpbmcoKSwgY29uc3QgUVVybCAmYmFzZVVybCA9IFFV cmwoKSk7CiAKICAgICB2b2lkIGFkZFRvSmF2YVNjcmlwdFdpbmRvd09iamVjdChjb25zdCBRU3Ry aW5nICZuYW1lLCBRT2JqZWN0ICpvYmplY3QpOworI2lmICFkZWZpbmVkKFFUX05PX1NDUklQVCkg JiYgIWRlZmluZWQoQlVJTERfV0VCS0lUKQogICAgIHZvaWQgYWRkVG9KYXZhU2NyaXB0V2luZG93 T2JqZWN0KGNvbnN0IFFTdHJpbmcgJm5hbWUsIFFPYmplY3QgKm9iamVjdCwgUVNjcmlwdEVuZ2lu ZTo6VmFsdWVPd25lcnNoaXAgb3duZXJzaGlwKTsKKyNlbmRpZgogICAgIFFTdHJpbmcgdG9IdG1s KCkgY29uc3Q7CiAgICAgUVN0cmluZyB0b1BsYWluVGV4dCgpIGNvbnN0OwogICAgIFFTdHJpbmcg cmVuZGVyVHJlZUR1bXAoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cg Yi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDYwNDAzNzguLmRiZTZiNGIgMTAwNjQ0Ci0tLSBh L1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDEwLTAyLTAzICBCZXJuaGFyZCBSb3NlbmtyYWVuemVyICA8YnJAYmxhbmtwYWdl LmNoPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF0gQXBwbGljYXRpb25zIHVzaW5nIFF0V2ViS2l0IGZhaWwgdG8gYnVpbGQgaWYgUXQgd2FzIGJ1 aWx0IHdpdGggLW5vLXNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzQ1MTkKKworICAgICAgICAqIEFwaS9xd2ViZnJhbWUuaDoKKwogMjAxMC0w Mi0wMiAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQXJpeWEgSGlkYXlhdC4K