34516 2010-02-03 00:24:17 -0800 [BREWMP] Port KURL::fileSystemPath 2010-02-09 02:24:24 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue oldest_to_newest 187288 0 skyul 2010-02-03 00:24:17 -0800 Convert a file URL to a file path. 187294 1 48004 skyul 2010-02-03 01:26:47 -0800 Created attachment 48004 Port KURL::fileSystemPath 187537 2 48004 eric 2010-02-03 16:20:26 -0800 Comment on attachment 48004 Port KURL::fileSystemPath Why is CString.h include needed? Are you sure this is correct? Does the brew port really never use root-relative file urls? 187830 3 skyul 2010-02-04 09:28:13 -0800 (In reply to comment #2) > (From update of attachment 48004 [details]) > Why is CString.h include needed? > > Are you sure this is correct? Does the brew port really never use > root-relative file urls? This is intentional. This follows the behavior of IWeb, BREW's HTTP engine which opens files in BREW's application-relative file namespace. 187831 4 48149 skyul 2010-02-04 09:35:43 -0800 Created attachment 48149 Port KURL::fileSystemPath Add more comments to explain why we use application relative paths. 188809 5 48149 eric 2010-02-08 15:49:33 -0800 Comment on attachment 48149 Port KURL::fileSystemPath I'm not sure how this will affect loading resources that WebCore depends on from disk. Like cursor images or CSS files, but OK. 188937 6 48149 commit-queue 2010-02-09 02:24:18 -0800 Comment on attachment 48149 Port KURL::fileSystemPath Clearing flags on attachment: 48149 Committed r54542: <http://trac.webkit.org/changeset/54542> 188938 7 commit-queue 2010-02-09 02:24:24 -0800 All reviewed patches have been landed. Closing bug. 48004 2010-02-03 01:26:47 -0800 2010-02-04 09:35:43 -0800 Port KURL::fileSystemPath KURL.patch text/plain 2099 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDI3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMDMgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBQb3J0IEtVUkw6OmZpbGVTeXN0ZW1QYXRoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDUxNgorCisgICAgICAgIENvbnZlcnQgYSBm aWxlIFVSTCB0byBhIGZpbGUgcGF0aCBieSBwcmVmaXhpbmcKKyAgICAgICAgQUVFRlNfSE9NRV9E SVIgdG8gYWNjZXNzIGZpbGVzIHJlbGF0aXZlIHRvIHRoZSBjdXJyZW50CisgICAgICAgIG1vZHVs ZSBkaXJlY3RvcnkgaW4gYSBjYXNlLXNlbnNpdGl2ZSBtYW5uZXIuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9icmV3L0tVUkxCcmV3LmNwcDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpLVVJMOjpm aWxlU3lzdGVtUGF0aCk6CisKIDIwMTAtMDItMDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9icmV3L0tVUkxCcmV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2JyZXcvS1VSTEJyZXcuY3BwCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9i cmV3L0tVUkxCcmV3LmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzNSBAQAorLyoKKyAqIENv cHlyaWdodCAoQykgMjAxMCBDb21wYW55IDEwMCwgSW5jLgorICoKKyAqIFRoaXMgbGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlm eSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCisg KiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBl aXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBh bnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4g dGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJS QU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgKiBNRVJDSEFOVEFC SUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQor ICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgor ICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUg ZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAqIHRoZSBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisgKiBC b3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyAqCisgKi8KKyNpbmNsdWRlICJjb25maWcuaCIK KyNpbmNsdWRlICJLVVJMLmgiCisKKyNpbmNsdWRlICJDU3RyaW5nLmgiCisKKyNpbmNsdWRlIDxB RUVGaWxlLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworU3RyaW5nIEtVUkw6OmZpbGVTeXN0 ZW1QYXRoKCkgY29uc3QKK3sKKyAgICAvLyBBY2Nlc3MgZmlsZXMgcmVsYXRpdmUgdG8gdGhlIGN1 cnJlbnQgbW9kdWxlIGRpcmVjdG9yeSBpbiBhIGNhc2Utc2Vuc2l0aXZlIG1hbm5lci4KKyAgICBy ZXR1cm4gU3RyaW5nKEFFRUZTX0hPTUVfRElSKSArIHBhdGgoKTsKK30KKworfQo= 48149 2010-02-04 09:35:43 -0800 2010-02-09 02:24:18 -0800 Port KURL::fileSystemPath KURL.patch text/plain 2375 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDM0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDItMDQgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBQb3J0IEtVUkw6OmZpbGVTeXN0ZW1QYXRoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDUxNgorCisgICAgICAgIENvbnZlcnQgYSBm aWxlIFVSTCB0byBhIGZpbGUgcGF0aCBieSBwcmVmaXhpbmcKKyAgICAgICAgQUVFRlNfSE9NRV9E SVIgdG8gYWNjZXNzIGZpbGVzIHJlbGF0aXZlIHRvIHRoZSBjdXJyZW50CisgICAgICAgIG1vZHVs ZSBkaXJlY3RvcnkgaW4gYSBjYXNlLXNlbnNpdGl2ZSBtYW5uZXIuCisKKyAgICAgICAgQXMgSVdl YiAiZmlsZToiIGVuZ2luZSBvcGVucyBmaWxlcyBpbiBCUkVXJ3MgYXBwbGljYXRpb24tcmVsYXRp dmUKKyAgICAgICAgZmlsZSBuYW1lc3BhY2UsIHdlIGZvbGxvdyB0aGUgc2FtZSBwb2xpY3kgaGVy ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2JyZXcvS1VSTEJyZXcuY3BwOiBBZGRlZC4KKyAgICAg ICAgKFdlYkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwogMjAxMC0wMi0wNCAgTm8nYW0g Um9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFyaXlhIEhpZGF5YXQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvS1VSTEJyZXcu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYnJldy9LVVJMQnJldy5jcHAJKHJl dmlzaW9uIDApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvS1VSTEJyZXcuY3BwCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDM3IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwIENvbXBhbnkg MTAwLCBJbmMuCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0 aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5 IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogdmVyc2lvbiAyIG9mIHRo ZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorICoKKyAq IFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg dXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGlt cGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBB UlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMaWJyYXJ5IEdlbmVyYWwgUHVibGlj IExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyAqCisgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2 ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgKiBh bG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcuTElCLiAgSWYgbm90 LCB3cml0ZSB0bworICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJh bmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwKKyAqIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNB LgorICoKKyAqLworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIktVUkwuaCIKKworI2lu Y2x1ZGUgIkNTdHJpbmcuaCIKKworI2luY2x1ZGUgPEFFRUZpbGUuaD4KKworbmFtZXNwYWNlIFdl YkNvcmUgeworCitTdHJpbmcgS1VSTDo6ZmlsZVN5c3RlbVBhdGgoKSBjb25zdAoreworICAgIC8v IEFjY2VzcyBmaWxlcyByZWxhdGl2ZSB0byB0aGUgY3VycmVudCBtb2R1bGUgZGlyZWN0b3J5IGlu IGEgY2FzZS1zZW5zaXRpdmUgbWFubmVyLgorICAgIC8vIEFzIElXZWIgImZpbGU6IiBlbmdpbmUg b3BlbnMgZmlsZXMgaW4gQlJFVydzIGFwcGxpY2F0aW9uLXJlbGF0aXZlIGZpbGUgbmFtZXNwYWNl LAorICAgIC8vIHdlIGZvbGxvdyB0aGUgc2FtZSBwb2xpY3kgaGVyZS4KKyAgICByZXR1cm4gU3Ry aW5nKEFFRUZTX0hPTUVfRElSKSArIHBhdGgoKTsKK30KKworfQo=