34510 2010-02-02 18:39:27 -0800 54113 causes crashes with -webkit-gradient and border-bottom 2010-02-02 21:30:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.bing.com/reference/semhtml/Navagio P2 Normal --- 1 jamesr oliver commit-queue hyatt oliver simon.fraser oldest_to_newest 187230 0 jamesr 2010-02-02 18:39:27 -0800 The following: <!DOCTYPE html> <div style="border-bottom:1px solid; background:-webkit-gradient(linear,0% 100%, 0% 100%, from(red),to(blue))"> </div> makes WebKit asplode after r54113. This structure is used on http://www.bing.com/reference/semhtml/Navagio (and probably other pages as well). 187237 1 47988 jamesr 2010-02-02 19:42:28 -0800 Created attachment 47988 Patch 187241 2 47988 dimich 2010-02-02 20:09:50 -0800 Comment on attachment 47988 Patch Looks good. 187258 3 47988 commit-queue 2010-02-02 21:22:19 -0800 Comment on attachment 47988 Patch Clearing flags on attachment: 47988 Committed r54272: <http://trac.webkit.org/changeset/54272> 187259 4 commit-queue 2010-02-02 21:22:26 -0800 All reviewed patches have been landed. Closing bug. 187260 5 jamesr 2010-02-02 21:25:36 -0800 The commit message is pretty borked: http://trac.webkit.org/changeset/54272 I think it's because the diff for WebCore/ChangeLog looks like this: -2010-02-02 Fumitoshi Ukai <ukai@chromium.org> +2010-02-02 James Robinson <jamesr@chromium.org> + Reviewed by NOBODY (OOPS!). + + Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash + https://bugs.webkit.org/show_bug.cgi?id=34510 + + * fast/gradients/crash-on-1px-border.html: Added. + +2010-02-02 Fumitoshi Ukai <ukai@chromium.org> where it should have been just: +2010-02-02 James Robinson <jamesr@chromium.org> + + Reviewed by NOBODY (OOPS!). + + Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash + https://bugs.webkit.org/show_bug.cgi?id=34510 + + * fast/gradients/crash-on-1px-border.html: Added. I guess git got a bit confused when generating the diff? 187262 6 jamesr 2010-02-02 21:30:43 -0800 My apologies, I meant LayoutTests/ChangeLog. The ChangeLog is now slightly out of order as well. 47988 2010-02-02 19:42:28 -0800 2010-02-02 21:22:18 -0800 Patch bug-34510-20100202194227.patch text/plain 2941 jamesr ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMTBhODAxLi5mYTEyODEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTMgQEAKLTIwMTAtMDIt MDIgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisyMDEwLTAyLTAyICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB0aGF0IHRoZSBjb21iaW5hdGlvbiBvZiBi b3JkZXItYm90dG9tOjFweDsgYW5kIC13ZWJraXQtZ3JhZGllbnQobGluZWFyKSBkb2Vzbid0IGNy YXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDUx MAorCisgICAgICAgICogZmFzdC9ncmFkaWVudHMvY3Jhc2gtb24tMXB4LWJvcmRlci5odG1sOiBB ZGRlZC4KKworMjAxMC0wMi0wMiAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9yZz4g CiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCiAKICAgICAgICAgV2Vi U29ja2V0IHdyYXBwZXIgY2FuIGJlIGNvbGxlY3RlZCBldmVuIGlmIGV2ZW50cyBhcmUgcGVuZGlu ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ncmFkaWVudHMvY3Jhc2gtb24tMXB4LWJv cmRlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2dyYWRpZW50cy9jcmFzaC1vbi0x cHgtYm9yZGVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li4wY2NiOTY0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ncmFkaWVudHMv Y3Jhc2gtb24tMXB4LWJvcmRlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitMaW5lYXIg Z3JhZGllbnQgd2l0aCAxcHggYm9yZGVyLWJvdHRvbS4gU2hvdWxkIG5vdCBjcmFzaAorCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZ3JhZGllbnRzL2NyYXNoLW9uLTFweC1ib3JkZXIu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZ3JhZGllbnRzL2NyYXNoLW9uLTFweC1ib3JkZXIuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hNjNjMDQ5Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ncmFkaWVudHMvY3Jhc2gtb24tMXB4LWJvcmRlci5o dG1sCkBAIC0wLDAgKzEsMTUgQEAKKzxoZWFkPgorPHN0eWxlPgorLnRoaW4geworICBib3JkZXIt Ym90dG9tOiAxcHggc29saWQ7CisgIGJhY2tncm91bmQ6IC13ZWJraXQtZ3JhZGllbnQobGluZWFy LCAwJSAxMDAlLCAwJSAxMDAlLCBmcm9tKHJlZCksIHRvKGJsdWUpKQorfQorPC9zdHlsZT4KKzxz Y3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICB3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzxoMT5MaW5lYXIgZ3JhZGllbnQgd2l0aCAxcHggYm9yZGVyLWJvdHRvbS4gU2hvdWxkIG5vdCBj cmFzaDwvaDE+Cis8ZGl2IGNsYXNzPSJ0aGluIj48L2Rpdj4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjkxYmQxYy4uM2FiZWM2NiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMC0wMi0wMiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBhIG51bGwgY2hlY2sgZm9yIGltYWdlLCB3aGljaCBtaWdodCBiZSBOVUxMIGlmIHRpbGVTaXpl IGlzIGVtcHR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNDUxMAorCisgICAgICAgIFRlc3Q6IGZhc3QvZ3JhZGllbnRzL2NyYXNoLW9uLTFweC1ib3Jk ZXIuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveE1vZGVsU2NhbGVPYnNlcnZlcjo6c2hvdWxkUGFp bnRCYWNrZ3JvdW5kQXRMb3dRdWFsaXR5KToKKwogMjAxMC0wMi0wMiAgRnVtaXRvc2hpIFVrYWkg IDx1a2FpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1 cnlha292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmpl Y3QuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCmluZGV4 IGYyY2Q5YmQuLmE2OGM5MzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eE1vZGVsT2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9i amVjdC5jcHAKQEAgLTExOCw3ICsxMTgsNyBAQCBib29sIFJlbmRlckJveE1vZGVsU2NhbGVPYnNl cnZlcjo6c2hvdWxkUGFpbnRCYWNrZ3JvdW5kQXRMb3dRdWFsaXR5KEdyYXBoaWNzQ29udAogewog ICAgIC8vIElmIHRoZSBpbWFnZSBpcyBub3QgYSBiaXRtYXAgaW1hZ2UsIHRoZW4gbm9uZSBvZiB0 aGlzIGlzIHJlbGV2YW50IGFuZCB3ZSBqdXN0IHBhaW50IGF0IGhpZ2gKICAgICAvLyBxdWFsaXR5 LgotICAgIGlmICghaW1hZ2UtPmlzQml0bWFwSW1hZ2UoKSkKKyAgICBpZiAoIWltYWdlIHx8ICFp bWFnZS0+aXNCaXRtYXBJbWFnZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAvLyBN YWtlIHN1cmUgdG8gdXNlIHRoZSB1bnpvb21lZCBpbWFnZSBzaXplLCBzaW5jZSBpZiBhIGZ1bGwg cGFnZSB6b29tIGlzIGluIGVmZmVjdCwgdGhlIGltYWdlCg==