34491 2010-02-02 10:40:56 -0800 [Skia] GraphicsContext::beginTransparencyLayer doesn't retain the compositing mode 2013-04-09 12:51:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 0 gdk gdk commit-queue dglazkov eric krit schenney oldest_to_newest 187042 0 gdk 2010-02-02 10:40:56 -0800 When using the Skia graphics context, the beginTransparencyLayer call currently creates a new layer, but does not keep the current compositing mode for use when merging the created layer back onto the rest of the context. There's a test that exercises this functionality (fast/backgrounds/svg-ask-mask.html), but it's never passed in Chromium. 187044 1 47950 gdk 2010-02-02 10:42:02 -0800 Created attachment 47950 Initial patch 187150 2 eric 2010-02-02 14:24:02 -0800 It's still strange that we have a "PlatformContextSkia" abstraction layer. :) But glad this is fixed. 187167 3 47950 commit-queue 2010-02-02 15:06:59 -0800 Comment on attachment 47950 Initial patch Clearing flags on attachment: 47950 Committed r54257: <http://trac.webkit.org/changeset/54257> 187168 4 commit-queue 2010-02-02 15:07:08 -0800 All reviewed patches have been landed. Closing bug. 187193 5 dglazkov 2010-02-02 16:06:38 -0800 Rolled out in http://trac.webkit.org/changeset/54262, because it broke basically all Win tests :) 47950 2010-02-02 10:42:02 -0800 2010-02-02 16:07:25 -0800 Initial patch skia-transparency-layer.patch text/plain 3919 gdk ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmRhNWUxMy4uNjQ2NGI4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wMi0wMiAgR2FycmV0IEtlbGx5 ICA8Z2RrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaGVuIHVzaW5nIHRoZSBTa2lhIGdyYXBoaWNzIGNvbnRleHQsIHRoZSBi ZWdpblRyYW5zcGFyZW5jeUxheWVyIGNhbGwKKyAgICAgICAgY3VycmVudGx5IGNyZWF0ZXMgYSBu ZXcgbGF5ZXIsIGJ1dCBkb2VzIG5vdCBrZWVwIHRoZSBjdXJyZW50CisgICAgICAgIGNvbXBvc2l0 aW5nIG1vZGUgZm9yIHVzZSB3aGVuIG1lcmdpbmcgdGhlIGNyZWF0ZWQgbGF5ZXIgYmFjayBvbnRv IHRoZQorICAgICAgICByZXN0IG9mIHRoZSBjb250ZXh0LiBUaGlzIHBhdGNoIGZpeGVzIHRoYXQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQ5MQor CisgICAgICAgIGZhc3QvYmFja2dyb3VuZHMvc3ZnLWFzLW1hc2suaHRtbCBpcyBhZmZlY3RlZCBi eSB0aGlzIGNoYW5nZSBpbiBDaHJvbWl1bSwKKyAgICAgICAgYnV0IG5vdCBmaXhlZC4gVGhpcyBp cyB0aGUgZmlyc3Qgb2YgYSBzZXJpZXMgb2YgcGF0Y2hlcyB0byBmaXggaXQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpiZWdpblRyYW5zcGFyZW5jeUxheWVyKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgor ICAgICAgICAoUGxhdGZvcm1Db250ZXh0U2tpYTo6YmVnaW5UcmFuc3BhcmVuY3lMYXllcik6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmg6CisK IDIwMTAtMDItMDIgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5YXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKaW5kZXggYmQ5N2NhMi4u OWViNDllNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBo aWNzQ29udGV4dFNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9H cmFwaGljc0NvbnRleHRTa2lhLmNwcApAQCAtMjY0LDE1ICsyNjQsNyBAQCB2b2lkIEdyYXBoaWNz Q29udGV4dDo6YmVnaW5UcmFuc3BhcmVuY3lMYXllcihmbG9hdCBvcGFjaXR5KQogICAgIGlmIChw YWludGluZ0Rpc2FibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIC8vIFdlIG5lZWQgdGhl ICJhbHBoYSIgbGF5ZXIgZmxhZyBoZXJlIGJlY2F1c2UgdGhlIGJhc2UgbGF5ZXIgaXMgb3BhcXVl Ci0gICAgLy8gKHRoZSBzdXJmYWNlIG9mIHRoZSBwYWdlKSBidXQgbGF5ZXJzIG9uIHRvcCBtYXkg aGF2ZSB0cmFuc3BhcmVudCBwYXJ0cy4KLSAgICAvLyBXaXRob3V0IGV4cGxpY2l0bHkgc2V0dGlu ZyB0aGUgYWxwaGEgZmxhZywgdGhlIGxheWVyIHdpbGwgaW5oZXJpdCB0aGUKLSAgICAvLyBvcGFx dWUgc2V0dGluZyBvZiB0aGUgYmFzZSBhbmQgc29tZSB0aGluZ3Mgd29uJ3Qgd29yayBwcm9wZXJs eS4KLSAgICBwbGF0Zm9ybUNvbnRleHQoKS0+Y2FudmFzKCktPnNhdmVMYXllckFscGhhKAotICAg ICAgICAwLAotICAgICAgICBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPihvcGFjaXR5ICogMjU1 KSwKLSAgICAgICAgc3RhdGljX2Nhc3Q8U2tDYW52YXM6OlNhdmVGbGFncz4oU2tDYW52YXM6OmtI YXNBbHBoYUxheWVyX1NhdmVGbGFnIHwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgU2tDYW52YXM6OmtGdWxsQ29sb3JMYXllcl9TYXZlRmxhZykpOworICAgIHBsYXRm b3JtQ29udGV4dCgpLT5iZWdpblRyYW5zcGFyZW5jeUxheWVyKG9wYWNpdHkpOwogfQogCiB2b2lk IEdyYXBoaWNzQ29udGV4dDo6ZW5kVHJhbnNwYXJlbmN5TGF5ZXIoKQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCmluZGV4 IDkyYTE4NzAuLjZmNTFhNWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKQEAgLTYyMiwzICs2MjIsMTkgQEAgdm9p ZCBQbGF0Zm9ybUNvbnRleHRTa2lhOjphcHBseUFudGlBbGlhc2VkQ2xpcFBhdGhzKFdURjo6VmVj dG9yPFNrUGF0aD4mIHBhdGhzKQogCiAgICAgbV9jYW52YXMtPnJlc3RvcmUoKTsKIH0KKwordm9p ZCBQbGF0Zm9ybUNvbnRleHRTa2lhOjpiZWdpblRyYW5zcGFyZW5jeUxheWVyKGZsb2F0IG9wYWNp dHkpCit7CisgICAgU2tQYWludCBsYXllclBhaW50OworICAgIHNldHVwUGFpbnRDb21tb24oJmxh eWVyUGFpbnQpOworICAgIGxheWVyUGFpbnQuc2V0QWxwaGEoc3RhdGljX2Nhc3Q8dW5zaWduZWQg Y2hhcj4ob3BhY2l0eSAqIDI1NSkpOworCisgICAgLy8gV2UgbmVlZCB0aGUgImFscGhhIiBsYXll ciBmbGFnIGhlcmUgYmVjYXVzZSB0aGUgYmFzZSBsYXllciBpcyBvcGFxdWUKKyAgICAvLyAodGhl IHN1cmZhY2Ugb2YgdGhlIHBhZ2UpIGJ1dCBsYXllcnMgb24gdG9wIG1heSBoYXZlIHRyYW5zcGFy ZW50IHBhcnRzLgorICAgIC8vIFdpdGhvdXQgZXhwbGljaXRseSBzZXR0aW5nIHRoZSBhbHBoYSBm bGFnLCB0aGUgbGF5ZXIgd2lsbCBpbmhlcml0IHRoZQorICAgIC8vIG9wYXF1ZSBzZXR0aW5nIG9m IHRoZSBiYXNlIGFuZCBzb21lIHRoaW5ncyB3b24ndCB3b3JrIHByb3Blcmx5LgorICAgIFNrQ2Fu dmFzOjpTYXZlRmxhZ3MgbGF5ZXJGbGFncyA9IHN0YXRpY19jYXN0PFNrQ2FudmFzOjpTYXZlRmxh Z3M+KAorICAgICAgICBTa0NhbnZhczo6a0hhc0FscGhhTGF5ZXJfU2F2ZUZsYWcgfCBTa0NhbnZh czo6a0Z1bGxDb2xvckxheWVyX1NhdmVGbGFnKTsKKworICAgIG1fY2FudmFzLT5zYXZlTGF5ZXIo MCwgJmxheWVyUGFpbnQsIGxheWVyRmxhZ3MpOworfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuaCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmgKaW5kZXggZTQ0NTI2Mi4uNGJk NDc0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3Jt Q29udGV4dFNraWEuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZv cm1Db250ZXh0U2tpYS5oCkBAIC0xMzcsNiArMTM3LDggQEAgcHVibGljOgogICAgIHZvaWQgYWRk UGF0aChjb25zdCBTa1BhdGgmKTsKICAgICBTa1BhdGggY3VycmVudFBhdGhJbkxvY2FsQ29vcmRp bmF0ZXMoKSBjb25zdDsKIAorICAgIHZvaWQgYmVnaW5UcmFuc3BhcmVuY3lMYXllcihmbG9hdCBv cGFjaXR5KTsKKwogICAgIC8vIFJldHVybnMgdGhlIGZpbGwgY29sb3IuIFRoZSByZXR1cm5lZCBj b2xvciBoYXMgaXQncyBhbHBoYSBhZGp1c3RlZAogICAgIC8vIGJ5IHRoZSBjdXJyZW50IGFscGhh LgogICAgIFNrQ29sb3IgZWZmZWN0aXZlRmlsbENvbG9yKCkgY29uc3Q7Cg==