34471 2010-02-02 04:33:58 -0800 [Chromium] Implement WebFrameImpl::pageNumberForElementById 2010-02-02 20:20:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned hayato webkit.review.bot yuzo oldest_to_newest 186911 0 hamaji 2010-02-02 04:33:58 -0800 This is necessary to implement layoutTestController.pageNumberForElementById in test_shell. This API was added in http://trac.webkit.org/changeset/54205 Chromium bug: http://code.google.com/p/chromium/issues/detail?id=34219 186912 1 47921 hamaji 2010-02-02 04:35:09 -0800 Created attachment 47921 Patch v1 186916 2 webkit.review.bot 2010-02-02 04:40:24 -0800 Attachment 47921 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebFrameImpl.h:168: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.h:169: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1522: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1523: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1532: page_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/public/WebFrame.h:490: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/public/WebFrame.h:491: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 7 If any of these errors are false positives, please file a bug against check-webkit-style. 186920 3 47922 hamaji 2010-02-02 04:48:41 -0800 Created attachment 47922 Patch v2 186921 4 hamaji 2010-02-02 04:49:15 -0800 I've fixed the style issues. Thanks for the bot :) 186978 5 47922 dglazkov 2010-02-02 08:36:14 -0800 Comment on attachment 47922 Patch v2 sounds good! 187245 6 47922 hamaji 2010-02-02 20:20:18 -0800 Comment on attachment 47922 Patch v2 Clearing flags on attachment: 47922 Committed r54270: <http://trac.webkit.org/changeset/54270> 187246 7 hamaji 2010-02-02 20:20:26 -0800 All reviewed patches have been landed. Closing bug. 47921 2010-02-02 04:35:09 -0800 2010-02-02 04:48:34 -0800 Patch v1 bug-34471-20100202043507.patch text/plain 3094 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDc5NjFjN2EuLjFhOGUxMWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTAyLTAyICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBJbXBsZW1lbnQgV2ViRnJhbWVJbXBsOjpwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDcxCisK KyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpwYWdlTnVtYmVyRm9yRWxlbWVu dEJ5SWQpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMC0wMi0wMSAgSmVy ZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKaW5kZXggNTc1ZGFlNi4uYjlk YTRmMCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBi L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtNDgzLDYgKzQ4MywxMyBAQCBw dWJsaWM6CiAgICAgLy8gdXNlZCB0byBzdXBwb3J0IGxheW91dCB0ZXN0cy4KICAgICB2aXJ0dWFs IFdlYlN0cmluZyBjb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlk KSBjb25zdCA9IDA7CiAKKworICAgIC8vIFJldHVybnMgdGhlIG51bWJlciBvZiBwYWdlIHdoZXJl IHRoZSBzcGVjaWZpZWQgZWxlbWVudCB3aWxsIGJlIHB1dC4KKyAgICAvLyBUaGlzIG1ldGhvZCBp cyB1c2VkIHRvIHN1cHBvcnQgbGF5b3V0IHRlc3RzLgorICAgIHZpcnR1YWwgaW50IHBhZ2VOdW1i ZXJGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlkLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmbG9hdCBwYWdlX3dpZHRoX2luX3BpeGVscywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxvYXQgcGFnZV9oZWlnaHRfaW5f cGl4ZWxzKSBjb25zdCA9IDA7CisKIHByb3RlY3RlZDoKICAgICB+V2ViRnJhbWUoKSB7IH0KIH07 CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggNzk0N2MxOS4uNzRkMDY0NyAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBiL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMTUxOCw2ICsxNTE4LDIxIEBA IFdlYlN0cmluZyBXZWJGcmFtZUltcGw6OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKGNvbnN0 IFdlYlN0cmluZyYgaWQpIGNvbnN0CiAgICAgcmV0dXJuIGNvdW50ZXJWYWx1ZUZvckVsZW1lbnQo ZWxlbWVudCk7CiB9CiAKK2ludCBXZWJGcmFtZUltcGw6OnBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJ ZChjb25zdCBXZWJTdHJpbmcmIGlkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZsb2F0IHBhZ2Vfd2lkdGhfaW5fcGl4ZWxzLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGZsb2F0IHBhZ2VfaGVpZ2h0X2luX3BpeGVscykgY29u c3QKK3sKKyAgICBpZiAoIW1fZnJhbWUpCisgICAgICAgIHJldHVybiAtMTsKKworICAgIEVsZW1l bnQqIGVsZW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5nZXRFbGVtZW50QnlJZChpZCk7Cisg ICAgaWYgKCFlbGVtZW50KQorICAgICAgICByZXR1cm4gLTE7CisKKyAgICBGbG9hdFNpemUgcGFn ZV9zaXplKHBhZ2Vfd2lkdGhfaW5fcGl4ZWxzLCBwYWdlX2hlaWdodF9pbl9waXhlbHMpOworICAg IHJldHVybiBQcmludENvbnRleHQ6OnBhZ2VOdW1iZXJGb3JFbGVtZW50KGVsZW1lbnQsIHBhZ2Vf c2l6ZSk7Cit9CisKIC8vIFdlYkZyYW1lSW1wbCBwdWJsaWMgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIFBhc3NSZWZQdHI8V2ViRnJh bWVJbXBsPiBXZWJGcmFtZUltcGw6OmNyZWF0ZShXZWJGcmFtZUNsaWVudCogY2xpZW50KQpkaWZm IC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKaW5kZXggYmUxMmRiZi4uMzllZTljOSAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBAIC0xNjQsNiArMTY0LDkgQEAgcHVibGljOgogICAgIHZp cnR1YWwgV2ViU3RyaW5nIGNvbnRlbnRBc01hcmt1cCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2Vi U3RyaW5nIHJlbmRlclRyZWVBc1RleHQoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBj b3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlkKSBjb25zdDsKKyAg ICB2aXJ0dWFsIGludCBwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQoY29uc3QgV2ViU3RyaW5nJiBp ZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxvYXQgcGFnZV93 aWR0aF9pbl9waXhlbHMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGZsb2F0IHBhZ2VfaGVpZ2h0X2luX3BpeGVscykgY29uc3Q7CiAKICAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxXZWJGcmFtZUltcGw+IGNyZWF0ZShXZWJGcmFtZUNsaWVudCogY2xpZW50KTsKICAgICB+ V2ViRnJhbWVJbXBsKCk7Cg== 47922 2010-02-02 04:48:41 -0800 2010-02-02 20:20:18 -0800 Patch v2 bug-34471-20100202044839.patch text/plain 3068 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDc5NjFjN2EuLjFhOGUxMWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTAyLTAyICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBJbXBsZW1lbnQgV2ViRnJhbWVJbXBsOjpwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDcxCisK KyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpwYWdlTnVtYmVyRm9yRWxlbWVu dEJ5SWQpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMC0wMi0wMSAgSmVy ZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKaW5kZXggNTc1ZGFlNi4uYTU2 ZTZjYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBi L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtNDgzLDYgKzQ4MywxMyBAQCBw dWJsaWM6CiAgICAgLy8gdXNlZCB0byBzdXBwb3J0IGxheW91dCB0ZXN0cy4KICAgICB2aXJ0dWFs IFdlYlN0cmluZyBjb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlk KSBjb25zdCA9IDA7CiAKKworICAgIC8vIFJldHVybnMgdGhlIG51bWJlciBvZiBwYWdlIHdoZXJl IHRoZSBzcGVjaWZpZWQgZWxlbWVudCB3aWxsIGJlIHB1dC4KKyAgICAvLyBUaGlzIG1ldGhvZCBp cyB1c2VkIHRvIHN1cHBvcnQgbGF5b3V0IHRlc3RzLgorICAgIHZpcnR1YWwgaW50IHBhZ2VOdW1i ZXJGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlkLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmbG9hdCBwYWdlV2lkdGhJblBpeGVscywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxvYXQgcGFnZUhlaWdodEluUGl4ZWxz KSBjb25zdCA9IDA7CisKIHByb3RlY3RlZDoKICAgICB+V2ViRnJhbWUoKSB7IH0KIH07CmRpZmYg LS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggNzk0N2MxOS4uMmY5MTFmMSAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBiL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMTUxOCw2ICsxNTE4LDIxIEBAIFdlYlN0 cmluZyBXZWJGcmFtZUltcGw6OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKGNvbnN0IFdlYlN0 cmluZyYgaWQpIGNvbnN0CiAgICAgcmV0dXJuIGNvdW50ZXJWYWx1ZUZvckVsZW1lbnQoZWxlbWVu dCk7CiB9CiAKK2ludCBXZWJGcmFtZUltcGw6OnBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJZChjb25z dCBXZWJTdHJpbmcmIGlkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGZsb2F0IHBhZ2VXaWR0aEluUGl4ZWxzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZsb2F0IHBhZ2VIZWlnaHRJblBpeGVscykgY29uc3QKK3sKKyAgICBp ZiAoIW1fZnJhbWUpCisgICAgICAgIHJldHVybiAtMTsKKworICAgIEVsZW1lbnQqIGVsZW1lbnQg PSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5nZXRFbGVtZW50QnlJZChpZCk7CisgICAgaWYgKCFlbGVt ZW50KQorICAgICAgICByZXR1cm4gLTE7CisKKyAgICBGbG9hdFNpemUgcGFnZVNpemUocGFnZVdp ZHRoSW5QaXhlbHMsIHBhZ2VIZWlnaHRJblBpeGVscyk7CisgICAgcmV0dXJuIFByaW50Q29udGV4 dDo6cGFnZU51bWJlckZvckVsZW1lbnQoZWxlbWVudCwgcGFnZVNpemUpOworfQorCiAvLyBXZWJG cmFtZUltcGwgcHVibGljIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogCiBQYXNzUmVmUHRyPFdlYkZyYW1lSW1wbD4gV2ViRnJhbWVJbXBs OjpjcmVhdGUoV2ViRnJhbWVDbGllbnQqIGNsaWVudCkKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRnJhbWVJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5oCmluZGV4IGJlMTJkYmYuLmNjYmE2ZDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwu aApAQCAtMTY0LDYgKzE2NCw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBjb250 ZW50QXNNYXJrdXAoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyByZW5kZXJUcmVlQXNU ZXh0KCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgY291bnRlclZhbHVlRm9yRWxlbWVu dEJ5SWQoY29uc3QgV2ViU3RyaW5nJiBpZCkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQgcGFnZU51 bWJlckZvckVsZW1lbnRCeUlkKGNvbnN0IFdlYlN0cmluZyYgaWQsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGZsb2F0IHBhZ2VXaWR0aEluUGl4ZWxzLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbG9hdCBwYWdlSGVpZ2h0SW5QaXhl bHMpIGNvbnN0OwogCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8V2ViRnJhbWVJbXBsPiBjcmVhdGUo V2ViRnJhbWVDbGllbnQqIGNsaWVudCk7CiAgICAgfldlYkZyYW1lSW1wbCgpOwo=