34466 2010-02-01 23:46:02 -0800 [Chromium] WebSecurityOrigin::createFromDatabaseIdentifier should not return a pointer 2010-04-16 19:22:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow dumi fishd oldest_to_newest 186825 0 jorlow 2010-02-01 23:46:02 -0800 WebSecurityOrigin::createFromDatabaseIdentifier should not return a pointer to a WebSecurityOrigin. It should simply be a WebSecurityOrigin. 189768 1 jorlow 2010-02-11 12:11:53 -0800 Thanks for taking that on Dumi! If you're super brave, there are probably other places like this that can be changed. If you're super duper brave, there are other places that can be changed like this IFF you add an equals operator to them (like WebStorageNamespace). If you don't want to do that stuff, it's fine though. 213456 2 53573 dumi 2010-04-16 15:46:26 -0700 Created attachment 53573 patch Will land in Chromium as a 2-sided patch. 213460 3 53573 jorlow 2010-04-16 15:58:42 -0700 Comment on attachment 53573 patch Please follow the standard changeLog conventions. 213562 4 dumi 2010-04-16 19:22:38 -0700 Landed as r57768 in WebKit and 44870 in Chromium. 53573 2010-04-16 15:46:26 -0700 2010-04-16 15:58:54 -0700 patch patch text/plain 3345 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTc3NTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMTYgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2luZyB0aGUgcmV0dXJuIHR5cGUgb2YKKyAg ICAgICAgV2ViU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21EYXRhYmFzZUlkZW50aWZpZXIoKSBm cm9tCisgICAgICAgIFdlYlNlY3VyaXR5T3JpZ2luKiB0byBXZWJTZWN1cml0eU9yaWdpbi4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDY2CisKKyAg ICAgICAgKiBwdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaDoKKyAgICAgICAgKiBzcmMvV2ViRGF0 YWJhc2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEYXRhYmFzZTo6Y2xvc2VEYXRhYmFzZUlt bWVkaWF0ZWx5KToKKyAgICAgICAgKiBzcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmll cik6CisKIDIwMTAtMDQtMTYgIEphcmtrbyBTYWtraW5lbiAgPGphcmtrby5qLnNha2tpbmVuQGdt YWlsLmNvbT4KICAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oCShyZXZpc2lvbiA1Nzc1 MykKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaAkod29ya2lu ZyBjb3B5KQpAQCAtNTYsOCArNTYsNyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiAqdGhpczsK ICAgICB9CiAKLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmV0dXJuIGEgV2ViU2VjdXJpdHlP cmlnaW4sIG5vdCBhIHBvaW50ZXIgdG8gb25lLgotICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYlNl Y3VyaXR5T3JpZ2luKiBjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVyKGNvbnN0IFdlYlN0cmlu ZyYgZGF0YWJhc2VJZGVudGlmaWVyKTsKKyAgICBXRUJLSVRfQVBJIHN0YXRpYyBXZWJTZWN1cml0 eU9yaWdpbiBjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVyKGNvbnN0IFdlYlN0cmluZyYgZGF0 YWJhc2VJZGVudGlmaWVyKTsKICAgICBXRUJLSVRfQVBJIHN0YXRpYyBXZWJTZWN1cml0eU9yaWdp biBjcmVhdGVGcm9tU3RyaW5nKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIFdFQktJVF9BUEkgc3Rh dGljIFdlYlNlY3VyaXR5T3JpZ2luIGNyZWF0ZShjb25zdCBXZWJVUkwmKTsKIApJbmRleDogV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhYmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL3NyYy9XZWJEYXRhYmFzZS5jcHAJKHJldmlzaW9uIDU3NzUzKQorKysgV2ViS2l0L2No cm9taXVtL3NyYy9XZWJEYXRhYmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMSw3ICsxMTEs NyBAQCB2b2lkIFdlYkRhdGFiYXNlOjp1cGRhdGVEYXRhYmFzZVNpemUoCiB2b2lkIFdlYkRhdGFi YXNlOjpjbG9zZURhdGFiYXNlSW1tZWRpYXRlbHkoY29uc3QgV2ViU3RyaW5nJiBvcmlnaW5JZGVu dGlmaWVyLCBjb25zdCBXZWJTdHJpbmcmIGRhdGFiYXNlTmFtZSkKIHsKICAgICBIYXNoU2V0PFJl ZlB0cjxEYXRhYmFzZT4gPiBkYXRhYmFzZUhhbmRsZXM7Ci0gICAgUGFzc1JlZlB0cjxTZWN1cml0 eU9yaWdpbj4gb3JpZ2luUHJwKCpXZWJTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNl SWRlbnRpZmllcihvcmlnaW5JZGVudGlmaWVyKSk7CisgICAgUGFzc1JlZlB0cjxTZWN1cml0eU9y aWdpbj4gb3JpZ2luUHJwKFdlYlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tRGF0YWJhc2VJZGVu dGlmaWVyKG9yaWdpbklkZW50aWZpZXIpKTsKICAgICBSZWZQdHI8U2VjdXJpdHlPcmlnaW4+IG9y aWdpbiA9IG9yaWdpblBycDsKICAgICBEYXRhYmFzZVRyYWNrZXI6OnRyYWNrZXIoKS5nZXRPcGVu RGF0YWJhc2VzKG9yaWdpbi5nZXQoKSwgZGF0YWJhc2VOYW1lLCAmZGF0YWJhc2VIYW5kbGVzKTsK ICAgICBmb3IgKEhhc2hTZXQ8UmVmUHRyPERhdGFiYXNlPiA+OjppdGVyYXRvciBpdCA9IGRhdGFi YXNlSGFuZGxlcy5iZWdpbigpOyBpdCAhPSBkYXRhYmFzZUhhbmRsZXMuZW5kKCk7ICsraXQpIHsK SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwCShyZXZpc2lv biA1Nzc1MykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00NCw5ICs0NCw5IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3Mg V2ViU2VjdXJpdHlPcmlnaW5Qcml2YXRlIDogcHVibGljIFNlY3VyaXR5T3JpZ2luIHsKIH07CiAK LVdlYlNlY3VyaXR5T3JpZ2luKiBXZWJTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNl SWRlbnRpZmllcihjb25zdCBXZWJTdHJpbmcmIGRhdGFiYXNlSWRlbnRpZmllcikKK1dlYlNlY3Vy aXR5T3JpZ2luIFdlYlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVy KGNvbnN0IFdlYlN0cmluZyYgZGF0YWJhc2VJZGVudGlmaWVyKQogewotICAgIHJldHVybiBuZXcg V2ViU2VjdXJpdHlPcmlnaW4oU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21EYXRhYmFzZUlkZW50 aWZpZXIoZGF0YWJhc2VJZGVudGlmaWVyKSk7CisgICAgcmV0dXJuIFdlYlNlY3VyaXR5T3JpZ2lu KFNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVyKGRhdGFiYXNlSWRl bnRpZmllcikpOwogfQogCiBXZWJTZWN1cml0eU9yaWdpbiBXZWJTZWN1cml0eU9yaWdpbjo6Y3Jl YXRlRnJvbVN0cmluZyhjb25zdCBXZWJTdHJpbmcmIG9yaWdpbikK