34460 2010-02-01 18:17:09 -0800 [Chromium] Add WebSecurityOrigin::createFromString factory 2010-02-02 00:52:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow webkit-unassigned oldest_to_newest 186744 0 jorlow 2010-02-01 18:17:09 -0800 [Chromium] Add WebSecurityOrigin::createFromString factory 186745 1 47894 jorlow 2010-02-01 18:17:49 -0800 Created attachment 47894 Patch 186818 2 47894 fishd 2010-02-01 22:55:06 -0800 Comment on attachment 47894 Patch > Index: WebKit/chromium/public/WebSecurityOrigin.h > WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& databaseIdentifier); > + WEBKIT_API static WebSecurityOrigin* createFromString(const WebString& origin); There's no reason for either of these to return pointers. WebSecurityOrigin is already like a smart pointer class. Just return by value. 186824 3 47908 jorlow 2010-02-01 23:43:30 -0800 Created attachment 47908 Patch 186836 4 47908 fishd 2010-02-02 00:09:19 -0800 Comment on attachment 47908 Patch > Index: WebKit/chromium/public/WebSecurityOrigin.h > + WEBKIT_API static WebSecurityOrigin createFromString(const WebString& origin); nit: nix the origin parameter name. otherwise, r=me 186850 5 jorlow 2010-02-02 00:52:38 -0800 Committed r54214: <http://trac.webkit.org/changeset/54214> 47894 2010-02-01 18:17:49 -0800 2010-02-01 23:43:26 -0800 Patch bug-34460-20100201181748.patch text/plain 1832 jorlow SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQxODkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDEgIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBBZGQgV2ViU2VjdXJpdHlPcmlnaW46 OmNyZWF0ZUZyb21TdHJpbmcgZmFjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzQ0NjAKKworICAgICAgICAqIHB1YmxpYy9XZWJTZWN1cml0eU9y aWdpbi5oOgorICAgICAgICAqIHNyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5nKToKKwogMjAxMC0wMS0y NyAgTWF0dCBQZXJyeSAgPG1wY29tcGxldGVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1 cml0eU9yaWdpbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2Vj dXJpdHlPcmlnaW4uaAkocmV2aXNpb24gNTQxNDApCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlNlY3VyaXR5T3JpZ2luLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDYgKzU2LDcgQEAgcHVi bGljOgogICAgIH0KIAogICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYlNlY3VyaXR5T3JpZ2luKiBj cmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVyKGNvbnN0IFdlYlN0cmluZyYgZGF0YWJhc2VJZGVu dGlmaWVyKTsKKyAgICBXRUJLSVRfQVBJIHN0YXRpYyBXZWJTZWN1cml0eU9yaWdpbiogY3JlYXRl RnJvbVN0cmluZyhjb25zdCBXZWJTdHJpbmcmIG9yaWdpbik7CiAKICAgICBXRUJLSVRfQVBJIHZv aWQgcmVzZXQoKTsKICAgICBXRUJLSVRfQVBJIHZvaWQgYXNzaWduKGNvbnN0IFdlYlNlY3VyaXR5 T3JpZ2luJik7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNw cAkocmV2aXNpb24gNTQxNDApCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3Jp Z2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsMTEgQEAgV2ViU2VjdXJpdHlPcmln aW4qIFdlYlNlY3VyaXR5T3JpZ2luOjpjcgogICAgIHJldHVybiBuZXcgV2ViU2VjdXJpdHlPcmln aW4oU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21EYXRhYmFzZUlkZW50aWZpZXIoZGF0YWJhc2VJ ZGVudGlmaWVyKSk7CiB9CiAKK1dlYlNlY3VyaXR5T3JpZ2luKiBXZWJTZWN1cml0eU9yaWdpbjo6 Y3JlYXRlRnJvbVN0cmluZyhjb25zdCBXZWJTdHJpbmcmIG9yaWdpbikKK3sKKyAgICByZXR1cm4g bmV3IFdlYlNlY3VyaXR5T3JpZ2luKFNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5nKG9y aWdpbikpOworfQorCiB2b2lkIFdlYlNlY3VyaXR5T3JpZ2luOjpyZXNldCgpCiB7CiAgICAgYXNz aWduKDApOwo= 47908 2010-02-01 23:43:30 -0800 2010-02-02 00:09:18 -0800 Patch bug-34460-20100201234328.patch text/plain 1948 jorlow SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQxOTUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDEgIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBBZGQgV2ViU2VjdXJpdHlPcmlnaW46 OmNyZWF0ZUZyb21TdHJpbmcgZmFjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzQ0NjAKKworICAgICAgICAqIHB1YmxpYy9XZWJTZWN1cml0eU9y aWdpbi5oOgorICAgICAgICAqIHNyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5nKToKKwogMjAxMC0wMi0w MSAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgYXR0ZW1wdCB0byBmaXggdGhlIGJyb2tlbiBidWlsZC4KSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgJKHJldmlzaW9uIDU0MTk1KQorKysg V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oCSh3b3JraW5nIGNvcHkp CkBAIC01NSw3ICs1NSw5IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0K IAorICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCByZXR1cm4gYSBXZWJTZWN1cml0eU9yaWdpbiwg bm90IGEgcG9pbnRlciB0byBvbmUuCiAgICAgV0VCS0lUX0FQSSBzdGF0aWMgV2ViU2VjdXJpdHlP cmlnaW4qIGNyZWF0ZUZyb21EYXRhYmFzZUlkZW50aWZpZXIoY29uc3QgV2ViU3RyaW5nJiBkYXRh YmFzZUlkZW50aWZpZXIpOworICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYlNlY3VyaXR5T3JpZ2lu IGNyZWF0ZUZyb21TdHJpbmcoY29uc3QgV2ViU3RyaW5nJiBvcmlnaW4pOwogCiAgICAgV0VCS0lU X0FQSSB2b2lkIHJlc2V0KCk7CiAgICAgV0VCS0lUX0FQSSB2b2lkIGFzc2lnbihjb25zdCBXZWJT ZWN1cml0eU9yaWdpbiYpOwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9y aWdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9y aWdpbi5jcHAJKHJldmlzaW9uIDU0MTk1KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1 cml0eU9yaWdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYgKzQ3LDExIEBAIFdlYlNlY3Vy aXR5T3JpZ2luKiBXZWJTZWN1cml0eU9yaWdpbjo6Y3IKICAgICByZXR1cm4gbmV3IFdlYlNlY3Vy aXR5T3JpZ2luKFNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVyKGRh dGFiYXNlSWRlbnRpZmllcikpOwogfQogCitXZWJTZWN1cml0eU9yaWdpbiBXZWJTZWN1cml0eU9y aWdpbjo6Y3JlYXRlRnJvbVN0cmluZyhjb25zdCBXZWJTdHJpbmcmIG9yaWdpbikKK3sKKyAgICBy ZXR1cm4gV2ViU2VjdXJpdHlPcmlnaW4oU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21TdHJpbmco b3JpZ2luKSk7Cit9CisKIHZvaWQgV2ViU2VjdXJpdHlPcmlnaW46OnJlc2V0KCkKIHsKICAgICBh c3NpZ24oMCk7Cg==