34453 2010-02-01 15:54:40 -0800 [V8] Raising an exception while setting timeout/interval from a detached frame 2010-02-02 04:43:53 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kkanetkar kkanetkar commit-queue dimich japhet oldest_to_newest 186623 0 kkanetkar 2010-02-01 15:54:40 -0800 In http://trac.webkit.org/changeset/53439, raising exception was added to JSC bindings. Doing the same in V8 bindings. 186690 1 47877 kkanetkar 2010-02-01 16:39:20 -0800 Created attachment 47877 proposed fix 186742 2 dimich 2010-02-01 18:13:21 -0800 Is it possible to test this? 186743 3 kkanetkar 2010-02-01 18:16:55 -0800 I tested it locally on my machine, but I do not have the permission to run it on tribots. Let me know. 186753 4 47898 kkanetkar 2010-02-01 18:39:49 -0800 Created attachment 47898 patch2 Mentioned Chrome bug that has the layout test reference in ChangeLog. 186756 5 47898 dimich 2010-02-01 18:43:54 -0800 Comment on attachment 47898 patch2 So it fixes existing layout test that fails in Chromium (fast/dom/Window/timer-null-script-execution-context.html). Great. r=me 186917 6 47898 commit-queue 2010-02-02 04:43:46 -0800 Comment on attachment 47898 patch2 Clearing flags on attachment: 47898 Committed r54227: <http://trac.webkit.org/changeset/54227> 186918 7 commit-queue 2010-02-02 04:43:53 -0800 All reviewed patches have been landed. Closing bug. 47877 2010-02-01 16:39:20 -0800 2010-02-01 18:39:49 -0800 proposed fix bug3patch1.txt text/plain 1960 kkanetkar SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDE2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDEgIEthdml0YSBLYW5ldGthciAgPGtrYW5ldGthckBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1Y4XSBSYWlzaW5nIGFuIGV4Y2VwdGlvbiB3aGlsZSBzZXR0aW5nIHRpbWVvdXQvaW50 ZXJ2YWwgZnJvbSBhIGRldGFjaGVkIGZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQ1MworCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0 b20vVjhET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2luZG93U2V0VGlt ZW91dEltcGwpOgorCiAyMDEwLTAyLTAxICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCShyZXZpc2lv biA1NDE2MykKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9t LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzgsOCArNzgsMTUgQEAKICAgICBpZiAoYXJndW1lbnRD b3VudCA8IDEpCiAgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAKKyAgICBET01XaW5k b3cqIGltcCA9IFY4RE9NV2luZG93Ojp0b05hdGl2ZShhcmdzLkhvbGRlcigpKTsKKyAgICBTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBzY3JpcHRDb250ZXh0ID0gc3RhdGljX2Nhc3Q8U2NyaXB0RXhl Y3V0aW9uQ29udGV4dCo+KGltcC0+ZG9jdW1lbnQoKSk7CisKKyAgICBpZiAoIXNjcmlwdENvbnRl eHQpIHsKKyAgICAgICAgVjhQcm94eTo6c2V0RE9NRXhjZXB0aW9uKElOVkFMSURfQUNDRVNTX0VS Uik7CisgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisgICAgfQorCiAgICAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IGZ1bmN0aW9uID0gYXJnc1swXTsKLQogICAgIFdlYkNvcmU6OlN0cmlu ZyBmdW5jdGlvblN0cmluZzsKICAgICBpZiAoIWZ1bmN0aW9uLT5Jc0Z1bmN0aW9uKCkpIHsKICAg ICAgICAgaWYgKGZ1bmN0aW9uLT5Jc1N0cmluZygpKQpAQCAtMTA0LDE2ICsxMTEsOSBAQAogICAg IGlmIChhcmd1bWVudENvdW50ID49IDIpCiAgICAgICAgIHRpbWVvdXQgPSBhcmdzWzFdLT5JbnQz MlZhbHVlKCk7CiAKLSAgICBET01XaW5kb3cqIGltcCA9IFY4RE9NV2luZG93Ojp0b05hdGl2ZShh cmdzLkhvbGRlcigpKTsKLQogICAgIGlmICghVjhCaW5kaW5nU2VjdXJpdHk6OmNhbkFjY2Vzc0Zy YW1lKFY4QmluZGluZ1N0YXRlOjpPbmx5KCksIGltcC0+ZnJhbWUoKSwgdHJ1ZSkpCiAgICAgICAg IHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAKLSAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBz Y3JpcHRDb250ZXh0ID0gc3RhdGljX2Nhc3Q8U2NyaXB0RXhlY3V0aW9uQ29udGV4dCo+KGltcC0+ ZG9jdW1lbnQoKSk7Ci0KLSAgICBpZiAoIXNjcmlwdENvbnRleHQpCi0gICAgICAgIHJldHVybiB2 ODo6VW5kZWZpbmVkKCk7Ci0KICAgICBpbnQgaWQ7CiAgICAgaWYgKGZ1bmN0aW9uLT5Jc0Z1bmN0 aW9uKCkpIHsKICAgICAgICAgaW50IHBhcmFtQ291bnQgPSBhcmd1bWVudENvdW50ID49IDIgPyBh cmd1bWVudENvdW50IC0gMiA6IDA7Cg== 47898 2010-02-01 18:39:49 -0800 2010-02-02 04:43:46 -0800 patch2 bug3patch2.txt text/plain 2096 kkanetkar SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDE2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMDEgIEthdml0YSBLYW5ldGthciAgPGtrYW5ldGthckBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1Y4XSBSYWlzaW5nIGFuIGV4Y2VwdGlvbiB3aGlsZSBzZXR0aW5nIHRpbWVvdXQvaW50 ZXJ2YWwgZnJvbSBhIGRldGFjaGVkIGZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQ1MworICAgICAgICBUaGlzIGZpeGVzIHRoZSBpc3N1ZS9m YWlsaW5nIHRlc3QgbWVudGlvbmVkIGluIENocm9taXVtIGJ1ZzoKKyAgICAgICAgaHR0cDovL2Nv ZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MzI2NzEKKworCisgICAg ICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OldpbmRvd1NldFRpbWVvdXRJbXBsKToKKwogMjAxMC0wMi0wMSAgRHVtaXRydSBE YW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0 b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2lu ZG93Q3VzdG9tLmNwcAkocmV2aXNpb24gNTQxNjMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc4LDggKzc4LDE1 IEBACiAgICAgaWYgKGFyZ3VtZW50Q291bnQgPCAxKQogICAgICAgICByZXR1cm4gdjg6OlVuZGVm aW5lZCgpOwogCisgICAgRE9NV2luZG93KiBpbXAgPSBWOERPTVdpbmRvdzo6dG9OYXRpdmUoYXJn cy5Ib2xkZXIoKSk7CisgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0Q29udGV4dCA9 IHN0YXRpY19jYXN0PFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqPihpbXAtPmRvY3VtZW50KCkpOwor CisgICAgaWYgKCFzY3JpcHRDb250ZXh0KSB7CisgICAgICAgIFY4UHJveHk6OnNldERPTUV4Y2Vw dGlvbihJTlZBTElEX0FDQ0VTU19FUlIpOworICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgp OworICAgIH0KKwogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBmdW5jdGlvbiA9IGFyZ3NbMF07 Ci0KICAgICBXZWJDb3JlOjpTdHJpbmcgZnVuY3Rpb25TdHJpbmc7CiAgICAgaWYgKCFmdW5jdGlv bi0+SXNGdW5jdGlvbigpKSB7CiAgICAgICAgIGlmIChmdW5jdGlvbi0+SXNTdHJpbmcoKSkKQEAg LTEwNCwxNiArMTExLDkgQEAKICAgICBpZiAoYXJndW1lbnRDb3VudCA+PSAyKQogICAgICAgICB0 aW1lb3V0ID0gYXJnc1sxXS0+SW50MzJWYWx1ZSgpOwogCi0gICAgRE9NV2luZG93KiBpbXAgPSBW OERPTVdpbmRvdzo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0KICAgICBpZiAoIVY4QmluZGlu Z1NlY3VyaXR5OjpjYW5BY2Nlc3NGcmFtZShWOEJpbmRpbmdTdGF0ZTo6T25seSgpLCBpbXAtPmZy YW1lKCksIHRydWUpKQogICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogCi0gICAgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0Q29udGV4dCA9IHN0YXRpY19jYXN0PFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqPihpbXAtPmRvY3VtZW50KCkpOwotCi0gICAgaWYgKCFzY3JpcHRDb250 ZXh0KQotICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwotCiAgICAgaW50IGlkOwogICAg IGlmIChmdW5jdGlvbi0+SXNGdW5jdGlvbigpKSB7CiAgICAgICAgIGludCBwYXJhbUNvdW50ID0g YXJndW1lbnRDb3VudCA+PSAyID8gYXJndW1lbnRDb3VudCAtIDIgOiAwOwo=