34448 2010-02-01 14:00:58 -0800 RenderVideo::intrinsicSizeChanged infinite recursion 2010-02-01 14:21:39 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 186565 0 eric.carlson 2010-02-01 14:00:58 -0800 RenderVideo:: intrinsicSizeChanged calls RenderVideo:: intrinsicSizeChanged when it has a poster. Stupid at best, crashing at worse. 186566 1 eric.carlson 2010-02-01 14:01:18 -0800 <rdar://problem/7598130> 186571 2 47870 eric.carlson 2010-02-01 14:10:31 -0800 Created attachment 47870 Proposed patch 186573 3 47870 mitz 2010-02-01 14:17:47 -0800 Comment on attachment 47870 Proposed patch Eric told me that there’s no regression test because he was unable to reproduce the crash. 186574 4 eric.carlson 2010-02-01 14:21:39 -0800 http://trac.webkit.org/changeset/54151 47870 2010-02-01 14:10:31 -0800 2010-02-01 14:17:47 -0800 Proposed patch patch_1.txt text/plain 2785 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDE0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDItMDEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDQ4CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS83NTk4MTMwPgorCisgICAgICAgIFJlbmRlclZpZGVvOjppbnRyaW5z aWNTaXplQ2hhbmdlZCBpbmZpbml0ZSByZWN1cnNpb24KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJJbWFnZS5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW1hZ2U6OmludHJpbnNpY1Np emVDaGFuZ2VkKTogTWFrZSBwcm90ZWN0ZWQgaW5zdGVhZCBvZiBwcml2YXRlIHNvIGl0IGNhbgor ICAgICAgICAgICAgYmUgY2FsbGVkIGJ5IFJlbmRlclZpZGVvLgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJWaWRlby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWRlbzo6aW50cmlu c2ljU2l6ZUNoYW5nZWQpOiBDYWxsIFJlbmRlck1lZGlhOjppbnRyaW5zaWNTaXplQ2hhbmdlZCwg bm90CisgICAgICAgICAgICBSZW5kZXJWaWRlbzo6aW50cmluc2ljU2l6ZUNoYW5nZWQuCisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJWaWRlbzo6aW1hZ2VDaGFuZ2VkKTogQ2FsbCBSZW5kZXJNZWRp YTo6aW1hZ2VDaGFuZ2VkIGluc3RlYWQgb2YgCisgICAgICAgICAgICBSZW5kZXJJbWFnZTo6aW1h Z2VDaGFuZ2VkLgorCiAyMDEwLTAyLTAxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbi4KSW5kZXg6IFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckltYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW1hZ2UuaAkocmV2aXNpb24gNTQxNDApCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJJbWFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2ICs2NCw4IEBAIHByb3RlY3RlZDoKICAg ICBib29sIGlzV2lkdGhTcGVjaWZpZWQoKSBjb25zdDsKICAgICBib29sIGlzSGVpZ2h0U3BlY2lm aWVkKCkgY29uc3Q7CiAKKyAgICB2aXJ0dWFsIHZvaWQgaW50cmluc2ljU2l6ZUNoYW5nZWQoKSB7 IGltYWdlQ2hhbmdlZChpbWFnZVB0cigpKTsgfQorCiBwcml2YXRlOgogICAgIHZpcnR1YWwgY29u c3QgY2hhciogcmVuZGVyTmFtZSgpIGNvbnN0IHsgcmV0dXJuICJSZW5kZXJJbWFnZSI7IH0KIApA QCAtODksOCArOTEsNiBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgSW50U2l6ZSBpbWFnZVNpemUo ZmxvYXQgbXVsdGlwbGllcikgY29uc3QgeyByZXR1cm4gbV9jYWNoZWRJbWFnZSA/IG1fY2FjaGVk SW1hZ2UtPmltYWdlU2l6ZShtdWx0aXBsaWVyKSA6IEludFNpemUoKTsgfQogICAgIHZpcnR1YWwg V3JhcHBlZEltYWdlUHRyIGltYWdlUHRyKCkgY29uc3QgeyByZXR1cm4gbV9jYWNoZWRJbWFnZS5n ZXQoKTsgfQogCi0gICAgdmlydHVhbCB2b2lkIGludHJpbnNpY1NpemVDaGFuZ2VkKCkgeyBpbWFn ZUNoYW5nZWQoaW1hZ2VQdHIoKSk7IH0KLQogICAgIGludCBjYWxjQXNwZWN0UmF0aW9XaWR0aCgp IGNvbnN0OwogICAgIGludCBjYWxjQXNwZWN0UmF0aW9IZWlnaHQoKSBjb25zdDsKIApJbmRleDog V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcAkocmV2aXNpb24gNTQxNDApCisrKyBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJWaWRlby5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1LDcgKzg1LDcgQEAg UmVuZGVyVmlkZW86On5SZW5kZXJWaWRlbygpCiB2b2lkIFJlbmRlclZpZGVvOjppbnRyaW5zaWNT aXplQ2hhbmdlZCgpCiB7CiAgICAgaWYgKHZpZGVvRWxlbWVudCgpLT5zaG91bGREaXNwbGF5UG9z dGVySW1hZ2UoKSkKLSAgICAgICAgUmVuZGVyVmlkZW86OmludHJpbnNpY1NpemVDaGFuZ2VkKCk7 CisgICAgICAgIFJlbmRlck1lZGlhOjppbnRyaW5zaWNTaXplQ2hhbmdlZCgpOwogICAgIHZpZGVv U2l6ZUNoYW5nZWQoKTsgCiB9CiAKQEAgLTEwNCw3ICsxMDQsNyBAQCB2b2lkIFJlbmRlclZpZGVv Ojp2aWRlb1NpemVDaGFuZ2VkKCkKIAogdm9pZCBSZW5kZXJWaWRlbzo6aW1hZ2VDaGFuZ2VkKFdy YXBwZWRJbWFnZVB0ciBuZXdJbWFnZSwgY29uc3QgSW50UmVjdCogcmVjdCkKIHsKLSAgICBSZW5k ZXJJbWFnZTo6aW1hZ2VDaGFuZ2VkKG5ld0ltYWdlLCByZWN0KTsKKyAgICBSZW5kZXJNZWRpYTo6 aW1hZ2VDaGFuZ2VkKG5ld0ltYWdlLCByZWN0KTsKIAogICAgIC8vIENhY2hlIHRoZSBpbWFnZSBp bnRyaW5zaWMgc2l6ZSBzbyB3ZSBjYW4gY29udGludWUgdG8gdXNlIGl0IHRvIGRyYXcgdGhlIGlt YWdlIGNvcnJlY3RseQogICAgIC8vIGV2ZW4gYWZ0ZXIgd2Uga25vdyB0aGUgdmlkZW8gaW50cmlz aWMgc2l6ZSBidXQgYXJlbid0IGFibGUgdG8gZHJhdyB2aWRlbyBmcmFtZXMgeWV0Cg==