34429 2010-02-01 07:40:05 -0800 [Qt] window.alert fails to display HTML tag 2010-02-10 07:20:38 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 sangeetha.sugavanam webkit-unassigned commit-queue hausmann kling laszlo.gombos oldest_to_newest 186417 0 sangeetha.sugavanam 2010-02-01 07:40:05 -0800 Steps to Reproduce: 1) Launch QtLauncher. 2) Save the file windowtest.html. 3) Open the file windowtest.html from QtLauncher. 4) Click on the Display Alert button. Expected Outcome: ----------------- '<p>string in between <tag></p>' is displayed as an alert without HTML formatting (<p> is treated like a string). Actual Outcome: --------------- 'string in between' is displayed as an alert instead. And if '<script>somescript</script>' is put as a n argument instead, nothing will be displayed in the alert box. Mozilla Firefox 3.5.2 displays '<p>string in between <tag></p>' Apple Safari 4.0.1 displays '<p>string in between <tag></p>' 186420 1 47843 sangeetha.sugavanam 2010-02-01 07:45:06 -0800 Created attachment 47843 windowtest.html for QtLauncher 186870 2 47914 kling 2010-02-02 02:01:09 -0800 Created attachment 47914 Patch to escape HTML entities in JS alert/prompt boxes 186871 3 kling 2010-02-02 02:03:36 -0800 And (about the testcase): you can't have </script> inside a JS string literal, that stops the parser in its tracks. See for example: http://www.herongyang.com/JavaScript/Browser-Include-Script-Tag-in-String-Literal.html 186894 4 47918 kling 2010-02-02 03:37:08 -0800 Created attachment 47918 Patch fixed to work with all 3 JS dialogs We should do the same for all the JS dialog types. :) 186923 5 47918 commit-queue 2010-02-02 05:00:03 -0800 Comment on attachment 47918 Patch fixed to work with all 3 JS dialogs Clearing flags on attachment: 47918 Committed r54228: <http://trac.webkit.org/changeset/54228> 186924 6 commit-queue 2010-02-02 05:00:11 -0800 All reviewed patches have been landed. Closing bug. 189361 7 hausmann 2010-02-10 07:20:38 -0800 I wonder if the escaping should perhaps be done on the ChromeClientQt side, instead of in the default implementation. That way we can unit test this bug fix and not every application that re-implements these handlers has to do the same Qt::escape trick. Unless of course there's a compelling reason to forward the tags to the application... 47843 2010-02-01 07:45:06 -0800 2010-02-01 07:45:06 -0800 windowtest.html for QtLauncher windowtest.html text/html 504 sangeetha.sugavanam PCFkb2N0eXBlIGh0bWw+PCEtLSBUaGlzIGlzIHRoZSBIVE1MIDUgZG9jdHlwZSwgYWxzbyBrbm93 biBhcyB0aGUgInNraW5ueSIgZG9jdHlwZSAtLT4NCjxodG1sPg0KICAgIDxoZWFkPg0KICAgICAg ICA8dGl0bGU+V2luZG93IEFsZXJ0IFRlc3QgUGFnZTwvdGl0bGU+DQogICAgICAgIDxzY3JpcHQg dHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCiAgICAgICAgICAgIGZ1bmN0aW9uIERpc3BsYXlBbGVy dCgpIHsNCiAgICAgICAgICAgICAgICBhbGVydCggJzxzY3JpcHQ+c29tZXNjcmlwdDwvc2NyaXB0 PicgKTsNCiAgICAgICAgICAgIH0NCiAgICAgICAgPC9zY3JpcHQ+DQogICAgPC9oZWFkPg0KICAg IDxib2R5Pg0KICAgICAgICA8ZGl2PjxiPkNsaWNrIHRvIGRpc3BsYXkgYWxlcnQ6PC9iPjwvZGl2 Pg0KICAgICAgICA8cD48L3A+DQogICAgICAgIDxidXR0b24gb25jbGljaz0iRGlzcGxheUFsZXJ0 KCkiPkRpc3BsYXkgQWxlcnQ8L2J1dHRvbj4NCiAgICA8L2JvZHk+DQo8L2h0bWw+ 47914 2010-02-02 02:01:09 -0800 2010-02-02 03:37:08 -0800 Patch to escape HTML entities in JS alert/prompt boxes bug-34429.diff text/plain 1843 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggN2UzYjA4NC4uMDQ0OWMyYiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEw NSw2ICsxMDUsNyBAQAogI2luY2x1ZGUgPFFTdHlsZT4KICNpbmNsdWRlIDxRU3lzSW5mbz4KICNp bmNsdWRlIDxRVGV4dENoYXJGb3JtYXQ+CisjaW5jbHVkZSA8UVRleHREb2N1bWVudD4KICNpbmNs dWRlIDxRTmV0d29ya0FjY2Vzc01hbmFnZXI+CiAjaW5jbHVkZSA8UU5ldHdvcmtSZXF1ZXN0Pgog I2lmIGRlZmluZWQoUV9XU19YMTEpCkBAIC0xODcxLDcgKzE4NzIsNyBAQCB2b2lkIFFXZWJQYWdl OjpqYXZhU2NyaXB0QWxlcnQoUVdlYkZyYW1lICpmcmFtZSwgY29uc3QgUVN0cmluZyYgbXNnKQog ewogICAgIFFfVU5VU0VEKGZyYW1lKQogI2lmbmRlZiBRVF9OT19NRVNTQUdFQk9YCi0gICAgUU1l c3NhZ2VCb3g6OmluZm9ybWF0aW9uKHZpZXcoKSwgdHIoIkphdmFTY3JpcHQgQWxlcnQgLSAlMSIp LmFyZyhtYWluRnJhbWUoKS0+dXJsKCkuaG9zdCgpKSwgbXNnLCBRTWVzc2FnZUJveDo6T2spOwor ICAgIFFNZXNzYWdlQm94OjppbmZvcm1hdGlvbih2aWV3KCksIHRyKCJKYXZhU2NyaXB0IEFsZXJ0 IC0gJTEiKS5hcmcobWFpbkZyYW1lKCktPnVybCgpLmhvc3QoKSksIFF0Ojplc2NhcGUobXNnKSwg UU1lc3NhZ2VCb3g6Ok9rKTsKICNlbmRpZgogfQogCkBAIC0xODg3LDcgKzE4ODgsNyBAQCBib29s IFFXZWJQYWdlOjpqYXZhU2NyaXB0Q29uZmlybShRV2ViRnJhbWUgKmZyYW1lLCBjb25zdCBRU3Ry aW5nJiBtc2cpCiAjaWZkZWYgUVRfTk9fTUVTU0FHRUJPWAogICAgIHJldHVybiB0cnVlOwogI2Vs c2UKLSAgICByZXR1cm4gUU1lc3NhZ2VCb3g6OlllcyA9PSBRTWVzc2FnZUJveDo6aW5mb3JtYXRp b24odmlldygpLCB0cigiSmF2YVNjcmlwdCBDb25maXJtIC0gJTEiKS5hcmcobWFpbkZyYW1lKCkt PnVybCgpLmhvc3QoKSksIG1zZywgUU1lc3NhZ2VCb3g6OlllcywgUU1lc3NhZ2VCb3g6Ok5vKTsK KyAgICByZXR1cm4gUU1lc3NhZ2VCb3g6OlllcyA9PSBRTWVzc2FnZUJveDo6aW5mb3JtYXRpb24o dmlldygpLCB0cigiSmF2YVNjcmlwdCBDb25maXJtIC0gJTEiKS5hcmcobWFpbkZyYW1lKCktPnVy bCgpLmhvc3QoKSksIFF0Ojplc2NhcGUobXNnKSwgUU1lc3NhZ2VCb3g6OlllcywgUU1lc3NhZ2VC b3g6Ok5vKTsKICNlbmRpZgogfQogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIv V2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAxNzA2NjVhLi4xOThiN2FhIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxMC0wMi0wMiAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g RGlzcGxheSBIVE1MIHRhZ3MgdmVyYmF0aW0gaW4gSlMgYWxlcnQvcHJvbXB0IGJveGVzCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDI5CisKKyAg ICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2U6OmphdmFTY3JpcHRB bGVydCk6CisgICAgICAgIChRV2ViUGFnZTo6amF2YVNjcmlwdENvbmZpcm0pOgorCiAyMDEwLTAx LTI5ICBCZW4gTXVyZG9jaCAgPGJlbm1AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEaW1pdHJpIEdsYXprb3YuCg== 47918 2010-02-02 03:37:08 -0800 2010-02-02 05:00:03 -0800 Patch fixed to work with all 3 JS dialogs bug-34429-2.diff text/plain 2432 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggN2UzYjA4NC4uZWEyNDAxYiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEw NSw2ICsxMDUsNyBAQAogI2luY2x1ZGUgPFFTdHlsZT4KICNpbmNsdWRlIDxRU3lzSW5mbz4KICNp bmNsdWRlIDxRVGV4dENoYXJGb3JtYXQ+CisjaW5jbHVkZSA8UVRleHREb2N1bWVudD4KICNpbmNs dWRlIDxRTmV0d29ya0FjY2Vzc01hbmFnZXI+CiAjaW5jbHVkZSA8UU5ldHdvcmtSZXF1ZXN0Pgog I2lmIGRlZmluZWQoUV9XU19YMTEpCkBAIC0xODcxLDcgKzE4NzIsNyBAQCB2b2lkIFFXZWJQYWdl OjpqYXZhU2NyaXB0QWxlcnQoUVdlYkZyYW1lICpmcmFtZSwgY29uc3QgUVN0cmluZyYgbXNnKQog ewogICAgIFFfVU5VU0VEKGZyYW1lKQogI2lmbmRlZiBRVF9OT19NRVNTQUdFQk9YCi0gICAgUU1l c3NhZ2VCb3g6OmluZm9ybWF0aW9uKHZpZXcoKSwgdHIoIkphdmFTY3JpcHQgQWxlcnQgLSAlMSIp LmFyZyhtYWluRnJhbWUoKS0+dXJsKCkuaG9zdCgpKSwgbXNnLCBRTWVzc2FnZUJveDo6T2spOwor ICAgIFFNZXNzYWdlQm94OjppbmZvcm1hdGlvbih2aWV3KCksIHRyKCJKYXZhU2NyaXB0IEFsZXJ0 IC0gJTEiKS5hcmcobWFpbkZyYW1lKCktPnVybCgpLmhvc3QoKSksIFF0Ojplc2NhcGUobXNnKSwg UU1lc3NhZ2VCb3g6Ok9rKTsKICNlbmRpZgogfQogCkBAIC0xODg3LDcgKzE4ODgsNyBAQCBib29s IFFXZWJQYWdlOjpqYXZhU2NyaXB0Q29uZmlybShRV2ViRnJhbWUgKmZyYW1lLCBjb25zdCBRU3Ry aW5nJiBtc2cpCiAjaWZkZWYgUVRfTk9fTUVTU0FHRUJPWAogICAgIHJldHVybiB0cnVlOwogI2Vs c2UKLSAgICByZXR1cm4gUU1lc3NhZ2VCb3g6OlllcyA9PSBRTWVzc2FnZUJveDo6aW5mb3JtYXRp b24odmlldygpLCB0cigiSmF2YVNjcmlwdCBDb25maXJtIC0gJTEiKS5hcmcobWFpbkZyYW1lKCkt PnVybCgpLmhvc3QoKSksIG1zZywgUU1lc3NhZ2VCb3g6OlllcywgUU1lc3NhZ2VCb3g6Ok5vKTsK KyAgICByZXR1cm4gUU1lc3NhZ2VCb3g6OlllcyA9PSBRTWVzc2FnZUJveDo6aW5mb3JtYXRpb24o dmlldygpLCB0cigiSmF2YVNjcmlwdCBDb25maXJtIC0gJTEiKS5hcmcobWFpbkZyYW1lKCktPnVy bCgpLmhvc3QoKSksIFF0Ojplc2NhcGUobXNnKSwgUU1lc3NhZ2VCb3g6OlllcywgUU1lc3NhZ2VC b3g6Ok5vKTsKICNlbmRpZgogfQogCkBAIC0xOTA2LDcgKzE5MDcsNyBAQCBib29sIFFXZWJQYWdl OjpqYXZhU2NyaXB0UHJvbXB0KFFXZWJGcmFtZSAqZnJhbWUsIGNvbnN0IFFTdHJpbmcmIG1zZywg Y29uc3QgUVN0cgogICAgIFFfVU5VU0VEKGZyYW1lKQogICAgIGJvb2wgb2sgPSBmYWxzZTsKICNp Zm5kZWYgUVRfTk9fSU5QVVRESUFMT0cKLSAgICBRU3RyaW5nIHggPSBRSW5wdXREaWFsb2c6Omdl dFRleHQodmlldygpLCB0cigiSmF2YVNjcmlwdCBQcm9tcHQgLSAlMSIpLmFyZyhtYWluRnJhbWUo KS0+dXJsKCkuaG9zdCgpKSwgbXNnLCBRTGluZUVkaXQ6Ok5vcm1hbCwgZGVmYXVsdFZhbHVlLCAm b2spOworICAgIFFTdHJpbmcgeCA9IFFJbnB1dERpYWxvZzo6Z2V0VGV4dCh2aWV3KCksIHRyKCJK YXZhU2NyaXB0IFByb21wdCAtICUxIikuYXJnKG1haW5GcmFtZSgpLT51cmwoKS5ob3N0KCkpLCBR dDo6ZXNjYXBlKG1zZyksIFFMaW5lRWRpdDo6Tm9ybWFsLCBkZWZhdWx0VmFsdWUsICZvayk7CiAg ICAgaWYgKG9rICYmIHJlc3VsdCkKICAgICAgICAgKnJlc3VsdCA9IHg7CiAjZW5kaWYKZGlmZiAt LWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDE3 MDY2NWEuLjk5MDE1ZTIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAyLTAyICBBbmRyZWFzIEts aW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEaXNwbGF5IEhUTUwgdGFncyB2ZXJiYXRpbSBp biBKUyBhbGVydC9jb25maXJtL3Byb21wdCBib3hlcworCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQyOQorCisgICAgICAgICogQXBpL3F3ZWJwYWdl LmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjpqYXZhU2NyaXB0QWxlcnQpOgorICAgICAgICAoUVdl YlBhZ2U6OmphdmFTY3JpcHRDb25maXJtKToKKyAgICAgICAgKFFXZWJQYWdlOjpqYXZhU2NyaXB0 UHJvbXB0KToKKwogMjAxMC0wMS0yOSAgQmVuIE11cmRvY2ggIDxiZW5tQGdvb2dsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292Lgo=