34411 2010-02-01 00:20:22 -0800 debug-safari doesn't pass --debug option to gdb-safari on MacOSX 2010-02-18 01:18:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned cjerdonek eric oldest_to_newest 186323 0 hamaji 2010-02-01 00:20:22 -0800 Because determinePassedConfiguration modifies @ARGV. 186324 1 47818 hamaji 2010-02-01 00:21:01 -0800 Created attachment 47818 Patch v1 186629 2 eric 2010-02-01 15:59:02 -0800 This seems like a systemic problem with our perl code. 191262 3 47818 eric 2010-02-17 15:43:17 -0800 Comment on attachment 47818 Patch v1 Doesn't webkitdirs.pm already have a function to return args like this? It must. How does run-webkit-tests --debug know to call build-dumprendertree with --debug otherwise? 191387 4 48967 hamaji 2010-02-17 21:14:31 -0800 Created attachment 48967 Patch v2 191388 5 hamaji 2010-02-17 21:15:01 -0800 True. Thanks for the nice suggestion! 191449 6 48967 abarth 2010-02-18 00:10:21 -0800 Comment on attachment 48967 Patch v2 LGTM. I'm not an expert on our perl code, however. 191481 7 48967 hamaji 2010-02-18 01:17:56 -0800 Comment on attachment 48967 Patch v2 Clearing flags on attachment: 48967 Committed r54947: <http://trac.webkit.org/changeset/54947> 191482 8 hamaji 2010-02-18 01:18:04 -0800 All reviewed patches have been landed. Closing bug. 47818 2010-02-01 00:21:01 -0800 2010-02-17 21:14:24 -0800 Patch v1 bug-34411-20100201002059.patch text/plain 1413 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjYmE0ODBkLi45OGU1YTQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MDEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkZWJ1Zy1zYWZhcmkgZG9lc24n dCBwYXNzIC0tZGVidWcgb3B0aW9uIHRvIGdkYi1zYWZhcmkgb24gTWFjT1NYCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQxMQorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRkaXJzLnBtOgorCiAyMDEwLTAxLTI5ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU3RlcGhhbmllIExld2lzLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGQ2NjdhOGEuLjVjNDNmZTAgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTY2LDYgKzY2LDcgQEAgbXkgJGlzV3g7CiBteSBAd3hB cmdzOwogbXkgJGlzQ2hyb21pdW07CiBteSAkaXNJbnNwZWN0b3JGcm9udGVuZDsKK215IEBvcmln aW5hbEFyZ3M7CiAKICMgVmFyaWFibGVzIGZvciBXaW4zMiBzdXBwb3J0CiBteSAkdmNCdWlsZFBh dGg7CkBAIC00MTgsNiArNDE5LDggQEAgc3ViIHBhc3NlZENvbmZpZ3VyYXRpb24KIAogc3ViIHNl dENvbmZpZ3VyYXRpb24KIHsKKyAgICBAb3JpZ2luYWxBcmdzID0gQEFSR1Y7CisKICAgICBzZXRB cmNoaXRlY3R1cmUoKTsKIAogICAgIGlmIChteSAkY29uZmlnID0gc2hpZnQgQF8pIHsKQEAgLTE2 NTUsNyArMTY1OCw3IEBAIHN1YiBydW5TYWZhcmkKICAgICBteSAoJGRlYnVnZ2VyKSA9IEBfOwog CiAgICAgaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewotICAgICAgICByZXR1cm4gc3lzdGVtICIk RmluZEJpbjo6QmluL2dkYi1zYWZhcmkiLCBAQVJHViBpZiAkZGVidWdnZXI7CisgICAgICAgIHJl dHVybiBzeXN0ZW0gIiRGaW5kQmluOjpCaW4vZ2RiLXNhZmFyaSIsIEBvcmlnaW5hbEFyZ3MgaWYg JGRlYnVnZ2VyOwogCiAgICAgICAgIG15ICRwcm9kdWN0RGlyID0gcHJvZHVjdERpcigpOwogICAg ICAgICBwcmludCAiU3RhcnRpbmcgU2FmYXJpIHdpdGggRFlMRF9GUkFNRVdPUktfUEFUSCBzZXQg dG8gcG9pbnQgdG8gYnVpbHQgV2ViS2l0IGluICRwcm9kdWN0RGlyLlxuIjsK 48967 2010-02-17 21:14:31 -0800 2010-02-18 01:17:56 -0800 Patch v2 bug-34411-20100217211429.patch text/plain 1114 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzMmQ5MzUzLi45NzU0NmM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MTggIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkZWJ1Zy1zYWZhcmkgZG9lc24n dCBwYXNzIC0tZGVidWcgb3B0aW9uIHRvIGdkYi1zYWZhcmkgb24gTWFjT1NYCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQxMQorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRkaXJzLnBtOgorCiAyMDEwLTAyLTE3ICBTaGluaWNoaXJvIEhhbWFqaSAg PGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggOWM3OWE3Mi4uNzk4NTc5MCAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTQ2MSw3ICsxNDYxLDcgQEAgc3ViIHJ1blNhZmFy aQogICAgIG15ICgkZGVidWdnZXIpID0gQF87CiAKICAgICBpZiAoaXNBcHBsZU1hY1dlYktpdCgp KSB7Ci0gICAgICAgIHJldHVybiBzeXN0ZW0gIiRGaW5kQmluOjpCaW4vZ2RiLXNhZmFyaSIsIEBB UkdWIGlmICRkZWJ1Z2dlcjsKKyAgICAgICAgcmV0dXJuIHN5c3RlbSAiJEZpbmRCaW46OkJpbi9n ZGItc2FmYXJpIiwgYXJndW1lbnRzRm9yQ29uZmlndXJhdGlvbigpIGlmICRkZWJ1Z2dlcjsKIAog ICAgICAgICBteSAkcHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKICAgICAgICAgcHJpbnQgIlN0 YXJ0aW5nIFNhZmFyaSB3aXRoIERZTERfRlJBTUVXT1JLX1BBVEggc2V0IHRvIHBvaW50IHRvIGJ1 aWx0IFdlYktpdCBpbiAkcHJvZHVjdERpci5cbiI7Cg==