34390 2010-01-31 02:27:52 -0800 Limit the scope of packing alignment to avoid MSVC C4103 warning. 2010-01-31 18:38:00 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned aroben commit-queue oldest_to_newest 186179 0 skyul 2010-01-31 02:27:52 -0800 Limit the scope of packing alignment with pack(push) and pack(pop) to avoid C4103. C4103: alignment changed after including header. 186180 1 47788 skyul 2010-01-31 02:32:18 -0800 Created attachment 47788 Patch 186188 2 skyul 2010-01-31 05:38:13 -0800 CC'ing aroben@apple.com who added #pragma pack(16) in http://trac.webkit.org/changeset/35684 186275 3 47788 commit-queue 2010-01-31 18:37:56 -0800 Comment on attachment 47788 Patch Clearing flags on attachment: 47788 Committed r54122: <http://trac.webkit.org/changeset/54122> 186276 4 commit-queue 2010-01-31 18:38:00 -0800 All reviewed patches have been landed. Closing bug. 47788 2010-01-31 02:32:18 -0800 2010-01-31 18:37:55 -0800 Patch packing.patch text/plain 2372 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDEwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMzEgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBMaW1pdCB0aGUgc2NvcGUgb2YgcGFja2luZyBhbGlnbm1lbnQgdG8gYXZvaWQgTVNWQyBDNDEw MyB3YXJuaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzQzOTAKKworICAgICAgICBVc2UgcGFjayhwdXNoLCAxNikgYW5kIHBhY2socG9wKSB0byBs aW1pdCB0aGUgc2NvcGUgb2YgcGFja2luZworICAgICAgICBhbGlnbm1lbnQgY2hhbmdlLgorCisg ICAgICAgICogYmluZGluZ3MvanMvSlNTVkdQT0RUeXBlV3JhcHBlci5oOgorCiAyMDEwLTAxLTMx ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZHUE9E VHlwZVdyYXBwZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZHUE9E VHlwZVdyYXBwZXIuaAkocmV2aXNpb24gNTQxMDgpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pT U1ZHUE9EVHlwZVdyYXBwZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNzEsNyArNzEsNyBAQCBwdWJs aWM6CiAvLyBHZXR0ZXJNZXRob2QgYW5kIFNldHRlck1ldGhvZCBhcmUgZWFjaCAxMiBieXRlcy4g V2UgaGF2ZSB0byBwYWNrIHRvIGEgc2l6ZQogLy8gZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvIHRo YXQgdG8gYXZvaWQgYW4gYWxpZ25tZW50IHdhcm5pbmcgKEM0MTIxKS4gMTYgaXMKIC8vIHRoZSBu ZXh0LWxhcmdlc3Qgc2l6ZSBhbGxvd2VkIGZvciBwYWNraW5nLCBzbyB3ZSB1c2UgdGhhdC4KLSNw cmFnbWEgcGFjaygxNikKKyNwcmFnbWEgcGFjayhwdXNoLCAxNikKICNlbmRpZgogdGVtcGxhdGU8 dHlwZW5hbWUgUE9EVHlwZSwgdHlwZW5hbWUgUE9EVHlwZUNyZWF0b3I+CiBjbGFzcyBKU1NWR0R5 bmFtaWNQT0RUeXBlV3JhcHBlciA6IHB1YmxpYyBKU1NWR1BPRFR5cGVXcmFwcGVyPFBPRFR5cGU+ IHsKQEAgLTExMyw2ICsxMTMsOSBAQCBwcml2YXRlOgogICAgIEdldHRlck1ldGhvZCBtX2dldHRl cjsKICAgICBTZXR0ZXJNZXRob2QgbV9zZXR0ZXI7CiB9OworI2lmIENPTVBJTEVSKE1TVkMpCisj cHJhZ21hIHBhY2socG9wKQorI2VuZGlmCiAKIC8vIFJlcHJlc2VudHMgYSBKUyB3cmFwcGVyIG9i amVjdCBmb3IgU1ZHIFBPRCB0eXBlcyAobm90IGZvciBTVkdBbmltYXRlZCogY2xhc3NlcykuIEFu eSBtb2RpZmljYXRpb24gdG8gdGhlIFNWRyBQT0QKIC8vIHR5cGVzIGRvbid0IGNhdXNlIGFueSB1 cGRhdGVzIHVubGlrZSBKU1NWR0R5bmFtaWNQT0RUeXBlV3JhcHBlci4gVGhpcyBjbGFzcyBpcyB1 c2VkIGZvciByZXR1cm4gdmFsdWVzIChpZS4gZ2V0QkJveCgpKQpAQCAtMTc1LDcgKzE3OCw3IEBA IHByaXZhdGU6CiAvLyBHZXR0ZXJNZXRob2QgYW5kIFNldHRlck1ldGhvZCBhcmUgZWFjaCAxMiBi eXRlcy4gV2UgaGF2ZSB0byBwYWNrIHRvIGEgc2l6ZQogLy8gZ3JlYXRlciB0aGFuIG9yIGVxdWFs IHRvIHRoYXQgdG8gYXZvaWQgYW4gYWxpZ25tZW50IHdhcm5pbmcgKEM0MTIxKS4gMTYgaXMKIC8v IHRoZSBuZXh0LWxhcmdlc3Qgc2l6ZSBhbGxvd2VkIGZvciBwYWNraW5nLCBzbyB3ZSB1c2UgdGhh dC4KLSNwcmFnbWEgcGFjaygxNikKKyNwcmFnbWEgcGFjayhwdXNoLCAxNikKICNlbmRpZgogdGVt cGxhdGU8dHlwZW5hbWUgUE9EVHlwZSwgdHlwZW5hbWUgUGFyZW50VHlwZT4KIGNsYXNzIEpTU1ZH U3RhdGljUE9EVHlwZVdyYXBwZXJXaXRoUGFyZW50IDogcHVibGljIEpTU1ZHUE9EVHlwZVdyYXBw ZXI8UE9EVHlwZT4gewpAQCAtMzEwLDYgKzMxMyw5IEBAIHN0cnVjdCBQT0RUeXBlV3JhcHBlckNh Y2hlSW5mbyB7CiAgICAgR2V0dGVyTWV0aG9kIGdldHRlcjsKICAgICBTZXR0ZXJNZXRob2Qgc2V0 dGVyOwogfTsKKyNpZiBDT01QSUxFUihNU1ZDKQorI3ByYWdtYSBwYWNrKHBvcCkKKyNlbmRpZgog CiB0ZW1wbGF0ZTx0eXBlbmFtZSBQT0RUeXBlLCB0eXBlbmFtZSBQT0RUeXBlQ3JlYXRvcj4KIHN0 cnVjdCBQT0RUeXBlV3JhcHBlckNhY2hlSW5mb0hhc2ggewo=