34387 2010-01-30 22:05:12 -0800 GtkLauncher is not compiled when --enable-mathml specified 2010-02-04 18:40:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 marinalan webkit-unassigned cmsigler commit-queue hamaji oldest_to_newest 186164 0 marinalan 2010-01-30 22:05:12 -0800 already second week, after svn update ./autogen.sh --enable-web-sockets --enable-mathml --enable-geolocation --enable-3D-transforms --enable-filters make it compiles everything, except GtkLauncher. Last messages on console are: -------------------------------------------------------------- CXX JavaScriptCore/Programs_jsc-jsc.o CXXLD Programs/jsc CC JavaScriptCore/API/tests/Programs_minidom-JSNode.o CC JavaScriptCore/API/tests/Programs_minidom-JSNodeList.o CC JavaScriptCore/API/tests/Programs_minidom-Node.o CC JavaScriptCore/API/tests/Programs_minidom-NodeList.o CC JavaScriptCore/API/tests/Programs_minidom-minidom.o CCLD Programs/minidom CC WebKitTools/GtkLauncher/Programs_GtkLauncher-main.o CCLD Programs/GtkLauncher ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::RenderMathMLBlock::RenderMathMLBlock(WebCore::Node*)' collect2: ld returned 1 exit status make[1]: *** [Programs/GtkLauncher] Error 1 make[1]: Leaving directory `/home/marina/src/WebKit' make: *** [all] Error 2 186165 1 marinalan 2010-01-30 22:06:10 -0800 My distribution is fedora 12 186454 2 cmsigler 2010-02-01 09:25:36 -0800 (In reply to comment #0) > already second week, after > ... > CC WebKitTools/GtkLauncher/Programs_GtkLauncher-main.o > CCLD Programs/GtkLauncher > ./.libs/libwebkit-1.0.so: undefined reference to > `WebCore::RenderMathMLBlock::RenderMathMLBlock(WebCore::Node*)' > collect2: ld returned 1 exit status > make[1]: *** [Programs/GtkLauncher] Error 1 > make[1]: Leaving directory `/home/marina/src/WebKit' > make: *** [all] Error 2 I can confirm this build error. Specifics: - Gentoo 10.0/current on amd64 (x86_64) platform (this is wholly independent of marinalan's Fedora 12 dist., FWIW) - svn update run, updated to revision r54134 - Ran the following: $ make distclean $ ./autogen.sh --enable-mathml $ ./configure --enable-mathml $ make - Identical build error as reported by marinalan - Building without --enable-mathml succeeds In inspecting my local dir tree after the build failed, I see that neither WebCore/mathml/RenderMathMLBlock.cpp nor WebCore/mathml/MathMLTextElement.cpp is being built. I have little experience in working with autoconf/automake, but I'm trying to find where the build configuration problem lies. I think it's in WebCore/GNUmakefile.am. Will report back if I find a fix for the build error I'm experiencing. Clemmitt 186471 3 cmsigler 2010-02-01 10:18:02 -0800 (In reply to comment #2) > I can confirm this build error. Specifics: ... > Will report back if I find a fix for the build error > I'm experiencing. Yes, the problem is in WebCore/GNUmakefile.am. It appears to me that when r53764 (or r52721) was committed, GNUmakefile.am wasn't updated correspondingly. Here is a QnD patch: === Cut here -- START === --- WebCore/GNUmakefile.am.orig 2010-02-01 09:32:29.000000000 -0500 +++ WebCore/GNUmakefile.am 2010-02-01 12:20:18.000000000 -0500 @@ -2713,7 +2713,11 @@ WebCore/mathml/MathMLInlineContainerElement.cpp \ WebCore/mathml/MathMLInlineContainerElement.h \ WebCore/mathml/MathMLMathElement.cpp \ - WebCore/mathml/MathMLMathElement.h + WebCore/mathml/MathMLMathElement.h \ + WebCore/mathml/MathMLTextElement.cpp \ + WebCore/mathml/MathMLTextElement.h \ + WebCore/mathml/RenderMathMLBlock.cpp \ + WebCore/mathml/RenderMathMLBlock.h webcore_built_sources += \ DerivedSources/MathMLElementFactory.cpp \ === Cut here -- END === I hope someone with commit privileges will be able to patch this into the trunk. TIA for your help, and for WebKit. Clemmitt 187526 4 cmsigler 2010-02-03 16:07:36 -0800 (In reply to comment #3) I wonder what one does to get the attention of a developer, if no one goes through bugzilla examining reported problems or looking for fixes? I'll try again by attaching a patch for this problem. Hopefully the patch will be reviewed. Clemmitt 187531 5 48072 cmsigler 2010-02-03 16:15:49 -0800 Created attachment 48072 Patch to fix WebKitGTK build when --enable-mathml specified. Patch to fix WebKitGTK build when --enable-mathml specified. 187534 6 48073 cmsigler 2010-02-03 16:17:48 -0800 Created attachment 48073 Patch to fix WebKitGTK build when --enable-mathml specified. Patch to fix WebKitGTK build when --enable-mathml specified. 187733 7 48073 hamaji 2010-02-04 04:20:58 -0800 Comment on attachment 48073 Patch to fix WebKitGTK build when --enable-mathml specified. Thanks for sending this patch. This seems to be OK, but please add a ChangeLog entry for your change. WebKitTools/Scripts/prepare-ChangeLog should do the trick. Please read the following document for the detail. http://webkit.org/coding/contributing.html For the record, this is the corresponding change: http://trac.webkit.org/changeset/53764 187734 8 hamaji 2010-02-04 04:21:56 -0800 Changing the title of this bug 187781 9 cmsigler 2010-02-04 07:10:50 -0800 (In reply to comment #7) > (From update of attachment 48073 [details]) > Thanks for sending this patch. This seems to be OK, but please add a ChangeLog > entry for your change. WebKitTools/Scripts/prepare-ChangeLog should do the > trick. My apologies. I don't think I've contributed a WebKit patch for over year and a half; my memory failed me :^) I'll get the ChangeLog entry together next. > For the record, this is the corresponding change: > http://trac.webkit.org/changeset/53764 Thanks for looking up that change. Clemmitt 187916 10 48163 cmsigler 2010-02-04 13:27:17 -0800 Created attachment 48163 Patch to fix WebKitGTK build when --enable-mathml specified. Patch to fix WebKitGTK build when --enable-mathml specified. 187992 11 48163 levin 2010-02-04 16:14:01 -0800 Comment on attachment 48163 Patch to fix WebKitGTK build when --enable-mathml specified. > Index: WebCore/ChangeLog > + https://bugs.webkit.org/show_bug.cgi?id=34387 > + > + No new tests. Typically one would say something like "No change in functionality so no new tests." or "Covered by existing tests for MathML." 188002 12 48163 commit-queue 2010-02-04 16:36:03 -0800 Comment on attachment 48163 Patch to fix WebKitGTK build when --enable-mathml specified. Clearing flags on attachment: 48163 Committed r54386: <http://trac.webkit.org/changeset/54386> 188003 13 commit-queue 2010-02-04 16:36:10 -0800 All reviewed patches have been landed. Closing bug. 188047 14 cmsigler 2010-02-04 18:40:27 -0800 (In reply to comment #11) > Typically one would say something like "No change in functionality so no new > tests." or "Covered by existing tests for MathML." David, thanks for the pointer and landing :^) Clemmitt 48072 2010-02-03 16:15:49 -0800 2010-02-03 16:17:48 -0800 Patch to fix WebKitGTK build when --enable-mathml specified. WebCore_GNUmakefile.am.patch text/plain 606 cmsigler LS0tIFdlYkNvcmUvR05VbWFrZWZpbGUuYW0ub3JpZwkyMDEwLTAyLTAzIDE5OjEyOjE5LjAwMDAw MDAwMCAtMDUwMAorKysgV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQkyMDEwLTAyLTAzIDE5OjEzOjAx LjAwMDAwMDAwMCAtMDUwMApAQCAtMjcxOCw3ICsyNzE4LDExIEBACiAJV2ViQ29yZS9tYXRobWwv TWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudC5jcHAgXAogCVdlYkNvcmUvbWF0aG1sL01hdGhN TElubGluZUNvbnRhaW5lckVsZW1lbnQuaCAgXAogCVdlYkNvcmUvbWF0aG1sL01hdGhNTE1hdGhF bGVtZW50LmNwcCBcCi0JV2ViQ29yZS9tYXRobWwvTWF0aE1MTWF0aEVsZW1lbnQuaAorCVdlYkNv cmUvbWF0aG1sL01hdGhNTE1hdGhFbGVtZW50LmggXAorCVdlYkNvcmUvbWF0aG1sL01hdGhNTFRl eHRFbGVtZW50LmNwcCBcCisJV2ViQ29yZS9tYXRobWwvTWF0aE1MVGV4dEVsZW1lbnQuaCBcCisJ V2ViQ29yZS9tYXRobWwvUmVuZGVyTWF0aE1MQmxvY2suY3BwIFwKKwlXZWJDb3JlL21hdGhtbC9S ZW5kZXJNYXRoTUxCbG9jay5oCiAKIHdlYmNvcmVfYnVpbHRfc291cmNlcyArPSBcCiAJRGVyaXZl ZFNvdXJjZXMvTWF0aE1MRWxlbWVudEZhY3RvcnkuY3BwIFwK 48073 2010-02-03 16:17:48 -0800 2010-02-04 13:27:17 -0800 Patch to fix WebKitGTK build when --enable-mathml specified. WebCore_GNUmakefile.am.patch text/plain 606 cmsigler LS0tIFdlYkNvcmUvR05VbWFrZWZpbGUuYW0ub3JpZwkyMDEwLTAyLTAzIDE5OjEyOjE5LjAwMDAw MDAwMCAtMDUwMAorKysgV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQkyMDEwLTAyLTAzIDE5OjEzOjAx LjAwMDAwMDAwMCAtMDUwMApAQCAtMjcxOCw3ICsyNzE4LDExIEBACiAJV2ViQ29yZS9tYXRobWwv TWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudC5jcHAgXAogCVdlYkNvcmUvbWF0aG1sL01hdGhN TElubGluZUNvbnRhaW5lckVsZW1lbnQuaCAgXAogCVdlYkNvcmUvbWF0aG1sL01hdGhNTE1hdGhF bGVtZW50LmNwcCBcCi0JV2ViQ29yZS9tYXRobWwvTWF0aE1MTWF0aEVsZW1lbnQuaAorCVdlYkNv cmUvbWF0aG1sL01hdGhNTE1hdGhFbGVtZW50LmggXAorCVdlYkNvcmUvbWF0aG1sL01hdGhNTFRl eHRFbGVtZW50LmNwcCBcCisJV2ViQ29yZS9tYXRobWwvTWF0aE1MVGV4dEVsZW1lbnQuaCBcCisJ V2ViQ29yZS9tYXRobWwvUmVuZGVyTWF0aE1MQmxvY2suY3BwIFwKKwlXZWJDb3JlL21hdGhtbC9S ZW5kZXJNYXRoTUxCbG9jay5oCiAKIHdlYmNvcmVfYnVpbHRfc291cmNlcyArPSBcCiAJRGVyaXZl ZFNvdXJjZXMvTWF0aE1MRWxlbWVudEZhY3RvcnkuY3BwIFwK 48163 2010-02-04 13:27:17 -0800 2010-02-04 16:36:02 -0800 Patch to fix WebKitGTK build when --enable-mathml specified. WebCore_GNUmakefile.am.patch text/plain 1327 cmsigler SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDM2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMDQgIENsZW1taXR0IFNpZ2xlciAgPGNtc2lnbGVyQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZWJLaXRHVEsgZG9lc24ndCBidWlsZCBHdGtMYXVuY2hlciB3aGVuIC0tZW5hYmxlLW1hdGht bCBpcyBzcGVjaWZpZWQuCisgICAgICAgIFVwZGF0ZWQgV2ViQ29yZS9HTlVtYWtlZmlsZS5hbSB0 byBpbmNsdWRlIG5lZWRlZCBmaWxlcyBpbiBidWlsZC4KKyAgICAgICAgCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDM4NworCisgICAgICAgIE5vIG5l dyB0ZXN0cy4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAyMDEwLTAyLTA0ICBDaHJp cyBHdWlsbG9yeSAgPGNocmlzLmd1aWxsb3J5QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiA1NDM2NCkKKysrIFdlYkNv cmUvR05VbWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTI3MjIsNyArMjcyMiwxMSBAQCB3 ZWJjb3JlX3NvdXJjZXMgKz0gXAogCVdlYkNvcmUvbWF0aG1sL01hdGhNTElubGluZUNvbnRhaW5l ckVsZW1lbnQuY3BwIFwKIAlXZWJDb3JlL21hdGhtbC9NYXRoTUxJbmxpbmVDb250YWluZXJFbGVt ZW50LmggIFwKIAlXZWJDb3JlL21hdGhtbC9NYXRoTUxNYXRoRWxlbWVudC5jcHAgXAotCVdlYkNv cmUvbWF0aG1sL01hdGhNTE1hdGhFbGVtZW50LmgKKwlXZWJDb3JlL21hdGhtbC9NYXRoTUxNYXRo RWxlbWVudC5oIFwKKwlXZWJDb3JlL21hdGhtbC9NYXRoTUxUZXh0RWxlbWVudC5jcHAgXAorCVdl YkNvcmUvbWF0aG1sL01hdGhNTFRleHRFbGVtZW50LmggXAorCVdlYkNvcmUvbWF0aG1sL1JlbmRl ck1hdGhNTEJsb2NrLmNwcCBcCisJV2ViQ29yZS9tYXRobWwvUmVuZGVyTWF0aE1MQmxvY2suaAog CiB3ZWJjb3JlX2J1aWx0X3NvdXJjZXMgKz0gXAogCURlcml2ZWRTb3VyY2VzL01hdGhNTEVsZW1l bnRGYWN0b3J5LmNwcCBcCg==