34383 2010-01-30 18:37:39 -0800 Do color animations on premultiplied colors 2010-03-24 00:00:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino krit oldest_to_newest 186143 0 simon.fraser 2010-01-30 18:37:39 -0800 Per <http://lists.w3.org/Archives/Public/www-style/2009Jul/0048.html>, we should interpolate colors by first converting them to premultiplied alpha. This avoids the 'fade through gray' when animating from 'transparent' to an opaque color. 186144 1 47779 simon.fraser 2010-01-30 18:39:32 -0800 Created attachment 47779 Patch 186146 2 47779 mitz 2010-01-30 18:45:41 -0800 Comment on attachment 47779 Patch It’s scary that Color can be either premultiplied or non-premultiplied. 186149 3 simon.fraser 2010-01-30 19:22:05 -0800 http://trac.webkit.org/changeset/54106 203293 4 simon.fraser 2010-03-23 17:09:20 -0700 *** Bug 34334 has been marked as a duplicate of this bug. *** 203338 5 krit 2010-03-23 23:58:30 -0700 Why not fixing premultipliedARGBFromColor directly? It affects other parts (mainly Cairo for what it was introduced) too. 203341 6 krit 2010-03-24 00:00:29 -0700 premultipliedARGBFromColor is related to bug 30333 47779 2010-01-30 18:39:32 -0800 2010-01-30 18:45:41 -0800 Patch bug-34383-20100130183930.patch text/plain 5169 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NDkyYzE2Li5kZDI3YmNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt MzAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gY29sb3IgYW5pbWF0aW9ucyBv biBwcmVtdWx0aXBsaWVkIGNvbG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQzODMKKyAgICAgICAgCisgICAgICAgIFRlc3RjYXNlIGZvciBhbmlt YXRpbmcgZnJvbSB0cmFuc3BhcmVudCBjb2xvcnMuCisKKyAgICAgICAgKiB0cmFuc2l0aW9ucy9j b2xvci10cmFuc2l0aW9uLXByZW11bHRpcGxpZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiB0cmFuc2l0aW9ucy9jb2xvci10cmFuc2l0aW9uLXByZW11bHRpcGxpZWQuaHRtbDogQWRk ZWQuCisKIDIwMTAtMDEtMjkgIFZpY3RvciBXYW5nICA8dmljdG9yd0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgZGFyaW5AYXBwbGUuY29tLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvdHJhbnNpdGlvbnMvY29sb3ItdHJhbnNpdGlvbi1wcmVtdWx0aXBsaWVkLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL2NvbG9yLXRyYW5zaXRpb24tcHJlbXVsdGlw bGllZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNTlm Y2E4OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL2NvbG9yLXRy YW5zaXRpb24tcHJlbXVsdGlwbGllZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitQQVNT IC0gImJhY2tncm91bmQtY29sb3IiIHByb3BlcnR5IGZvciAib25lIiBlbGVtZW50IGF0IDAuNXMg c2F3IHNvbWV0aGluZyBjbG9zZSB0bzogMCwxMjcsMAorUEFTUyAtICJiYWNrZ3JvdW5kLWNvbG9y IiBwcm9wZXJ0eSBmb3IgInR3byIgZWxlbWVudCBhdCAwLjVzIHNhdyBzb21ldGhpbmcgY2xvc2Ug dG86IDAsMCwyNTUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvY29sb3It dHJhbnNpdGlvbi1wcmVtdWx0aXBsaWVkLmh0bWwgYi9MYXlvdXRUZXN0cy90cmFuc2l0aW9ucy9j b2xvci10cmFuc2l0aW9uLXByZW11bHRpcGxpZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi5kNzI1YTE2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvdHJh bnNpdGlvbnMvY29sb3ItdHJhbnNpdGlvbi1wcmVtdWx0aXBsaWVkLmh0bWwKQEAgLTAsMCArMSw2 MSBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+CisgIDxzdHlsZSB0eXBlPSJ0 ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgIAorICAgIC5ib3ggeworICAgICAgd2lkdGg6IDEw MHB4OworICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgIG1hcmdpbjogMTBweDsKKyAgICAgIGJv cmRlcjogMXB4IHNvbGlkIGJsYWNrOworICAgICAgLXdlYmtpdC10cmFuc2l0aW9uOiBiYWNrZ3Jv dW5kLWNvbG9yIDFzIGxpbmVhcjsKKyAgICAgIC1tb3otdHJhbnNpdGlvbjogYmFja2dyb3VuZC1j b2xvciAxcyBsaW5lYXI7CisgICAgfQorICAgIAorICAgICNvbmUgeworICAgICAgYmFja2dyb3Vu ZC1jb2xvcjogdHJhbnNwYXJlbnQ7CisgICAgfQorICAgIAorICAgICNvbmUuY2hhbmdlZCB7Cisg ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKyAgICB9CisgICAgCisgICAgI3R3byB7Cisg ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2JhKDAsIDI1NSwgMCwgMCk7CisgICAgfQorCisgICAg I3R3by5jaGFuZ2VkIHsKKyAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMCwgMCwgMjU1LCAx KTsKKyAgICB9CisgIDwvc3R5bGU+CisgIDxzY3JpcHQgc3JjPSJ0cmFuc2l0aW9uLXRlc3QtaGVs cGVycy5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+PC9zY3JpcHQ+ CisgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+CisgICAg Y29uc3QgZXhwZWN0ZWRWYWx1ZXMgPSBbCisgICAgICAvLyBbdGltZSwgZWxlbWVudC1pZCwgcHJv cGVydHksIGV4cGVjdGVkLXZhbHVlLCB0b2xlcmFuY2VdCisgICAgICBbMC41LCAnb25lJywgJ2Jh Y2tncm91bmQtY29sb3InLCBbMCwgMTI3LCAwXSwgMl0sCisgICAgICBbMC41LCAndHdvJywgJ2Jh Y2tncm91bmQtY29sb3InLCBbMCwgMCwgMjU1XSwgMl0KKyAgICBdOworCisgICAgZnVuY3Rpb24g c2V0dXBUZXN0KCkKKyAgICB7CisgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnb25lJyku Y2xhc3NOYW1lID0gJ2JveCBjaGFuZ2VkJzsKKyAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd0d28nKS5jbGFzc05hbWUgPSAnYm94IGNoYW5nZWQnOworICAgIH0KKworICAgIHJ1blRyYW5z aXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzLCBzZXR1cFRlc3QsIHRydWUpOworICA8L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorCisgIDxkaXYgY2xhc3M9ImJveCIgaWQ9Im9uZSI+CisgIDwvZGl2 PgorCisgIDxkaXYgY2xhc3M9ImJveCIgaWQ9InR3byI+CisgIDwvZGl2PgorICAKKyAgPGRpdiBp ZD0icmVzdWx0Ij4KKyAgPC9kaXY+CisKKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0 IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDRkZWQ3ZDQuLjRmYzQ2ODAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMzAg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gY29sb3IgYW5pbWF0aW9ucyBvbiBw cmVtdWx0aXBsaWVkIGNvbG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzQzODMKKyAgICAgICAgCisgICAgICAgIENvbnZlcnQgY29sb3JzIHRvIHBy ZW11bHRpcGxpZWQgYWxwaGEgYmVmb3JlIGludGVycG9sYXRpbmcgdGhlbSwKKyAgICAgICAgdGhl biBjb252ZXJ0IHRoZSByZXN1bHQgYmFjayB0byBub24tcHJlbXVsdGlwbGllZC4gVGhpcyBnaXZl cyBiZXR0ZXIKKyAgICAgICAgcmVzdWx0cyB3aGVuIGFuaW1hdGluZyBmcm9tIHRyYW5zcGFyZW50 IGNvbG9ycy4KKworICAgICAgICBUZXN0OiB0cmFuc2l0aW9ucy9jb2xvci10cmFuc2l0aW9uLXBy ZW11bHRpcGxpZWQuaHRtbAorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFz ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpibGVuZEZ1bmMpOgorCiAyMDEwLTAxLTI5ICBTdGV2 ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlv bkJhc2UuY3BwIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAppbmRl eCAxMzUzNjVjLi4yYTJhYjRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0Fu aW1hdGlvbkJhc2UuY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFz ZS5jcHAKQEAgLTkyLDEwICs5MiwxNyBAQCBzdGF0aWMgaW5saW5lIENvbG9yIGJsZW5kRnVuYyhj b25zdCBBbmltYXRpb25CYXNlKiBhbmltLCBjb25zdCBDb2xvciYgZnJvbSwgY29ucwogICAgIGlm IChwcm9ncmVzcyA9PSAxICYmICF0by5pc1ZhbGlkKCkpCiAgICAgICAgIHJldHVybiBDb2xvcigp OwogCi0gICAgcmV0dXJuIENvbG9yKGJsZW5kRnVuYyhhbmltLCBmcm9tLnJlZCgpLCB0by5yZWQo KSwgcHJvZ3Jlc3MpLAotICAgICAgICAgICAgICAgICBibGVuZEZ1bmMoYW5pbSwgZnJvbS5ncmVl bigpLCB0by5ncmVlbigpLCBwcm9ncmVzcyksCi0gICAgICAgICAgICAgICAgIGJsZW5kRnVuYyhh bmltLCBmcm9tLmJsdWUoKSwgdG8uYmx1ZSgpLCBwcm9ncmVzcyksCi0gICAgICAgICAgICAgICAg IGJsZW5kRnVuYyhhbmltLCBmcm9tLmFscGhhKCksIHRvLmFscGhhKCksIHByb2dyZXNzKSk7Cisg ICAgLy8gQ29udHJhcnkgdG8gdGhlIG5hbWUsIFJHQkEzMiBhY3R1YWxseSBzdG9yZXMgQVJHQiwg c28gd2UgY2FuIGluaXRpYWxpemUgQ29sb3IgZGlyZWN0bHkgZnJvbSBwcmVtdWx0aXBsaWVkQVJH QkZyb21Db2xvcigpLgorICAgIC8vIEFsc28sIHByZW11bHRpcGxpZWRBUkdCRnJvbUNvbG9yKCkg YmFpbHMgb24gemVybyBhbHBoYSwgc28gc3BlY2lhbC1jYXNlIHRoYXQuCisgICAgQ29sb3IgcHJl bXVsdEZyb20gPSBmcm9tLmFscGhhKCkgPyBwcmVtdWx0aXBsaWVkQVJHQkZyb21Db2xvcihmcm9t KSA6IDA7CisgICAgQ29sb3IgcHJlbXVsdFRvID0gdG8uYWxwaGEoKSA/IHByZW11bHRpcGxpZWRB UkdCRnJvbUNvbG9yKHRvKSA6IDA7CisKKyAgICBDb2xvciBwcmVtdWx0QmxlbmRlZChibGVuZEZ1 bmMoYW5pbSwgcHJlbXVsdEZyb20ucmVkKCksIHByZW11bHRUby5yZWQoKSwgcHJvZ3Jlc3MpLAor ICAgICAgICAgICAgICAgICBibGVuZEZ1bmMoYW5pbSwgcHJlbXVsdEZyb20uZ3JlZW4oKSwgcHJl bXVsdFRvLmdyZWVuKCksIHByb2dyZXNzKSwKKyAgICAgICAgICAgICAgICAgYmxlbmRGdW5jKGFu aW0sIHByZW11bHRGcm9tLmJsdWUoKSwgcHJlbXVsdFRvLmJsdWUoKSwgcHJvZ3Jlc3MpLAorICAg ICAgICAgICAgICAgICBibGVuZEZ1bmMoYW5pbSwgcHJlbXVsdEZyb20uYWxwaGEoKSwgcHJlbXVs dFRvLmFscGhhKCksIHByb2dyZXNzKSk7CisKKyAgICByZXR1cm4gQ29sb3IoY29sb3JGcm9tUHJl bXVsdGlwbGllZEFSR0IocHJlbXVsdEJsZW5kZWQucmdiKCkpKTsKIH0KIAogc3RhdGljIGlubGlu ZSBMZW5ndGggYmxlbmRGdW5jKGNvbnN0IEFuaW1hdGlvbkJhc2UqLCBjb25zdCBMZW5ndGgmIGZy b20sIGNvbnN0IExlbmd0aCYgdG8sIGRvdWJsZSBwcm9ncmVzcykK