34378 2010-01-30 13:31:23 -0800 [Qt] WinCE buildfix after r52729 2010-02-01 16:39:42 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned commit-queue zherczeg oldest_to_newest 186127 0 paroga 2010-01-30 13:31:23 -0800 Rename WTF_PLATFORM_*_ENDIAN to WTF_CPU_*_ENDIAN 186128 1 47774 paroga 2010-01-30 13:33:45 -0800 Created attachment 47774 The patch 186250 2 47774 ariya.hidayat 2010-01-31 15:48:26 -0800 Comment on attachment 47774 The patch LGTM. Maybe fix that typo (Q_BIG_EDIAN) as well? 186342 3 47823 paroga 2010-02-01 02:44:39 -0800 Created attachment 47823 The patch (typo fixed) 186357 4 zherczeg 2010-02-01 04:19:30 -0800 The patch looks good to me, although the comment says: We can not determine the endianess at compile time. If this comment is not valid anymore, please remove or modify it. Furthermore, please do not set commit‑queue flags in the future. It should only be enabled after your patch is accepted. 186359 5 paroga 2010-02-01 04:31:11 -0800 (In reply to comment #4) > The patch looks good to me, although the comment says: > > We can not determine the endianess at compile time. > > If this comment is not valid anymore, please remove or modify it. Furthermore, > please do not set commit‑queue flags in the future. It should only be enabled > after your patch is accepted. Currently i compile JSC without Qt. Platform.h "dedects" MIDDLE_ENDIAN which is wrong! So i think the comment is valid. I want to change this to the following in a further patch: #if OS(WINCE) # undef WTF_CPU_BIG_ENDIAN # undef WTF_CPU_MIDDLE_ENDIAN # if PLATFORM(QT) # include <QtGlobal> # if Q_BYTE_ORDER == Q_BIG_ENDIAN # define WTF_CPU_BIG_ENDIAN 1 # endif # endif # include <ce_time.h> #endif 186395 6 zherczeg 2010-02-01 06:50:32 -0800 > I want to change this to the following in a further patch: Fixing fixes is not really a WebKit style. Please do this change in patch. 186398 7 paroga 2010-02-01 06:55:52 -0800 (In reply to comment #6) > > I want to change this to the following in a further patch: > > Fixing fixes is not really a WebKit style. Please do this change in patch. What should i do now? Changing WTF_PLATFORM_*_ENDIAN to WTF_CPU_*_ENDIAN is _only_ a buildfix. Should i change it to comment #5 or should i change the whole ARM ENDIAN DEDECTION (add ugly OS(WINCE))? 186691 8 47823 commit-queue 2010-02-01 16:39:37 -0800 Comment on attachment 47823 The patch (typo fixed) Clearing flags on attachment: 47823 Committed r54176: <http://trac.webkit.org/changeset/54176> 186692 9 commit-queue 2010-02-01 16:39:42 -0800 All reviewed patches have been landed. Closing bug. 47774 2010-01-30 13:33:45 -0800 2010-02-01 02:44:39 -0800 The patch bug-34378.patch text/plain 1078 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MTAzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEtMzAgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBXaW5DRSBidWlsZGZpeCBhZnRlciByNTI3Mjku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDM3OAor CisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTAtMDEtMjkgIE1hcmsgUm93ZSAgPG1y b3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBTb3J0IFhjb2RlIHByb2plY3RzLgpJbmRleDogSmF2 YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDU0MTAzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1Bs YXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4MSwxMCArNDgxLDEwIEBACiAqLwogI2lmIE9T KFdJTkNFKSAmJiBQTEFURk9STShRVCkKICMgICBpbmNsdWRlIDxRdEdsb2JhbD4KLSMgICB1bmRl ZiBXVEZfUExBVEZPUk1fQklHX0VORElBTgotIyAgIHVuZGVmIFdURl9QTEFURk9STV9NSURETEVf RU5ESUFOCisjICAgdW5kZWYgV1RGX0NQVV9CSUdfRU5ESUFOCisjICAgdW5kZWYgV1RGX0NQVV9N SURETEVfRU5ESUFOCiAjICAgaWYgUV9CWVRFX09SREVSID09IFFfQklHX0VESUFOCi0jICAgICAg IGRlZmluZSBXVEZfUExBVEZPUk1fQklHX0VORElBTiAxCisjICAgICAgIGRlZmluZSBXVEZfQ1BV X0JJR19FTkRJQU4gMQogIyAgIGVuZGlmCiAKICMgICBpbmNsdWRlIDxjZV90aW1lLmg+Cg== 47823 2010-02-01 02:44:39 -0800 2010-02-01 16:39:37 -0800 The patch (typo fixed) bug-34378.patch text/plain 1145 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MTAzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEtMzAgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBXaW5DRSBidWlsZGZpeCBhZnRlciByNTI3Mjkg YW5kIGZpeCBmb3IgUV9CSUdfRU5ESUFOIHR5cG8uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDM3OAorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6 CisKIDIwMTAtMDEtMjkgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBT b3J0IFhjb2RlIHByb2plY3RzLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDU0 MTAzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAg LTQ4MSwxMCArNDgxLDEwIEBACiAqLwogI2lmIE9TKFdJTkNFKSAmJiBQTEFURk9STShRVCkKICMg ICBpbmNsdWRlIDxRdEdsb2JhbD4KLSMgICB1bmRlZiBXVEZfUExBVEZPUk1fQklHX0VORElBTgot IyAgIHVuZGVmIFdURl9QTEFURk9STV9NSURETEVfRU5ESUFOCi0jICAgaWYgUV9CWVRFX09SREVS ID09IFFfQklHX0VESUFOCi0jICAgICAgIGRlZmluZSBXVEZfUExBVEZPUk1fQklHX0VORElBTiAx CisjICAgdW5kZWYgV1RGX0NQVV9CSUdfRU5ESUFOCisjICAgdW5kZWYgV1RGX0NQVV9NSURETEVf RU5ESUFOCisjICAgaWYgUV9CWVRFX09SREVSID09IFFfQklHX0VORElBTgorIyAgICAgICBkZWZp bmUgV1RGX0NQVV9CSUdfRU5ESUFOIDEKICMgICBlbmRpZgogCiAjICAgaW5jbHVkZSA8Y2VfdGlt ZS5oPgo=