34353 2010-01-29 16:47:31 -0800 [Chromium] Clean up WebStorageArea 2010-02-01 18:43:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow eric michaeln oldest_to_newest 186003 0 jorlow 2010-01-29 16:47:31 -0800 [Chromium] Clean up WebStorageArea 186004 1 47744 jorlow 2010-01-29 16:48:07 -0800 Created attachment 47744 Patch 186552 2 michaeln 2010-02-01 13:37:04 -0800 lgtm (fwiw) 186625 3 47744 eric 2010-02-01 15:56:08 -0800 Comment on attachment 47744 Patch Your unofficial reviews help a lot actually. :) So thank you! 186663 4 eric 2010-02-01 16:13:40 -0800 Attachment 47744 was posted by a committer and has review+, assigning to Jeremy Orlow for commit. 186755 5 jorlow 2010-02-01 18:43:22 -0800 Committed r54191: <http://trac.webkit.org/changeset/54191> 47744 2010-01-29 16:48:07 -0800 2010-02-01 15:56:08 -0800 Patch bug-34353-20100129164806.patch text/plain 3180 jorlow SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQwODcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMjkgIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBDbGVhbiB1cCBXZWJTdG9yYWdlQXJl YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQzNTMK KworICAgICAgICBHZXQgcmlkIG9mIGxlZ2FjeSBnbHVlIGNvZGUgYW5kIGZpeCBhIHR5cG8uCisK KyAgICAgICAgKiBwdWJsaWMvV2ViU3RvcmFnZUFyZWEuaDoKKwogMjAxMC0wMS0yOSAgSmVyZW15 IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1p dHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlN0b3JhZ2VBcmVh LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTdG9yYWdlQXJlYS5o CShyZXZpc2lvbiA1NDA4MSkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3RvcmFnZUFy ZWEuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsNDQgKzU3LDE3IEBAIHB1YmxpYzoKICAgICAvLyBu byBlbnRyeSBmb3IgdGhhdCBrZXkuCiAgICAgdmlydHVhbCBXZWJTdHJpbmcgZ2V0SXRlbShjb25z dCBXZWJTdHJpbmcmIGtleSkgPSAwOwogCi0gICAgLy8gU2V0IHRoZSB2YWx1ZSB0aGF0IGNvcnJl c3BvbmRzIHRvIGEgc3BlY2lmaWMga2V5LiBRdW90YUV4Y2VwdGlvbiBpcyBzZXQgaWYgd2UndmUK KyAgICAvLyBTZXQgdGhlIHZhbHVlIHRoYXQgY29ycmVzcG9uZHMgdG8gYSBzcGVjaWZpYyBrZXku IFF1b3RhRXhjZXB0aW9uIGlzIHNldCBpZgogICAgIC8vIHRoZSBTdG9yYWdlQXJlYSB3b3VsZCBo YXZlIGV4Y2VlZGVkIGl0cyBxdW90YS4gVGhlIHZhbHVlIGlzIE5PVCBzZXQgd2hlbiB0aGVyZSdz CiAgICAgLy8gYW4gZXhjZXB0aW9uLiAgdXJsIGlzIHRoZSB1cmwgdGhhdCBzaG91bGQgYmUgdXNl ZCBpZiBhIHN0b3JhZ2UgZXZlbnQgZmlyZXMuCi0gICAgLy8gRklYTUU6IFRoZSBmb2xsb3dpbmcg aXMgYSBoYWNrIHRvIGtlZXAgQ2hyb21pdW0gY29tcGlsaW5nIHVudGlsIHRoZSBvdGhlciBoYWxm IGlzIGxhbmRlZC4gIFJlbW92ZSBzb29uLgotICAgIHZpcnR1YWwgdm9pZCBzZXRJdGVtKGNvbnN0 IFdlYlN0cmluZyYga2V5LCBjb25zdCBXZWJTdHJpbmcmIG5ld1ZhbHVlLCBjb25zdCBXZWJVUkwm IHVybCwgYm9vbCYgcXVvdGFFeGNlcHRpb24pIC8vIERlcHJlY2F0ZWQuCi0gICAgewotICAgICAg ICBXZWJTdHJpbmcgb2xkVmFsdWU7Ci0gICAgICAgIHNldEl0ZW0oa2V5LCBuZXdWYWx1ZSwgdXJs LCBxdW90YUV4Y2VwdGlvbiwgb2xkVmFsdWUpOwotICAgIH0KLSAgICB2aXJ0dWFsIHZvaWQgc2V0 SXRlbShjb25zdCBXZWJTdHJpbmcmIGtleSwgY29uc3QgV2ViU3RyaW5nJiBuZXdWYWx1ZSwgY29u c3QgV2ViVVJMJiB1cmwsIGJvb2wmIHF1b3RhRXhjZXB0aW9uLCBXZWJTdHJpbmcmIG9sZFZhbHVl KQotICAgIHsKLSAgICAgICAgc2V0SXRlbShrZXksIG5ld1ZhbHVlLCB1cmwsIHF1b3RhRXhjZXB0 aW9uKTsKLSAgICB9CisgICAgdmlydHVhbCB2b2lkIHNldEl0ZW0oY29uc3QgV2ViU3RyaW5nJiBr ZXksIGNvbnN0IFdlYlN0cmluZyYgbmV3VmFsdWUsIGNvbnN0IFdlYlVSTCYgdXJsLCBib29sJiBx dW90YUV4Y2VwdGlvbiwgV2ViU3RyaW5nJiBvbGRWYWx1ZSkgPSAwOwogCiAgICAgLy8gUmVtb3Zl IHRoZSB2YWx1ZSBhc3NvY2lhdGVkIHdpdGggYSBwYXJ0aWN1bGFyIGtleS4gIHVybCBpcyB0aGUg dXJsIHRoYXQgc2hvdWxkIGJlIHVzZWQKICAgICAvLyBpZiBhIHN0b3JhZ2UgZXZlbnQgZmlyZXMu Ci0gICAgLy8gRklYTUU6IFRoZSBmb2xsb3dpbmcgaXMgYSBoYWNrIHRvIGtlZXAgQ2hyb21pdW0g Y29tcGlsaW5nIHVudGlsIHRoZSBvdGhlciBoYWxmIGlzIGxhbmRlZC4gIFJlbW92ZSBzb29uLgot ICAgIHZpcnR1YWwgdm9pZCByZW1vdmVJdGVtKGNvbnN0IFdlYlN0cmluZyYga2V5LCBjb25zdCBX ZWJVUkwmIHVybCkgLy8gRGVwcmVjYXRlZC4KLSAgICB7Ci0gICAgICAgIFdlYlN0cmluZyBvbGRW YWx1ZTsKLSAgICAgICAgcmVtb3ZlSXRlbShrZXksIHVybCwgb2xkVmFsdWUpOwotICAgIH0KLSAg ICB2aXJ0dWFsIHZvaWQgcmVtb3ZlSXRlbShjb25zdCBXZWJTdHJpbmcmIGtleSwgY29uc3QgV2Vi VVJMJiB1cmwsIFdlYlN0cmluZyYgb2xkVmFsdWUpCi0gICAgewotICAgICAgICByZW1vdmVJdGVt KGtleSwgdXJsKTsKLSAgICB9CisgICAgdmlydHVhbCB2b2lkIHJlbW92ZUl0ZW0oY29uc3QgV2Vi U3RyaW5nJiBrZXksIGNvbnN0IFdlYlVSTCYgdXJsLCBXZWJTdHJpbmcmIG9sZFZhbHVlKSA9IDA7 CiAKICAgICAvLyBDbGVhciBhbGwga2V5L3ZhbHVlIHBhaXJzLiAgdXJsIGlzIHRoZSB1cmwgdGhh dCBzaG91bGQgYmUgdXNlZCBpZiBhIHN0b3JhZ2UgZXZlbnQgZmlyZXMuCi0gICAgLy8gRklYTUU6 IFRoZSBmb2xsb3dpbmcgaXMgYSBoYWNrIHRvIGtlZXAgQ2hyb21pdW0gY29tcGlsaW5nIHVudGls IHRoZSBvdGhlciBoYWxmIGlzIGxhbmRlZC4gIFJlbW92ZSBzb29uLgotICAgIHZpcnR1YWwgdm9p ZCBjbGVhcihjb25zdCBXZWJVUkwmIHVybCkgLy8gRGVwcmVjYXRlZC4KLSAgICB7Ci0gICAgICAg IGJvb2wgc29tZXRoaW5nQ2xlYXJlZDsKLSAgICAgICAgY2xlYXIodXJsLCBzb21ldGhpbmdDbGVh cmVkKTsKLSAgICB9Ci0gICAgdmlydHVhbCB2b2lkIGNsZWFyKGNvbnN0IFdlYlVSTCYgdXJsLCBi b29sJiBzb21ldGhpbmdDbGVhcmVkKQotICAgIHsKLSAgICAgICAgY2xlYXIodXJsKTsKLSAgICB9 CisgICAgdmlydHVhbCB2b2lkIGNsZWFyKGNvbnN0IFdlYlVSTCYgdXJsLCBib29sJiBzb21ldGhp bmdDbGVhcmVkKSA9IDA7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK