3435 2005-06-11 06:01:10 -0700 Parentheses are backwards in Hebrew text (no bidi mirroring?) 2005-08-19 14:07:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 the_great_spam_bin hyatt mitz oldest_to_newest 11442 0 the_great_spam_bin 2005-06-11 06:01:23 -0700 Parentheses in Hebrew text seem to be displayed in the wrong direction. In the attachment, the parentheses should open toward the word (i.e. be around the word), but instead open away from the word. I think right and left parentheses are among the characters that must be replaced with "mirror" characters according to the Unicode spec. From a very brief perusal of the code, it seems that WebKit doesn't implement this. See: http://www.unicode.org/reports/tr9/ http://www.unicode.org/Public/UNIDATA/BidiMirroring.txt 11443 1 2247 the_great_spam_bin 2005-06-11 06:03:46 -0700 Created attachment 2247 testcase 11444 2 mitz 2005-06-11 07:37:10 -0700 (In reply to comment #1) I can't seem to reproduce this. (I think mirroring is mostly handled by ATSUI, although you can see that WebKit/WebCoreSupport.subproj/WebTextRenderer.m:2041 does take it into account in width calculations). There are mirroring-related issues in the rendering of "visually-ordered Hebrew", where mirroring happens although it shouldn't. 11447 3 the_great_spam_bin 2005-06-11 08:34:46 -0700 (In reply to comment #2) > (In reply to comment #1) > > I can't seem to reproduce this. (I think mirroring is mostly handled by ATSUI, although you can see that > WebKit/WebCoreSupport.subproj/WebTextRenderer.m:2041 does take it into account in width > calculations). There are mirroring-related issues in the rendering of "visually-ordered Hebrew", where > mirroring happens although it shouldn't. I've done a little more investigating, and it seems that WebTextRenderer.m has two code paths for text rendering, CG and ATSUI, and it uses ATSUI to render Hebrew. WebTextRenderer.m:2041 is on the CG code path, and so it never gets executed for Hebrew. The ATSUI code path sets the text direction with kATSULineDirectionTag in _createATSUTextLayoutForRun, but its unclear whether ATSUI is supposed to do mirroring automatically. If it is, maybe it's an ATSUI bug. What OS version are you using? I'm on 10.4.1 I've actually managed to fix this by putting in a hack that calls u_charMirror() in the ATSUI code path. 11450 4 mitz 2005-06-11 09:14:58 -0700 (In reply to comment #3) > What OS version are you using? I'm on 10.4.1 10.4.1, Safari 2.0 (412), Standard Font: Times 16, Default Encoding: Western (ISO Latin 1), and I get the same results with the CVS version. I remember mirroring being an issue in early releases, but I also remember that it has been fixed some time ago. This may provide an important clue: <http://forums.ort.org.il/scripts/showsm.asp?which_forum=307&mess=2242612> A user reporting that he's seeing reverse parentheses and that his work around is disabling Arial in Font Book. Some Hebrew-speaking Mac users install a version of Arial that comes from Microsoft (and includes Hebrew), so maybe that's the culprit. 11459 5 nickshanks 2005-06-11 10:53:11 -0700 Arabic also has problems. Where 12345 represents arabic characters as encoded in the bytestream, I see: <p dir="rtl">(12345)</p> come out as: )(54321 This is not related to Arial Unicode MS as the font used is Geeza Pro. 11490 6 mitz 2005-06-11 14:02:47 -0700 (In reply to comment #3) Looks like an ATSUI issue with certain fonts. Here's how I confirmed this: Built ATSUIFontPanelDemo from /Developer/Examples/ATSUI/Font Panel Support/, run it, changed the text to Hebrew text in parentheses, then tried various fonts. Lucida Grande, New Peninim MT and Arial Hebrew do the mirroring fine, while that Arial from Microsoft (Version 2.98; Unique name: Monotype:Arial Regular:Version 2.98 (Microsoft)) gives reversed parentheses. You should probably file a bug against ATSUI on Radar. 11491 7 mitz 2005-06-11 14:16:59 -0700 (In reply to comment #5) > Arabic also has problems. Where 12345 represents arabic characters as encoded in the bytestream, I see: > > <p dir="rtl">(12345)</p> > > come out as: > > )(54321 > > This is not related to Arial Unicode MS as the font used is Geeza Pro. I can reproduce this with the latest shipping Safari but not with the latest CVS version (which includes a fix for paragraphs beginning with neutrals). What do you get when the paragraph doesn't begin with a neutral, e.g. <p dir="rtl">12 (345) 67</p> ? 13693 8 mitz 2005-07-02 09:37:14 -0700 Analysis: ATSUI is supposed to handle mirroring, but it does so only if the font's glyph properties table ('prop') contains the mirrored glyph information. Thus mirroring doesn't happen with fonts that don't have that information in their 'prop' (or don't have a 'prop' at all), and when ATSUI uses a fallback font, but the original font doesn't have mirroring information. There seems to be no way (short of looking at the 'prop' table) of finding out what ATSUI is going to do with mirrored characters. However, there is a way to force ATSUI to never mirror, and then WebTextRenderer could always mirror (like it does for CG). This can be done by reversing the RTL text run and prepending an LRE prior to passing to ATSUI, and not to setting the ATSUI line direction to RTL. Another option is to drop ATSUI altogether for Hebrew (I don't know about Arabic) and use CG. This would solve other issues with Hebrew (such as poor choice of fallback fonts and no support for text justification, letter spacing and word spacing). 13818 9 2774 mitz 2005-07-03 12:12:47 -0700 Created attachment 2774 Proposed patch This patch tries to guess whether ATSUI will perform mirroring or not, based on the existence of a 'prop' table for the font, and applies mirroring itself it ATSUI will not. 14160 10 2774 mjs 2005-07-07 21:37:25 -0700 Comment on attachment 2774 Proposed patch r=me Make sure to add the test case to layout tests when landing. 14446 11 2927 ggaren 2005-07-12 10:26:51 -0700 Created attachment 2927 layout test The old test lacked a font declaration, so it wasn't guaranteed to fail. 17006 12 adele 2005-08-19 14:07:30 -0700 using <rdar://problem/4215911> to track this. 2247 2005-06-11 06:03:46 -0700 2005-07-12 10:26:51 -0700 testcase mirroring.html text/html 128 the_great_spam_bin /v8APABoAHQAbQBsACAAZABpAHIAPQAiAHIAdABsACIAPgAKADwAaABlAGEAZAA+ADwALwBoAGUA YQBkAD4ACgA8AGIAbwBkAHkAPgAKACgF3AXeBdMF2QXgBdUF6gApAAoAPAAvAGIAbwBkAHkAPgAK ADwALwBoAHQAbQBsAD4= 2774 2005-07-03 12:12:47 -0700 2005-07-08 00:27:41 -0700 Proposed patch 3435_patch_r1.txt text/plain 4643 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIuaCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4zNwpkaWZmIC11IC1wIC1yMS4zNyBXZWJUZXh0UmVuZGVyZXIuaAotLS0g V2ViVGV4dFJlbmRlcmVyLmgJMjAwNS8wNi8wNiAwMjoyMToxOQkxLjM3CisrKyBXZWJUZXh0UmVu ZGVyZXIuaAkyMDA1LzA3LzAzIDE5OjA3OjAyCkBAIC03MCw2ICs3MCw3IEBAIHR5cGVkZWYgc3Ry dWN0IENoYXJhY3RlcldpZHRoSXRlcmF0b3IgQ2gKICAgICBOU0ZvbnQgKnNtYWxsQ2Fwc0ZvbnQ7 CiAgICAgQVRTVVN0eWxlIF9BVFNVU3N0eWxlOwogICAgIEJPT0wgQVRTVVN0eWxlSW5pdGlhbGl6 ZWQ7CisgICAgQk9PTCBBVFNVTWlycm9yczsKIH0KIAogKyAoQk9PTClzaG91bGRCdWZmZXJUZXh0 RHJhd2luZzsKSW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNzYKZGlmZiAtdSAtcCAtcjEuMTc2IFdlYlRleHRSZW5k ZXJlci5tCi0tLSBXZWJUZXh0UmVuZGVyZXIubQkyMDA1LzA2LzMwIDAxOjI4OjM2CTEuMTc2Cisr KyBXZWJUZXh0UmVuZGVyZXIubQkyMDA1LzA3LzAzIDE5OjA3OjA5CkBAIC0xNDU0LDYgKzE0NTQs NyBAQCBzdGF0aWMgY29uc3QgY2hhciAqam9pbmluZ05hbWVzW10gPSB7CiAKICAgICBpZiAoIUFU U1VTdHlsZUluaXRpYWxpemVkKXsKICAgICAgICAgT1NTdGF0dXMgc3RhdHVzOworICAgICAgICBC eXRlQ291bnQgcHJvcFRhYmxlU2l6ZTsKICAgICAgICAgCiAgICAgICAgIHN0YXR1cyA9IEFUU1VD cmVhdGVTdHlsZSgmX0FUU1VTc3R5bGUpOwogICAgICAgICBpZihzdGF0dXMgIT0gbm9FcnIpCkBA IC0xNDc0LDYgKzE0NzUsMTMgQEAgc3RhdGljIGNvbnN0IGNoYXIgKmpvaW5pbmdOYW1lc1tdID0g ewogICAgICAgICBzdGF0dXMgPSBBVFNVU2V0QXR0cmlidXRlcyAoX0FUU1VTc3R5bGUsIDMsIHN0 eWxlVGFncywgc3R5bGVTaXplcywgc3R5bGVWYWx1ZXMpOwogICAgICAgICBpZihzdGF0dXMgIT0g bm9FcnIpCiAgICAgICAgICAgICBGQVRBTF9BTFdBWVMgKCJBVFNVU2V0QXR0cmlidXRlcyBmYWls ZWQgKCVkKSIsIHN0YXR1cyk7CisgICAgICAgIHN0YXR1cyA9IEFUU0ZvbnRHZXRUYWJsZShmb250 SUQsICdwcm9wJywgMCwgMCwgMCwgJnByb3BUYWJsZVNpemUpOworICAgICAgICBpZiAoc3RhdHVz ID09IG5vRXJyKSAgICAvLyBuYWl2ZWx5IGFzc3VtZSB0aGF0IGlmIGEgJ3Byb3AnIHRhYmxlIGV4 aXN0cyB0aGVuIGl0IGNvbnRhaW5zIG1pcnJvcmluZyBpbmZvCisgICAgICAgICAgICBBVFNVTWly cm9ycyA9IFlFUzsKKyAgICAgICAgZWxzZSBpZiAoc3RhdHVzID09IGtBVFNJbnZhbGlkRm9udFRh YmxlQWNjZXNzKQorICAgICAgICAgICAgQVRTVU1pcnJvcnMgPSBOTzsKKyAgICAgICAgZWxzZQor ICAgICAgICAgICAgRkFUQUxfQUxXQVlTICgiQVRTRm9udEdldFRhYmxlIGZhaWxlZCAoJWQpIiwg c3RhdHVzKTsKIAogICAgICAgICBBVFNVU3R5bGVJbml0aWFsaXplZCA9IFlFUzsKICAgICB9CkBA IC0xNTg2LDYgKzE1OTQsMjUgQEAgc3RhdGljIFdlYkNvcmVUZXh0UnVuIHJldmVyc2VDaGFyYWN0 ZXJzSQogICAgIHJldHVybiBzd2FwcGVkUnVuOwogfQogCisvLyBCZSBzdXJlIHRvIGZyZWUgdGhl IHJ1bi5jaGFyYWN0ZXJzIGFsbG9jYXRlZCBieSB0aGlzIGZ1bmN0aW9uLgorc3RhdGljIFdlYkNv cmVUZXh0UnVuIGFwcGx5TWlycm9yaW5nVG9SdW4oY29uc3QgV2ViQ29yZVRleHRSdW4gKnJ1bikK K3sKKyAgICBXZWJDb3JlVGV4dFJ1biBzd2FwcGVkUnVuOworICAgIHVuc2lnbmVkIGludCBpOwor ICAgIAorICAgIFVuaUNoYXIgKnN3YXBwZWRDaGFyYWN0ZXJzID0gKFVuaUNoYXIgKiltYWxsb2Mo c2l6ZW9mKFVuaUNoYXIpKihydW4tPmxlbmd0aCkpOworICAgIGZvciAoaT0wOyBpIDwgcnVuLT5s ZW5ndGg7IGkrKykgeworICAgICAgICAvLyB3aWxsIGNob2tlIG9uIHN1cnJvZ2F0ZSBwYWlycz8K KyAgICAgICAgc3dhcHBlZENoYXJhY3RlcnNbaV0gPSB1X2NoYXJNaXJyb3IocnVuLT5jaGFyYWN0 ZXJzW2ldKTsKKyAgICB9CisgICAgc3dhcHBlZFJ1bi5mcm9tID0gcnVuLT5mcm9tOworICAgIHN3 YXBwZWRSdW4udG8gPSBydW4tPnRvOworICAgIHN3YXBwZWRSdW4ubGVuZ3RoID0gcnVuLT5sZW5n dGg7CisgICAgc3dhcHBlZFJ1bi5jaGFyYWN0ZXJzID0gc3dhcHBlZENoYXJhY3RlcnM7CisKKyAg ICByZXR1cm4gc3dhcHBlZFJ1bjsKK30KKwogLSAodm9pZClfQVRTVV9kcmF3SGlnaGxpZ2h0Rm9y UnVuOihjb25zdCBXZWJDb3JlVGV4dFJ1biAqKXJ1biBzdHlsZTooY29uc3QgV2ViQ29yZVRleHRT dHlsZSAqKXN0eWxlIGdlb21ldHJ5Oihjb25zdCBXZWJDb3JlVGV4dEdlb21ldHJ5ICopZ2VvbWV0 cnkKIHsKICAgICAvLyBUaGUgb25seSBDb2NvYSBjYWxscyBtYWRlIGhlcmUgYXJlIHRvIE5TQ29s b3IgYW5kIE5TQmV6aWVyUGF0aCwKQEAgLTE2MDQsNiArMTYzMSw5IEBAIHN0YXRpYyBXZWJDb3Jl VGV4dFJ1biByZXZlcnNlQ2hhcmFjdGVyc0kKICAgICBpZiAoc3R5bGUtPnZpc3VhbGx5T3JkZXJl ZCkgewogICAgICAgICBzd2FwcGVkUnVuID0gcmV2ZXJzZUNoYXJhY3RlcnNJblJ1bihydW4pOwog ICAgICAgICBhUnVuID0gJnN3YXBwZWRSdW47CisgICAgfSBlbHNlIGlmIChzdHlsZS0+cnRsICYm ICFBVFNVTWlycm9ycykgeworICAgICAgICBzd2FwcGVkUnVuID0gYXBwbHlNaXJyb3JpbmdUb1J1 bihydW4pOworICAgICAgICBhUnVuID0gJnN3YXBwZWRSdW47CiAgICAgfQogCiAgICAgZnJvbSA9 IGFSdW4tPmZyb207CkBAIC0xNjU2LDcgKzE2ODYsNyBAQCBzdGF0aWMgV2ViQ29yZVRleHRSdW4g cmV2ZXJzZUNoYXJhY3RlcnNJCiAKICAgICBBVFNVRGlzcG9zZVRleHRMYXlvdXQgKGxheW91dCk7 IC8vIElnbm9yZSB0aGUgZXJyb3IuICBOb3RoaW5nIHdlIGNhbiBkbyBhbnl3YXkuCiAKLSAgICBp ZiAoc3R5bGUtPnZpc3VhbGx5T3JkZXJlZCkKKyAgICBpZiAoc3R5bGUtPnZpc3VhbGx5T3JkZXJl ZCB8fCAoc3R5bGUtPnJ0bCAmJiAhQVRTVU1pcnJvcnMpKQogICAgICAgICBmcmVlICgodm9pZCAq KXN3YXBwZWRSdW4uY2hhcmFjdGVycyk7CiB9CiAKQEAgLTE2NzYsNiArMTcwNiw5IEBAIHN0YXRp YyBXZWJDb3JlVGV4dFJ1biByZXZlcnNlQ2hhcmFjdGVyc0kKICAgICBpZiAoc3R5bGUtPnZpc3Vh bGx5T3JkZXJlZCkgewogICAgICAgICBzd2FwcGVkUnVuID0gcmV2ZXJzZUNoYXJhY3RlcnNJblJ1 bihydW4pOwogICAgICAgICBhUnVuID0gJnN3YXBwZWRSdW47CisgICAgfSBlbHNlIGlmIChzdHls ZS0+cnRsICYmICFBVFNVTWlycm9ycykgeworICAgICAgICBzd2FwcGVkUnVuID0gYXBwbHlNaXJy b3JpbmdUb1J1bihydW4pOworICAgICAgICBhUnVuID0gJnN3YXBwZWRSdW47CiAgICAgfQogCiAg ICAgZnJvbSA9IGFSdW4tPmZyb207CkBAIC0xNzA5LDcgKzE3NDIsNyBAQCBzdGF0aWMgV2ViQ29y ZVRleHRSdW4gcmV2ZXJzZUNoYXJhY3RlcnNJCiAKICAgICBBVFNVRGlzcG9zZVRleHRMYXlvdXQg KGxheW91dCk7IC8vIElnbm9yZSB0aGUgZXJyb3IuICBOb3RoaW5nIHdlIGNhbiBkbyBhbnl3YXku CiAgICAgCi0gICAgaWYgKHN0eWxlLT52aXN1YWxseU9yZGVyZWQpCisgICAgaWYgKHN0eWxlLT52 aXN1YWxseU9yZGVyZWQgfHwgKHN0eWxlLT5ydGwgJiYgIUFUU1VNaXJyb3JzKSkKICAgICAgICAg ZnJlZSAoKHZvaWQgKilzd2FwcGVkUnVuLmNoYXJhY3RlcnMpOwogfQogCkBAIC0xNzMxLDYgKzE3 NjQsOSBAQCBzdGF0aWMgV2ViQ29yZVRleHRSdW4gcmV2ZXJzZUNoYXJhY3RlcnNJCiAgICAgaWYg KHN0eWxlLT52aXN1YWxseU9yZGVyZWQpIHsKICAgICAgICAgc3dhcHBlZFJ1biA9IHJldmVyc2VD aGFyYWN0ZXJzSW5SdW4ocnVuKTsKICAgICAgICAgYVJ1biA9ICZzd2FwcGVkUnVuOworICAgIH0g ZWxzZSBpZiAoc3R5bGUtPnJ0bCAmJiAhQVRTVU1pcnJvcnMpIHsKKyAgICAgICAgc3dhcHBlZFJ1 biA9IGFwcGx5TWlycm9yaW5nVG9SdW4ocnVuKTsKKyAgICAgICAgYVJ1biA9ICZzd2FwcGVkUnVu OwogICAgIH0KIAogICAgIGxheW91dCA9IFtzZWxmIF9jcmVhdGVBVFNVVGV4dExheW91dEZvclJ1 bjphUnVuIHN0eWxlOnN0eWxlXTsKQEAgLTE3NDcsNyArMTc4Myw3IEBAIHN0YXRpYyBXZWJDb3Jl VGV4dFJ1biByZXZlcnNlQ2hhcmFjdGVyc0kKICAgICAgICAgLy8gRmFpbGVkIHRvIGZpbmQgb2Zm c2V0ISAgUmV0dXJuIDAgb2Zmc2V0LgogICAgIH0KICAgICAgICAKLSAgICBpZiAoc3R5bGUtPnZp c3VhbGx5T3JkZXJlZCkgeworICAgIGlmIChzdHlsZS0+dmlzdWFsbHlPcmRlcmVkIHx8IChzdHls ZS0+cnRsICYmICFBVFNVTWlycm9ycykpIHsKICAgICAgICAgZnJlZSAoKHZvaWQgKilzd2FwcGVk UnVuLmNoYXJhY3RlcnMpOwogICAgIH0KIAo= 2927 2005-07-12 10:26:51 -0700 2005-07-12 10:26:51 -0700 layout test bidi-parens.html text/html 446 ggaren 77u/PGh0bWw+CjxoZWFkPgo8c3R5bGU+Ci5jb25zb2xlIHsKCWZvbnQtZmFtaWx5OiBBcmlhbCwg VGltZXMgTmV3IFJvbWFuCn0KPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KPHA+VGhpcyB0ZXN0IGNo ZWNrcyBmb3IgYSByZWdyZXNzaW9uIGFnYWluc3QgPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9w ZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDM1Ij4zNDM1IFBhcmVudGhlc2VzIGFyZSBi YWNrd2FyZHMgaW4gSGVicmV3IHRleHQgKG5vIGJpZGkgbWlycm9yaW5nPyk8L2E+LjwvcD4KPHA+ U3VjY2VzczogcGFyZW50aGVzZXMgZW5jYXBzdWxhdGUgd29yZC48L3A+CjxwPkZhaWx1cmU6IHBh cmVudGhlc2VzIGZhY2UgYXdheSBmcm9tIHdvcmQuPC9wPgo8aHI+CjxwIGlkPSJjb25zb2xlIiBk aXI9InJ0bCI+CijXnNee15PXmdeg15XXqikKPC9wPgo8L2JvZHk+CjwvaHRtbD4=