34343 2010-01-29 13:22:21 -0800 Client-based Geolocation starts updating before getting consent from the user 2010-01-29 14:08:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken webkit-unassigned oldest_to_newest 185945 0 sfalken 2010-01-29 13:22:21 -0800 Client-based Geolocation starts updating before getting consent from the user 185946 1 47732 sfalken 2010-01-29 13:35:10 -0800 Created attachment 47732 Patch 185951 2 47732 darin 2010-01-29 13:45:23 -0800 Comment on attachment 47732 Patch > + ASSERT(m_frame); > + Page* page = m_frame->page(); > + ASSERT(page); > + page->geolocationController()->addObserver(this); What guarantees they are non-zero? You should figure out what the right behavior would be in those cases and handle instead of asserting. Otherwise, r=me 185955 3 sfalken 2010-01-29 14:08:29 -0800 Committed r54079: <http://trac.webkit.org/changeset/54079> 47732 2010-01-29 13:35:10 -0800 2010-01-29 13:45:23 -0800 Patch bug-34343-20100129133509.patch text/plain 4150 sfalken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDA3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDEtMjkgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDbGllbnQtYmFzZWQgR2VvbG9jYXRpb24gc3RhcnRzIHVwZGF0aW5nIGJlZm9yZSBnZXR0aW5n IGNvbnNlbnQgZnJvbSB0aGUgdXNlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQzNDMKKworICAgICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb246OnN0YXJ0UmVxdWVzdCk6IFBhc3Mgbm90aWZp ZXIgaW5zdGVhZCBvZiBvcHRpb25zIHRvIHN0YXJ0VXBkYXRpbmcuCisgICAgICAgIChXZWJDb3Jl OjpHZW9sb2NhdGlvbjo6c2V0SXNBbGxvd2VkKTogQWRkIHRoZSBvYnNlcnZlciBvciBub3RpZnkg b2YgZXJyb3IgZm9yIGRlZmVycmVkIHN0YXJ0VXBkYXRpbmcuCisgICAgICAgIChXZWJDb3JlOjpH ZW9sb2NhdGlvbjo6c3RhcnRVcGRhdGluZyk6IFBhc3Mgbm90aWZpZXIgaW5zdGVhZCBvZiBvcHRp b25zLCBzaW5jZSB3ZSBtYXkgbmVlZCB0byBjYWxsIGl0IGlmIHdlIGZhaWwgdG8gZ2V0IHVzZXIg Y29uc2VudC4KKyAgICAgICAgRGVmZXIgYWRkaW5nIHRoZSBvYnNlcnZlciBpZiB3ZSBkb24ndCB5 ZXQgaGF2ZSB1c2VyIGNvbnNlbnQsIHNpbmNlIHRoaXMgY291bGQga2ljayBvZmYKKyAgICAgICAg c2VydmVyLWJhc2VkIHdpZmkgR2VvbG9jYXRpb24gcmVxdWVzdHMuCisgICAgICAgICogcGFnZS9H ZW9sb2NhdGlvbi5oOgorCiAyMDEwLTAxLTI5ICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgT2theWVkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViQ29yZS9w YWdlL0dlb2xvY2F0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRp b24uY3BwCShyZXZpc2lvbiA1NDA3MCkKKysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI0NSw3ICsyNDUsNyBAQCBQYXNzUmVmUHRyPEdlb2xvY2F0aW9u OjpHZW9Ob3RpZmllcj4gR2VvCiAgICAgaWYgKGlzRGVuaWVkKCkpCiAgICAgICAgIG5vdGlmaWVy LT5zZXRGYXRhbEVycm9yKFBvc2l0aW9uRXJyb3I6OmNyZWF0ZShQb3NpdGlvbkVycm9yOjpQRVJN SVNTSU9OX0RFTklFRCwgcGVybWlzc2lvbkRlbmllZEVycm9yTWVzc2FnZSkpOwogICAgIGVsc2Ug ewotICAgICAgICBpZiAobm90aWZpZXItPmhhc1plcm9UaW1lb3V0KCkgfHwgc3RhcnRVcGRhdGlu Zyhub3RpZmllci0+bV9vcHRpb25zLmdldCgpKSkKKyAgICAgICAgaWYgKG5vdGlmaWVyLT5oYXNa ZXJvVGltZW91dCgpIHx8IHN0YXJ0VXBkYXRpbmcobm90aWZpZXIuZ2V0KCkpKQogICAgICAgICAg ICAgbm90aWZpZXItPnN0YXJ0VGltZXJJZk5lZWRlZCgpOwogICAgICAgICBlbHNlCiAgICAgICAg ICAgICBub3RpZmllci0+c2V0RmF0YWxFcnJvcihQb3NpdGlvbkVycm9yOjpjcmVhdGUoUG9zaXRp b25FcnJvcjo6UE9TSVRJT05fVU5BVkFJTEFCTEUsICJGYWlsZWQgdG8gc3RhcnQgR2VvbG9jYXRp b24gc2VydmljZSIpKTsKQEAgLTMwMSw2ICszMDEsMjMgQEAgdm9pZCBHZW9sb2NhdGlvbjo6c2V0 SXNBbGxvd2VkKGJvb2wgYWxsbwogewogICAgIG1fYWxsb3dHZW9sb2NhdGlvbiA9IGFsbG93ZWQg PyBZZXMgOiBObzsKICAgICAKKyNpZiBFTkFCTEUoQ0xJRU5UX0JBU0VEX0dFT0xPQ0FUSU9OKQor ICAgIGlmIChtX3N0YXJ0UmVxdWVzdFBlcm1pc3Npb25Ob3RpZmllcikgeworICAgICAgICBpZiAo aXNBbGxvd2VkKCkpIHsKKyAgICAgICAgICAgIC8vIFBlcm1pc3Npb24gcmVxdWVzdCB3YXMgbWFk ZSBkdXJpbmcgdGhlIHN0YXJ0VXBkYXRpbmcgcHJvY2VzcworICAgICAgICAgICAgbV9zdGFydFJl cXVlc3RQZXJtaXNzaW9uTm90aWZpZXIgPSAwOworICAgICAgICAgICAgQVNTRVJUKG1fZnJhbWUp OworICAgICAgICAgICAgUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsKKyAgICAgICAgICAg IEFTU0VSVChwYWdlKTsKKyAgICAgICAgICAgIHBhZ2UtPmdlb2xvY2F0aW9uQ29udHJvbGxlcigp LT5hZGRPYnNlcnZlcih0aGlzKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIG1fc3Rh cnRSZXF1ZXN0UGVybWlzc2lvbk5vdGlmaWVyLT5zZXRGYXRhbEVycm9yKFBvc2l0aW9uRXJyb3I6 OmNyZWF0ZShQb3NpdGlvbkVycm9yOjpQRVJNSVNTSU9OX0RFTklFRCwgcGVybWlzc2lvbkRlbmll ZEVycm9yTWVzc2FnZSkpOworICAgICAgICAgICAgbV9vbmVTaG90cy5hZGQobV9zdGFydFJlcXVl c3RQZXJtaXNzaW9uTm90aWZpZXIpOworICAgICAgICB9CisgICAgICAgIHJldHVybjsKKyAgICB9 CisjZW5kaWYKKyAgICAKICAgICBpZiAoaXNBbGxvd2VkKCkpCiAgICAgICAgIG1ha2VTdWNjZXNz Q2FsbGJhY2tzKCk7CiAgICAgZWxzZSB7CkBAIC00NzksMTIgKzQ5NiwxNyBAQCB2b2lkIEdlb2xv Y2F0aW9uOjpnZW9sb2NhdGlvblNlcnZpY2VFcnJvCiAKICNlbmRpZgogCi1ib29sIEdlb2xvY2F0 aW9uOjpzdGFydFVwZGF0aW5nKFBvc2l0aW9uT3B0aW9ucyogb3B0aW9ucykKK2Jvb2wgR2VvbG9j YXRpb246OnN0YXJ0VXBkYXRpbmcoR2VvTm90aWZpZXIqIG5vdGlmaWVyKQogewogI2lmIEVOQUJM RShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCiAgICAgLy8gRklYTUU6IFBhc3Mgb3B0aW9ucyB0 byBjbGllbnQuCi0gICAgVU5VU0VEX1BBUkFNKG9wdGlvbnMpOwogCisgICAgaWYgKCFpc0FsbG93 ZWQoKSkgeworICAgICAgICBtX3N0YXJ0UmVxdWVzdFBlcm1pc3Npb25Ob3RpZmllciA9IG5vdGlm aWVyOworICAgICAgICByZXF1ZXN0UGVybWlzc2lvbigpOworICAgICAgICByZXR1cm4gdHJ1ZTsK KyAgICB9CisgICAgCiAgICAgaWYgKCFtX2ZyYW1lKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK QEAgLTQ5NSw3ICs1MTcsNyBAQCBib29sIEdlb2xvY2F0aW9uOjpzdGFydFVwZGF0aW5nKFBvc2l0 aW9uCiAgICAgcGFnZS0+Z2VvbG9jYXRpb25Db250cm9sbGVyKCktPmFkZE9ic2VydmVyKHRoaXMp OwogICAgIHJldHVybiB0cnVlOwogI2Vsc2UKLSAgICByZXR1cm4gbV9zZXJ2aWNlLT5zdGFydFVw ZGF0aW5nKG9wdGlvbnMpOworICAgIHJldHVybiBtX3NlcnZpY2UtPnN0YXJ0VXBkYXRpbmcobm90 aWZpZXItPm9wdGlvbnMpOwogI2VuZGlmCiB9CiAKSW5kZXg6IFdlYkNvcmUvcGFnZS9HZW9sb2Nh dGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5oCShyZXZpc2lv biA1NDA3MCkKKysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMzgsNyArMTM4LDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgcmVxdWVzdFBlcm1pc3Npb24o KTsKIAotICAgIGJvb2wgc3RhcnRVcGRhdGluZyhQb3NpdGlvbk9wdGlvbnMqKTsKKyAgICBib29s IHN0YXJ0VXBkYXRpbmcoR2VvTm90aWZpZXIqKTsKICAgICB2b2lkIHN0b3BVcGRhdGluZygpOwog CiAjaWYgIUVOQUJMRShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCkBAIC0xNTksNiArMTU5LDgg QEAgcHJpdmF0ZToKICAgICBGcmFtZSogbV9mcmFtZTsKICNpZiAhRU5BQkxFKENMSUVOVF9CQVNF RF9HRU9MT0NBVElPTikKICAgICBPd25QdHI8R2VvbG9jYXRpb25TZXJ2aWNlPiBtX3NlcnZpY2U7 CisjZWxzZQorICAgIFJlZlB0cjxHZW9Ob3RpZmllcj4gbV9zdGFydFJlcXVlc3RQZXJtaXNzaW9u Tm90aWZpZXI7CiAjZW5kaWYKICAgICBSZWZQdHI8R2VvcG9zaXRpb24+IG1fbGFzdFBvc2l0aW9u OwogICAgIFJlZlB0cjxHZW9wb3NpdGlvbj4gbV9jdXJyZW50UG9zaXRpb247Cg==