34335 2010-01-29 10:06:33 -0800 ScriptCallFrame's do not get line numbers/source id's if the caller is unkown. 2010-02-02 02:15:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm dglazkov ggaren sam oldest_to_newest 185899 0 benm 2010-01-29 10:06:33 -0800 When we append a StackCallFrame to the ScriptCallStack, if the calling function is unknown we do not supply the CallFrame with any source id or line number information although this data is available. Instead, an empty source id and line number of 0 is supplied. I propose a patch to add the correct line number and source ID to the callframe. Patch and updates to layout tests to follow. 186360 1 47829 benm 2010-02-01 04:44:16 -0800 Created attachment 47829 Proposed patch and updated layout tests. 186465 2 47829 darin 2010-02-01 10:00:54 -0800 Comment on attachment 47829 Proposed patch and updated layout tests. > + * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed. > + * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Removed. > + * platform/win/inspector/console-log-before-inspector-open-expected.txt: Removed. Change log doesn't say why you did this. I presume that these platform-specific results were actually just working around the bug? 186467 3 benm 2010-02-01 10:03:56 -0800 Thanks for the review! (In reply to comment #2) > (From update of attachment 47829 [details]) > > + * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed. > > + * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Removed. > > + * platform/win/inspector/console-log-before-inspector-open-expected.txt: Removed. > > Change log doesn't say why you did this. I presume that these platform-specific > results were actually just working around the bug? Precisely - I can update the ChangeLog and land manually, if you like? Thanks, Ben 186474 4 47829 benm 2010-02-01 10:29:57 -0800 Comment on attachment 47829 Proposed patch and updated layout tests. Will land manually. 186872 5 benm 2010-02-02 02:15:21 -0800 Landed as r54138. Closing bug. 47829 2010-02-01 04:44:16 -0800 2010-02-01 10:29:57 -0800 Proposed patch and updated layout tests. 34335.txt text/plain 6652 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDEzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDItMDEgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjcmlw dENhbGxGcmFtZSdzIGRvIG5vdCBnZXQgbGluZSBudW1iZXJzL3NvdXJjZSBpZCdzIGlmIHRoZSBj YWxsZXIgaXMgdW5rb3duLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzQzMzUKKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdENhbGxTdGFjay5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDYWxsU3RhY2s6OlNjcmlwdENhbGxTdGFjayk6 IElmIHRoZSBjYWxsZXIgaXMgdW5rbm93biwgdGhlIGxpbmUgbnVtYmVyIGFuZCBzb3VyY2UgaW5m b3JtYXRpb24gaXMgc3RpbGwgYXZhaWxibGUgc28gcGFzcyBpdCB0byB0aGUgU2NyaXB0Q2FsbEZy YW1lIGJlaW5nIGNvbnN0cnVjdGVkLgorCiAyMDEwLTAyLTAxICBTdGV2ZSBCbG9jayAgPHN0ZXZl YmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBcml5YSBIaWRheWF0LgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWxsU3RhY2suY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q2FsbFN0YWNrLmNwcAkocmV2aXNpb24gNTQx MzIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENhbGxTdGFjay5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTU0LDE0ICs1NCwxNSBAQCBTY3JpcHRDYWxsU3RhY2s6OlNjcmlwdENhbGxTdGFj ayhFeGVjU3RhCiAKICAgICBleGVjLT5pbnRlcnByZXRlcigpLT5yZXRyaWV2ZUxhc3RDYWxsZXIo ZXhlYywgc2lnbmVkTGluZU51bWJlciwgc291cmNlSUQsIHVybFN0cmluZywgZnVuY3Rpb24pOwog CisgICAgdW5zaWduZWQgbGluZU51bWJlciA9IHNpZ25lZExpbmVOdW1iZXIgPj0gMCA/IHNpZ25l ZExpbmVOdW1iZXIgOiAwOworCiAgICAgaWYgKGZ1bmN0aW9uKSB7CiAgICAgICAgIG1fY2FsbGVy ID0gYXNJbnRlcm5hbEZ1bmN0aW9uKGZ1bmN0aW9uKTsKLSAgICAgICAgdW5zaWduZWQgbGluZU51 bWJlciA9IHNpZ25lZExpbmVOdW1iZXIgPj0gMCA/IHNpZ25lZExpbmVOdW1iZXIgOiAwOwogICAg ICAgICBtX2ZyYW1lcy5hcHBlbmQoU2NyaXB0Q2FsbEZyYW1lKG1fY2FsbGVyLT5uYW1lKG1fZXhl YyksIHVybFN0cmluZywgbGluZU51bWJlciwgYXJncywgc2tpcEFyZ3VtZW50Q291bnQpKTsKICAg ICB9IGVsc2UgewogICAgICAgICAvLyBDYWxsZXIgaXMgdW5rbm93biwgYnV0IHdlIHNob3VsZCBz dGlsbCBhZGQgdGhlIGZyYW1lLCBiZWNhdXNlCiAgICAgICAgIC8vIHNvbWV0aGluZyBjYWxsZWQg dXMsIGFuZCBnYXZlIHVzIGFyZ3VtZW50cy4KLSAgICAgICAgbV9mcmFtZXMuYXBwZW5kKFNjcmlw dENhbGxGcmFtZShVU3RyaW5nKCksIFVTdHJpbmcoKSwgMCwgYXJncywgc2tpcEFyZ3VtZW50Q291 bnQpKTsKKyAgICAgICAgbV9mcmFtZXMuYXBwZW5kKFNjcmlwdENhbGxGcmFtZShVU3RyaW5nKCks IHVybFN0cmluZywgbGluZU51bWJlciwgYXJncywgc2tpcEFyZ3VtZW50Q291bnQpKTsKICAgICB9 CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MTMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDItMDEgIEJlbiBNdXJkb2No ICA8YmVubUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNjcmlwdENhbGxGcmFtZSdzIGRvIG5vdCBnZXQgbGluZSBudW1iZXJzL3Nv dXJjZSBpZCdzIGlmIHRoZSBjYWxsZXIgaXMgdW5rb3duLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQzMzUKKworICAgICAgICBVcGRhdGUgbGF5b3V0 IHRlc3RzIHRoYXQgZGlkIG5vdCBoYXZlIHNvdXJjZSBhbmQgbGluZSBudW1iZXIgaW5mb3JtYXRp b24gZm9yIHRoZWlyIGNvbnNvbGUgbWVzc2FnZXMsIGFzIHRoaXMgaW5mb3JtYXRpb24gaXMgbm93 IGF2YWlsYWJsZSB0byB0aGUgU2NyaXB0Q2FsbEZyYW1lIGFuZCB0aHVzIGNhbiBiZSBwYXNzZWQg dG8gdGhlIGluc3BlY3RvciwgZm9yIGV4YW1wbGUuCisKKyAgICAgICAgKiBmYXN0L2pzL2NvbnNv bGUtbm9uLXN0cmluZy12YWx1ZXMtZXhwZWN0ZWQudHh0OiBBZGQgY29uc29sZSBsaW5lIG51bWJl ci9zb3VyY2UuCisgICAgICAgICogdXNlcnNjcmlwdHMvc2NyaXB0LW5vdC1ydW4tZm9yLWZyYWdt ZW50cy1leHBlY3RlZC50eHQ6IGRpdHRvLgorICAgICAgICAqIHVzZXJzY3JpcHRzL3NjcmlwdC1y dW4tYXQtc3RhcnQtZXhwZWN0ZWQudHh0OiBkaXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv aW5zcGVjdG9yL2NvbnNvbGUtbG9nLWJlZm9yZS1pbnNwZWN0b3Itb3Blbi1leHBlY3RlZC50eHQ6 IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2luc3BlY3Rvci9jb25zb2xlLWxvZy1i ZWZvcmUtaW5zcGVjdG9yLW9wZW4tZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIHBs YXRmb3JtL3dpbi9pbnNwZWN0b3IvY29uc29sZS1sb2ctYmVmb3JlLWluc3BlY3Rvci1vcGVuLWV4 cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAKKwogMjAxMC0wMi0wMSAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9jb25zb2xlLW5vbi1zdHJpbmctdmFsdWVzLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2NvbnNvbGUtbm9uLXN0 cmluZy12YWx1ZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1NDEzMikKKysrIExheW91dFRlc3Rz L2Zhc3QvanMvY29uc29sZS1ub24tc3RyaW5nLXZhbHVlcy1leHBlY3RlZC50eHQJKHdvcmtpbmcg Y29weSkKQEAgLTEsNSArMSw1IEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogSSBhbSBhIHN0 cmluZwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDA6IDQyCitDT05TT0xFIE1FU1NBR0U6IGxpbmUg MTI6IEkgYW0gYSBzdHJpbmcKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogNDIKIFNob3VsZCBz ZWUgdHdvIGNvbnNvbGUgbWVzc2FnZXMsIHRoZSBmaXJzdCBhIHN0cmluZywgYW5kIHRoZSBzZWNv bmQgYSBudW1iZXIuCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9pbnNwZWN0b3IvY29uc29sZS1sb2ctYmVmb3JlLWluc3Bl Y3Rvci1vcGVuLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvaW5zcGVjdG9yL2NvbnNvbGUtbG9nLWJlZm9yZS1pbnNwZWN0b3Itb3Blbi1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDU0MTMyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2luc3Bl Y3Rvci9jb25zb2xlLWxvZy1iZWZvcmUtaW5zcGVjdG9yLW9wZW4tZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDEzICswLDAgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBsb2cK LUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBkZWJ1ZwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDA6 IGluZm8KLUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiB3YXJuCi1DT05TT0xFIE1FU1NBR0U6IGxp bmUgMDogZXJyb3IKLVRlc3RzIHRoYXQgV2ViIEluc3BlY3RvciB3b24ndCBjcmFzaCBpZiBzb21l IGNvbnNvbGUgaGF2ZSBiZWVuIGxvZ2dlZCBieSB0aGUgdGltZSBpdCdzIG9wZW5pbmcuCi0KLWxv ZwotZGVidWcKLWluZm8KLXdhcm4KLWVycm9yCi0KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9pbnNwZWN0b3IvY29uc29sZS1sb2ctYmVmb3JlLWluc3BlY3Rvci1vcGVuLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvaW5zcGVjdG9yL2Nv bnNvbGUtbG9nLWJlZm9yZS1pbnNwZWN0b3Itb3Blbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU0 MTMyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2luc3BlY3Rvci9jb25zb2xlLWxvZy1i ZWZvcmUtaW5zcGVjdG9yLW9wZW4tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDEz ICswLDAgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBsb2cKLUNPTlNPTEUgTUVTU0FHRTog bGluZSAwOiBkZWJ1ZwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDA6IGluZm8KLUNPTlNPTEUgTUVT U0FHRTogbGluZSAwOiB3YXJuCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogZXJyb3IKLVRlc3Rz IHRoYXQgV2ViIEluc3BlY3RvciB3b24ndCBjcmFzaCBpZiBzb21lIGNvbnNvbGUgaGF2ZSBiZWVu IGxvZ2dlZCBieSB0aGUgdGltZSBpdCdzIG9wZW5pbmcuCi0KLWxvZwotZGVidWcKLWluZm8KLXdh cm4KLWVycm9yCi0KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9pbnNwZWN0b3IvY29u c29sZS1sb2ctYmVmb3JlLWluc3BlY3Rvci1vcGVuLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vaW5zcGVjdG9yL2NvbnNvbGUtbG9nLWJlZm9yZS1p bnNwZWN0b3Itb3Blbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU0MTMyKQorKysgTGF5b3V0VGVz dHMvcGxhdGZvcm0vd2luL2luc3BlY3Rvci9jb25zb2xlLWxvZy1iZWZvcmUtaW5zcGVjdG9yLW9w ZW4tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDEzICswLDAgQEAKLUNPTlNPTEUg TUVTU0FHRTogbGluZSAwOiBsb2cKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBkZWJ1ZwotQ09O U09MRSBNRVNTQUdFOiBsaW5lIDA6IGluZm8KLUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiB3YXJu Ci1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogZXJyb3IKLVRlc3RzIHRoYXQgV2ViIEluc3BlY3Rv ciB3b24ndCBjcmFzaCBpZiBzb21lIGNvbnNvbGUgaGF2ZSBiZWVuIGxvZ2dlZCBieSB0aGUgdGlt ZSBpdCdzIG9wZW5pbmcuCi0KLWxvZwotZGVidWcKLWluZm8KLXdhcm4KLWVycm9yCi0KSW5kZXg6 IExheW91dFRlc3RzL3VzZXJzY3JpcHRzL3NjcmlwdC1ub3QtcnVuLWZvci1mcmFnbWVudHMtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3VzZXJzY3JpcHRzL3NjcmlwdC1u b3QtcnVuLWZvci1mcmFnbWVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1NDEzMikKKysrIExh eW91dFRlc3RzL3VzZXJzY3JpcHRzL3NjcmlwdC1ub3QtcnVuLWZvci1mcmFnbWVudHMtZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMyBAQAotQ09OU09MRSBNRVNTQUdFOiBs aW5lIDA6IGluamVjdGVkCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogaW5qZWN0ZWQKK0NPTlNP TEUgTUVTU0FHRTogbGluZSAxOiBpbmplY3RlZAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE6IGlu amVjdGVkCiBUaGlzIHRlc3Qgc2hvdWxkIG5vdCBpbmZpbml0ZWx5IGluamVjdCB1c2VyIHNjcmlw dHMuIApJbmRleDogTGF5b3V0VGVzdHMvdXNlcnNjcmlwdHMvc2NyaXB0LXJ1bi1hdC1zdGFydC1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvdXNlcnNjcmlwdHMvc2NyaXB0 LXJ1bi1hdC1zdGFydC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU0MTMyKQorKysgTGF5b3V0VGVz dHMvdXNlcnNjcmlwdHMvc2NyaXB0LXJ1bi1hdC1zdGFydC1leHBlY3RlZC50eHQJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwzIEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogU1VDQ0VTUwot Q09OU09MRSBNRVNTQUdFOiBsaW5lIDA6IFNVQ0NFU1MKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAx OiBTVUNDRVNTCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogU1VDQ0VTUwogVGhpcyB0ZXN0IHNo b3VsZCBsb2cgYSBjb25zb2xlIG1lc3NhZ2Ugb24gc3VjY2Vzcy4gCg==