34329 2010-01-29 06:35:48 -0800 Cannot inspect Web Inspector in QtLauncher 2010-02-02 07:36:59 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 1 jberlin jberlin jberlin laszlo.gombos psycovic oldest_to_newest 185855 0 jberlin 2010-01-29 06:35:48 -0800 The only option in the context menu that appears when right-clicking inside the Web Inspector is to Reload. It would very helpful to those who want to work on the Web Inspector while living on the Linux platform for it to be possible to inspect the Web Inspector (as can be done inside Safari on Mac OS X and Windows). Briefly looking into the code for the QWebInspector, it appears that it sub-classes QWidget and is just using the default context menus for that. Is there a way to get at the QWebPage that contains the code for the Web Inspector (if there is one)? 186777 1 47903 jberlin 2010-02-01 20:17:36 -0800 Created attachment 47903 Patch to enable inspecting the web inspector in the QtLauncher 186852 2 47903 zecke 2010-02-02 01:01:12 -0800 Comment on attachment 47903 Patch to enable inspecting the web inspector in the QtLauncher I love the patch. It sucks to have comments on a one liner. So if you fix them you can land the patch rightaway. > + Need a short description and bug URL (OOPS!) Please remove this. You have done everything that is needed for this. > InspectorClientWebPage(QObject* parent = 0) > - : QWebPage(parent) > + : QWebPage(parent) Even if you fix the style, we normally tend to do this in two separate commits. You have my rubber stamp to fix this style issue with the code. 186925 3 jberlin 2010-02-02 05:01:31 -0800 (In reply to comment #2) > (From update of attachment 47903 [details]) > I love the patch. It sucks to have comments on a one liner. So if you fix them > you can land the patch rightaway. > So r=you on the first patch which just removes the line setting the DeveloperExtraEnabled setting and then rs=you on a second patch that fixes the style? Or do you want me to repost the first patch here? > > > + Need a short description and bug URL (OOPS!) > > Please remove this. You have done everything that is needed for this. Whoops! Sorry about that. > > > InspectorClientWebPage(QObject* parent = 0) > > - : QWebPage(parent) > > + : QWebPage(parent) > > Even if you fix the style, we normally tend to do this in two separate commits. > You have my rubber stamp to fix this style issue with the code. 186952 4 jberlin 2010-02-02 07:27:25 -0800 Enabled inspecting the web inspector in the qt launcher: http://trac.webkit.org/changeset/54233 Will commit the style change next. 186958 5 jberlin 2010-02-02 07:36:59 -0800 (In reply to comment #4) > Enabled inspecting the web inspector in the qt launcher: > > http://trac.webkit.org/changeset/54233 > > Will commit the style change next. Committed style change: http://trac.webkit.org/changeset/54236 Closing bug. 47903 2010-02-01 20:17:36 -0800 2010-02-02 01:01:12 -0800 Patch to enable inspecting the web inspector in the QtLauncher enableInspectingWebInspectorQt.patch text/plain 1385 jberlin SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTQxOTUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMDEgIEplc3NpZSBCZXJsaW4gIDxqYmVybGlu QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKyAgICAg ICAgW1F0XSBFbmFibGUgaW5zcGVjdGluZyB0aGUgV2ViIEluc3BlY3RvciBpbiBRdExhdW5jaGVy CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MzI5 CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRXZWJQYWdlOjpJbnNwZWN0b3JDbGllbnRXZWJQ YWdlKToKKyAgICAgICAgQWxsb3cgdGhlIERldmVsb3BlckV4dHJhc0VuYWJsZWQgc2V0dGluZyB0 byBkZWZhdWx0IHRvIHRydWUgZm9yIHRoZSBwYWdlIGNvbnRhaW5pbmcgdGhlIFdlYiBJbnNwZWN0 b3IuCisKIDIwMTAtMDEtMjkgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3Jl U3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcAkocmV2aXNpb24gNTQxODIpCisrKyBX ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01OCw5ICs1OCw4IEBAIGNsYXNzIEluc3BlY3RvckNsaWVudFdlYlBhZ2UgOiBwdWJs aWMgUVcKICAgICBmcmllbmQgY2xhc3MgSW5zcGVjdG9yQ2xpZW50UXQ7CiBwdWJsaWM6CiAgICAg SW5zcGVjdG9yQ2xpZW50V2ViUGFnZShRT2JqZWN0KiBwYXJlbnQgPSAwKQotICAgIDogUVdlYlBh Z2UocGFyZW50KQorICAgICAgICA6IFFXZWJQYWdlKHBhcmVudCkKICAgICB7Ci0gICAgICAgIHNl dHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OkRldmVsb3BlckV4dHJhc0VuYWJs ZWQsIGZhbHNlKTsKICAgICB9CiAKICAgICBRV2ViUGFnZSogY3JlYXRlV2luZG93KFFXZWJQYWdl OjpXZWJXaW5kb3dUeXBlKQo=