34322 2010-01-29 03:11:30 -0800 Web Inspector: REGRESSION(r54001): Web inspector monospace font is wrong on some versions of Mac OS X 2010-01-29 09:22:37 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 mrowe apavlov bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 185794 0 mrowe 2010-01-29 03:11:30 -0800 On Mac OS X 10.6 the monospace font in the inspector is Monaco rather than Menlo as expected. This regression was caused by <http://trac.webkit.org/changeset/54001>, which introduced JavaScript code to detect that Mac OS X version and uses that information to choose which monospace font should be used. However, the manner in which it parses the Mac OS X version is broken. It assumes that Mac OS X version numbers always have three components, which is clearly not the case. The code also makes the strange decision that if the user agent string is from a version of Mac OS X it is not familiar with that it must be running on 10.5. It’s not at all clear to me why the inspector is attempting to detect platforms from JavaScript like this. The inspector was already set up to use the correct platform-specific monospace fonts by configuring the default fixed-width font and size before creating the inspector’s WebView (see <http://trac.webkit.org/browser/trunk/WebKit/mac/WebCoreSupport/WebInspectorClient.mm#L189> for example). 185799 1 mrowe 2010-01-29 03:23:51 -0800 <rdar://problem/7590854> 185864 2 47716 apavlov 2010-01-29 07:18:39 -0800 Created attachment 47716 [PATCH] Fix MacOS X version detection (in userAgent can have 2 or 3 segments) 185886 3 47716 commit-queue 2010-01-29 09:22:30 -0800 Comment on attachment 47716 [PATCH] Fix MacOS X version detection (in userAgent can have 2 or 3 segments) Clearing flags on attachment: 47716 Committed r54067: <http://trac.webkit.org/changeset/54067> 185887 4 commit-queue 2010-01-29 09:22:37 -0800 All reviewed patches have been landed. Closing bug. 47716 2010-01-29 07:18:39 -0800 2010-01-29 09:22:29 -0800 [PATCH] Fix MacOS X version detection (in userAgent can have 2 or 3 segments) macosversion.patch text/plain 1783 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzJiYmM4Yi4uNzQ4NjQ1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMC0wMS0yOSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBNYWNPUyBYIHZlcnNpb24gZGV0ZWN0aW9uCisKKyAg ICAgICAgTWFjT1MgWCB2ZXJzaW9uIGNhbiBoYXZlIDIgb3IgMyBzZWdtZW50cy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MzIyCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5fZGV0ZWN0UGxhdGZvcm0pOgorCisyMDEwLTAxLTI5ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVy LgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNvdXJjZSB2aWV3IGRpc3BsYXlzIHRleHQgdXNp bmcgd3JvbmcgZm9udHMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCmlu ZGV4IGM4NTMyZDguLmM2MzdmMzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5qcwpAQCAtODMsMTggKzgzLDE4IEBAIHZhciBXZWJJbnNwZWN0b3IgPSB7CiAgICAgICAg ICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5PUy5XaW5kb3dzVmlzdGFPckxhdGVyOwogICAg ICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5PUy5XaW5kb3dzOwogICAgICAgICB9IGVsc2Ug aWYgKG5hdGl2ZVBsYXRmb3JtID09PSAibWFjIikgewotICAgICAgICAgICAgdmFyIG1hdGNoID0g dXNlckFnZW50Lm1hdGNoKC9NYWMgT1MgWFxzKig/OihcZCspXyhcZCspXyg/OlxkKykpPy8pOwor ICAgICAgICAgICAgdmFyIG1hdGNoID0gdXNlckFnZW50Lm1hdGNoKC9NYWMgT1MgWFxzKig/Oihc ZCspXyhcZCspKT8vKTsKICAgICAgICAgICAgIGlmICghbWF0Y2ggfHwgbWF0Y2hbMV0gIT0gMTAp Ci0gICAgICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5PUy5NYWNMZW9wYXJkOworICAg ICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuT1MuTWFjU25vd0xlb3BhcmQ7CiAgICAg ICAgICAgICBzd2l0Y2ggKE51bWJlcihtYXRjaFsyXSkpIHsKICAgICAgICAgICAgICAgICBjYXNl IDQ6CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuT1MuTWFjVGlnZXI7 CiAgICAgICAgICAgICAgICAgY2FzZSA1OgogICAgICAgICAgICAgICAgICAgICByZXR1cm4gV2Vi SW5zcGVjdG9yLk9TLk1hY0xlb3BhcmQ7CiAgICAgICAgICAgICAgICAgY2FzZSA2OgorICAgICAg ICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0 b3IuT1MuTWFjU25vd0xlb3BhcmQ7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICByZXR1cm4g V2ViSW5zcGVjdG9yLk9TLk1hY0xlb3BhcmQ7CiAgICAgICAgIH0KIAogICAgICAgICByZXR1cm4g bmF0aXZlUGxhdGZvcm07Cg==