34319 2010-01-29 02:43:08 -0800 Web Inspector: wire together buttons on welcome view and on status bar 2010-03-29 02:06:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov pfeldman oldest_to_newest 185786 0 mnaganov 2010-01-29 02:43:08 -0800 In Profiles panel, pressing buttons on the Welcome view doesn't change their look, only status bar button repaints itself. This is confusing, because it may appear to an user that the welcome view button doesn't work. I think, welcome view and status bar buttons must update their look regardless of what button was pressed. 185789 1 47692 mnaganov 2010-01-29 02:46:38 -0800 Created attachment 47692 proposed patch 185792 2 47692 pfeldman 2010-01-29 02:56:42 -0800 Comment on attachment 47692 proposed patch It is now even more confusing - once you toggle a button, welcome message stops making sense: it suggests that red button starts the profiler. 204606 3 51745 mnaganov 2010-03-26 09:07:48 -0700 Created attachment 51745 another approach OK, another approach, this time by limiting functionality. This is how it looks like: http://i42.tinypic.com/dgt5wk.png 205157 4 51745 pfeldman 2010-03-28 05:08:59 -0700 Comment on attachment 51745 another approach Note that you could attach the screenshot to the bug. 205342 5 mnaganov 2010-03-29 02:06:15 -0700 Manually committed r56711: http://trac.webkit.org/changeset/56711 Author: mnaganov@chromium.org <mnaganov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Mon Mar 29 08:52:19 2010 +0000 2010-03-29 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Remove a possibility of confusion from Profiles panel Welcome screen by turning buttons into non-clickable glyphs. Also, span instructions alongside panel width. https://bugs.webkit.org/show_bug.cgi?id=34319 * English.lproj/localizedStrings.js: * inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._addWelcomeMessage): * inspector/front-end/inspector.css: (.panel-enabler-view.welcome .instructions): (.panel-enabler-view.welcome button.status-bar-item): * src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): 47692 2010-01-29 02:46:38 -0800 2010-03-26 09:07:48 -0700 proposed patch hide-welcome-after-pressing-button-patch text/plain 5040 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWJjMDk1Yi4uN2FiNDAxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMS0yOSAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdpcmUgdG9nZXRoZXIgYnV0dG9ucyBvbiB3ZWxjb21lIHZp ZXcgYW5kIG9uIHN0YXR1cyBiYXIgKFByb2ZpbGVzIHBhbmVsLikKKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQzMTkKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Q cm9maWxlc1BhbmVsLnByb3RvdHlwZS5nZXQgc3RhdHVzQmFySXRlbXMpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlLnJlZ2lzdGVyUHJvZmlsZVR5cGUpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlLl9hZGRXZWxjb21l TWVzc2FnZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUu dXBkYXRlUHJvZmlsZVR5cGVCdXR0b25zKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxl c1BhbmVsLnByb3RvdHlwZS5fdXBkYXRlSW50ZXJmYWNlKToKKwogMjAxMC0wMS0yOSAgRGFyaW4g RmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQ YW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCmlu ZGV4IGRkMDQ5YTEuLjE2OWRiMWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9Qcm9maWxlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Q cm9maWxlc1BhbmVsLmpzCkBAIC0xNDUsNyArMTQ1LDcgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVz UGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgdmFyIHByb2ZpbGVUeXBlID0gdGhpcy5n ZXRQcm9maWxlVHlwZSh0eXBlSWQpOwogICAgICAgICAgICAgaWYgKHByb2ZpbGVUeXBlLmJ1dHRv blN0eWxlKSB7CiAgICAgICAgICAgICAgICAgdmFyIGJ1dHRvbiA9IG5ldyBXZWJJbnNwZWN0b3Iu U3RhdHVzQmFyQnV0dG9uKHByb2ZpbGVUeXBlLmJ1dHRvblRvb2x0aXAsIHByb2ZpbGVUeXBlLmJ1 dHRvblN0eWxlLCBwcm9maWxlVHlwZS5idXR0b25DYXB0aW9uKTsKLSAgICAgICAgICAgICAgICB0 aGlzLl9wcm9maWxlVHlwZUJ1dHRvbnNCeUlkTWFwW3R5cGVJZF0gPSBidXR0b24uZWxlbWVudDsK KyAgICAgICAgICAgICAgICB0aGlzLl9wcm9maWxlVHlwZUJ1dHRvbnNCeUlkTWFwW3R5cGVJZF0u c3RhdHVzQmFyID0gYnV0dG9uLmVsZW1lbnQ7CiAgICAgICAgICAgICAgICAgYnV0dG9uLmVsZW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBjbGlja0hhbmRsZXIuYmluZCh0aGlzLCBwcm9m aWxlVHlwZSwgYnV0dG9uLmVsZW1lbnQpLCBmYWxzZSk7CiAgICAgICAgICAgICAgICAgaXRlbXMu cHVzaChidXR0b24uZWxlbWVudCk7CiAgICAgICAgICAgICB9CkBAIC0yMTAsNiArMjEwLDcgQEAg V2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlID0gewogICAgIHJlZ2lzdGVyUHJv ZmlsZVR5cGU6IGZ1bmN0aW9uKHByb2ZpbGVUeXBlKQogICAgIHsKICAgICAgICAgdGhpcy5fcHJv ZmlsZVR5cGVzQnlJZE1hcFtwcm9maWxlVHlwZS5pZF0gPSBwcm9maWxlVHlwZTsKKyAgICAgICAg dGhpcy5fcHJvZmlsZVR5cGVCdXR0b25zQnlJZE1hcFtwcm9maWxlVHlwZS5pZF0gPSB7IHN0YXR1 c0JhcjogbnVsbCwgd2VsY29tZVZpZXc6IG51bGwgfTsKICAgICAgICAgcHJvZmlsZVR5cGUudHJl ZUVsZW1lbnQgPSBuZXcgV2ViSW5zcGVjdG9yLlNpZGViYXJTZWN0aW9uVHJlZUVsZW1lbnQocHJv ZmlsZVR5cGUubmFtZSwgbnVsbCwgdHJ1ZSk7CiAgICAgICAgIHRoaXMuc2lkZWJhclRyZWUuYXBw ZW5kQ2hpbGQocHJvZmlsZVR5cGUudHJlZUVsZW1lbnQpOwogICAgICAgICBwcm9maWxlVHlwZS50 cmVlRWxlbWVudC5leHBhbmQoKTsKQEAgLTIzMiw2ICsyMzMsNyBAQCBXZWJJbnNwZWN0b3IuUHJv ZmlsZXNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB2YXIgYnV0dG9uID0gbmV3IFdl Ykluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24ocHJvZmlsZVR5cGUuYnV0dG9uVG9vbHRpcCwgcHJv ZmlsZVR5cGUuYnV0dG9uU3R5bGUsIHByb2ZpbGVUeXBlLmJ1dHRvbkNhcHRpb24pOwogICAgICAg ICAgICAgYnV0dG9uLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBwcm9maWxlVHlw ZS5idXR0b25DbGlja2VkLmJpbmQocHJvZmlsZVR5cGUpLCBmYWxzZSk7CiAgICAgICAgICAgICBj b250YWluZXIuYXBwZW5kQ2hpbGQoYnV0dG9uLmVsZW1lbnQpOworICAgICAgICAgICAgdGhpcy5f cHJvZmlsZVR5cGVCdXR0b25zQnlJZE1hcFtwcm9maWxlVHlwZS5pZF0ud2VsY29tZVZpZXcgPSBi dXR0b24uZWxlbWVudDsKICAgICAgICAKICAgICAgICAgICAgIHZhciBwYXJ0MiA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICAgICAgICAgIHBhcnQyLmlubmVySFRNTCA9IG1l c3NhZ2Uuc3Vic3RyKGJ1dHRvblBvcyArIDIpOwpAQCAtMzUyLDExICszNTQsMTYgQEAgV2ViSW5z cGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlID0gewogICAgIHVwZGF0ZVByb2ZpbGVUeXBl QnV0dG9uczogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgZm9yICh2YXIgdHlwZUlkIGluIHRo aXMuX3Byb2ZpbGVUeXBlQnV0dG9uc0J5SWRNYXApIHsKLSAgICAgICAgICAgIHZhciBidXR0b25F bGVtZW50ID0gdGhpcy5fcHJvZmlsZVR5cGVCdXR0b25zQnlJZE1hcFt0eXBlSWRdOworICAgICAg ICAgICAgdmFyIGJ1dHRvbnMgPSB0aGlzLl9wcm9maWxlVHlwZUJ1dHRvbnNCeUlkTWFwW3R5cGVJ ZF07CiAgICAgICAgICAgICB2YXIgcHJvZmlsZVR5cGUgPSB0aGlzLmdldFByb2ZpbGVUeXBlKHR5 cGVJZCk7Ci0gICAgICAgICAgICBidXR0b25FbGVtZW50LmNsYXNzTmFtZSA9IHByb2ZpbGVUeXBl LmJ1dHRvblN0eWxlOwotICAgICAgICAgICAgYnV0dG9uRWxlbWVudC50aXRsZSA9IHByb2ZpbGVU eXBlLmJ1dHRvblRvb2x0aXA7Ci0gICAgICAgICAgICAvLyBGSVhNRTogQXBwbHkgcHJvZmlsZVR5 cGUuYnV0dG9uQ2FwdGlvbiBvbmNlIGNhcHRpb25zIGFyZSBhZGRlZCB0byBidXR0b24gY29udHJv bHMuCisgICAgICAgICAgICBmb3IgKHZhciBidXR0b25Mb2NhdGlvbiBpbiBidXR0b25zKSB7Cisg ICAgICAgICAgICAgICAgdmFyIGJ1dHRvbkVsZW1lbnQgPSBidXR0b25zW2J1dHRvbkxvY2F0aW9u XTsKKyAgICAgICAgICAgICAgICBpZiAoYnV0dG9uRWxlbWVudCkgeworICAgICAgICAgICAgICAg ICAgICBidXR0b25FbGVtZW50LmNsYXNzTmFtZSA9IHByb2ZpbGVUeXBlLmJ1dHRvblN0eWxlOwor ICAgICAgICAgICAgICAgICAgICBidXR0b25FbGVtZW50LnRpdGxlID0gcHJvZmlsZVR5cGUuYnV0 dG9uVG9vbHRpcDsKKyAgICAgICAgICAgICAgICAgICAgLy8gRklYTUU6IEFwcGx5IHByb2ZpbGVU eXBlLmJ1dHRvbkNhcHRpb24gb25jZSBjYXB0aW9ucyBhcmUgYWRkZWQgdG8gYnV0dG9uIGNvbnRy b2xzLgorICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0s CiAKQEAgLTQzMywxNCArNDQwLDE0IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3Rv dHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuZW5hYmxlVG9nZ2xlQnV0dG9uLnRpdGxlID0gV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCJQcm9maWxpbmcgZW5hYmxlZC4gQ2xpY2sgdG8gZGlzYWJsZS4i KTsKICAgICAgICAgICAgIHRoaXMuZW5hYmxlVG9nZ2xlQnV0dG9uLnRvZ2dsZWQgPSB0cnVlOwog ICAgICAgICAgICAgZm9yICh2YXIgdHlwZUlkIGluIHRoaXMuX3Byb2ZpbGVUeXBlQnV0dG9uc0J5 SWRNYXApCi0gICAgICAgICAgICAgICAgdGhpcy5fcHJvZmlsZVR5cGVCdXR0b25zQnlJZE1hcFt0 eXBlSWRdLnJlbW92ZVN0eWxlQ2xhc3MoImhpZGRlbiIpOworICAgICAgICAgICAgICAgIHRoaXMu X3Byb2ZpbGVUeXBlQnV0dG9uc0J5SWRNYXBbdHlwZUlkXS5zdGF0dXNCYXIucmVtb3ZlU3R5bGVD bGFzcygiaGlkZGVuIik7CiAgICAgICAgICAgICB0aGlzLnByb2ZpbGVWaWV3U3RhdHVzQmFySXRl bXNDb250YWluZXIucmVtb3ZlU3R5bGVDbGFzcygiaGlkZGVuIik7CiAgICAgICAgICAgICB0aGlz LnBhbmVsRW5hYmxlclZpZXcudmlzaWJsZSA9IGZhbHNlOwogICAgICAgICB9IGVsc2UgewogICAg ICAgICAgICAgdGhpcy5lbmFibGVUb2dnbGVCdXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlByb2ZpbGluZyBkaXNhYmxlZC4gQ2xpY2sgdG8gZW5hYmxlLiIpOwogICAgICAgICAg ICAgdGhpcy5lbmFibGVUb2dnbGVCdXR0b24udG9nZ2xlZCA9IGZhbHNlOwogICAgICAgICAgICAg Zm9yICh2YXIgdHlwZUlkIGluIHRoaXMuX3Byb2ZpbGVUeXBlQnV0dG9uc0J5SWRNYXApCi0gICAg ICAgICAgICAgICAgdGhpcy5fcHJvZmlsZVR5cGVCdXR0b25zQnlJZE1hcFt0eXBlSWRdLmFkZFN0 eWxlQ2xhc3MoImhpZGRlbiIpOworICAgICAgICAgICAgICAgIHRoaXMuX3Byb2ZpbGVUeXBlQnV0 dG9uc0J5SWRNYXBbdHlwZUlkXS5zdGF0dXNCYXIuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7CiAg ICAgICAgICAgICB0aGlzLnByb2ZpbGVWaWV3U3RhdHVzQmFySXRlbXNDb250YWluZXIuYWRkU3R5 bGVDbGFzcygiaGlkZGVuIik7CiAgICAgICAgICAgICB0aGlzLnBhbmVsRW5hYmxlclZpZXcudmlz aWJsZSA9IHRydWU7CiAgICAgICAgIH0K 51745 2010-03-26 09:07:48 -0700 2010-03-28 05:08:59 -0700 another approach welcome-screen-patch text/plain 4739 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzY2MGYwNi4uYTY4YjhkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wMy0yNiAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBhIHBvc3NpYmlsaXR5IG9mIGNvbmZ1c2lvbiBm cm9tIFByb2ZpbGVzIHBhbmVsIFdlbGNvbWUgc2NyZWVuCisgICAgICAgIGJ5IHR1cm5pbmcgYnV0 dG9ucyBpbnRvIG5vbi1jbGlja2FibGUgZ2x5cGhzLiBBbHNvLCBzcGFuIGluc3RydWN0aW9ucwor ICAgICAgICBhbG9uZ3NpZGUgcGFuZWwgd2lkdGguCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MzE5CisKKyAgICAgICAgKiBFbmdsaXNoLmxwcm9q L2xvY2FsaXplZFN0cmluZ3MuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9m aWxlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVHlwZS5wcm90b3R5 cGUuZ2V0IHdlbGNvbWVNZXNzYWdlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1By b2ZpbGVzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90 b3R5cGUuX2FkZFdlbGNvbWVNZXNzYWdlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L2luc3BlY3Rvci5jc3M6CisgICAgICAgICgucGFuZWwtZW5hYmxlci12aWV3LndlbGNvbWUgLmlu c3RydWN0aW9ucyk6CisgICAgICAgICgucGFuZWwtZW5hYmxlci12aWV3LndlbGNvbWUgYnV0dG9u LnN0YXR1cy1iYXItaXRlbSk6CisKIDIwMTAtMDMtMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvV2ViQ29yZS9Fbmds aXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggOWM4ZmU2ZGEzY2E0MzMwYTk2NGU0 MmM3NjFlOTYxZTc1MmYyNjE5Yi4uMjJmMmM2OGMyOTY0ODQ4Nzc5YmZjNzMwODAzMDg4YTJjM2Yz ZjRlNCAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA1OAp6Y21acGgkSjh7Qlh+VU1mJHE4 YUNvT3VpLTNgR3EyM158a2k+ckVMSUNVQDY2UHF3TSZuI3xNNCFIT2lseHgyb2EKRjl7QFpNNjR3 OSMKCmRlbHRhIDU5CnpjbVpwZyRKOTJEWH5VTWZOJEc1cDZUSTBiQUVgNTl3XyErUEN9T2Fpe0px WTFAJk8rZik8aHQkV2IobH1RPCUpPQpJX1dFam0wRm0rKHRwRVQzCgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1Byb2ZpbGVWaWV3LmpzCmluZGV4IDFlZmEwZGMuLmQ1ZjJjY2YgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlVmlldy5qcworKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZVZpZXcuanMKQEAgLTYwMSw3ICs2MDEs NyBAQCBXZWJJbnNwZWN0b3IuQ1BVUHJvZmlsZVR5cGUucHJvdG90eXBlID0gewogCiAgICAgZ2V0 IHdlbGNvbWVNZXNzYWdlKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlN0YXJ0IENQVSBwcm9maWxpbmcgYnkgcHJlc3Npbmc8YnI+dGhlICVzIGJ1dHRvbiBv biB0aGUgc3RhdHVzIGJhci4iKTsKKyAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiQ29udHJvbCBDUFUgcHJvZmlsaW5nIGJ5IHByZXNzaW5nIHRoZSAlcyBidXR0b24gb24gdGhl IHN0YXR1cyBiYXIuIik7CiAgICAgfSwKIAogICAgIHNldFJlY29yZGluZ1Byb2ZpbGU6IGZ1bmN0 aW9uKGlzUHJvZmlsaW5nKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Byb2ZpbGVzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQ YW5lbC5qcwppbmRleCBjYTBiOGQ5Li5iZmIwMmYyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwpAQCAtMjM5LDcgKzIzOSw2IEBAIFdlYkluc3BlY3Rv ci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGNvbnRhaW5lci5hcHBl bmRDaGlsZChwYXJ0MSk7CiAgICAgIAogICAgICAgICAgICAgdmFyIGJ1dHRvbiA9IG5ldyBXZWJJ bnNwZWN0b3IuU3RhdHVzQmFyQnV0dG9uKHByb2ZpbGVUeXBlLmJ1dHRvblRvb2x0aXAsIHByb2Zp bGVUeXBlLmJ1dHRvblN0eWxlLCBwcm9maWxlVHlwZS5idXR0b25DYXB0aW9uKTsKLSAgICAgICAg ICAgIGJ1dHRvbi5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgcHJvZmlsZVR5cGUu YnV0dG9uQ2xpY2tlZC5iaW5kKHByb2ZpbGVUeXBlKSwgZmFsc2UpOwogICAgICAgICAgICAgY29u dGFpbmVyLmFwcGVuZENoaWxkKGJ1dHRvbi5lbGVtZW50KTsKICAgICAgICAKICAgICAgICAgICAg IHZhciBwYXJ0MiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKZGlmZiAtLWdpdCBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKaW5kZXggYzczMGY2Yy4uMGI3MmE5NCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKQEAgLTIzMDIsNyArMjMw Miw2IEBAIGJ1dHRvbi5zaG93LWFsbC1ub2RlcyB7CiAucGFuZWwtZW5hYmxlci12aWV3LndlbGNv bWUgLmluc3RydWN0aW9ucyB7CiAgICAgZGlzcGxheTogaW5saW5lLWJsb2NrOwogICAgIHZlcnRp Y2FsLWFsaWduOiBtaWRkbGU7Ci0gICAgd2lkdGg6IDMzMHB4OwogICAgIG1hcmdpbjogMDsKICAg ICB3aGl0ZS1zcGFjZTogbm9ybWFsOwogICAgIGxpbmUtaGVpZ2h0OiAxNzUlOwpAQCAtMjMxMyw3 ICsyMzEyLDggQEAgYnV0dG9uLnNob3ctYWxsLW5vZGVzIHsKIH0KIAogLnBhbmVsLWVuYWJsZXIt dmlldy53ZWxjb21lIGJ1dHRvbi5zdGF0dXMtYmFyLWl0ZW0gewotICAgIHZlcnRpY2FsLWFsaWdu OiBtaWRkbGU7CisgICAgYmFja2dyb3VuZC1pbWFnZTogbm9uZTsKKyAgICB2ZXJ0aWNhbC1hbGln bjogdG9wOwogfQogCiAucGFuZSBidXR0b24gewpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMzEwZWFhOS4uZjAz ZTg4MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMjYgIE1pa2hhaWwg TmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgYSBwb3NzaWJpbGl0eSBvZiBjb25mdXNp b24gZnJvbSBQcm9maWxlcyBwYW5lbCBXZWxjb21lIHNjcmVlbgorICAgICAgICBieSB0dXJuaW5n IGJ1dHRvbnMgaW50byBub24tY2xpY2thYmxlIGdseXBocy4gQWxzbywgc3BhbiBpbnN0cnVjdGlv bnMKKyAgICAgICAgYWxvbmdzaWRlIHBhbmVsIHdpZHRoLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDMxOQorCisgICAgICAgICogc3JjL2pzL0hl YXBQcm9maWxlclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFBy b2ZpbGVUeXBlLnByb3RvdHlwZS5nZXQgd2VsY29tZU1lc3NhZ2UpOgorCiAyMDEwLTAzLTI1ICBU b255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0hlYXBQcm9maWxl clBhbmVsLmpzIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9IZWFwUHJvZmlsZXJQYW5lbC5qcwpp bmRleCBhYmJmNTgwLi5iYjlmYmUwIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL2pz L0hlYXBQcm9maWxlclBhbmVsLmpzCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvSGVhcFBy b2ZpbGVyUGFuZWwuanMKQEAgLTkzNyw3ICs5MzcsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90UHJvZmlsZVR5cGUucHJvdG90eXBlID0gewogCiAgICAgZ2V0IHdlbGNvbWVNZXNzYWdlKCkK ICAgICB7Ci0gICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkdldCBhIGhlYXAg c25hcHNob3QgYnkgcHJlc3Npbmc8YnI+dGhlICVzIGJ1dHRvbiBvbiB0aGUgc3RhdHVzIGJhci4i KTsKKyAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiR2V0IGEgaGVhcCBzbmFw c2hvdCBieSBwcmVzc2luZyB0aGUgJXMgYnV0dG9uIG9uIHRoZSBzdGF0dXMgYmFyLiIpOwogICAg IH0sCiAKICAgICBjcmVhdGVTaWRlYmFyVHJlZUVsZW1lbnRGb3JQcm9maWxlOiBmdW5jdGlvbihw cm9maWxlKQo=