34298 2010-01-28 18:15:59 -0800 [Chromium] StorageNamespaceProxy::copy() should be a no-op 2010-01-28 23:15:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow fishd oldest_to_newest 185677 0 jorlow 2010-01-28 18:15:59 -0800 StorageNamespaceProxy::copy() should be a no-op 185681 1 47664 jorlow 2010-01-28 18:22:17 -0800 Created attachment 47664 Patch 185693 2 jorlow 2010-01-28 19:01:24 -0800 It's worth noting the current behavior asserts NOT REACHED when m_storageNamespace->copy() is called. :-) 185745 3 47664 fishd 2010-01-28 22:55:38 -0800 Comment on attachment 47664 Patch > + // The WebViewClient knows what its session storage namespace id is but we > + // do not. Returning 0 here causes it to be fetched (via theWebViewClient) nit: "theWebViewClient" -> "the WebViewClient" > + // on its next use. Note that it is WebViewClient::createView's > + // responsibility to clone the session storage namespace id and that the > + // only time copy() is called is directly after the createView call...which > + // is why all of this is safe. nit: It seems like some of this should be documented on WebViewClient::createView. R=me Feel free to fixup comments and commit. 185753 4 jorlow 2010-01-28 23:15:43 -0800 Committed r54046: <http://trac.webkit.org/changeset/54046> 47664 2010-01-28 18:22:17 -0800 2010-01-28 22:55:38 -0800 Patch bug-34298-20100128182216.patch text/plain 1704 jorlow SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTQwMzYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMjggIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcmFnZU5hbWVzcGFjZVByb3h5Ojpjb3B5KCkgc2hv dWxkIGJlIGEgbm8tb3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM0Mjk4CisKKyAgICAgICAgVGhlIGNvbW1lbnQgaW4gdGhlIGNvZGUgc2hvdWxkIG1h a2UgY2xlYXIgd2h5LgorCisgICAgICAgICogc3JjL1N0b3JhZ2VOYW1lc3BhY2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlTmFtZXNwYWNlUHJveHk6OmNvcHkpOgorCiAyMDEw LTAxLTI3ICBBYXJvbiBCb29kbWFuICA8YWFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9TdG9yYWdlTmFt ZXNwYWNlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvU3RvcmFn ZU5hbWVzcGFjZVByb3h5LmNwcAkocmV2aXNpb24gNTM5NTQpCisrKyBXZWJLaXQvY2hyb21pdW0v c3JjL1N0b3JhZ2VOYW1lc3BhY2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2LDcgKzY2 LDE0IEBAIFN0b3JhZ2VOYW1lc3BhY2VQcm94eTo6flN0b3JhZ2VOYW1lc3BhY2UKIAogUGFzc1Jl ZlB0cjxTdG9yYWdlTmFtZXNwYWNlPiBTdG9yYWdlTmFtZXNwYWNlUHJveHk6OmNvcHkoKQogewot ICAgIHJldHVybiBhZG9wdFJlZihuZXcgU3RvcmFnZU5hbWVzcGFjZVByb3h5KG1fc3RvcmFnZU5h bWVzcGFjZS0+Y29weSgpLCBtX3N0b3JhZ2VUeXBlKSk7CisgICAgQVNTRVJUKG1fc3RvcmFnZVR5 cGUgPT0gU2Vzc2lvblN0b3JhZ2UpOworICAgIC8vIFRoZSBXZWJWaWV3Q2xpZW50IGtub3dzIHdo YXQgaXRzIHNlc3Npb24gc3RvcmFnZSBuYW1lc3BhY2UgaWQgaXMgYnV0IHdlCisgICAgLy8gZG8g bm90LiAgUmV0dXJuaW5nIDAgaGVyZSBjYXVzZXMgaXQgdG8gYmUgZmV0Y2hlZCAodmlhIHRoZVdl YlZpZXdDbGllbnQpCisgICAgLy8gb24gaXRzIG5leHQgdXNlLiAgTm90ZSB0aGF0IGl0IGlzIFdl YlZpZXdDbGllbnQ6OmNyZWF0ZVZpZXcncworICAgIC8vIHJlc3BvbnNpYmlsaXR5IHRvIGNsb25l IHRoZSBzZXNzaW9uIHN0b3JhZ2UgbmFtZXNwYWNlIGlkIGFuZCB0aGF0IHRoZQorICAgIC8vIG9u bHkgdGltZSBjb3B5KCkgaXMgY2FsbGVkIGlzIGRpcmVjdGx5IGFmdGVyIHRoZSBjcmVhdGVWaWV3 IGNhbGwuLi53aGljaAorICAgIC8vIGlzIHdoeSBhbGwgb2YgdGhpcyBpcyBzYWZlLgorICAgIHJl dHVybiAwOwogfQogCiBQYXNzUmVmUHRyPFN0b3JhZ2VBcmVhPiBTdG9yYWdlTmFtZXNwYWNlUHJv eHk6OnN0b3JhZ2VBcmVhKFBhc3NSZWZQdHI8U2VjdXJpdHlPcmlnaW4+IG9yaWdpbikK