34297 2010-01-28 18:12:17 -0800 [Win] Fix a bug of round() with huge integral numbers 2010-01-31 18:35:59 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 tkent webkit-unassigned bweinstein darin laszlo.gombos oldest_to_newest 185675 0 tkent 2010-01-28 18:12:17 -0800 [Win] Fix a bug of round() with huge integral numbers 185682 1 47665 tkent 2010-01-28 18:22:20 -0800 Created attachment 47665 Proposed patch 185685 2 bweinstein 2010-01-28 18:27:52 -0800 There are a big number of tests in svg that are being Skipped on Windows due to rounding issues. Can you see if this patch fixes them? # <rdar://problem/5663632> TextStream::operator<<(float) rounding differs between Mac OS X and Windows svg/batik/paints/patternRegions.svg svg/batik/text/textAnchor.svg svg/carto.net/button.svg svg/carto.net/colourpicker.svg svg/carto.net/combobox.svg svg/carto.net/selectionlist.svg svg/carto.net/slider.svg svg/carto.net/textbox.svg svg/carto.net/window.svg svg/custom/circular-marker-reference-1.svg svg/custom/circular-marker-reference-3.svg svg/custom/circular-marker-reference-4.svg svg/custom/coords-relative-units-transforms.svg svg/custom/marker-changes.svg svg/custom/use-referencing-nonexisting-symbol.svg svg/custom/width-full-percentage.svg svg/W3C-SVG-1.1/coords-viewattr-01-b.svg svg/W3C-SVG-1.1/fonts-elem-01-t.svg svg/W3C-SVG-1.1/fonts-elem-02-t.svg svg/W3C-SVG-1.1/fonts-elem-03-b.svg svg/W3C-SVG-1.1/fonts-elem-04-b.svg svg/W3C-SVG-1.1/fonts-elem-07-b.svg Thanks! 185697 3 tkent 2010-01-28 19:29:27 -0800 (In reply to comment #2) > There are a big number of tests in svg that are being Skipped on Windows due to > rounding issues. Can you see if this patch fixes them? > > # <rdar://problem/5663632> TextStream::operator<<(float) rounding differs > between Mac OS X and Windows This patch won't change the behavior of snprintf() in TextStream::operator<<(float). Unfortunately, they won't be fixed. 185964 4 47665 darin 2010-01-29 14:25:50 -0800 Comment on attachment 47665 Proposed patch > + if (!_finite(num)) > + return num; Seems bad for performance to do this. Can't we just leave this out? It seems that infinity or NAN would be unchanged by the code below. > + double tmp = ceil(num); I think we can come up with a better name than "tmp" for this. I suggest "ceiling" or "integer"? 186274 5 tkent 2010-01-31 18:35:59 -0800 (In reply to comment #4) > (From update of attachment 47665 [details]) > > + if (!_finite(num)) > > + return num; > > Seems bad for performance to do this. Can't we just leave this out? It seems > that infinity or NAN would be unchanged by the code below. ok, removed. > > > + double tmp = ceil(num); > > I think we can come up with a better name than "tmp" for this. I suggest > "ceiling" or "integer"? Renamed it to "integer". Landed as r54121 <http://trac.webkit.org/changeset/54121> 47665 2010-01-28 18:22:20 -0800 2010-01-29 14:25:49 -0800 Proposed patch bug-34297-20100129112218.patch text/plain 5750 tkent ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAzMzQ5MWU3Li4yODY2MjU3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTAtMDEtMjggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXaW5kb3dzXSBGaXgg YSBidWcgb2Ygcm91bmQoKSB3aXRoIGh1Z2UgaW50ZWdyYWwgbnVtYmVycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQyOTcKKworICAgICAgICBGaXgg YSBidWcgdGhhdCByb3VuZCgpIGZvciBodWdlIGludGVncmFsIG51bWJlcnMgcmV0dXJucyBpbmNv cnJlY3QKKyAgICAgICAgcmVzdWx0cy4gRm9yIGV4YW1wbGUsIHJvdW5kKDg2Mzk5OTk5MTM2MDAw MDEpIHJldHVybnMKKyAgICAgICAgODYzOTk5OTkxMzYwMDAwMiB3aXRob3V0IHRoaXMgY2hhbmdl IHRob3VnaCB0aGUgZG91YmxlIHR5cGUgY2FuCisgICAgICAgIHJlcHJlc2VudCA4NjM5OTk5OTEz NjAwMDAxIHByZWNpc2VseS4KKworICAgICAgICBNYXRoLnJvdW5kKCkgb2YgSmF2YVNjcmlwdCBo YXMgYSBzaW1pbGFyIHByb2JsZW0uIEJ1dCB0aGlzIGNoYW5nZQorICAgICAgICBkb2Vzbid0IGZp eCBpdCBiZWNhdXNlIE1hdGgucm91bmQoKSBkb2Vzbid0IHVzZSByb3VuZCgpIG9mCisgICAgICAg IE1hdGhFeHRyYS5oLgorCisgICAgICAgICogd3RmL01hdGhFeHRyYXMuaDoKKyAgICAgICAgKHJv dW5kKTogQXZvaWQgdG8gZG8gIm51bSArIDAuNSIgb3IgIm51bSAtIDAuNSIuCisgICAgICAgIChy b3VuZGYpOiBGaXhlZCBzaW1pbGFybHkuCisgICAgICAgIChsbHJvdW5kKTogQ2FsbHMgcm91bmQo KS4KKyAgICAgICAgKGxscm91bmRmKTogQ2FsbHMgcm91bmRmKCkuCisgICAgICAgIChscm91bmQp OiBDYWxscyByb3VuZCgpLgorICAgICAgICAobHJvdW5kZik6IENhbGxzIHJvdW5kZigpLgorCiAy MDEwLTAxLTI3ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2lu ZG93cyBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJh cy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAppbmRleCA5ZWE1N2ZkLi4yM2Y0 ZWQ2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCisrKyBiL0ph dmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTk4LDEyICs5OCwyOSBAQCBpbmxpbmUg Ym9vbCBzaWduYml0KGRvdWJsZSB4KSB7IHN0cnVjdCBpZWVlX2RvdWJsZSAqcCA9IChzdHJ1Y3Qg aWVlZV9kb3VibGUgKikmeAogCiAjaWYgQ09NUElMRVIoTVNWQykgfHwgQ09NUElMRVIoUlZDVCkK IAotaW5saW5lIGxvbmcgbG9uZyBsbHJvdW5kKGRvdWJsZSBudW0pIHsgcmV0dXJuIHN0YXRpY19j YXN0PGxvbmcgbG9uZz4obnVtID4gMCA/IG51bSArIDAuNSA6IGNlaWwobnVtIC0gMC41KSk7IH0K LWlubGluZSBsb25nIGxvbmcgbGxyb3VuZGYoZmxvYXQgbnVtKSB7IHJldHVybiBzdGF0aWNfY2Fz dDxsb25nIGxvbmc+KG51bSA+IDAgPyBudW0gKyAwLjVmIDogY2VpbChudW0gLSAwLjVmKSk7IH0K LWlubGluZSBsb25nIGxyb3VuZChkb3VibGUgbnVtKSB7IHJldHVybiBzdGF0aWNfY2FzdDxsb25n PihudW0gPiAwID8gbnVtICsgMC41IDogY2VpbChudW0gLSAwLjUpKTsgfQotaW5saW5lIGxvbmcg bHJvdW5kZihmbG9hdCBudW0pIHsgcmV0dXJuIHN0YXRpY19jYXN0PGxvbmc+KG51bSA+IDAgPyBu dW0gKyAwLjVmIDogY2VpbGYobnVtIC0gMC41ZikpOyB9Ci1pbmxpbmUgZG91YmxlIHJvdW5kKGRv dWJsZSBudW0pIHsgcmV0dXJuIG51bSA+IDAgPyBmbG9vcihudW0gKyAwLjUpIDogY2VpbChudW0g LSAwLjUpOyB9Ci1pbmxpbmUgZmxvYXQgcm91bmRmKGZsb2F0IG51bSkgeyByZXR1cm4gbnVtID4g MCA/IGZsb29yZihudW0gKyAwLjVmKSA6IGNlaWxmKG51bSAtIDAuNWYpOyB9CisvLyBXZSBtdXN0 IG5vdCBkbyAnbnVtICsgMC41JyBvciAnbnVtIC0gMC41JyBiZWNhdXNlIHRoZXkgY2FuIGNhdXNl IHByZWNpc2lvbiBsb3NzLgorc3RhdGljIGRvdWJsZSByb3VuZChkb3VibGUgbnVtKQoreworICAg IGlmICghX2Zpbml0ZShudW0pKQorICAgICAgICByZXR1cm4gbnVtOworICAgIGRvdWJsZSB0bXAg PSBjZWlsKG51bSk7CisgICAgaWYgKG51bSA+IDApCisgICAgICAgIHJldHVybiB0bXAgLSBudW0g PiAwLjUgPyB0bXAgLSAxLjAgOiB0bXA7CisgICAgcmV0dXJuIHRtcCAtIG51bSA+PSAwLjUgPyB0 bXAgLSAxLjAgOiB0bXA7Cit9CitzdGF0aWMgZmxvYXQgcm91bmRmKGZsb2F0IG51bSkKK3sKKyAg ICBpZiAoIV9maW5pdGUobnVtKSkKKyAgICAgICAgcmV0dXJuIG51bTsKKyAgICBmbG9hdCB0bXAg PSBjZWlsZihudW0pOworICAgIGlmIChudW0gPiAwKQorICAgICAgICByZXR1cm4gdG1wIC0gbnVt ID4gMC41ZiA/IHRtcCAtIDEuMGYgOiB0bXA7CisgICAgcmV0dXJuIHRtcCAtIG51bSA+PSAwLjVm ID8gdG1wIC0gMS4wZiA6IHRtcDsKK30KK2lubGluZSBsb25nIGxvbmcgbGxyb3VuZChkb3VibGUg bnVtKSB7IHJldHVybiBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHJvdW5kKG51bSkpOyB9Citpbmxp bmUgbG9uZyBsb25nIGxscm91bmRmKGZsb2F0IG51bSkgeyByZXR1cm4gc3RhdGljX2Nhc3Q8bG9u ZyBsb25nPihyb3VuZGYobnVtKSk7IH0KK2lubGluZSBsb25nIGxyb3VuZChkb3VibGUgbnVtKSB7 IHJldHVybiBzdGF0aWNfY2FzdDxsb25nPihyb3VuZChudW0pKTsgfQoraW5saW5lIGxvbmcgbHJv dW5kZihmbG9hdCBudW0pIHsgcmV0dXJuIHN0YXRpY19jYXN0PGxvbmc+KHJvdW5kZihudW0pKTsg fQogaW5saW5lIGRvdWJsZSB0cnVuYyhkb3VibGUgbnVtKSB7IHJldHVybiBudW0gPiAwID8gZmxv b3IobnVtKSA6IGNlaWwobnVtKTsgfQogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NWFjZWJkLi4wNThmNGM0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMjggIEtlbnQgVGFtdXJhICA8dGtlbnRA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtXaW5dIEZpeCBhIGJ1ZyBvZiByb3VuZCgpIHdpdGggaHVnZSBpbnRlZ3JhbCBudW1i ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI5 NworCisgICAgICAgIEFkZCBhIHRlc3QgY2FzZSB0byBjYWxsIHJvdW5kKDg2Mzk5OTk5MTM2MDAw MDEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pbnB1dC12YWx1ZWFzbnVtYmVyLWRhdGV0aW1l LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9pbnB1dC12 YWx1ZWFzbnVtYmVyLWRhdGV0aW1lLmpzOgorCiAyMDEwLTAxLTI4ICBYYW4gTG9wZXogIDx4bG9w ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBDYW4gRG5EIGZpbGVzIHRvIG91ciBmaWxl Y2hvb3NlciB3aWRnZXQgKDxpbnB1dCB0eXBlPSJmaWxlIj4pCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL2lucHV0LXZhbHVlYXNudW1iZXItZGF0ZXRpbWUtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC12YWx1ZWFzbnVtYmVyLWRhdGV0aW1lLWV4 cGVjdGVkLnR4dAppbmRleCA1ZDFkZGQ0Li4wMjgyOGZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2lucHV0LXZhbHVlYXNudW1iZXItZGF0ZXRpbWUtZXhwZWN0ZWQudHh0Cisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtdmFsdWVhc251bWJlci1kYXRldGltZS1l eHBlY3RlZC50eHQKQEAgLTE0LDYgKzE0LDcgQEAgUEFTUyBzZXRWYWx1ZUFzTnVtYmVyQW5kR2V0 VmFsdWUoMTAwMDAsIDAsIDEsIDEyLCAwLCAxLCAwKSBpcyAiMTAwMDAtMDEtMDFUMTI6MDAKIFBB U1Mgc2V0VmFsdWVBc051bWJlckFuZEdldFZhbHVlKDc5NCwgOSwgMjIsIDAsIDAsIDAsIDApIGlz ICIiCiBQQVNTIHNldFZhbHVlQXNOdW1iZXJBbmRHZXRWYWx1ZSgxNTgyLCA5LCAxNCwgMjMsIDU5 LCA1OSwgOTk5KSBpcyAiIgogUEFTUyBzZXRWYWx1ZUFzTnVtYmVyQW5kR2V0VmFsdWUoMTU4Miwg OSwgMTUsIDAsIDAsIDAsIDApIGlzICIxNTgyLTEwLTE1VDAwOjAwWiIKK1BBU1Mgc2V0VmFsdWVB c051bWJlckFuZEdldFZhbHVlKDI3NTc2MCwgOCwgMTIsIDAsIDAsIDAsIDEpIGlzICIyNzU3NjAt MDktMTJUMDA6MDA6MDAuMDAxWiIKIFBBU1Mgc2V0VmFsdWVBc051bWJlckFuZEdldFZhbHVlKDI3 NTc2MCwgOCwgMTMsIDAsIDAsIDAsIDApIGlzICIyNzU3NjAtMDktMTNUMDA6MDBaIgogVGVzdHMg dG8gc2V0IGludmFsaWQgdmFsdWVzIHRvIHZhbHVlQXNOdW1iZXI6CiBQQVNTIGlucHV0LnZhbHVl ID0gIiI7IGlucHV0LnZhbHVlQXNOdW1iZXIgPSBudWxsOyBpbnB1dC52YWx1ZSBpcyAiMTk3MC0w MS0wMVQwMDowMFoiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NjcmlwdC10 ZXN0cy9pbnB1dC12YWx1ZWFzbnVtYmVyLWRhdGV0aW1lLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9zY3JpcHQtdGVzdHMvaW5wdXQtdmFsdWVhc251bWJlci1kYXRldGltZS5qcwppbmRleCAy YWJlN2JmLi4zMjVkMGVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Njcmlw dC10ZXN0cy9pbnB1dC12YWx1ZWFzbnVtYmVyLWRhdGV0aW1lLmpzCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvc2NyaXB0LXRlc3RzL2lucHV0LXZhbHVlYXNudW1iZXItZGF0ZXRpbWUuanMK QEAgLTI2LDYgKzI2LDcgQEAgc2hvdWxkQmUoJ3NldFZhbHVlQXNOdW1iZXJBbmRHZXRWYWx1ZSgx MDAwMCwgMCwgMSwgMTIsIDAsIDEsIDApJywgJyIxMDAwMC0wMS0wMVQKIHNob3VsZEJlKCdzZXRW YWx1ZUFzTnVtYmVyQW5kR2V0VmFsdWUoNzk0LCA5LCAyMiwgMCwgMCwgMCwgMCknLCAnIiInKTsK IHNob3VsZEJlKCdzZXRWYWx1ZUFzTnVtYmVyQW5kR2V0VmFsdWUoMTU4MiwgOSwgMTQsIDIzLCA1 OSwgNTksIDk5OSknLCAnIiInKTsKIHNob3VsZEJlKCdzZXRWYWx1ZUFzTnVtYmVyQW5kR2V0VmFs dWUoMTU4MiwgOSwgMTUsIDAsIDAsIDAsIDApJywgJyIxNTgyLTEwLTE1VDAwOjAwWiInKTsKK3No b3VsZEJlKCdzZXRWYWx1ZUFzTnVtYmVyQW5kR2V0VmFsdWUoMjc1NzYwLCA4LCAxMiwgMCwgMCwg MCwgMSknLCAnIjI3NTc2MC0wOS0xMlQwMDowMDowMC4wMDFaIicpOwogc2hvdWxkQmUoJ3NldFZh bHVlQXNOdW1iZXJBbmRHZXRWYWx1ZSgyNzU3NjAsIDgsIDEzLCAwLCAwLCAwLCAwKScsICciMjc1 NzYwLTA5LTEzVDAwOjAwWiInKTsKIC8vIERhdGUuVVRDKCkgb2YgVjggdGhyb3dzIGFuIGV4Y2Vw dGlvbiBmb3IgdGhlIGZvbGxvd2luZyB2YWx1ZSB0aG91Z2ggSmF2YVNjcmlwdENvcmUgZG9lc24n dC4KIC8vIHNob3VsZEJlKCdzZXRWYWx1ZUFzTnVtYmVyQW5kR2V0VmFsdWUoMjc1NzYwLCA4LCAx MywgMCwgMCwgMCwgMSknLCAnIjI3NTc2MC0wOS0xM1QwMDowMDowMC4wMDFaIicpOwo=