34292 2010-01-28 16:50:02 -0800 V8 implementation of MessageEvent.initMessageEvent() does not set source correctly 2010-01-29 10:13:21 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue oldest_to_newest 185643 0 atwilson 2010-01-28 16:50:02 -0800 The code to set the source attribute in MessageEvent.initMessageEvent() in the v8 bindings is broken, because it assumes that the passed-in parameter is a wrapped DOMWindow object, when instead it's an object that inherits from DOMWindow via the prototype chain. This causes fast/events/init-events.html to fail downstream in Chrome. 185679 1 47663 atwilson 2010-01-28 18:18:17 -0800 Created attachment 47663 Patch 185734 2 47663 abarth 2010-01-28 22:01:11 -0800 Comment on attachment 47663 Patch Nice! That came out very pretty. 185903 3 47663 commit-queue 2010-01-29 10:13:16 -0800 Comment on attachment 47663 Patch Clearing flags on attachment: 47663 Committed r54070: <http://trac.webkit.org/changeset/54070> 185904 4 commit-queue 2010-01-29 10:13:21 -0800 All reviewed patches have been landed. Closing bug. 47663 2010-01-28 18:18:17 -0800 2010-01-29 10:13:16 -0800 Patch bug-34292-20100128181815.patch text/plain 1906 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTNkZmQ1MC4uOTJjNGJkMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMS0yOCAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVjggaW1wbGVtZW50YXRpb24gb2YgTWVzc2FnZUV2ZW50LmluaXRN ZXNzYWdlRXZlbnQoKSBkb2VzIG5vdCBzZXQgc291cmNlIGNvcnJlY3RseS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MjkyCisKKyAgICAgICAgVGVz dDogZmFzdC9ldmVudHMvaW5pdC1ldmVudHMuaHRtbCB3aWxsIHBhc3MgaW4gQ2hyb21lIG5vdy4K KworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpWOE1lc3NhZ2VFdmVudDo6aW5pdE1lc3NhZ2VFdmVudENhbGxi YWNrKToKKyAgICAgICAgTm93IHByb3Blcmx5IGV4dHJhY3RzIHRoZSByZWZlcmVuY2UgdG8gdGhl IERPTVdpbmRvdyBvYmplY3QgZnJvbSB0aGUgcGFzc2VkLWluIHdpbmRvdyBwYXJhbWV0ZXIuCisK IDIwMTAtMDEtMjcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwCmluZGV4IDJiMDI3ZGMuLjll NDA4NTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZUV2 ZW50Q3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VF dmVudEN1c3RvbS5jcHAKQEAgLTY4LDcgKzY4LDE0IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBW OE1lc3NhZ2VFdmVudDo6aW5pdE1lc3NhZ2VFdmVudENhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVu CiAgICAgUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gZGF0YUFyZyA9IFNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZTo6Y3JlYXRlKGFyZ3NbM10pOwogICAgIFN0cmluZyBvcmlnaW5BcmcgPSB2OFZh bHVlVG9XZWJDb3JlU3RyaW5nKGFyZ3NbNF0pOwogICAgIFN0cmluZyBsYXN0RXZlbnRJZEFyZyA9 IHY4VmFsdWVUb1dlYkNvcmVTdHJpbmcoYXJnc1s1XSk7Ci0gICAgRE9NV2luZG93KiBzb3VyY2VB cmcgPSBWOERPTVdpbmRvdzo6SGFzSW5zdGFuY2UoYXJnc1s2XSkgPyBWOERPTVdpbmRvdzo6dG9O YXRpdmUodjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChhcmdzWzZdKSkgOiAwOworCisgICAg RE9NV2luZG93KiBzb3VyY2VBcmcgPSAwOworICAgIGlmIChhcmdzWzZdLT5Jc09iamVjdCgpKSB7 CisgICAgICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlciA9IHY4OjpIYW5kbGU8djg6 Ok9iamVjdD46OkNhc3QoYXJnc1s2XSk7CisgICAgICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4g d2luZG93ID0gVjhET01XcmFwcGVyOjpsb29rdXBET01XcmFwcGVyKFY4Q2xhc3NJbmRleDo6RE9N V0lORE9XLCB3cmFwcGVyKTsKKyAgICAgICAgaWYgKCF3aW5kb3cuSXNFbXB0eSgpKQorICAgICAg ICAgICAgc291cmNlQXJnID0gVjhET01XaW5kb3c6OnRvTmF0aXZlKHdpbmRvdyk7CisgICAgfQog ICAgIE93blB0cjxNZXNzYWdlUG9ydEFycmF5PiBwb3J0QXJyYXk7CiAKICAgICBpZiAoIWlzVW5k ZWZpbmVkT3JOdWxsKGFyZ3NbN10pKSB7Cg==