34291 2010-01-28 16:49:46 -0800 DOM Objects shouldn't all require custom mark functions 2010-01-28 20:00:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned oldest_to_newest 185642 0 oliver 2010-01-28 16:49:46 -0800 DOM Objects shouldn't all require custom mark functions 185656 1 47660 oliver 2010-01-28 17:15:50 -0800 Created attachment 47660 Patch 185698 2 47660 barraclough 2010-01-28 19:31:58 -0800 Comment on attachment 47660 Patch I think it'd be nice to have a 'static const unsigned' value for 'AnonymousSlotCount - 1'. r+ 185705 3 oliver 2010-01-28 20:00:21 -0800 Committed r54040: <http://trac.webkit.org/changeset/54040> 47660 2010-01-28 17:15:50 -0800 2010-01-28 19:31:58 -0800 Patch bug-34291-20100128171549.patch text/plain 4283 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwZmJmOGI0Li5mNzcwMzNhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTAtMDEtMjggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET00gT2JqZWN0cyBzaG91 bGRuJ3QgYWxsIHJlcXVpcmUgY3VzdG9tIG1hcmsgZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI5MQorCisgICAgICAgIE1ha2UgZ2V0 QW5vbnltb3VzVmFsdWUgY29uc3QtZnJpZW5kbHkKKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmpl Y3QuaDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OmdldEFub255bW91c1ZhbHVlKToKKworMjAx MC0wMS0yOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmll d2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgogCiAgICAgICAgIFNpbXBsaWZ5IGFub255bW91cyBz bG90IGltcGxlbWVudGF0aW9uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmggYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKaW5kZXggNDE0ZTBl OC4uMmIzMWE2NSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5o CisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaApAQCAtMjIyLDcgKzIyMiw3 IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgQVNTRVJUKGluZGV4IDwgbV9zdHJ1Y3R1 cmUtPmFub255bW91c1Nsb3RDb3VudCgpKTsKICAgICAgICAgICAgICpsb2NhdGlvbkZvck9mZnNl dChpbmRleCkgPSB2YWx1ZTsKICAgICAgICAgfQotICAgICAgICBKU1ZhbHVlIGdldEFub255bW91 c1ZhbHVlKHVuc2lnbmVkIGluZGV4KQorICAgICAgICBKU1ZhbHVlIGdldEFub255bW91c1ZhbHVl KHVuc2lnbmVkIGluZGV4KSBjb25zdAogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlQoaW5k ZXggPCBtX3N0cnVjdHVyZS0+YW5vbnltb3VzU2xvdENvdW50KCkpOwogICAgICAgICAgICAgcmV0 dXJuICpsb2NhdGlvbkZvck9mZnNldChpbmRleCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY3ZGM4OWMuLjhjZjg3OTYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MjAgQEAKIDIwMTAtMDEtMjggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET00gT2JqZWN0cyBz aG91bGRuJ3QgYWxsIHJlcXVpcmUgY3VzdG9tIG1hcmsgZnVuY3Rpb25zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI5MQorCisgICAgICAgIE1ha2Ug RE9NT2JqZWN0V2l0aEdsb2JhbFBvaW50ZXIgdXNlIGFuIGFub255bW91cyBzbG90IHRvIHN0b3Jl IHRoZSBnbG9iYWwgb2JqZWN0CisgICAgICAgIHJlZmVyZW5jZS4KKworICAgICAgICAqIGJpbmRp bmdzL2pzL0pTRE9NQmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NT2JqZWN0V2l0aEds b2JhbFBvaW50ZXI6Omdsb2JhbE9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpET01PYmplY3RX aXRoR2xvYmFsUG9pbnRlcjo6c2NyaXB0RXhlY3V0aW9uQ29udGV4dCk6CisgICAgICAgIChXZWJD b3JlOjpET01PYmplY3RXaXRoR2xvYmFsUG9pbnRlcjo6RE9NT2JqZWN0V2l0aEdsb2JhbFBvaW50 ZXIpOgorCisyMDEwLTAxLTI4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCiAKICAgICAgICAgU2ltcGxpZnkg YW5vbnltb3VzIHNsb3QgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNET01CaW5kaW5nLmggYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5o CmluZGV4IDFlNzg4NDcuLjI1MGFjYmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMv SlNET01CaW5kaW5nLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaApA QCAtNzEsMTIgKzcxLDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAvLyB1cGRhdGVkIHRv IHN0b3JlIGEgZ2xvYmFsT2JqZWN0IHBvaW50ZXIuCiAgICAgY2xhc3MgRE9NT2JqZWN0V2l0aEds b2JhbFBvaW50ZXIgOiBwdWJsaWMgRE9NT2JqZWN0IHsKICAgICBwdWJsaWM6Ci0gICAgICAgIEpT RE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QoKSBjb25zdCB7IHJldHVybiBtX2dsb2JhbE9i amVjdDsgfQorICAgICAgICBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KCkgY29uc3Qg eyByZXR1cm4gc3RhdGljX2Nhc3Q8SlNET01HbG9iYWxPYmplY3QqPihnZXRBbm9ueW1vdXNWYWx1 ZShBbm9ueW1vdXNTbG90Q291bnQgLSAxKS5hc0NlbGwoKSk7IH0KIAogICAgICAgICBTY3JpcHRF eGVjdXRpb25Db250ZXh0KiBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkgY29uc3QKICAgICAgICAg ewogICAgICAgICAgICAgLy8gRklYTUU6IFNob3VsZCBuZXZlciBiZSAwLCBidXQgY2FuIGJlIGR1 ZSB0byBidWcgMjc2NDAuCi0gICAgICAgICAgICByZXR1cm4gbV9nbG9iYWxPYmplY3QtPnNjcmlw dEV4ZWN1dGlvbkNvbnRleHQoKTsKKyAgICAgICAgICAgIHJldHVybiBnbG9iYWxPYmplY3QoKS0+ c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpOwogICAgICAgICB9CiAKICAgICAgICAgc3RhdGljIFBh c3NSZWZQdHI8SlNDOjpTdHJ1Y3R1cmU+IGNyZWF0ZVN0cnVjdHVyZShKU0M6OkpTVmFsdWUgcHJv dG90eXBlKQpAQCAtODUsMjcgKzg1LDE4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg fQogCiAgICAgcHJvdGVjdGVkOgotICAgICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgU3RydWN0 dXJlRmxhZ3MgPSBKU0M6Ok92ZXJyaWRlc01hcmtDaGlsZHJlbiB8IERPTU9iamVjdDo6U3RydWN0 dXJlRmxhZ3M7CisgICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBBbm9ueW1vdXNTbG90Q291 bnQgPSAxICsgRE9NT2JqZWN0OjpBbm9ueW1vdXNTbG90Q291bnQ7CiAKICAgICAgICAgRE9NT2Jq ZWN0V2l0aEdsb2JhbFBvaW50ZXIoTm9uTnVsbFBhc3NSZWZQdHI8SlNDOjpTdHJ1Y3R1cmU+IHN0 cnVjdHVyZSwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICAgICAgICAgIDog RE9NT2JqZWN0KHN0cnVjdHVyZSkKLSAgICAgICAgICAgICwgbV9nbG9iYWxPYmplY3QoZ2xvYmFs T2JqZWN0KQogICAgICAgICB7CiAgICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBBU1NFUlQgaXMg dmFsaWQsIGJ1dCBmaXJlcyBpbiBmYXN0L2RvbS9nYy02Lmh0bWwgd2hlbiB0cnlpbmcgdG8gY3Jl YXRlCiAgICAgICAgICAgICAvLyBuZXcgSmF2YVNjcmlwdCBvYmplY3RzIG9uIGRldGFjaGVkIHdp bmRvd3MgZHVlIHRvIERPTVdpbmRvdzo6ZG9jdW1lbnQoKQogICAgICAgICAgICAgLy8gbmVlZGlu ZyB0byByZWFjaCB0aHJvdWdoIHRoZSBmcmFtZSB0byBnZXQgdG8gdGhlIERvY3VtZW50Ki4gIFNl ZSBidWcgMjc2NDAuCiAgICAgICAgICAgICAvLyBBU1NFUlQoZ2xvYmFsT2JqZWN0LT5zY3JpcHRF eGVjdXRpb25Db250ZXh0KCkpOworICAgICAgICAgICAgcHV0QW5vbnltb3VzVmFsdWUoQW5vbnlt b3VzU2xvdENvdW50IC0gMSwgZ2xvYmFsT2JqZWN0KTsKICAgICAgICAgfQogICAgICAgICB2aXJ0 dWFsIH5ET01PYmplY3RXaXRoR2xvYmFsUG9pbnRlcigpIHsgfQotCi0gICAgICAgIHZvaWQgbWFy a0NoaWxkcmVuKEpTQzo6TWFya1N0YWNrJiBtYXJrU3RhY2spCi0gICAgICAgIHsKLSAgICAgICAg ICAgIERPTU9iamVjdDo6bWFya0NoaWxkcmVuKG1hcmtTdGFjayk7Ci0gICAgICAgICAgICBtYXJr U3RhY2suYXBwZW5kKG1fZ2xvYmFsT2JqZWN0KTsKLSAgICAgICAgfQotCi0gICAgcHJpdmF0ZToK LSAgICAgICAgSlNET01HbG9iYWxPYmplY3QqIG1fZ2xvYmFsT2JqZWN0OwogICAgIH07CiAKICAg ICAvLyBCYXNlIGNsYXNzIGZvciBhbGwgY29uc3RydWN0b3Igb2JqZWN0cyBpbiB0aGUgSlNDIGJp bmRpbmdzLgo=