34272 2010-01-28 09:50:17 -0800 [Android] V8 Bindings are missing numerous forward-declarations and includes 2010-01-29 04:35:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking commit-queue steveblock oldest_to_newest 185529 0 steveblock 2010-01-28 09:50:17 -0800 In the V8 Bindings, numerous numerous forward-declarations and includes are picked up through includes guarded by feature or platform flags. This causes build errors on Android, where these flags may not be enabled. - Scriptcontroller.h - Need to forward declare NPObject Chromium picks this up though V8Proxy.h -> ChromiumBridge.h - V8DOMWrapper.h - Need to forward declare V8Proxy Chromium picks this up through V8CustomXpathNSResolver.h, the contents of which are guarded with XPATH - V8DOMWindowShell.cpp - Need to include CString.h and PlatformBridge.h for Android 185541 1 47630 steveblock 2010-01-28 10:42:11 -0800 Created attachment 47630 Patch 185542 2 47630 abarth 2010-01-28 10:45:18 -0800 Comment on attachment 47630 Patch Those are mostly my mistakes. Thanks for fixing them. How close are we to having Android buildable from svn.webkit.org? That's the best way to catch future regressions like these. 185596 3 47630 commit-queue 2010-01-28 13:34:53 -0800 Comment on attachment 47630 Patch Clearing flags on attachment: 47630 Committed r54014: <http://trac.webkit.org/changeset/54014> 185597 4 commit-queue 2010-01-28 13:34:58 -0800 All reviewed patches have been landed. Closing bug. 185818 5 steveblock 2010-01-29 04:35:43 -0800 > How close are we to having Android buildable from svn.webkit.org? That's the > best way to catch future regressions like these. We've so far made good progress with upstreaming the Android changes back to webkit.org. We're going as fast as we can and hope to be done by the end of Spring. Thanks for all your help with reviewing! 47630 2010-01-28 10:42:11 -0800 2010-01-28 13:34:52 -0800 Patch bug-34272-20100128184209.patch text/plain 2065 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDAwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMjggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeCBtaXNzaW5nIGZvcndhcmQtZGVjbGFyYXRpb25zIGFuZCBpbmNsdWRlcyBpbiBWOCBiaW5k aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQy NzIKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAgICog YmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oOiBNb2RpZmllZC4gRm9yd2FyZC1kZWNsYXJl IE5QT2JqZWN0CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHA6IE1v ZGlmaWVkLiBJbmNsdWRlIENTdHJpbmcuaCBhbmQgUGxhdGZvcm1CcmlkZ2UuaAorICAgICAgICAq IGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oOiBNb2RpZmllZC4gRm9yd2FyZC1kZWNsYXJlIFY4 UHJveHkKKwogMjAxMC0wMS0yOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgJKHJldmlzaW9uIDU0MDA0KQorKysgV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQy LDggQEAKICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3Iu aD4KIAorc3RydWN0IE5QT2JqZWN0OworCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIERP TVdyYXBwZXJXb3JsZDsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVs bC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxs LmNwcAkocmV2aXNpb24gNTQwMDQpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93 U2hlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw4IEBACiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiVjhET01XaW5kb3dTaGVsbC5oIgogCi0jaW5jbHVkZSAiQ2hyb21p dW1CcmlkZ2UuaCIKKyNpbmNsdWRlICJDU3RyaW5nLmgiCisjaW5jbHVkZSAiUGxhdGZvcm1Ccmlk Z2UuaCIKICNpbmNsdWRlICJDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUg IkRhdGVFeHRlbnNpb24uaCIKICNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgpJbmRleDogV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCShyZXZpc2lvbiA1NDAwNCkKKysrIFdlYkNvcmUvYmlu ZGluZ3MvdjgvVjhET01XcmFwcGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTkyLDYgKzkyLDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNsYXNzIFN0eWxlU2hlZXRMaXN0OwogICAgIGNsYXNz IFY4RXZlbnRMaXN0ZW5lcjsKICAgICBjbGFzcyBWOE9iamVjdEV2ZW50TGlzdGVuZXI7CisgICAg Y2xhc3MgVjhQcm94eTsKICNpZiBFTkFCTEUoV0VCX1NPQ0tFVFMpCiAgICAgY2xhc3MgV2ViU29j a2V0OwogI2VuZGlmCg==