34270 2010-01-28 09:13:25 -0800 WebCore should not use int64 type 2010-01-28 18:58:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned commit-queue jianli michaeln oldest_to_newest 185524 0 steveblock 2010-01-28 09:13:25 -0800 V8Binding.h uses int64 type. This should not be used in WebCore. This was introduced in http://trac.webkit.org/changeset/53574 and causes build errors on Android. See https://bugs.webkit.org/show_bug.cgi?id=25011 for a similar example. 185537 1 47628 steveblock 2010-01-28 10:34:29 -0800 Created attachment 47628 Patch 185691 2 47628 commit-queue 2010-01-28 18:58:04 -0800 Comment on attachment 47628 Patch Clearing flags on attachment: 47628 Committed r54038: <http://trac.webkit.org/changeset/54038> 185692 3 commit-queue 2010-01-28 18:58:10 -0800 All reviewed patches have been landed. Closing bug. 47628 2010-01-28 10:34:29 -0800 2010-01-28 18:58:03 -0800 Patch bug-34270-20100128183427.patch text/plain 1298 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDAwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMjggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSBsb25nIGxvbmcgcmF0aGVyIHRoYW4gaW50NjQgaW4gVjhCaW5kaW5nLmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MjcwCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBidWlsZCBmaXggb25seS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 QmluZGluZy5oOiBNb2RpZmllZC4KKyAgICAgICAgKFdlYkNvcmU6OnRvSW50NjQpOiBSZXR1cm5z IGxvbmcgbG9uZworCiAyMDEwLTAxLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGlu Z3MvdjgvVjhCaW5kaW5nLmgJKHJldmlzaW9uIDU0MDA0KQorKysgV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDkgKzExMiw5IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGZsb2F0Pih2YWx1ZS0+TnVt YmVyVmFsdWUoKSk7CiAgICAgfQogCi0gICAgaW5saW5lIGludDY0IHRvSW50NjQodjg6OkxvY2Fs PHY4OjpWYWx1ZT4gdmFsdWUpCisgICAgaW5saW5lIGxvbmcgbG9uZyB0b0ludDY0KHY4OjpMb2Nh bDx2ODo6VmFsdWU+IHZhbHVlKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGlu dDY0Pih2YWx1ZS0+SW50ZWdlclZhbHVlKCkpOworICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 bG9uZyBsb25nPih2YWx1ZS0+SW50ZWdlclZhbHVlKCkpOwogICAgIH0KIAogICAgIC8vIEZJWE1F OiBEcm9wIHRoaXMgaW4gZmF2b3Igb2YgdGhlIHR5cGUgc3BlY2lmaWMgdjhWYWx1ZVRvV2ViQ29y ZVN0cmluZyB3aGVuIHdlIHJld29yayB0aGUgY29kZSBnZW5lcmF0aW9uLgo=