34254 2010-01-28 05:26:16 -0800 [WML] Build error in WML enabled build. 2010-01-28 17:15:18 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 nayankk webkit-unassigned commit-queue oldest_to_newest 185437 0 nayankk 2010-01-28 05:26:16 -0800 With the changeset 53514, WML enabled builds are failing with following errors, CXX WebCore/wml/libwebkit_1_0_la-WMLDocument.lo CXX WebCore/wml/libwebkit_1_0_la-WMLElement.lo WebCore/wml/WMLDocument.cpp: In constructor ‘WebCore::WMLDocument::WMLDocument(WebCore::Frame*)’: WebCore/wml/WMLDocument.cpp:39: error: no matching function for call to ‘WebCore::Document::Document(WebCore::Frame*&, bool)’ ./WebCore/dom/Document.h:938: note: candidates are: WebCore::Document::Document(WebCore::Frame*, bool, bool) ./WebCore/dom/Document.h:178: note: WebCore::Document::Document(const WebCore::Document&) make[1]: *** [WebCore/wml/libwebkit_1_0_la-WMLDocument.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/nayan/webkit/WebKit-SVN' make: *** [all] Error 2 185441 1 47608 nayankk 2010-01-28 05:38:00 -0800 Created attachment 47608 Patch to fix compilation error. 185469 2 47608 nayankk 2010-01-28 07:03:49 -0800 Comment on attachment 47608 Patch to fix compilation error. My mistake, un-intentionally set review flag to '+' instead of '?'!. Correcting it. 185572 3 47608 laszlo.gombos 2010-01-28 12:25:49 -0800 Comment on attachment 47608 Patch to fix compilation error. r=me. 185653 4 47608 commit-queue 2010-01-28 17:15:14 -0800 Comment on attachment 47608 Patch to fix compilation error. Clearing flags on attachment: 47608 Committed r54030: <http://trac.webkit.org/changeset/54030> 185654 5 commit-queue 2010-01-28 17:15:18 -0800 All reviewed patches have been landed. Closing bug. 47608 2010-01-28 05:38:00 -0800 2010-01-28 17:15:13 -0800 Patch to fix compilation error. CompilationErrorFix.patch text/plain 1006 nayankk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Mzk5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMjggIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIGNvbXBpbGF0aW9uIGVycm9yIGluIFdNTCBlbmFibGVkIGJ1aWxkIGludHJvZHVjZWQg YmVjYXVzZSBvZiB0aGUgY2hhbmdlc2V0IDUzNTE0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI1NAorCisgICAgICAgICogd21sL1dNTERvY3Vt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldNTERvY3VtZW50OjpXTUxEb2N1bWVudCk6CisK IDIwMTAtMDEtMjggIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL3dtbC9X TUxEb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93bWwvV01MRG9jdW1lbnQuY3Bw CShyZXZpc2lvbiA1Mzk5MykKKysrIFdlYkNvcmUvd21sL1dNTERvY3VtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzUsNyArMzUsNyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBXTUxEb2N1 bWVudDo6V01MRG9jdW1lbnQoRnJhbWUqIGZyYW1lKQotICAgIDogRG9jdW1lbnQoZnJhbWUsIGZh bHNlKSAKKyAgICA6IERvY3VtZW50KGZyYW1lLCBmYWxzZSwgZmFsc2UpIAogICAgICwgbV9hY3Rp dmVDYXJkKDApCiB7CiAgICAgY2xlYXJYTUxWZXJzaW9uKCk7Cg==