34252 2010-01-28 03:46:13 -0800 make-script-test-wrapper can not handle js file which contains NULL char. 2010-01-28 17:33:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P3 Minor --- 0 hayato webkit-unassigned commit-queue oldest_to_newest 185412 0 hayato 2010-01-28 03:46:13 -0800 WebKitTools/Script/make-script-test-wrapper handle js file wrongly if the js file contains NULL char. For example, if you run make-script-test-wrapper script, LayoutTests/fast/js/script-tests/null-char-in-string.js is wrongly modified, which should not be touched. 185419 1 47604 hayato 2010-01-28 04:07:09 -0800 Created attachment 47604 remove-null-char-from-input-js-file 185420 2 hayato 2010-01-28 04:09:12 -0800 I've attached the patch, which removes NULL char form input JS file. 185580 3 47604 darin 2010-01-28 12:45:25 -0800 Comment on attachment 47604 remove-null-char-from-input-js-file Why do we need to handle input files with \0 characters in them?? 185581 4 47604 darin 2010-01-28 12:45:50 -0800 Comment on attachment 47604 remove-null-char-from-input-js-file Oh, I see there is one test that has one. OK. 185666 5 47604 commit-queue 2010-01-28 17:32:56 -0800 Comment on attachment 47604 remove-null-char-from-input-js-file Clearing flags on attachment: 47604 Committed r54033: <http://trac.webkit.org/changeset/54033> 185667 6 commit-queue 2010-01-28 17:33:01 -0800 All reviewed patches have been landed. Closing bug. 47604 2010-01-28 04:07:09 -0800 2010-01-28 17:32:55 -0800 remove-null-char-from-input-js-file bug-34252-20100128210707.patch text/plain 1202 hayato ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzNTJiNzk2Li5kYWVjYmIzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEt MjggIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBOVUxMIGNoYXIgZnJvbSBpbnB1 dCBKUyBmaWxlIGJlY2F1c2UgJ2dyZXAnIGZhaWxzIGlmIHRoZSBmaWxlIGNvbnRhaW5zIE5VTEwg Y2hhci4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzQyNTIKKworICAgICAgICAqIFNjcmlwdHMvbWFrZS1zY3JpcHQtdGVzdC13cmFwcGVyczoKKwog MjAxMC0wMS0yOCAgQ2hyaXMgSmVyZG9uZWsgIDxjamVyZG9uZWtAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaGluaWNoaXJvIEhhbWFqaS4KZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbWFrZS1zY3JpcHQtdGVzdC13cmFwcGVycyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvbWFrZS1zY3JpcHQtdGVzdC13cmFwcGVycwppbmRleCAxMzM0NzZjLi5hZWQxODM0IDEwMDc1 NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21ha2Utc2NyaXB0LXRlc3Qtd3JhcHBlcnMKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tYWtlLXNjcmlwdC10ZXN0LXdyYXBwZXJzCkBAIC05OSw3 ICs5OSw3IEBAIGZvciBteSAkdGZpbGUgKEB0ZW1wbGF0ZXMpIHsKICAgICAgICAgJGh0bWwgPX4g czoke3RlbXBsYXRlRGlyZWN0b3J5fS8oLiopXC5qczokMS5odG1sOjsKICAgICAgICAgbmV4dCBp ZiAtZiAiJGh0bWwtZGlzYWJsZWQiOwogCi0gICAgICAgIHN5c3RlbSgiZ3JlcCAtcSAnc3VjY2Vz c2Z1bGx5UGFyc2VkID0nICRmaWxlIik7CisgICAgICAgIHN5c3RlbSgiY2F0ICR7ZmlsZX0gfCB0 ciAnXFwwJyAnICcgfCBncmVwIC1xICdzdWNjZXNzZnVsbHlQYXJzZWQgPSciKTsKICAgICAgICAg aWYgKCQ/ICE9IDApIHsKICAgICAgICAgICAgIGBlY2hvICIiID4+ICIke2ZpbGV9ImA7CiAgICAg ICAgICAgICBgZWNobyAidmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7IiA+PiAiJHtmaWxl fSJgOwo=