34224 2010-01-27 12:19:06 -0800 [v8] minor cosmetic fix in V8 bindings codegenerator 2010-01-28 08:37:05 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned abarth commit-queue oldest_to_newest 185182 0 antonm 2010-01-27 12:19:06 -0800 Need to swap , and a space. 185185 1 47557 antonm 2010-01-27 12:22:04 -0800 Created attachment 47557 First take 185199 2 47557 antonm 2010-01-27 13:31:48 -0800 Comment on attachment 47557 First take Thanks, David. 185224 3 47557 commit-queue 2010-01-27 14:41:58 -0800 Comment on attachment 47557 First take Clearing flags on attachment: 47557 Committed r53953: <http://trac.webkit.org/changeset/53953> 185225 4 commit-queue 2010-01-27 14:42:03 -0800 All reviewed patches have been landed. Closing bug. 185355 5 abarth 2010-01-27 23:45:14 -0800 Oh good. I thought v9 was making a comeback. 185410 6 antonm 2010-01-28 03:36:24 -0800 (In reply to comment #5) > Oh good. I thought v9 was making a comeback. Huh? Oh should I take it off the bug? 185494 7 abarth 2010-01-28 08:30:42 -0800 For a while, there were two versions of the V8 API, one called v8 and one called v9. If you think life is confusing now, you should have seen that! Thankfully, v9 killed v8, so the API we use now is technically v9, but we kept the v8 name because sounds better. :) 185501 8 antonm 2010-01-28 08:37:05 -0800 (In reply to comment #7) > For a while, there were two versions of the V8 API, one called v8 and one > called v9. If you think life is confusing now, you should have seen that! > Thankfully, v9 killed v8, so the API we use now is technically v9, but we kept > the v8 name because sounds better. :) Cool. Thanks a lot for explanations. 47557 2010-01-27 12:22:04 -0800 2010-01-27 14:41:57 -0800 First take bug-34224-20100127232202.patch text/plain 1365 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTA1ODAxYi4uY2YyMWFjZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wMS0yNyAgQW50b24gTXVoaW4g IDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFt2OF0gbWlub3IgY29zbWV0aWMgZml4IGluIFY4IGJpbmRpbmdzIGNv ZGVnZW5lcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM0MjI0CisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bToKKwogMjAxMC0wMS0yNyAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IGE3YmI0YjUuLmVhNmMwOTkgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysr IGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMTQxMSw3 ICsxNDExLDcgQEAgRU5ECiAKICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgZGVzYy0+JHtzZXRP bn1UZW1wbGF0ZSgpLT5TZXROYW1lZFByb3BlcnR5SGFuZGxlcihWOCR7aW50ZXJmYWNlTmFtZX06 Om5hbWVkUHJvcGVydHlHZXR0ZXIsICIpOwogICAgIHB1c2goQGltcGxDb250ZW50LCAkaGFzU2V0 dGVyID8gIlY4JHtpbnRlcmZhY2VOYW1lfTo6bmFtZWRQcm9wZXJ0eVNldHRlciwgIiA6ICIwLCAi KTsKLSAgICBwdXNoKEBpbXBsQ29udGVudCwgIjAgLCIpOyAjIE5hbWVkUHJvcGVydHlRdWVyeSAt LSBub3QgYmVpbmcgdXNlZCBhdCB0aGUgbW9tZW50LgorICAgIHB1c2goQGltcGxDb250ZW50LCAi MCwgIik7ICMgTmFtZWRQcm9wZXJ0eVF1ZXJ5IC0tIG5vdCBiZWluZyB1c2VkIGF0IHRoZSBtb21l bnQuCiAgICAgcHVzaChAaW1wbENvbnRlbnQsICRoYXNEZWxldGVyID8gIlY4JHtpbnRlcmZhY2VO YW1lfTo6bmFtZWRQcm9wZXJ0eURlbGV0ZXIsICIgOiAiMCwgIik7CiAgICAgcHVzaChAaW1wbENv bnRlbnQsICRoYXNFbnVtZXJhdG9yID8gIlY4JHtpbnRlcmZhY2VOYW1lfTo6bmFtZWRQcm9wZXJ0 eUVudW1lcmF0b3IiIDogIjAiKTsKICAgICBwdXNoKEBpbXBsQ29udGVudCwgIik7XG4iKTsK