34223 2010-01-27 12:04:32 -0800 Remove trailing \ from inline function code 2010-01-27 14:59:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned commit-queue oldest_to_newest 185178 0 antonm 2010-01-27 12:04:32 -0800 That's most probably remnants of refactoring which turned a macro into a function. 185179 1 47556 antonm 2010-01-27 12:07:41 -0800 Created attachment 47556 First patch 185186 2 47556 darin 2010-01-27 12:27:45 -0800 Comment on attachment 47556 First patch Comments should also be "//" instead of "/*". Spaces should be around the "-" operator too, not just the "<<" operator. 185187 3 47558 antonm 2010-01-27 12:30:34 -0800 Created attachment 47558 Adding spaces around - 185189 4 antonm 2010-01-27 12:31:12 -0800 (In reply to comment #2) > (From update of attachment 47556 [details]) > Comments should also be "//" instead of "/*". > > Spaces should be around the "-" operator too, not just the "<<" operator. Thanks, done. 185201 5 47558 antonm 2010-01-27 13:32:41 -0800 Comment on attachment 47558 Adding spaces around - Thanks, Darin. 185228 6 47558 commit-queue 2010-01-27 14:59:30 -0800 Comment on attachment 47558 Adding spaces around - Clearing flags on attachment: 47558 Committed r53954: <http://trac.webkit.org/changeset/53954> 185229 7 commit-queue 2010-01-27 14:59:35 -0800 All reviewed patches have been landed. Closing bug. 47556 2010-01-27 12:07:41 -0800 2010-01-27 12:30:28 -0800 First patch bug-34223-20100127230739.patch text/plain 1669 antonm ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA5MzNmZGMxLi5lZjYzY2MzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTAtMDEtMjcgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdHJhaWxp bmcgXCBmcm9tIGlubGluZSBmdW5jdGlvbiBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDIyMworCisgICAgICAgICogYXNzZW1ibGVyL0FSTXY3 QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFSTVRodW1iSW1tZWRpYXRlOjpjb3VudExlYWRp bmdaZXJvc1BhcnRpYWwpOgorCiAyMDEwLTAxLTI3ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29t cGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaCBiL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCmluZGV4IDZjZGU2M2IuLjg1NWZiMWIg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCisr KyBiL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCkBAIC0yMDEsMTAg KzIwMSwxMCBAQCBjbGFzcyBBUk1UaHVtYkltbWVkaWF0ZSB7CiAKICAgICBBTFdBWVNfSU5MSU5F IHN0YXRpYyB2b2lkIGNvdW50TGVhZGluZ1plcm9zUGFydGlhbCh1aW50MzJfdCYgdmFsdWUsIGlu dDMyX3QmIHplcm9zLCBjb25zdCBpbnQgTikKICAgICB7Ci0gICAgICAgIGlmICh2YWx1ZSAmIH4o KDE8PE4pLTEpKSAvKiBjaGVjayBmb3IgYW55IG9mIHRoZSB0b3AgTiBiaXRzIChvZiAyTiBiaXRz KSBhcmUgc2V0ICovIFwKLSAgICAgICAgICAgIHZhbHVlID4+PSBOOyAgICAgICAgIC8qIGlmIGFu eSB3ZXJlIHNldCwgbG9zZSB0aGUgYm90dG9tIE4gKi8gXAotICAgICAgICBlbHNlICAgICAgICAg ICAgICAgICAgICAgLyogaWYgbm9uZSBvZiB0aGUgdG9wIE4gYml0cyBhcmUgc2V0LCAqLyBcCi0g ICAgICAgICAgICB6ZXJvcyArPSBOOyAgICAgICAgICAvKiB0aGVuIHdlIGhhdmUgaWRlbnRpZmll ZCBOIGxlYWRpbmcgemVyb3MgKi8KKyAgICAgICAgaWYgKHZhbHVlICYgfigoMSA8PCBOKS0xKSkg LyogY2hlY2sgZm9yIGFueSBvZiB0aGUgdG9wIE4gYml0cyAob2YgMk4gYml0cykgYXJlIHNldCAq LworICAgICAgICAgICAgdmFsdWUgPj49IE47ICAgICAgICAgICAvKiBpZiBhbnkgd2VyZSBzZXQs IGxvc2UgdGhlIGJvdHRvbSBOICovCisgICAgICAgIGVsc2UgICAgICAgICAgICAgICAgICAgICAg IC8qIGlmIG5vbmUgb2YgdGhlIHRvcCBOIGJpdHMgYXJlIHNldCwgKi8KKyAgICAgICAgICAgIHpl cm9zICs9IE47ICAgICAgICAgICAgLyogdGhlbiB3ZSBoYXZlIGlkZW50aWZpZWQgTiBsZWFkaW5n IHplcm9zICovCiAgICAgfQogCiAgICAgc3RhdGljIGludDMyX3QgY291bnRMZWFkaW5nWmVyb3Mo dWludDMyX3QgdmFsdWUpCg== 47558 2010-01-27 12:30:34 -0800 2010-01-27 14:59:30 -0800 Adding spaces around - bug-34223-20100127233032.patch text/plain 1677 antonm ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA5MzNmZGMxLi5lZjYzY2MzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTAtMDEtMjcgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdHJhaWxp bmcgXCBmcm9tIGlubGluZSBmdW5jdGlvbiBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDIyMworCisgICAgICAgICogYXNzZW1ibGVyL0FSTXY3 QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFSTVRodW1iSW1tZWRpYXRlOjpjb3VudExlYWRp bmdaZXJvc1BhcnRpYWwpOgorCiAyMDEwLTAxLTI3ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29t cGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaCBiL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCmluZGV4IDZjZGU2M2IuLjRlMzk0YjIg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCisr KyBiL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCkBAIC0yMDEsMTAg KzIwMSwxMCBAQCBjbGFzcyBBUk1UaHVtYkltbWVkaWF0ZSB7CiAKICAgICBBTFdBWVNfSU5MSU5F IHN0YXRpYyB2b2lkIGNvdW50TGVhZGluZ1plcm9zUGFydGlhbCh1aW50MzJfdCYgdmFsdWUsIGlu dDMyX3QmIHplcm9zLCBjb25zdCBpbnQgTikKICAgICB7Ci0gICAgICAgIGlmICh2YWx1ZSAmIH4o KDE8PE4pLTEpKSAvKiBjaGVjayBmb3IgYW55IG9mIHRoZSB0b3AgTiBiaXRzIChvZiAyTiBiaXRz KSBhcmUgc2V0ICovIFwKLSAgICAgICAgICAgIHZhbHVlID4+PSBOOyAgICAgICAgIC8qIGlmIGFu eSB3ZXJlIHNldCwgbG9zZSB0aGUgYm90dG9tIE4gKi8gXAotICAgICAgICBlbHNlICAgICAgICAg ICAgICAgICAgICAgLyogaWYgbm9uZSBvZiB0aGUgdG9wIE4gYml0cyBhcmUgc2V0LCAqLyBcCi0g ICAgICAgICAgICB6ZXJvcyArPSBOOyAgICAgICAgICAvKiB0aGVuIHdlIGhhdmUgaWRlbnRpZmll ZCBOIGxlYWRpbmcgemVyb3MgKi8KKyAgICAgICAgaWYgKHZhbHVlICYgfigoMSA8PCBOKSAtIDEp KSAvKiBjaGVjayBmb3IgYW55IG9mIHRoZSB0b3AgTiBiaXRzIChvZiAyTiBiaXRzKSBhcmUgc2V0 ICovCisgICAgICAgICAgICB2YWx1ZSA+Pj0gTjsgICAgICAgICAgICAgLyogaWYgYW55IHdlcmUg c2V0LCBsb3NlIHRoZSBib3R0b20gTiAqLworICAgICAgICBlbHNlICAgICAgICAgICAgICAgICAg ICAgICAgIC8qIGlmIG5vbmUgb2YgdGhlIHRvcCBOIGJpdHMgYXJlIHNldCwgKi8KKyAgICAgICAg ICAgIHplcm9zICs9IE47ICAgICAgICAgICAgICAvKiB0aGVuIHdlIGhhdmUgaWRlbnRpZmllZCBO IGxlYWRpbmcgemVyb3MgKi8KICAgICB9CiAKICAgICBzdGF0aWMgaW50MzJfdCBjb3VudExlYWRp bmdaZXJvcyh1aW50MzJfdCB2YWx1ZSkK