34216 2010-01-27 08:20:38 -0800 AccessibilityController.h doesn't compile with RealView ARM compilers 2010-01-27 17:05:54 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned commit-queue oldest_to_newest 185105 0 gwright 2010-01-27 08:20:38 -0800 When trying to compile using RealView I get the following error: "../../../WebKitTools/DumpRenderTree/AccessibilityController.h", line 30: Error: #59: function call is not allowed in a constant expression #if PLATFORM(WIN) ^ "../../../WebKitTools/DumpRenderTree/AccessibilityController.h", line 56: Error: #59: function call is not allowed in a constant expression #if PLATFORM(WIN) ^ This only seems to happen with RealView (I'm using RVCT 4). 185117 1 47540 gwright 2010-01-27 08:37:55 -0800 Created attachment 47540 Add missing #include Add missing include for wtf/Platform.h so that the #if PLATFORM(WIN) statement doesn't result in an error. 185118 2 47540 manyoso 2010-01-27 08:41:32 -0800 Comment on attachment 47540 Add missing #include Add a real changelog please. 185122 3 47542 gwright 2010-01-27 08:50:28 -0800 Created attachment 47542 Add ChangeLog Update to previous patch to include a proper ChangeLog. 185285 4 47542 commit-queue 2010-01-27 17:05:49 -0800 Comment on attachment 47542 Add ChangeLog Clearing flags on attachment: 47542 Committed r53962: <http://trac.webkit.org/changeset/53962> 185286 5 commit-queue 2010-01-27 17:05:54 -0800 All reviewed patches have been landed. Closing bug. 47540 2010-01-27 08:37:55 -0800 2010-01-27 08:50:28 -0800 Add missing #include accessibility-header.patch text/plain 844 gwright Y29tbWl0IDVkYzc1MTRmYWNkNjkwYzdkYzI4NTVhOTgyNGE5ZjZhOWU0ZTUwZTYKQXV0aG9yOiBH ZW9yZ2UgV3JpZ2h0IDxnd3JpZ2h0QHJpbS5jb20+CkRhdGU6ICAgV2VkIEphbiAyNyAxMToyMjox OCAyMDEwIC0wNTAwCgogICAgMjAxMC0wMS0yNyAgR2VvcmdlIFdyaWdodCAgPGd3cmlnaHRAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQyMTYK ICAgIAogICAgICAgICAgICBBZGQgbWlzc2luZyBpbmNsdWRlIGZvciB3dGYvUGxhdGZvcm0uaAog ICAgCiAgICAgICAgICAgICogRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIu aDoKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5 Q29udHJvbGxlci5oIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eUNv bnRyb2xsZXIuaAppbmRleCBiNGQ0NWViLi41YTc1YzJjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5oCisrKyBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL0FjY2Vzc2liaWxpdHlDb250cm9sbGVyLmgKQEAgLTI3LDYgKzI3 LDcgQEAKICNkZWZpbmUgQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJfaAogCiAjaW5jbHVkZSA8SmF2 YVNjcmlwdENvcmUvSlNPYmplY3RSZWYuaD4KKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KICNp ZiBQTEFURk9STShXSU4pCiAjaW5jbHVkZSA8d2luZG93cy5oPgogI2VuZGlmCg== 47542 2010-01-27 08:50:28 -0800 2010-01-27 17:05:48 -0800 Add ChangeLog accessibility-header-2.patch text/plain 1360 gwright Y29tbWl0IDA5MjIwNDEwMzQwZWQ4MDQyMDE0NDhmMGM5ZWU1YWNkN2MxMzYyODQKQXV0aG9yOiBH ZW9yZ2UgV3JpZ2h0IDxnd3JpZ2h0QHJpbS5jb20+CkRhdGU6ICAgV2VkIEphbiAyNyAxMToyMjox OCAyMDEwIC0wNTAwCgogICAgMjAxMC0wMS0yNyAgR2VvcmdlIFdyaWdodCAgPGd3cmlnaHRAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQyMTYK ICAgIAogICAgICAgICAgICBBZGQgbWlzc2luZyBpbmNsdWRlIGZvciB3dGYvUGxhdGZvcm0uaAog ICAgCiAgICAgICAgICAgICogRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIu aDoKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFu Z2VMb2cKaW5kZXggZmUyODM5Yy4uOGEwYWY1MCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEw LTAxLTI3ICBHZW9yZ2UgV3JpZ2h0ICA8Z3dyaWdodEByaW0uY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNDIxNgorCisgICAgICAgIEFkZCBtaXNzaW5nIGluY2x1ZGUgZm9y IHd0Zi9QbGF0Zm9ybS5oCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5 Q29udHJvbGxlci5oOgorCiAyMDEwLTAxLTEzICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCB0aW55IHR5cG8gZml4IGluIGRvY3N0 cmluZ3MuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmls aXR5Q29udHJvbGxlci5oIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuaAppbmRleCBiNGQ0NWViLi41YTc1YzJjIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5oCisrKyBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL0FjY2Vzc2liaWxpdHlDb250cm9sbGVyLmgKQEAgLTI3LDYg KzI3LDcgQEAKICNkZWZpbmUgQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJfaAogCiAjaW5jbHVkZSA8 SmF2YVNjcmlwdENvcmUvSlNPYmplY3RSZWYuaD4KKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4K ICNpZiBQTEFURk9STShXSU4pCiAjaW5jbHVkZSA8d2luZG93cy5oPgogI2VuZGlmCg==