34212 2010-01-27 05:49:47 -0800 [Qt] DRT keepWebHistory is not being called in redirect-30*.pl tests 2010-08-19 05:19:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 diegohcg webkit-qt-unassigned ademar commit-queue kenneth ossy robert tonikitoo oldest_to_newest 185052 0 diegohcg 2010-01-27 05:49:47 -0800 The tests: http/tests/history/redirect-301.pl http/tests/history/redirect-302.pl http/tests/history/redirect-303.pl http/tests/history/redirect-307.pl are failing because keepWebHistoryMethos is not being called 240835 1 robert 2010-06-21 13:11:04 -0700 (In reply to comment #0) > The tests: > > http/tests/history/redirect-301.pl > http/tests/history/redirect-302.pl > http/tests/history/redirect-303.pl > http/tests/history/redirect-307.pl > > are failing because keepWebHistoryMethos is not being called They're failing because QtWebKit does not parse/load the html body of the redirecting page so the layoutTestController commands don't get executed. The strange thing is a variety of other redirect requests depend on the fact that the body of a redirecting page is not displayed, so I'm not sure how other ports manage to execute the controller commands in the page without displaying it. They are certainly calling client->didReceiveData() which will load the page. Also, Qt's redirect logic is heavily embedded in QNetworkReplyHandler and it seems pretty fundamental there that a redirecting page won't get loaded. Not easy to work around this, even for tests, without breaking stuff. 266321 2 64758 ademar 2010-08-18 12:36:36 -0700 Created attachment 64758 Remove outdated references to renamed tests These tests have been renamed on http://trac.webkit.org/changeset/65340 (together with several changes in WebCore) And since them they're passing the Qt bot without problems. This patch just removes the outdated references from the Skipped file - I assume we can close this bug since the tests are passing for a while now. 266509 3 64758 commit-queue 2010-08-18 19:08:06 -0700 Comment on attachment 64758 Remove outdated references to renamed tests Rejecting patch 64758 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20870 test cases. media/video-preload.html -> crashed Exiting early after 1 failures. 17238 tests run. 780.96s total testing time 17237 test cases (99%) succeeded 1 test case (<1%) crashed 36 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3712377 266628 4 64758 ossy 2010-08-19 04:24:09 -0700 Comment on attachment 64758 Remove outdated references to renamed tests It was a flakey fail, cq+ -ed again. 266664 5 64758 commit-queue 2010-08-19 05:19:50 -0700 Comment on attachment 64758 Remove outdated references to renamed tests Clearing flags on attachment: 64758 Committed r65662: <http://trac.webkit.org/changeset/65662> 266665 6 commit-queue 2010-08-19 05:19:55 -0700 All reviewed patches have been landed. Closing bug. 64758 2010-08-18 12:36:36 -0700 2010-08-19 05:19:50 -0700 Remove outdated references to renamed tests 0001-Remove-outdated-reference-to-http-tests-history-redi.patch text/plain 2129 ademar RnJvbSBjNGNkOTY2MmFjNWFiYTE5NGZlOWM3NmU3MmNmNDBhYWQ1OTEyYWVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogV2VkLCAxOCBBdWcgMjAxMCAxNjoyNzozNyAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIFJlbW92ZSBvdXRkYXRlZCByZWZlcmVuY2UgdG8gaHR0cC90ZXN0cy9oaXN0 b3J5L3JlZGlyZWN0LSoucGwgdGVzdHMKClRob3NlIHRlc3RzIGhhdmUgYmVlbiByZW5hdGVkIG9u Cmh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY1MzQwCgpTaG91bGQgY2xvc2UgYnVn Cmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDIxMgotLS0KIExheW91 dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIExheW91 dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgfCAgICA3IC0tLS0tLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMTYgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTAzZTY5ZS4uODI2 YzJmZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA4LTE4ICBBZGVtYXIgZGUgU291emEg UmVpcyBKciAgPGFkZW1hci5yZWlzQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIG91dGRhdGVkIHJlZmVyZW5jZSB0 byBodHRwL3Rlc3RzL2hpc3RvcnkvcmVkaXJlY3QtKi5wbCB0ZXN0cworCisgICAgICAgIFtRdF0g RFJUIGtlZXBXZWJIaXN0b3J5IGlzIG5vdCBiZWluZyBjYWxsZWQgaW4gcmVkaXJlY3QtMzAqLnBs IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NDIxMgorCisgICAgICAgIFRob3NlIHRlc3RzIGhhdmUgYmVlbiByZW5hbWVkIG9uCisgICAgICAg IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY1MzQwCisKKyAgICAgICAgQW5kIGFy ZSBwYXNzaW5nIG9uIHRoZSBib3Qgc2luY2UgdGhlbi4KKworICAgICAgICAqIHBsYXRmb3JtL3F0 L1NraXBwZWQ6CisKIDIwMTAtMDgtMTggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiAgTW92ZSBzb21lIHRlc3QgZXhwZWN0YXRpb25z IHRoYXQgYXJlIG5vdCBwbGF0Zm9ybSBzcGVjaWZpYyB0byB0aGUgcmlnaHQgcGxhY2UuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvU2tpcHBlZAppbmRleCBlYzY5YjExLi44MmViZDAzIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKQEAgLTE1OSwxMyArMTU5LDYgQEAgaHR0cC90ZXN0cy9taXNjL2J1YmJsZS1kcmFn LWV2ZW50cy5odG1sCiAjIFtRdF0gaHR0cC90ZXN0cy9taXNjL3Nsb3ctbG9hZGluZy1tYXNrLmh0 bWwgdGltZWQgb3V0LgogaHR0cC90ZXN0cy9taXNjL3Nsb3ctbG9hZGluZy1tYXNrLmh0bWwKIAot IyBza2lwIGZhaWxpbmcgaGlzdG9yeSB0ZXN0cwotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQxNjcKLWh0dHAvdGVzdHMvaGlzdG9yeS9yZWRpcmVjdC0zMDEucGwK LWh0dHAvdGVzdHMvaGlzdG9yeS9yZWRpcmVjdC0zMDIucGwKLWh0dHAvdGVzdHMvaGlzdG9yeS9y ZWRpcmVjdC0zMDMucGwKLWh0dHAvdGVzdHMvaGlzdG9yeS9yZWRpcmVjdC0zMDcucGwKLQogIyBR dCBtYXkgd2FudCB0byBmb2xsb3cgR1RLKyBpbiBhZGRpbmcgYSBkZWZhdWx0IEFjY2VwdCBoZWFk ZXIgZm9yCiAjIHN1YnJlc291cmNlcy4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMzI0Mi4KIGh0dHAvdGVzdHMvbWlzYy9pbWFnZS1jaGVja3MtZm9yLWFjY2Vw dC5odG1sCi0tIAoxLjcuMi4xCgo=