34211 2010-01-27 05:06:53 -0800 [V8] Support getting integer-named properties using indexing notation on document object 2010-01-27 12:00:29 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ager webkit-unassigned commit-queue dglazkov japhet oldest_to_newest 185040 0 ager 2010-01-27 05:06:53 -0800 The V8 binding layer does not handle access of properties with integer names on HTMLDocuments as illustrated by the following example. We need to add an indexed property getter to HTMLDocuments. <html> <head> <script> function runTest() { alert(document['42']); alert(document[42]); } </script> </head> <body onload="runTest()"> <img name="42" src="foo.gif"> </body> </html> 185042 1 ager 2010-01-27 05:07:17 -0800 Corresponding Chromium bug: crbug.com/31662 185045 2 47520 ager 2010-01-27 05:19:12 -0800 Created attachment 47520 Add indexed property getter to HTMLDocument objects 185119 3 dglazkov 2010-01-27 08:42:12 -0800 Nate, you want to give it a look-over? 185124 4 japhet 2010-01-27 09:13:27 -0800 (In reply to comment #3) > Nate, you want to give it a look-over? LGTM 185127 5 47520 dglazkov 2010-01-27 09:19:22 -0800 Comment on attachment 47520 Add indexed property getter to HTMLDocument objects I wonder if we should just generate fallback index getters for all interfaces that have named property getters? 185175 6 47520 commit-queue 2010-01-27 12:00:23 -0800 Comment on attachment 47520 Add indexed property getter to HTMLDocument objects Clearing flags on attachment: 47520 Committed r53946: <http://trac.webkit.org/changeset/53946> 185176 7 commit-queue 2010-01-27 12:00:29 -0800 All reviewed patches have been landed. Closing bug. 47520 2010-01-27 05:19:12 -0800 2010-01-27 12:00:22 -0800 Add indexed property getter to HTMLDocument objects htmldocument.txt text/plain 4608 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzkyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMjcgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g U3VwcG9ydCBnZXR0aW5nIGludGVnZXItbmFtZWQgcHJvcGVydGllcyB1c2luZyBpbmRleGluZyBu b3RhdGlvbiBvbiBkb2N1bWVudCBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM0MjExCisKKyAgICAgICAgQWRkIGluZGV4ZWQgcHJvcGVydHkg Z2V0dGVyIHRvIEhUTUxEb2N1bWVudCB0byBzdXBwb3J0IGdldHRpbmcKKyAgICAgICAgZWxlbWVu dHMgd2l0aCBpbnRlZ2VyIG5hbWVzIHVzaW5nIGluZGV4aW5nIG5vdGF0aW9uIG9uIGRvY3VtZW50 LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL0hUTUxEb2N1bWVudC9nZXQtaWZyYW1lLXdpdGgt aW50ZWdlci1uYW1lLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1 c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOEhUTUxEb2N1bWVudDo6aW5kZXhlZFByb3Bl cnR5R2V0dGVyKToKKwogMjAxMC0wMS0yNyAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVy Y290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7gu CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHJl dmlzaW9uIDUzOTA3KQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JW OC5wbQkod29ya2luZyBjb3B5KQpAQCAtNDI4LDYgKzQyOCw3IEBAIEVORAogbXkgJWluZGV4ZXJT cGVjaWFsQ2FzZXMgPSAoCiAgICAgIlN0b3JhZ2UiID0+IDEsCiAgICAgIkhUTUxBcHBsZXRFbGVt ZW50IiA9PiAxLAorICAgICJIVE1MRG9jdW1lbnQiID0+IDEsCiAgICAgIkhUTUxFbWJlZEVsZW1l bnQiID0+IDEsCiAgICAgIkhUTUxPYmplY3RFbGVtZW50IiA9PiAxCiApOwpAQCAtMTMwNCw3ICsx MzA1LDkgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb25JbmRleGVyCiAgICAgbXkgJGlzU3Bl Y2lhbENhc2UgPSBleGlzdHMgJGluZGV4ZXJTcGVjaWFsQ2FzZXN7JGludGVyZmFjZU5hbWV9Owog ICAgIGlmICgkaXNTcGVjaWFsQ2FzZSkgewogICAgICAgICAkaGFzR2V0dGVyID0gMTsKLSAgICAg ICAgJGhhc0N1c3RvbVNldHRlciA9IDE7CisgICAgICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJEZWxlZ2F0aW5nUHV0RnVuY3Rpb24ifSkgeworICAgICAgICAgICAgJGhh c0N1c3RvbVNldHRlciA9IDE7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoISRoYXNHZXR0 ZXIpIHsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3Vz dG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxE b2N1bWVudEN1c3RvbS5jcHAJKHJldmlzaW9uIDUzOTA3KQorKysgV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OSw2 ICs5OSwxMyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhIVE1MRG9jdW1lbnQ6Om5hCiAgICAg cmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpIVE1M Q09MTEVDVElPTiwgaXRlbXMucmVsZWFzZSgpKTsKIH0KIAordjg6OkhhbmRsZTx2ODo6VmFsdWU+ IFY4SFRNTERvY3VtZW50OjppbmRleGVkUHJvcGVydHlHZXR0ZXIodWludDMyX3QgaW5kZXgsIGNv bnN0IHY4OjpBY2Nlc3NvckluZm8gJmluZm8pIAoreworICAgIElOQ19TVEFUUygiRE9NLkhUTUxE b2N1bWVudC5JbmRleGVkUHJvcGVydHlHZXR0ZXIiKTsKKyAgICB2ODo6TG9jYWw8djg6OkludGVn ZXI+IGluZGV4VjggPSB2ODo6SW50ZWdlcjo6TmV3RnJvbVVuc2lnbmVkKGluZGV4KTsKKyAgICBy ZXR1cm4gbmFtZWRQcm9wZXJ0eUdldHRlcihpbmRleFY4LT5Ub1N0cmluZygpLCBpbmZvKTsKK30K KwogLy8gSFRNTERvY3VtZW50IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogLy8gQ29uY2F0ZW5hdGVzICJhcmdzIiB0byBh IHN0cmluZy4gSWYgYXJncyBpcyBlbXB0eSwgcmV0dXJucyBlbXB0eSBzdHJpbmcuCkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzkyNSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAxLTI3ICBNYWRzIEFnZXIgIDxhZ2VyQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb VjhdIFN1cHBvcnQgZ2V0dGluZyBpbnRlZ2VyLW5hbWVkIHByb3BlcnRpZXMgdXNpbmcgaW5kZXhp bmcgbm90YXRpb24gb24gZG9jdW1lbnQgb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDIxMQorCisgICAgICAgICogZmFzdC9kb20vSFRNTERv Y3VtZW50L2dldC1pZnJhbWUtd2l0aC1pbnRlZ2VyLW5hbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2RvbS9IVE1MRG9jdW1lbnQvZ2V0LWlmcmFtZS13aXRoLWludGVnZXIt bmFtZS5odG1sOiBBZGRlZC4KKwogMjAxMC0wMS0yNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gUXQgcG9ydCBkb2Vzbid0IG5lZWQgcGxhdGZv cm0gZGVwZW5kZW50IGV4cGVjdGVkIGZpbGUgYW55bW9yZQpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTERvY3VtZW50L2dldC1pZnJhbWUtd2l0aC1pbnRlZ2VyLW5hbWUtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC9nZXQt aWZyYW1lLXdpdGgtaW50ZWdlci1uYW1lLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC9nZXQtaWZyYW1lLXdpdGgtaW50ZWdlci1u YW1lLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACisKK1RoaXMgdGVz dHMgdGhhdCBhbiBpZnJhbWUgd2l0aCBhbiBpbnRlZ2VyIG5hbWUgY2FuIGJlIGFjY2Vzc2VkIG9u IHRoZSBkb2N1bWVudCB3aXRoIGluZGV4aW5nIG5vdGF0aW9uLgorU1VDQ0VTUwpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L2dldC1pZnJhbWUtd2l0aC1pbnRlZ2VyLW5h bWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRG9jdW1lbnQv Z2V0LWlmcmFtZS13aXRoLWludGVnZXItbmFtZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L2dldC1pZnJhbWUtd2l0aC1pbnRlZ2VyLW5hbWUu aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNyBAQAorPGh0bWw+Cis8c2NyaXB0PgoraWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYgKGRvY3VtZW50Wycx J10gJiYgZG9jdW1lbnRbMV0pCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1 bHQnKS5pbm5lckhUTUwgPSAnU1VDQ0VTUyc7Cit9Cis8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0n cnVuVGVzdCgpJz4KKyAgICA8aWZyYW1lIG5hbWU9JzEnPjwvaWZyYW1lPgorICAgIDxkaXY+VGhp cyB0ZXN0cyB0aGF0IGFuIGlmcmFtZSB3aXRoIGFuIGludGVnZXIgbmFtZSBjYW4gYmUgYWNjZXNz ZWQgb24gdGhlIGRvY3VtZW50IHdpdGggaW5kZXhpbmcgbm90YXRpb24uPC9kaXY+CisgICAgPGRp diBpZD0ncmVzdWx0Jz5GQUlMVVJFPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CisK