34194 2010-01-26 20:07:57 -0800 [BREWMP] Add conversions between IntPoint and AEEPoint 2010-02-02 02:27:34 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue eric oldest_to_newest 184911 0 skyul 2010-01-26 20:07:57 -0800 AEEPoint is the data type used by BREWMP to represent a point. 184914 1 47486 skyul 2010-01-26 20:12:12 -0800 Created attachment 47486 Add conversions between IntPoint and AEEPoint 186606 2 47486 eric 2010-02-01 15:40:48 -0800 Comment on attachment 47486 Add conversions between IntPoint and AEEPoint 4 : m_x(static_cast<int>(point.x)) 35 , m_y(static_cast<int>(point.y)) Why do you need static_cast? Shouldn't an int16 expand to an int32 without cast? Otherewise looks fine. 186698 3 47880 skyul 2010-02-01 16:48:28 -0800 Created attachment 47880 Add conversions between IntPoint and AEEPoint Eric, you are right. I removed static_cast from int16 to int32. 186874 4 47880 commit-queue 2010-02-02 02:27:27 -0800 Comment on attachment 47880 Add conversions between IntPoint and AEEPoint Clearing flags on attachment: 47880 Committed r54219: <http://trac.webkit.org/changeset/54219> 186875 5 commit-queue 2010-02-02 02:27:34 -0800 All reviewed patches have been landed. Closing bug. 47486 2010-01-26 20:12:12 -0800 2010-02-01 16:48:28 -0800 Add conversions between IntPoint and AEEPoint AEEPoint.patch text/plain 3479 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Mzg4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMjYgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBBZGQgY29udmVyc2lvbnMgYmV0d2VlbiBJbnRQb2ludCBhbmQgQUVFUG9pbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MTk0CisK KyAgICAgICAgTWFrZSBpdCBlYXN5IHRvIGNvbnZlcnQgYmV0d2VlbiBJbnRQb2ludCBhbmQgQUVF UG9pbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JyZXcvSW50UG9pbnRCcmV3LmNwcDogQWRkZWQuCisgICAg ICAgIChXZWJDb3JlOjpJbnRQb2ludDo6SW50UG9pbnQpOgorICAgICAgICAoV2ViQ29yZTo6SW50 UG9pbnQ6Om9wZXJhdG9yIEFFRVBvaW50KToKKwogMjAxMC0wMS0yNiAgRG1pdHJ5IFRpdG92ICA8 ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQsIGF0dGVtcHQgdG8g Zml4IFRpZ2VyIGJ1aWxkLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2lu dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaAko cmV2aXNpb24gNTM4NzIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmgJ KHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDEwIEBAIGNsYXNzIEJQb2ludDsKIGNsYXNzIHd4 UG9pbnQ7CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEJSRVdNUCkKK3R5cGVkZWYgc3RydWN0IF9w b2ludCBBRUVQb2ludDsKKyNlbmRpZgorCiAjaWYgUExBVEZPUk0oU0tJQSkKIHN0cnVjdCBTa1Bv aW50Owogc3RydWN0IFNrSVBvaW50OwpAQCAtMTMzLDYgKzEzNywxMSBAQCBwdWJsaWM6CiAgICAg b3BlcmF0b3Igd3hQb2ludCgpIGNvbnN0OwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShCUkVXTVAp CisgICAgSW50UG9pbnQoY29uc3QgQUVFUG9pbnQmKTsKKyAgICBvcGVyYXRvciBBRUVQb2ludCgp IGNvbnN0OworI2VuZGlmCisKICNpZiBQTEFURk9STShTS0lBKQogICAgIEludFBvaW50KGNvbnN0 IFNrSVBvaW50Jik7CiAgICAgb3BlcmF0b3IgU2tJUG9pbnQoKSBjb25zdDsKSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYnJldy9JbnRQb2ludEJyZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYnJldy9JbnRQb2ludEJyZXcuY3BwCShyZXZpc2lv biAwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9icmV3L0ludFBvaW50QnJldy5jcHAJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDggQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMDkg Q29tcGFueSAxMDAsIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK KyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3Vy Y2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRo aXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAy LiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3Zl IGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Ig b3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAqCisgKiBU SElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIENPTVBVVEVSLCBJTkMuIGBgQVMgSVMn JyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVND TEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgQ09NUFVURVIsIElOQy4gT1IKKyAqIENP TlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFM LCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xV RElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBH T09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCisgKiBQUk9GSVRTOyBPUiBC VVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCisg KiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9S IFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4g QU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJ U0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAi Y29uZmlnLmgiCisjaW5jbHVkZSAiSW50UG9pbnQuaCIKKworI2luY2x1ZGUgPEFFRVBvaW50Lmg+ CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworSW50UG9pbnQ6OkludFBvaW50KGNvbnN0IEFFRVBv aW50JiBwb2ludCkKKyAgICA6IG1feChzdGF0aWNfY2FzdDxpbnQ+KHBvaW50LngpKQorICAgICwg bV95KHN0YXRpY19jYXN0PGludD4ocG9pbnQueSkpCit7Cit9CisKK0ludFBvaW50OjpvcGVyYXRv ciBBRUVQb2ludCgpIGNvbnN0Cit7CisgICAgQUVFUG9pbnQgcG9pbnQ7CisgICAgcG9pbnQueCA9 IHN0YXRpY19jYXN0PGludDE2PihtX3gpOworICAgIHBvaW50LnkgPSBzdGF0aWNfY2FzdDxpbnQx Nj4obV95KTsKKyAgICByZXR1cm4gcG9pbnQ7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUK Kwo= 47880 2010-02-01 16:48:28 -0800 2010-02-02 02:27:27 -0800 Add conversions between IntPoint and AEEPoint IntPoint.patch text/plain 3429 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDE3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMDEgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBBZGQgY29udmVyc2lvbnMgYmV0d2VlbiBJbnRQb2ludCBhbmQgQUVFUG9pbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MTk0CisK KyAgICAgICAgTWFrZSBpdCBlYXN5IHRvIGNvbnZlcnQgYmV0d2VlbiBJbnRQb2ludCBhbmQgQUVF UG9pbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JyZXcvSW50UG9pbnRCcmV3LmNwcDogQWRkZWQuCisgICAg ICAgIChXZWJDb3JlOjpJbnRQb2ludDo6SW50UG9pbnQpOgorICAgICAgICAoV2ViQ29yZTo6SW50 UG9pbnQ6Om9wZXJhdG9yIEFFRVBvaW50KToKKwogMjAxMC0wMi0wMSAgU3RldmUgQmxvY2sgIDxz dGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQXJpeWEgSGlkYXlh dC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmgJKHJldmlzaW9uIDU0MTcx KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oCSh3b3JraW5nIGNvcHkp CkBAIC02Myw2ICs2MywxMCBAQCBjbGFzcyBCUG9pbnQ7CiBjbGFzcyB3eFBvaW50OwogI2VuZGlm CiAKKyNpZiBQTEFURk9STShCUkVXTVApCit0eXBlZGVmIHN0cnVjdCBfcG9pbnQgQUVFUG9pbnQ7 CisjZW5kaWYKKwogI2lmIFBMQVRGT1JNKFNLSUEpCiBzdHJ1Y3QgU2tQb2ludDsKIHN0cnVjdCBT a0lQb2ludDsKQEAgLTEzMyw2ICsxMzcsMTEgQEAgcHVibGljOgogICAgIG9wZXJhdG9yIHd4UG9p bnQoKSBjb25zdDsKICNlbmRpZgogCisjaWYgUExBVEZPUk0oQlJFV01QKQorICAgIEludFBvaW50 KGNvbnN0IEFFRVBvaW50Jik7CisgICAgb3BlcmF0b3IgQUVFUG9pbnQoKSBjb25zdDsKKyNlbmRp ZgorCiAjaWYgUExBVEZPUk0oU0tJQSkKICAgICBJbnRQb2ludChjb25zdCBTa0lQb2ludCYpOwog ICAgIG9wZXJhdG9yIFNrSVBvaW50KCkgY29uc3Q7CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JyZXcvSW50UG9pbnRCcmV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2JyZXcvSW50UG9pbnRCcmV3LmNwcAkocmV2aXNpb24gMCkKKysrIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYnJldy9JbnRQb2ludEJyZXcuY3BwCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDQ4IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDA5IENvbXBhbnkgMTAwLCBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK KyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCBy ZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRp b25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAq ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFs cyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJ UyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRFUiwgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorICog RVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVE IFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5P IEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVSLCBJTkMuIE9SCisgKiBDT05UUklCVVRPUlMgQkUg TElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAq IEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklD RVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJS VVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZ LCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5D TFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9G IFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2lu Y2x1ZGUgIkludFBvaW50LmgiCisKKyNpbmNsdWRlIDxBRUVQb2ludC5oPgorCituYW1lc3BhY2Ug V2ViQ29yZSB7CisKK0ludFBvaW50OjpJbnRQb2ludChjb25zdCBBRUVQb2ludCYgcG9pbnQpCisg ICAgOiBtX3gocG9pbnQueCkKKyAgICAsIG1feShwb2ludC55KQoreworfQorCitJbnRQb2ludDo6 b3BlcmF0b3IgQUVFUG9pbnQoKSBjb25zdAoreworICAgIEFFRVBvaW50IHBvaW50OworICAgIHBv aW50LnggPSBzdGF0aWNfY2FzdDxpbnQxNj4obV94KTsKKyAgICBwb2ludC55ID0gc3RhdGljX2Nh c3Q8aW50MTY+KG1feSk7CisgICAgcmV0dXJuIHBvaW50OworfQorCit9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCisK