34193 2010-01-26 18:53:38 -0800 webkit-patch: Hangs on bad bugzilla username and completes? 2011-06-24 10:01:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All REOPENED P2 Normal --- 34265 34264 1 cjerdonek webkit-unassigned abarth cjerdonek commit-queue dbates eric joenotcharles oldest_to_newest 184893 0 cjerdonek 2010-01-26 18:53:38 -0800 Looking at the webkit-patch issues, this one is probably already recorded somewhere. I had an experience where webkit-patch hung for a minute and terminated -- apparently because the bugzilla username in my keychain was out of date. I spent another 15 minutes trying to get webkit-patch to work, only to discover later that the commit had already happened! It looks like it got interrupted while trying to mark the bug resolved. It's bad because there is no line of output saying anything like "Committed revision...." -- only "Processing patch 47411 from bug 34060." It's hard to know this means "committed" because the next output line says it is parsing the Changelog. It seems like the ChangeLog would be parsed before it starts committing. It would also be good if the error says what remaining steps didn't complete, so the user knows what remaining steps need to be manually completed. See below: $ WebKitTools/Scripts/webkit-patch land-from-bug --no-build --ignore-builders 34060 Fetching: https://bugs.webkit.org/show_bug.cgi?id=34060&ctype=xml 1 reviewed patch found on bug 34060. Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 47411 from bug 34060. Parsing ChangeLog: WebKitTools/ChangeLog Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Logging in as chris.jerdonek@gmail.com... Traceback (most recent call last): File "WebKitTools/Scripts/webkit-patch", line 108, in <module> WebKitPatch().main() File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main return command.check_arguments_and_execute(options, args, self) File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/commands/download.py", line 116, in execute self._process_patch(patch, options, args, tool) File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/commands/download.py", line 135, in _process_patch self._main_sequence.run_and_handle_errors(tool, options, state) File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors self._run(tool, options, state) File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run step(tool, options).run(state) File "/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/steps/closepatch.py", line 36, in run self._tool.bugs.clear_attachment_flags(state["patch"].id(), comment_text) File "/Users/chris_g4/dev/apple/WebKit-svn/WebKitTools/Scripts/webkitpy/bugzilla.py", line 632, in clear_attachment_flags self.authenticate() File "/Users/chris_g4/dev/apple/WebKit-svn/WebKitTools/Scripts/webkitpy/bugzilla.py", line 476, in authenticate "index.cgi?GoAheadAndLogIn=1") File "./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_mechanize.py", line 209, in open File "./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_mechanize.py", line 236, in _mech_open File "./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_opener.py", line 191, in open File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 401, in _open '_open', req) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain result = func(*args) File "./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_http.py", line 756, in https_open File "./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_http.py", line 706, in do_open urllib2.URLError: <urlopen error [Errno 60] Operation timed out> stonewall:WebKit-svn chris_g4$ 185088 1 47530 joenotcharles 2010-01-27 07:18:57 -0800 Created attachment 47530 patch to limit number of login attempts As a first cut, lets cap the number of login attempts so that noninteractive logins don't get stuck if the credentials are wrong 185353 2 47530 abarth 2010-01-27 23:43:03 -0800 Comment on attachment 47530 patch to limit number of login attempts Ok, but it seems like it should prompt you when the stored credentials don't work out. 185367 3 47530 commit-queue 2010-01-28 00:12:38 -0800 Comment on attachment 47530 patch to limit number of login attempts Clearing flags on attachment: 47530 Committed r53976: <http://trac.webkit.org/changeset/53976> 185368 4 commit-queue 2010-01-28 00:12:45 -0800 All reviewed patches have been landed. Closing bug. 185388 5 cjerdonek 2010-01-28 01:48:42 -0800 (In reply to comment #3) > (From update of attachment 47530 [details]) > Clearing flags on attachment: 47530 > > Committed r53976: <http://trac.webkit.org/changeset/53976> Thanks a lot for addressing this so quickly! I mentioned a couple other things though-- > It's bad because there is no line of > output saying anything like "Committed revision...." -- only "Processing > patch 47411 from bug 34060." It's hard to know this means "committed" > because the next output line says it is parsing the Changelog. It seems > like the ChangeLog would be parsed before it starts committing. It > would also be good if the error says what remaining steps didn't > complete, so the user knows what remaining steps need to be manually > completed. And Joe, you acknowledged that this is a "first cut". Could you preserve the other suggestions in a report that is not marked RESOLVED (or alternatively, re-open this one), or explain why the commit makes it unnecessary to address the other suggestions? Thanks a lot. 185466 6 joenotcharles 2010-01-28 06:52:09 -0800 I don't think I can reopen the bug, since I wasn't the submitter (at least, I don't see a link for that anywhere). Can you file a new bug with a "depends on" field for this one, with the title something like "webkit-patch does not clearly state whether it committed or not" since the actual hang has been dealt with? (Or else just reopen this one and change the title, if possible.) This does point out a disturbing lack of atomicity - as I understand it, the patch was landed to svn ok, since your svn login was correct, but then the associated bug wasn't updated in bugzilla, since the bugzilla login was not. Maybe it should login to bugzilla first and not push to svn unless that succeeded? It could still fail if there's a timeout or bugzilla service outage, though I guess the best approach would be, if any step failed, print out a nice big, "WARNING: the following steps were completed: ... But the following were NOT, you need to do them manually: ..." 185470 7 cjerdonek 2010-01-28 07:05:33 -0800 (In reply to comment #6) > I don't think I can reopen the bug, since I wasn't the submitter (at least, I > don't see a link for that anywhere). Can you file a new bug with a "depends > on" field for this one, with the title something like "webkit-patch does not > clearly state whether it committed or not" since the actual hang has been dealt > with? (Or else just reopen this one and change the title, if possible.) > > This does point out a disturbing lack of atomicity - as I understand it, the > patch was landed to svn ok, since your svn login was correct, but then the > associated bug wasn't updated in bugzilla, since the bugzilla login was not. > Maybe it should login to bugzilla first and not push to svn unless that > succeeded? It could still fail if there's a timeout or bugzilla service > outage, though > > I guess the best approach would be, if any step failed, print out a nice big, > "WARNING: the following steps were completed: ... But the following were NOT, > you need to do them manually: ..." Thanks, Joe. I'll go ahead and create new bugs, etc. for you right now. In the meantime, you can ask Maciej (or maybe Eric or someone) to grant you the editbugs privilege so you'll be able to reorganize/edit bugs yourself in the future. 185473 8 cjerdonek 2010-01-28 07:11:28 -0800 (In reply to comment #7) > Thanks, Joe. I'll go ahead and create new bugs, etc. for you right now. See the two bugs this depends on for the two issues remaining before this report should be marked resolved. 185500 9 abarth 2010-01-28 08:36:22 -0800 In general, we prefer to have one patch per bug. Bugs are cheap, so you might as well open new ones instead of reopening old ones. These are all great suggestions, by the way. We're very interested in improving the error handling for webkit-patch. That's one of it's major weak points at the moment. 185504 10 cjerdonek 2010-01-28 08:46:39 -0800 (In reply to comment #9) > In general, we prefer to have one patch per bug. Bugs are cheap, so you might > as well open new ones instead of reopening old ones. I agree with one patch per bug. In addition to reopening this one, I did open two new bugs. I just reopened this one to serve as the master bug for the other two (since it is the original report of all the issues). This report can be closed when the other two are resolved, without submitting further patches to this report. Or you can close this now. Whatever works best for you guys to keep track of the issues. Thanks! 185509 11 abarth 2010-01-28 08:49:26 -0800 It's certainly fine to keep this bug open as a meta bug. I was just spamming with generic advice. 426940 12 eric 2011-06-24 10:01:01 -0700 Is this still an issue? 47530 2010-01-27 07:18:57 -0800 2010-06-10 20:43:26 -0700 patch to limit number of login attempts 34193.patch text/plain 1691 joenotcharles ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiZWRlYTY3Li43NzJjNTM0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEt MjcgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIExpbWl0IGxvZ2luIHJldHJpZXMgdG8gNQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQxOTMKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHk6CisKIDIwMTAtMDEtMjcgIEVyaWMgU2Vp ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHkKaW5kZXggNmMyMjk1YS4u YzFjZjQxZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxs YS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5CkBAIC00 NjcsNyArNDY3LDkgQEAgY2xhc3MgQnVnemlsbGEob2JqZWN0KToKICAgICAgICAgICAgIHNlbGYu YXV0aGVudGljYXRlZCA9IFRydWUKICAgICAgICAgICAgIHJldHVybgogCisgICAgICAgIGF0dGVt cHRzID0gMAogICAgICAgICB3aGlsZSBub3Qgc2VsZi5hdXRoZW50aWNhdGVkOgorICAgICAgICAg ICAgYXR0ZW1wdHMgKz0gMQogICAgICAgICAgICAgKHVzZXJuYW1lLCBwYXNzd29yZCkgPSBDcmVk ZW50aWFscygKICAgICAgICAgICAgICAgICBzZWxmLmJ1Z19zZXJ2ZXJfaG9zdCwgZ2l0X3ByZWZp eD0iYnVnemlsbGEiKS5yZWFkX2NyZWRlbnRpYWxzKCkKIApAQCAtNDgzLDcgKzQ4NSwxMiBAQCBj bGFzcyBCdWd6aWxsYShvYmplY3QpOgogICAgICAgICAgICAgIyBJZiB0aGUgcmVzdWx0aW5nIHBh Z2UgaGFzIGEgdGl0bGUsIGFuZCBpdCBjb250YWlucyB0aGUgd29yZAogICAgICAgICAgICAgIyAi aW52YWxpZCIgYXNzdW1lIGl0J3MgdGhlIGxvZ2luIGZhaWx1cmUgcGFnZS4KICAgICAgICAgICAg IGlmIG1hdGNoIGFuZCByZS5zZWFyY2goIkludmFsaWQiLCBtYXRjaC5ncm91cCgxKSwgcmUuSUdO T1JFQ0FTRSk6Ci0gICAgICAgICAgICAgICAgbG9nKCJCdWd6aWxsYSBsb2dpbiBmYWlsZWQ6ICVz IiAlIG1hdGNoLmdyb3VwKDEpKQorICAgICAgICAgICAgICAgIGVycm9yTWVzc2FnZSA9ICJCdWd6 aWxsYSBsb2dpbiBmYWlsZWQ6ICVzIiAlIG1hdGNoLmdyb3VwKDEpCisgICAgICAgICAgICAgICAg IyByYWlzZSBhbiBleGNlcHRpb24gb25seSBpZiB0aGlzIHdhcyB0aGUgbGFzdCBhdHRlbXB0Cisg ICAgICAgICAgICAgICAgaWYgYXR0ZW1wdHMgPCA1OgorICAgICAgICAgICAgICAgICAgICBsb2co ZXJyb3JNZXNzYWdlKQorICAgICAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgICAg IHJhaXNlIEV4Y2VwdGlvbihlcnJvck1lc3NhZ2UpCiAgICAgICAgICAgICBlbHNlOgogICAgICAg ICAgICAgICAgIHNlbGYuYXV0aGVudGljYXRlZCA9IFRydWUKIAo=