34189 2010-01-26 16:07:00 -0800 check-webkit-style failed to complain about missing braces 2014-03-11 07:50:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned abarth aivopaas bburg cjerdonek commit-queue eric glenn hamaji levin llango.u-szeged rniwa oldest_to_newest 184810 0 evan 2010-01-26 16:07:00 -0800 This patch: https://bugs.webkit.org/show_bug.cgi?id=34186#c1 had this diff: ASSERT(U_SUCCESS(error)); + for (unsigned i = 0; i < normalizedString.length(); ++i) + if (Font::treatAsSpace(m_normalizedBuffer[i])) + m_normalizedBuffer[i] = ' '; Which I'm informed lacks parens. But the style bot didn't mind it. 184811 1 evan 2010-01-26 16:07:13 -0800 Er, make that: "... which lacks *braces*." 764111 2 aivopaas 2012-11-11 23:56:12 -0800 @@ -1862,7 +1862,8 @@ bool EventHandler::handleMouseMoveEvent(const PlatformMouseEvent& mouseEvent, Hi if (FrameView* view = m_frame->view()) { OptionalCursor optionalCursor = selectCursor(mev, scrollbar); if (optionalCursor.isCursorChange()) - view->setCursor(optionalCursor.cursor()); + m_currentMouseCursor = optionalCursor.cursor(); + view->setCursor(m_currentMouseCursor); } } 986135 3 bburg 2014-03-02 11:20:29 -0800 Ran into this again in review of https://bugs.webkit.org/show_bug.cgi?id=129388 987625 4 llango.u-szeged 2014-03-06 01:51:50 -0800 I have a draft patch for this. It works fine on the examples you mentioned previously, but it complains about this: if (missedCues[i].data()->startTime() < missedCues[i].data()->endTime()) eventTasks.append(std::make_pair(missedCues[i].data()->endTime(), missedCues[i].data())); I'm a bit confused. Is this false positive or not? Should we use braces in this case? 987660 5 225982 llango.u-szeged 2014-03-06 05:42:00 -0800 Created attachment 225982 Patch 987661 6 llango.u-szeged 2014-03-06 05:43:00 -0800 (In reply to comment #4) > I have a draft patch for this. It works fine on the examples you mentioned previously, but it complains about this: > > if (missedCues[i].data()->startTime() < missedCues[i].data()->endTime()) > eventTasks.append(std::make_pair(missedCues[i].data()->endTime(), > missedCues[i].data())); > > I'm a bit confused. Is this false positive or not? Should we use braces in this case? Meanwhile I found the answer here: http://www.webkit.org/coding/coding-style.html#braces-one-line 989282 7 225982 rniwa 2014-03-11 00:42:55 -0700 Comment on attachment 225982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225982&action=review rs=me. > Tools/Scripts/webkitpy/style/checkers/cpp.py:2407 > + if (match(r'^\s*\b(if|for|foreach|while|else)\b\s', line) We don't want foreach here. 989381 8 226423 llango.u-szeged 2014-03-11 07:12:07 -0700 Created attachment 226423 patch for landing 989391 9 226423 commit-queue 2014-03-11 07:50:55 -0700 Comment on attachment 226423 patch for landing Clearing flags on attachment: 226423 Committed r165451: <http://trac.webkit.org/changeset/165451> 989392 10 commit-queue 2014-03-11 07:50:59 -0700 All reviewed patches have been landed. Closing bug. 225982 2014-03-06 05:42:00 -0800 2014-03-11 07:11:58 -0700 Patch bug-34189-20140306054200.patch text/plain 5605 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MDk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjQwZTc1NGVlMGNmYmI3NjU2ZWFkYTE5NjU5Mzg0M2E1 MjM5M2RmOC4uMTUwNjI4MzY3MGEzMTBmMWMzYTNlNTNkZTc5NjEyNGJkZTkzNjIzMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAzLTA2ICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgZmFpbGVkIHRvIGNv bXBsYWluIGFib3V0IG1pc3NpbmcgYnJhY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNDE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHk6CisgICAgICAgIChjaGVja19icmFjZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0 LnRlc3RfYnJhY2VzKToKKwogMjAxNC0wMy0wNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFByZXBhcmluZyB0byBydW4gbGF5b3V0IHRlc3Rz IG9uIFdpbmNhaXJvLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weQppbmRleCA5ZDEyNGVkOGQ5YWNiMTNhMmQ1ZmUwZTYyOTFmMzJmYWZhYWRjYjdhLi42ZWNj NGU3ZWE4NjkzNGZjNWQxYzZmMzFmMTUzMjFiZmFmYzAxYjZiIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjQwMiw2ICsyNDAyLDMzIEBAIGRl ZiBjaGVja19icmFjZXMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAg IGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9uZXdsaW5lJywgNCwKICAgICAgICAgICAg ICAgJ2RvL3doaWxlIGNsYXVzZXMgc2hvdWxkIG5vdCBiZSBvbiBhIHNpbmdsZSBsaW5lJykKIAor ICAgICMgTXVsdGkgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxkIHVzZSBicmFjZXMuIFdlIGNo ZWNrIHRoZQorICAgICMgaW5kZW50YXRpb24gbGV2ZWwgb2YgdGhlIHN0YXRlbWVudHMuCisgICAg aWYgKG1hdGNoKHInXlxzKlxiKGlmfGZvcnxmb3JlYWNofHdoaWxlfGVsc2UpXGJccycsIGxpbmUp CisgICAgICAgIGFuZCBtYXRjaChyJy4qW157XSQnLCBsaW5lKQorICAgICAgICBhbmQgbGVuKGNs ZWFuX2xpbmVzLmVsaWRlZCkgPiBsaW5lX251bWJlciArIDIpOgorICAgICAgICBoYXNfYnJhY2Vz ID0gRmFsc2UKKyAgICAgICAgYmVnaW5fbGluZSA9IGxpbmUKKyAgICAgICAgYmVnaW5fbGluZV9u dW1iZXIgPSBsaW5lX251bWJlcgorICAgICAgICB3aGlsZSAoY2xlYW5fbGluZXMuZWxpZGVkW2Jl Z2luX2xpbmVfbnVtYmVyICsgMV0uc3RyaXAoKS5zdGFydHN3aXRoKCImJiIpCisgICAgICAgICAg ICBvciBjbGVhbl9saW5lcy5lbGlkZWRbYmVnaW5fbGluZV9udW1iZXIgKyAxXS5zdHJpcCgpLnN0 YXJ0c3dpdGgoInx8IikKKyAgICAgICAgICAgIG9yIHNlYXJjaChyJ14jXFMqJywgY2xlYW5fbGlu ZXMuZWxpZGVkW2JlZ2luX2xpbmVfbnVtYmVyICsgMV0pKToKKyAgICAgICAgICAgIGJlZ2luX2xp bmVfbnVtYmVyID0gYmVnaW5fbGluZV9udW1iZXIgKyAxCisgICAgICAgICAgICBiZWdpbl9saW5l ID0gY2xlYW5fbGluZXMuZWxpZGVkW2JlZ2luX2xpbmVfbnVtYmVyXQorICAgICAgICAgICAgaWYg c2VhcmNoKHInLip7JCcsIGJlZ2luX2xpbmUpOgorICAgICAgICAgICAgICAgIGhhc19icmFjZXMg PSBUcnVlCisKKyAgICAgICAgbmV4dF9saW5lID0gY2xlYW5fbGluZXMuZWxpZGVkW2JlZ2luX2xp bmVfbnVtYmVyICsgMV0KKyAgICAgICAgYWZ0ZXJfbmV4dF9saW5lID0gY2xlYW5fbGluZXMuZWxp ZGVkW2JlZ2luX2xpbmVfbnVtYmVyICsgMl0KKyAgICAgICAgY29udHJvbF9pbmRlbnQgPSBzZWFy Y2gocideKD9QPGluZGVudGF0aW9uPlxzKikuKicsIGxpbmUpLmdyb3VwKCdpbmRlbnRhdGlvbicp CisgICAgICAgIG5leHRfbGluZV9pbmRlbnQgPSBzZWFyY2gocideKD9QPGluZGVudGF0aW9uPlxz KikuKicsIG5leHRfbGluZSkuZ3JvdXAoJ2luZGVudGF0aW9uJykKKyAgICAgICAgYWZ0ZXJfbmV4 dF9saW5lX2luZGVudCA9IHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKS4qJywgYWZ0ZXJf bmV4dF9saW5lKS5ncm91cCgnaW5kZW50YXRpb24nKQorICAgICAgICBpZiAoYWZ0ZXJfbmV4dF9s aW5lICE9ICcnCisgICAgICAgICAgICBhbmQgbm90IGhhc19icmFjZXMKKyAgICAgICAgICAgIGFu ZCBjb250cm9sX2luZGVudCA8IG5leHRfbGluZV9pbmRlbnQKKyAgICAgICAgICAgIGFuZCBjb250 cm9sX2luZGVudCA8IGFmdGVyX25leHRfbGluZV9pbmRlbnQpOgorICAgICAgICAgICAgZXJyb3Io bGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2JyYWNlcycsIDQsICdNdWx0aSBsaW5lIGNvbnRyb2wg Y2xhdXNlcyBzaG91bGQgdXNlIGJyYWNlcy4nKQorCiAgICAgIyBCcmFjZXMgc2hvdWxkbid0IGJl IGZvbGxvd2VkIGJ5IGEgOyB1bmxlc3MgdGhleSdyZSBkZWZpbmluZyBhIHN0cnVjdAogICAgICMg b3IgaW5pdGlhbGl6aW5nIGFuIGFycmF5LgogICAgICMgV2UgY2FuJ3QgdGVsbCBpbiBnZW5lcmFs LCBidXQgd2UgY2FuIGZvciBzb21lIGNvbW1vbiBjYXNlcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZDI2MGI1 YmZkMGU2YzBlZDY2NzI0MjAwZmFhYmRjM2YxOTc1NWUyOS4uNGYwN2RhZjIxODNhOTMxZmU0MjFi ZTgxYjU4YzJhN2M0MGUxYTg3NiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTQ0MDMsNiArNDQwMyw1NiBAQCBj bGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNz ZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICd9IHdoaWxlICh0cnVlKTtcbicsCiAg ICAgICAgICAgICAnJykKKyAgICAgICAgIyA1LiBNdWx0aSBsaW5lIGNvbnRyb2wgY2xhdXNlcyBz aG91bGQgdXNlIGJyYWNlcy4KKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAor ICAgICAgICAgICAgJ2ZvciAoIDsgYzEgJiYgYzIgOyApXG4nCisgICAgICAgICAgICAnICAgIGlm IChjb25kaXRpb24xICYmIGNvbmRpdGlvbjIpXG4nCisgICAgICAgICAgICAnICAgICAgICBpID0g MTtcbicsCisgICAgICAgICAgICAnTXVsdGkgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxkIHVz ZSBicmFjZXMuICBbd2hpdGVzcGFjZS9icmFjZXNdIFs0XScpCisgICAgICAgIHNlbGYuYXNzZXJ0 X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcgICAgaWYgKGNvbmRpdGlvbilcbicKKyAg ICAgICAgICAgICcgICAgICAgIGkgPSAxO1xuJworICAgICAgICAgICAgJyAgICAgICAgaiA9IDE7 XG4nLAorICAgICAgICAgICAgJ011bHRpIGxpbmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCB1c2Ug YnJhY2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9t dWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIGlmIChjb25kaXRpb24xXG4nCisgICAg ICAgICAgICAnICAgICAgICB8fCBjb25kaXRpb24yXG4nCisgICAgICAgICAgICAnICAgICAgICAm JiBjb25kaXRpb24zKVxuJworICAgICAgICAgICAgJyAgICAgICAgaSA9IDE7XG4nCisgICAgICAg ICAgICAnICAgICAgICBqID0gMTtcbicsCisgICAgICAgICAgICAnTXVsdGkgbGluZSBjb250cm9s IGNsYXVzZXMgc2hvdWxkIHVzZSBicmFjZXMuICBbd2hpdGVzcGFjZS9icmFjZXNdIFs0XScpCisg ICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcgICAgaWYg KGNvbmRpdGlvbjFcbicKKyAgICAgICAgICAgICcgICAgICAgIHx8IGNvbmRpdGlvbjJcbicKKyAg ICAgICAgICAgICcgICAgICAgICYmIGNvbmRpdGlvbjMpIHtcbicKKyAgICAgICAgICAgICcgICAg ICAgIGkgPSAxO1xuJworICAgICAgICAgICAgJyAgICAgICAgaiA9IDE7XG4nCisgICAgICAgICAg ICAnICAgIH1cbicsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlf bGluZV9saW50KAorICAgICAgICAgICAgJ2lmIChjb25kaXRpb24pXG4nCisgICAgICAgICAgICAn I2lmZGVmIFNPTUVUSElOR1xuJworICAgICAgICAgICAgJyAgICBpID0gMTtcbicKKyAgICAgICAg ICAgICcjZW5kaWZcbicsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVs dGlfbGluZV9saW50KAorICAgICAgICAgICAgJyNpZmRlZiBTT01FVEhJTkdcbicKKyAgICAgICAg ICAgICdpZiAoY29uZGl0aW9uKVxuJworICAgICAgICAgICAgJyNlbmRpZlxuJworICAgICAgICAg ICAgJyAgICAvLyBTb21lIGNvbW1lbnRcbicKKyAgICAgICAgICAgICcgICAgaSA9IDE7XG4nLAor ICAgICAgICAgICAgJ011bHRpIGxpbmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCB1c2UgYnJhY2Vz LiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9s aW5lX2xpbnQoCisgICAgICAgICAgICAnaWYgKGNvbmRpdGlvbilcbicKKyAgICAgICAgICAgICcg ICAgbXlGdW5jdGlvbihyZWFsbHlMb25nUGFyYW0xLCByZWFsbHlMb25nUGFyYW0yLCAuLi5cbicK KyAgICAgICAgICAgICcgICAgICAgIHJlYWxseUxvbmdQYXJhbTUpO1xuJywKKyAgICAgICAgICAg ICdNdWx0aSBsaW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91bGQgdXNlIGJyYWNlcy4gIFt3aGl0ZXNw YWNlL2JyYWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAor ICAgICAgICAgICAgJ2lmIChjb25kaXRpb24pIHtcbicKKyAgICAgICAgICAgICcgICAgbXlGdW5j dGlvbihyZWFsbHlMb25nUGFyYW0xLCByZWFsbHlMb25nUGFyYW0yLCAuLi5cbicKKyAgICAgICAg ICAgICcgICAgICAgIHJlYWxseUxvbmdQYXJhbTUpO1xuJworICAgICAgICAgICAgJyAgICB9XG4n LAorICAgICAgICAgICAgJycpCiAKICAgICBkZWYgdGVzdF9udWxsX2ZhbHNlX3plcm8oc2VsZik6 CiAgICAgICAgICMgMS4gSW4gQysrLCB0aGUgbnVsbCBwb2ludGVyIHZhbHVlIHNob3VsZCBiZSB3 cml0dGVuIGFzIDAuIEluIEMsCg== 226423 2014-03-11 07:12:07 -0700 2014-03-11 07:50:55 -0700 patch for landing bug-34189-20140311151205.patch text/plain 5657 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjBmODE0NTQzOTg5MTJiMTkyYjY4MDVkZGU3M2ViNzdl M2IwM2JjOC4uNDUwNDMzZWQ3YTBiNDVlOWI1Mjg2Yzk3MDlhZGQ2MDkwYTk0MGMzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3 IEBACiAyMDE0LTAzLTExICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KIAorICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgZmFpbGVkIHRvIGNv bXBsYWluIGFib3V0IG1pc3NpbmcgYnJhY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNDE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2Ug Tml3YS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 OgorICAgICAgICAoY2hlY2tfYnJhY2VzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50 ZXN0X2JyYWNlcyk6CisKKzIwMTQtMDMtMTEgIEzDoXN6bMOzIExhbmfDsyAgPGxsYW5nby51LXN6 ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCiAgICAgICAgIFJlbW92ZSBRdCBjcnVmdCBmcm9t IHN0eWxlIGNoZWNrZXIuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzAwODUKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weQppbmRleCA4NzY0OWFkNGIzYzA4MTMwYTU5ZmQ3YzA4MzA5ODI3MjdhNTAzY2VhLi4z MDI2NDcyYmY5OGM5ZTU2Y2RmNDgxMzIxNDFhMDAxZWUwODFkMTlhIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjQwMSw2ICsyNDAxLDMzIEBA IGRlZiBjaGVja19icmFjZXMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAg ICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9uZXdsaW5lJywgNCwKICAgICAgICAg ICAgICAgJ2RvL3doaWxlIGNsYXVzZXMgc2hvdWxkIG5vdCBiZSBvbiBhIHNpbmdsZSBsaW5lJykK IAorICAgICMgTXVsdGkgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxkIHVzZSBicmFjZXMuIFdl IGNoZWNrIHRoZQorICAgICMgaW5kZW50YXRpb24gbGV2ZWwgb2YgdGhlIHN0YXRlbWVudHMuCisg ICAgaWYgKG1hdGNoKHInXlxzKlxiKGlmfGZvcnx3aGlsZXxlbHNlKVxiXHMnLCBsaW5lKQorICAg ICAgICBhbmQgbWF0Y2gocicuKltee10kJywgbGluZSkKKyAgICAgICAgYW5kIGxlbihjbGVhbl9s aW5lcy5lbGlkZWQpID4gbGluZV9udW1iZXIgKyAyKToKKyAgICAgICAgaGFzX2JyYWNlcyA9IEZh bHNlCisgICAgICAgIGJlZ2luX2xpbmUgPSBsaW5lCisgICAgICAgIGJlZ2luX2xpbmVfbnVtYmVy ID0gbGluZV9udW1iZXIKKyAgICAgICAgd2hpbGUgKGNsZWFuX2xpbmVzLmVsaWRlZFtiZWdpbl9s aW5lX251bWJlciArIDFdLnN0cmlwKCkuc3RhcnRzd2l0aCgiJiYiKQorICAgICAgICAgICAgb3Ig Y2xlYW5fbGluZXMuZWxpZGVkW2JlZ2luX2xpbmVfbnVtYmVyICsgMV0uc3RyaXAoKS5zdGFydHN3 aXRoKCJ8fCIpCisgICAgICAgICAgICBvciBzZWFyY2gocideI1xTKicsIGNsZWFuX2xpbmVzLmVs aWRlZFtiZWdpbl9saW5lX251bWJlciArIDFdKSk6CisgICAgICAgICAgICBiZWdpbl9saW5lX251 bWJlciA9IGJlZ2luX2xpbmVfbnVtYmVyICsgMQorICAgICAgICAgICAgYmVnaW5fbGluZSA9IGNs ZWFuX2xpbmVzLmVsaWRlZFtiZWdpbl9saW5lX251bWJlcl0KKyAgICAgICAgICAgIGlmIHNlYXJj aChyJy4qeyQnLCBiZWdpbl9saW5lKToKKyAgICAgICAgICAgICAgICBoYXNfYnJhY2VzID0gVHJ1 ZQorCisgICAgICAgIG5leHRfbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtiZWdpbl9saW5lX251 bWJlciArIDFdCisgICAgICAgIGFmdGVyX25leHRfbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFti ZWdpbl9saW5lX251bWJlciArIDJdCisgICAgICAgIGNvbnRyb2xfaW5kZW50ID0gc2VhcmNoKHIn Xig/UDxpbmRlbnRhdGlvbj5ccyopLionLCBsaW5lKS5ncm91cCgnaW5kZW50YXRpb24nKQorICAg ICAgICBuZXh0X2xpbmVfaW5kZW50ID0gc2VhcmNoKHInXig/UDxpbmRlbnRhdGlvbj5ccyopLion LCBuZXh0X2xpbmUpLmdyb3VwKCdpbmRlbnRhdGlvbicpCisgICAgICAgIGFmdGVyX25leHRfbGlu ZV9pbmRlbnQgPSBzZWFyY2gocideKD9QPGluZGVudGF0aW9uPlxzKikuKicsIGFmdGVyX25leHRf bGluZSkuZ3JvdXAoJ2luZGVudGF0aW9uJykKKyAgICAgICAgaWYgKGFmdGVyX25leHRfbGluZSAh PSAnJworICAgICAgICAgICAgYW5kIG5vdCBoYXNfYnJhY2VzCisgICAgICAgICAgICBhbmQgY29u dHJvbF9pbmRlbnQgPCBuZXh0X2xpbmVfaW5kZW50CisgICAgICAgICAgICBhbmQgY29udHJvbF9p bmRlbnQgPCBhZnRlcl9uZXh0X2xpbmVfaW5kZW50KToKKyAgICAgICAgICAgIGVycm9yKGxpbmVf bnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMnLCA0LCAnTXVsdGkgbGluZSBjb250cm9sIGNsYXVz ZXMgc2hvdWxkIHVzZSBicmFjZXMuJykKKwogICAgICMgQnJhY2VzIHNob3VsZG4ndCBiZSBmb2xs b3dlZCBieSBhIDsgdW5sZXNzIHRoZXkncmUgZGVmaW5pbmcgYSBzdHJ1Y3QKICAgICAjIG9yIGlu aXRpYWxpemluZyBhbiBhcnJheS4KICAgICAjIFdlIGNhbid0IHRlbGwgaW4gZ2VuZXJhbCwgYnV0 IHdlIGNhbiBmb3Igc29tZSBjb21tb24gY2FzZXMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDgyNDJiYWY1ODQw ZTcyZmI1MzM4ZGJkY2JjMDY3YzBiNzQxNzc2ZWQuLjRjMzI4NzY2OGIxNTA4NTgwYTFmM2VmZmFl M2NjYTJlNzVkYzJlZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC00Mzg2LDYgKzQzODYsNTYgQEAgY2xhc3Mg V2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9t dWx0aV9saW5lX2xpbnQoCiAgICAgICAgICAgICAnfSB3aGlsZSAodHJ1ZSk7XG4nLAogICAgICAg ICAgICAgJycpCisgICAgICAgICMgNS4gTXVsdGkgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxk IHVzZSBicmFjZXMuCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAg ICAgICAgICdmb3IgKCA7IGMxICYmIGMyIDsgKVxuJworICAgICAgICAgICAgJyAgICBpZiAoY29u ZGl0aW9uMSAmJiBjb25kaXRpb24yKVxuJworICAgICAgICAgICAgJyAgICAgICAgaSA9IDE7XG4n LAorICAgICAgICAgICAgJ011bHRpIGxpbmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCB1c2UgYnJh Y2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0 aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIGlmIChjb25kaXRpb24pXG4nCisgICAgICAg ICAgICAnICAgICAgICBpID0gMTtcbicKKyAgICAgICAgICAgICcgICAgICAgIGogPSAxO1xuJywK KyAgICAgICAgICAgICdNdWx0aSBsaW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91bGQgdXNlIGJyYWNl cy4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlf bGluZV9saW50KAorICAgICAgICAgICAgJyAgICBpZiAoY29uZGl0aW9uMVxuJworICAgICAgICAg ICAgJyAgICAgICAgfHwgY29uZGl0aW9uMlxuJworICAgICAgICAgICAgJyAgICAgICAgJiYgY29u ZGl0aW9uMylcbicKKyAgICAgICAgICAgICcgICAgICAgIGkgPSAxO1xuJworICAgICAgICAgICAg JyAgICAgICAgaiA9IDE7XG4nLAorICAgICAgICAgICAgJ011bHRpIGxpbmUgY29udHJvbCBjbGF1 c2VzIHNob3VsZCB1c2UgYnJhY2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nKQorICAgICAg ICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIGlmIChjb25k aXRpb24xXG4nCisgICAgICAgICAgICAnICAgICAgICB8fCBjb25kaXRpb24yXG4nCisgICAgICAg ICAgICAnICAgICAgICAmJiBjb25kaXRpb24zKSB7XG4nCisgICAgICAgICAgICAnICAgICAgICBp ID0gMTtcbicKKyAgICAgICAgICAgICcgICAgICAgIGogPSAxO1xuJworICAgICAgICAgICAgJyAg ICB9XG4nLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVf bGludCgKKyAgICAgICAgICAgICdpZiAoY29uZGl0aW9uKVxuJworICAgICAgICAgICAgJyNpZmRl ZiBTT01FVEhJTkdcbicKKyAgICAgICAgICAgICcgICAgaSA9IDE7XG4nCisgICAgICAgICAgICAn I2VuZGlmXG4nLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xp bmVfbGludCgKKyAgICAgICAgICAgICcjaWZkZWYgU09NRVRISU5HXG4nCisgICAgICAgICAgICAn aWYgKGNvbmRpdGlvbilcbicKKyAgICAgICAgICAgICcjZW5kaWZcbicKKyAgICAgICAgICAgICcg ICAgLy8gU29tZSBjb21tZW50XG4nCisgICAgICAgICAgICAnICAgIGkgPSAxO1xuJywKKyAgICAg ICAgICAgICdNdWx0aSBsaW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91bGQgdXNlIGJyYWNlcy4gIFt3 aGl0ZXNwYWNlL2JyYWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9s aW50KAorICAgICAgICAgICAgJ2lmIChjb25kaXRpb24pXG4nCisgICAgICAgICAgICAnICAgIG15 RnVuY3Rpb24ocmVhbGx5TG9uZ1BhcmFtMSwgcmVhbGx5TG9uZ1BhcmFtMiwgLi4uXG4nCisgICAg ICAgICAgICAnICAgICAgICByZWFsbHlMb25nUGFyYW01KTtcbicsCisgICAgICAgICAgICAnTXVs dGkgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxkIHVzZSBicmFjZXMuICBbd2hpdGVzcGFjZS9i cmFjZXNdIFs0XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAg ICAgICAgICdpZiAoY29uZGl0aW9uKSB7XG4nCisgICAgICAgICAgICAnICAgIG15RnVuY3Rpb24o cmVhbGx5TG9uZ1BhcmFtMSwgcmVhbGx5TG9uZ1BhcmFtMiwgLi4uXG4nCisgICAgICAgICAgICAn ICAgICAgICByZWFsbHlMb25nUGFyYW01KTtcbicKKyAgICAgICAgICAgICcgICAgfVxuJywKKyAg ICAgICAgICAgICcnKQogCiAgICAgZGVmIHRlc3RfbnVsbF9mYWxzZV96ZXJvKHNlbGYpOgogICAg ICAgICAjIDEuIEluIEMrKywgdGhlIG51bGwgcG9pbnRlciB2YWx1ZSBzaG91bGQgYmUgd3JpdHRl biBhcyAwLiBJbiBDLAo=