<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>34168</bug_id>
          
          <creation_ts>2010-01-26 08:43:10 -0800</creation_ts>
          <short_desc>[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms</short_desc>
          <delta_ts>2010-03-22 04:45:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Performance, Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>34208</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>ariya.hidayat</cc>
    
    <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>hausmann</cc>
    
    <cc>ismail</cc>
    
    <cc>kenneth</cc>
    
    <cc>skyul</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>184603</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-01-26 08:43:10 -0800</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=33408 introduces FAST_MOBILE_SCROLLING to disabled fixed background on embedded.
Qt Webkit could define that as well for its embedded platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>184604</commentid>
    <comment_count>1</comment_count>
      <attachid>47414</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-01-26 08:46:18 -0800</bug_when>
    <thetext>Created attachment 47414
Enable the #define for Maemo 5, Qt Embedded and Symbian</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>184605</commentid>
    <comment_count>2</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-01-26 08:51:00 -0800</bug_when>
    <thetext>We have to define if this is really what we want, as it changes the behaviour. Current iPhone and Android doesn&apos;t do anything like this, so this might be problematic.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>184637</commentid>
    <comment_count>3</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-01-26 11:09:59 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; We have to define if this is really what we want, as it changes the behaviour.
&gt; Current iPhone and Android doesn&apos;t do anything like this, so this might be
&gt; problematic.

I might be wrong but I had the impression they were using a virtual viewport of the size of the content. This would essentially give the same results.

Do you have one of those devices to check?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>184711</commentid>
    <comment_count>4</comment_count>
      <attachid>47414</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-26 14:00:09 -0800</bug_when>
    <thetext>Comment on attachment 47414
Enable the #define for Maemo 5, Qt Embedded and Symbian

OK, i trust you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>184713</commentid>
    <comment_count>5</comment_count>
      <attachid>47414</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-26 14:00:49 -0800</bug_when>
    <thetext>Comment on attachment 47414
Enable the #define for Maemo 5, Qt Embedded and Symbian

Hmm... I&apos;ll leave a qter to decide if this should actually be committed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>185001</commentid>
    <comment_count>6</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-01-27 01:45:30 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; We have to define if this is really what we want, as it changes the behaviour.
&gt; Current iPhone and Android doesn&apos;t do anything like this, so this might be
&gt; problematic.

Andreas just tested that on an iPhone, this gives the same behavior.
The way to achieve that is different as I mentioned.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186190</commentid>
    <comment_count>7</comment_count>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-01-31 06:59:16 -0800</bug_when>
    <thetext>I agree. We should certainly enable this for all the said platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186192</commentid>
    <comment_count>8</comment_count>
      <attachid>47414</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-01-31 07:10:40 -0800</bug_when>
    <thetext>Comment on attachment 47414
Enable the #define for Maemo 5, Qt Embedded and Symbian

Let&apos;s do it then!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186194</commentid>
    <comment_count>9</comment_count>
      <attachid>47414</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-31 07:42:41 -0800</bug_when>
    <thetext>Comment on attachment 47414
Enable the #define for Maemo 5, Qt Embedded and Symbian

Clearing flags on attachment: 47414

Committed r54109: &lt;http://trac.webkit.org/changeset/54109&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186195</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-31 07:42:48 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186202</commentid>
    <comment_count>11</comment_count>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2010-01-31 08:33:14 -0800</bug_when>
    <thetext>Not enabled on WinCE on purpose or just missed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186258</commentid>
    <comment_count>12</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-01-31 16:04:53 -0800</bug_when>
    <thetext>Just missed I&apos;m quite sure, feel free to provide a patch :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186266</commentid>
    <comment_count>13</comment_count>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2010-01-31 17:45:18 -0800</bug_when>
    <thetext>The fix is one liner, if WinCE is supposed to be supported I&apos;ll send a patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186320</commentid>
    <comment_count>14</comment_count>
      <attachid>47816</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-02-01 00:13:26 -0800</bug_when>
    <thetext>Created attachment 47816
Enable it for Windows CE

(In reply to comment #12)
&gt; Just missed I&apos;m quite sure, feel free to provide a patch :-)

Sorry, I forgot Qt supports so many platforms :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>186322</commentid>
    <comment_count>15</comment_count>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2010-02-01 00:14:05 -0800</bug_when>
    <thetext>Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202439</commentid>
    <comment_count>16</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-03-22 04:45:39 -0700</bug_when>
    <thetext>Cherry-picked into qtwebkit-4.6 with commit d70761926b1215c30158a7c50809e98b5dc8170c</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47414</attachid>
            <date>2010-01-26 08:46:18 -0800</date>
            <delta_ts>2010-01-31 07:42:41 -0800</delta_ts>
            <desc>Enable the #define for Maemo 5, Qt Embedded and Symbian</desc>
            <filename>enable_fast_mobile_scrolling.patch</filename>
            <type>text/plain</type>
            <size>1013</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NmI0MWUzYS4uN2VjNTNlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0yNiAgQmVuamFtaW4gUG91
bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRW5hYmxlIEZBU1RfTU9CSUxFX1NDUk9M
TElORyBvbiBRdCBlbWJlZGRlZCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MTY4CisKKyAgICAgICAgRW5hYmxlIEZBU1RfTU9CSUxF
X1NDUk9MTElORyBmb3IgUXQgb24gTWFlbW8gNSwgTGludXggZW1iZWRkZWQKKyAgICAgICAgYW5k
IFN5bWJpYW4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDEwLTAxLTI2ICBHYXJyZXQg
S2VsbHkgIDxnZGtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp
ZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1dlYkNvcmUvV2ViQ29yZS5w
cm8KaW5kZXggMmE0YTUxMi4uNDdiNjA5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBy
bworKysgYi9XZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0xMjMsNiArMTIzLDEwIEBAIFJFU09VUkNF
UyArPSBcCiAgICAgUkVTT1VSQ0VTICs9ICQkUFdELy4uL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250
LWVuZC9XZWJLaXQucXJjCiB9CiAKK21hbWVvNXxzeW1iaWFufGVtYmVkZGVkIHsKKyAgICBERUZJ
TkVTICs9IEVOQUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkc9MQorfQorCiBpbmNsdWRlKCQkUFdE
Ly4uL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaSkKIAogIyBEaXNhYmxlIEhUTUw1
IG1lZGlhIGNvbXBpbGF0aW9uIGlmIHBob25vbiBpcyB1bmF2YWlsYWJsZQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47816</attachid>
            <date>2010-02-01 00:13:26 -0800</date>
            <delta_ts>2010-02-01 04:39:47 -0800</delta_ts>
            <desc>Enable it for Windows CE</desc>
            <filename>fast_mobile_scrolling_win_ce.patch</filename>
            <type>text/plain</type>
            <size>917</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZjJlNmI4MC4uMWJlNDJmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMi0wMSAgQmVuamFtaW4gUG91
bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRW5hYmxlIEZBU1RfTU9CSUxFX1NDUk9M
TElORyBvbiBRdCBlbWJlZGRlZCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MTY4CisKKyAgICAgICAgRW5hYmxlIGl0IGZvciBXaW5k
b3dzIENFCisKKyAgICAgICAgKiBXZWJDb3JlLnBybzoKKwogMjAxMC0wMS0zMSAgS2VudCBUYW11
cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmV2ZXJ0IHI1
NDExMiBhbmQgcjU0MTI0IGJlY2F1c2Ugb2YgV2luZG93cyBidWlsZCBlcnJvci4KZGlmZiAtLWdp
dCBhL1dlYkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IGQ3YThj
NzkuLmY4NDc2MzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2ViQ29y
ZS9XZWJDb3JlLnBybwpAQCAtMTI1LDcgKzEyNSw3IEBAIFJFU09VUkNFUyArPSBcCiAgICAgUkVT
T1VSQ0VTICs9ICQkUFdELy4uL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJj
CiB9CiAKLW1hbWVvNXxzeW1iaWFufGVtYmVkZGVkIHsKK21hbWVvNXxzeW1iaWFufGVtYmVkZGVk
fHdpbmNlKiB7CiAgICAgREVGSU5FUyArPSBFTkFCTEVfRkFTVF9NT0JJTEVfU0NST0xMSU5HPTEK
IH0KIAo=
</data>
<flag name="review"
          id="30356"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="30357"
          type_id="3"
          status="+"
          setter="kenneth"
    />
          </attachment>
      

    </bug>

</bugzilla>