3412 2005-06-10 07:52:58 -0700 Object.prototype is missing toLocaleString, isPrototypeOf and propertyIsEnumerable 2005-07-14 10:42:26 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mrowe mrowe ggaren oldest_to_newest 11308 0 mrowe 2005-06-10 07:53:00 -0700 Section 15.2.4 of ECMA-262 specification lists toString, toLocaleString, valueOf, hasOwnProperty, isPrototypeOf and propertyIsEnumerable. WebKit currently only supports toString and valueOf. Bug #3293 covers hasOwnProperty. 11716 1 2293 mrowe 2005-06-13 05:26:56 -0700 Created attachment 2293 Implementation of Object.prototype.toLocaleString 14602 2 ggaren 2005-07-13 16:34:32 -0700 *** Bug 3989 has been marked as a duplicate of this bug. *** 14603 3 2951 ggaren 2005-07-13 16:47:54 -0700 Created attachment 2951 Implementation of Object.prototype.toLocaleString Previous patch had merge conflicts. 14604 4 2952 ggaren 2005-07-13 16:48:45 -0700 Created attachment 2952 /fast/js/object-prototype-toLocaleString.html layout test 14613 5 2951 mjs 2005-07-13 19:53:02 -0700 Comment on attachment 2951 Implementation of Object.prototype.toLocaleString r=me if the testing shows this matches other browsers. 14648 6 2961 ggaren 2005-07-14 10:04:17 -0700 Created attachment 2961 /fast/js/object-prototype-toLocaleString.html better output on failure 14652 7 ggaren 2005-07-14 10:12:39 -0700 (In reply to comment #5) Firefox and WinIE match. Mac IE doesn't, because it doesn't implement toLocaleString() at all. Upshot: I'll land the patch. 14655 8 ggaren 2005-07-14 10:42:26 -0700 Bug #3999 tracks propertyIsEnumerable. Bug #4000 tracks isPrototypeOf. This bug is only for toLocaleString(), so I'm closing it. 2293 2005-06-13 05:26:56 -0700 2005-07-13 16:47:54 -0700 Implementation of Object.prototype.toLocaleString javascriptcore-to-locale-string-p1.patch text/plain 2222 mrowe SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuY3BwLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjYKZGlmZiAtcCAtdSAtcjEuNiBKYXZhU2NyaXB0Q29yZS9r anMvb2JqZWN0X29iamVjdC5jcHAKLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0 LmNwcAkyMDA0LzA0LzA5IDIwOjA3OjQ3CTEuNgorKysgSmF2YVNjcmlwdENvcmUva2pzL29iamVj dF9vYmplY3QuY3BwCTIwMDUvMDYvMTMgMDg6Mjc6MTEKQEAgLTQwLDYgKzQwLDcgQEAgT2JqZWN0 UHJvdG90eXBlSW1wOjpPYmplY3RQcm90b3R5cGVJbXAoRQogICBWYWx1ZSBwcm90ZWN0KHRoaXMp OwogICBwdXREaXJlY3QodG9TdHJpbmdQcm9wZXJ0eU5hbWUsIG5ldyBPYmplY3RQcm90b0Z1bmNJ bXAoZXhlYyxmdW5jUHJvdG8sT2JqZWN0UHJvdG9GdW5jSW1wOjpUb1N0cmluZywgMCksIERvbnRF bnVtKTsKICAgcHV0RGlyZWN0KHZhbHVlT2ZQcm9wZXJ0eU5hbWUsICBuZXcgT2JqZWN0UHJvdG9G dW5jSW1wKGV4ZWMsZnVuY1Byb3RvLE9iamVjdFByb3RvRnVuY0ltcDo6VmFsdWVPZiwgIDApLCBE b250RW51bSk7CisgIHB1dERpcmVjdCh0b0xvY2FsZVN0cmluZ1Byb3BlcnR5TmFtZSwgbmV3IE9i amVjdFByb3RvRnVuY0ltcChleGVjLGZ1bmNQcm90byxPYmplY3RQcm90b0Z1bmNJbXA6OlRvTG9j YWxlU3RyaW5nLCAwKSwgRG9udEVudW0pOwogfQogCiAKQEAgLTYyLDEyICs2MywxOCBAQCBib29s IE9iamVjdFByb3RvRnVuY0ltcDo6aW1wbGVtZW50c0NhbGwoCiAKIC8vIEVDTUEgMTUuMi40LjIg KyAxNS4yLjQuMwogCi1WYWx1ZSBPYmplY3RQcm90b0Z1bmNJbXA6OmNhbGwoRXhlY1N0YXRlICov KmV4ZWMqLywgT2JqZWN0ICZ0aGlzT2JqLCBjb25zdCBMaXN0ICYvKmFyZ3MqLykKK1ZhbHVlIE9i amVjdFByb3RvRnVuY0ltcDo6Y2FsbChFeGVjU3RhdGUgKmV4ZWMsIE9iamVjdCAmdGhpc09iaiwg Y29uc3QgTGlzdCAmLyphcmdzKi8pCiB7Ci0gIGlmIChpZCA9PSBWYWx1ZU9mKQotICAgIHJldHVy biB0aGlzT2JqOwotICBlbHNlIC8qIFRvU3RyaW5nICovCi0gICAgcmV0dXJuIFN0cmluZygiW29i amVjdCAiK3RoaXNPYmouY2xhc3NOYW1lKCkrIl0iKTsKKyAgICBzd2l0Y2ggKGlkKQorICAgIHsK KyAgICAgICAgY2FzZSBWYWx1ZU9mOgorICAgICAgICAgICAgcmV0dXJuIHRoaXNPYmo7CisgICAg ICAgIGNhc2UgVG9Mb2NhbGVTdHJpbmc6CisgICAgICAgICAgICByZXR1cm4gdGhpc09iai5pbXAo KS0+dG9TdHJpbmcoZXhlYyk7CisgICAgICAgIGNhc2UgVG9TdHJpbmc6CisgICAgICAgIGRlZmF1 bHQ6CisgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCJbb2JqZWN0ICIrdGhpc09iai5jbGFzc05h bWUoKSsiXSIpOworICAgIH0KIH0KIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t IE9iamVjdE9iamVjdEltcCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbmRleDog SmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaCx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS4zCmRpZmYgLXAgLXUgLXIxLjMgSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9v YmplY3QuaAotLS0gSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaAkyMDAyLzA0LzE1 IDIzOjQxOjE3CTEuMworKysgSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaAkyMDA1 LzA2LzEzIDA4OjI3OjExCkBAIC01Myw3ICs1Myw3IEBAIG5hbWVzcGFjZSBLSlMgewogICAgIHZp cnR1YWwgYm9vbCBpbXBsZW1lbnRzQ2FsbCgpIGNvbnN0OwogICAgIHZpcnR1YWwgVmFsdWUgY2Fs bChFeGVjU3RhdGUgKmV4ZWMsIE9iamVjdCAmdGhpc09iaiwgY29uc3QgTGlzdCAmYXJncyk7CiAK LSAgICBlbnVtIHsgVG9TdHJpbmcsIFZhbHVlT2YgfTsKKyAgICBlbnVtIHsgVG9TdHJpbmcsIFZh bHVlT2YsIFRvTG9jYWxlU3RyaW5nIH07CiAgIHByaXZhdGU6CiAgICAgaW50IGlkOwogICB9Owo= 2951 2005-07-13 16:47:54 -0700 2005-07-13 19:53:02 -0700 Implementation of Object.prototype.toLocaleString patch.txt text/plain 2222 ggaren SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuY3BwLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjYKZGlmZiAtcCAtdSAtcjEuNiBKYXZhU2NyaXB0Q29yZS9r anMvb2JqZWN0X29iamVjdC5jcHAKLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9vYmplY3Rfb2JqZWN0 LmNwcAkyMDA0LzA0LzA5IDIwOjA3OjQ3CTEuNgorKysgSmF2YVNjcmlwdENvcmUva2pzL29iamVj dF9vYmplY3QuY3BwCTIwMDUvMDYvMTMgMDg6Mjc6MTEKQEAgLTQwLDYgKzQwLDcgQEAgT2JqZWN0 UHJvdG90eXBlSW1wOjpPYmplY3RQcm90b3R5cGVJbXAoRQogICBWYWx1ZSBwcm90ZWN0KHRoaXMp OwogICBwdXREaXJlY3QodG9TdHJpbmdQcm9wZXJ0eU5hbWUsIG5ldyBPYmplY3RQcm90b0Z1bmNJ bXAoZXhlYyxmdW5jUHJvdG8sT2JqZWN0UHJvdG9GdW5jSW1wOjpUb1N0cmluZywgMCksIERvbnRF bnVtKTsKICAgcHV0RGlyZWN0KHZhbHVlT2ZQcm9wZXJ0eU5hbWUsICBuZXcgT2JqZWN0UHJvdG9G dW5jSW1wKGV4ZWMsZnVuY1Byb3RvLE9iamVjdFByb3RvRnVuY0ltcDo6VmFsdWVPZiwgIDApLCBE b250RW51bSk7CisgIHB1dERpcmVjdCh0b0xvY2FsZVN0cmluZ1Byb3BlcnR5TmFtZSwgbmV3IE9i amVjdFByb3RvRnVuY0ltcChleGVjLGZ1bmNQcm90byxPYmplY3RQcm90b0Z1bmNJbXA6OlRvTG9j YWxlU3RyaW5nLCAwKSwgRG9udEVudW0pOwogfQogCiAKQEAgLTYyLDEyICs2MywxOCBAQCBib29s IE9iamVjdFByb3RvRnVuY0ltcDo6aW1wbGVtZW50c0NhbGwoCiAKIC8vIEVDTUEgMTUuMi40LjIg KyAxNS4yLjQuMwogCi1WYWx1ZSBPYmplY3RQcm90b0Z1bmNJbXA6OmNhbGwoRXhlY1N0YXRlICov KmV4ZWMqLywgT2JqZWN0ICZ0aGlzT2JqLCBjb25zdCBMaXN0ICYvKmFyZ3MqLykKK1ZhbHVlIE9i amVjdFByb3RvRnVuY0ltcDo6Y2FsbChFeGVjU3RhdGUgKmV4ZWMsIE9iamVjdCAmdGhpc09iaiwg Y29uc3QgTGlzdCAmLyphcmdzKi8pCiB7Ci0gIGlmIChpZCA9PSBWYWx1ZU9mKQotICAgIHJldHVy biB0aGlzT2JqOwotICBlbHNlIC8qIFRvU3RyaW5nICovCi0gICAgcmV0dXJuIFN0cmluZygiW29i amVjdCAiK3RoaXNPYmouY2xhc3NOYW1lKCkrIl0iKTsKKyAgICBzd2l0Y2ggKGlkKQorICAgIHsK KyAgICAgICAgY2FzZSBWYWx1ZU9mOgorICAgICAgICAgICAgcmV0dXJuIHRoaXNPYmo7CisgICAg ICAgIGNhc2UgVG9Mb2NhbGVTdHJpbmc6CisgICAgICAgICAgICByZXR1cm4gdGhpc09iai5pbXAo KS0+dG9TdHJpbmcoZXhlYyk7CisgICAgICAgIGNhc2UgVG9TdHJpbmc6CisgICAgICAgIGRlZmF1 bHQ6CisgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCJbb2JqZWN0ICIrdGhpc09iai5jbGFzc05h bWUoKSsiXSIpOworICAgIH0KIH0KIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t IE9iamVjdE9iamVjdEltcCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbmRleDog SmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaCx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS4zCmRpZmYgLXAgLXUgLXIxLjMgSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9v YmplY3QuaAotLS0gSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaAkyMDAyLzA0LzE1 IDIzOjQxOjE3CTEuMworKysgSmF2YVNjcmlwdENvcmUva2pzL29iamVjdF9vYmplY3QuaAkyMDA1 LzA2LzEzIDA4OjI3OjExCkBAIC01Myw3ICs1Myw3IEBAIG5hbWVzcGFjZSBLSlMgewogICAgIHZp cnR1YWwgYm9vbCBpbXBsZW1lbnRzQ2FsbCgpIGNvbnN0OwogICAgIHZpcnR1YWwgVmFsdWUgY2Fs bChFeGVjU3RhdGUgKmV4ZWMsIE9iamVjdCAmdGhpc09iaiwgY29uc3QgTGlzdCAmYXJncyk7CiAK LSAgICBlbnVtIHsgVG9TdHJpbmcsIFZhbHVlT2YgfTsKKyAgICBlbnVtIHsgVG9TdHJpbmcsIFZh bHVlT2YsIFRvTG9jYWxlU3RyaW5nIH07CiAgIHByaXZhdGU6CiAgICAgaW50IGlkOwogICB9Owo= 2952 2005-07-13 16:48:45 -0700 2005-07-14 10:04:17 -0700 /fast/js/object-prototype-toLocaleString.html object-prototype-toLocaleString.html text/html 903 ggaren PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBwcmludChtZXNzYWdlKSB7Cgl2YXIgcGFy YWdyYXBoID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgicCIpOwoJcGFyYWdyYXBoLmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpKTsKCWRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBoKTsKfQoKZnVuY3Rpb24gdGVz dCgpIHsKCWlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKCQlsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7Cgl9CgogICAgdmFyIG8gPSBuZXcgT2JqZWN0KCk7CiAgICBw cmludCgiT2JqZWN0LnRvTG9jYWxlU3RyaW5nKCkgKHNob3VsZCBiZSBcIiIgKyBvLnRvU3RyaW5n KCkgKyAiXCIpOiAiICsgby50b0xvY2FsZVN0cmluZygpKTsKICAgIAogICAgby50b0xvY2FsZVN0 cmluZyA9IGZ1bmN0aW9uICgpIHsgcmV0dXJuICJEeW5hbWljIHRvTG9jYWxlU3RyaW5nKCkiOyB9 CiAgICBwcmludCgiT2JqZWN0LnRvTG9jYWxlU3RyaW5nKCkgKHNob3VsZCBiZSBcIkR5bmFtaWMg dG9Mb2NhbGVTdHJpbmcoKVwiKTogIiArIG8udG9Mb2NhbGVTdHJpbmcoKSk7CiAgICAKfQo8L3Nj cmlwdD4KPC9oZWFkPgo8Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgo8cD5UZXN0czogT2JqZWN0LnBy b3RvdHlwZS50b0xvY2FsZVN0cmluZygpPC9wPgo8cD5SZWxhdGVkIGJ1ZzogPGEgaHJlZiA9ICJo dHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTM5ODkiPjM5ODkg SlNDIGRvZXNuJ3QgaW1wbGVtZW50IE9iamVjdC5wcm90b3R5cGUudG9Mb2NhbGVTdHJpbmcoKTwv YT48L3A+Cjxocj4KPGRpdiBpZD0nY29uc29sZScvPgo8L2JvZHk+CjwvaHRtbD4K 2961 2005-07-14 10:04:17 -0700 2005-07-14 10:04:17 -0700 /fast/js/object-prototype-toLocaleString.html object-prototype-toLocaleString.html text/html 1009 ggaren PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBwcmludChtZXNzYWdlKSB7Cgl2YXIgcGFy YWdyYXBoID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgicCIpOwoJcGFyYWdyYXBoLmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpKTsKCWRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBoKTsKfQoKZnVuY3Rpb24gdGVz dCgpIHsKCWlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKCQlsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7Cgl9CgogICAgdHJ5IHsKICAgICAgICB2YXIgbyA9IG5ldyBP YmplY3QoKTsKICAgICAgICBwcmludCgiT2JqZWN0LnRvTG9jYWxlU3RyaW5nKCkgKHNob3VsZCBi ZSBcIiIgKyBvLnRvU3RyaW5nKCkgKyAiXCIpOiAiICsgby50b0xvY2FsZVN0cmluZygpKTsKICAg ICAgICAKICAgICAgICBvLnRvTG9jYWxlU3RyaW5nID0gZnVuY3Rpb24gKCkgeyByZXR1cm4gIkR5 bmFtaWMgdG9Mb2NhbGVTdHJpbmcoKSI7IH0KICAgICAgICBwcmludCgiT2JqZWN0LnRvTG9jYWxl U3RyaW5nKCkgKHNob3VsZCBiZSBcIkR5bmFtaWMgdG9Mb2NhbGVTdHJpbmcoKVwiKTogIiArIG8u dG9Mb2NhbGVTdHJpbmcoKSk7CiAgICB9CiAgICBjYXRjaCAoZSkgewogICAgICAgIHByaW50KCJU ZXN0IGZhaWxlZC4gVGhyZXcgZXhjZXB0aW9uOiAiICsgZSk7CiAgICB9Cn0KPC9zY3JpcHQ+Cjwv aGVhZD4KPGJvZHkgb25sb2FkPSJ0ZXN0KCk7Ij4KPHA+VGVzdHM6IE9iamVjdC5wcm90b3R5cGUu dG9Mb2NhbGVTdHJpbmcoKTwvcD4KPHA+UmVsYXRlZCBidWc6IDxhIGhyZWYgPSAiaHR0cDovL2J1 Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTg5Ij4zOTg5IEpTQyBkb2Vz bid0IGltcGxlbWVudCBPYmplY3QucHJvdG90eXBlLnRvTG9jYWxlU3RyaW5nKCk8L2E+PC9wPgo8 aHI+CjxkaXYgaWQ9J2NvbnNvbGUnLz4KPC9ib2R5Pgo8L2h0bWw+Cg==