34085 2010-01-25 06:52:54 -0800 [GTK] Should use GStreamer codec installation infrastructure 2013-03-30 06:06:55 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 34318 1 slomo webkit-unassigned gustavo joone.hur joone manday otte pnormand spena oldest_to_newest 184274 0 slomo 2010-01-25 06:52:54 -0800 If a codec is missing for playing some stream with GStreamer, WebKit should support calling the GStreamer codec installation infrastructure. Relevant documentation: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstpbutilsmissingplugins.html http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstpbutilsinstallplugins.html In short, a message is posted on the bus with information about missing stuff. WebKit should start the installation then and restart playback after things are installed. Also all following ERROR/WARNING messages after the missing plugin message should be dropped until playback is restarted. 185822 1 gustavo 2010-01-29 05:14:31 -0800 I guess this should follow a policy decided by the application - some applications may want to never request installation of missing codecs. Looks like a good thing to start implementing our MediaPlayerClient, and our media player API for. 415731 2 pnormand 2011-06-06 00:55:06 -0700 *** Bug 62088 has been marked as a duplicate of this bug. *** 415735 3 manday 2011-06-06 01:22:17 -0700 I find this idea rather problematic. Users usually want their package manager to handle packages, not the application internally. I suggest to *not* implement this. 415736 4 slomo 2011-06-06 01:32:26 -0700 That's exactly the point of the GStreamer codec installation infrastructure. It will use a distribution specific script/application to install the codecs, which then use the distribution's package manager. 415744 5 manday 2011-06-06 01:48:35 -0700 My apologies, I wasn't aware of that. However, I must insist that you shall not remove control from the user, nor do I approve of overly fancy auto-mechanisms. But as I understood it, you also suggest that a message asks the user whether he wants to install Codec X/Y or not. I then, to merge bug #62088 into this thread, suggest that 1) If neither the audio nor the video codec is installed, or either of them is not installed, a "Warning" icon appears in the place where the video would actually play, clicking it removes it and opens a context menu in which a) The required codices can be viewed b) The required codices can be installed by a click of the mouse 2) If all codecs are avaible, no warning appears but a context menu still provides information about which codices are in use. 415746 6 manday 2011-06-06 01:49:52 -0700 *** Bug 62088 has been marked as a duplicate of this bug. *** 476695 7 manday 2011-10-02 10:42:30 -0700 *** Bug 69225 has been marked as a duplicate of this bug. *** 651291 8 spena 2012-06-18 03:29:35 -0700 This should / could be fixed together with bug #34318: handling missing codecs should be one specific case of error/warning/info handling. 866172 9 195748 pnormand 2013-03-29 08:14:09 -0700 Created attachment 195748 Patch 866178 10 195748 mrobinson 2013-03-29 08:17:35 -0700 Comment on attachment 195748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195748&action=review Very simple and nice! Please fix the style issues when landing. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:50 > +#include <gst/pbutils/missing-plugins.h> Should be listed alphabetically in the list. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:782 > + GstInstallPluginsReturn result = gst_install_plugins_async(&detail, 0, mediaPlayerPrivatePluginInstallerResultFunction, reinterpret_cast<gpointer>(this)); There's no cast necessary to go from a class pointer to void* and reinterpret_cast here can hide real errors, so please remove the cast. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:35 > +#include <gst/pbutils/install-plugins.h> Please list this alphabetically. 866179 11 pnormand 2013-03-29 08:18:19 -0700 (In reply to comment #1) > I guess this should follow a policy decided by the application - some applications may want to never request installation of missing codecs. Looks like a good thing to start implementing our MediaPlayerClient, and our media player API for. For now I left this aside. Actually I'm not sure an application would ever want to not install codecs. If this is the case I think that if no codec-installer program is found nothing will be done anyway. 866566 12 slomo 2013-03-30 00:34:22 -0700 Looks good to me 866610 13 pnormand 2013-03-30 06:06:55 -0700 Committed r147279: <http://trac.webkit.org/changeset/147279> 195748 2013-03-29 08:14:09 -0700 2013-03-29 08:17:35 -0700 Patch Patch.patch text/plain 6296 pnormand RnJvbSAyM2FjOWJmYThjMmI5MTFiNTc4NmNkNDhkOWJiYzdiMTU1YjBmZTU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDI5IE1hciAyMDEzIDE2OjEzOjM4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g UGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAyNCArKysrKysrKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8IDI3ICsrKysrKysrKysrKysrKysrKysrKysKIC4u Li9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggICAgICAgIHwgIDQgKysr KwogMyBmaWxlcyBjaGFuZ2VkLCA1NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGMxODQw ODIuLjk2NDQ0ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMy0wMy0yOSAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gU2hv dWxkIHVzZSBHU3RyZWFtZXIgY29kZWMgaW5zdGFsbGF0aW9uIGluZnJhc3RydWN0dXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDA4NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluaXRpYWwgc3VwcG9y dCBmb3IgdGhlIEdTdHJlYW1lciBjb2RlYyBpbnN0YWxsZXIuIFRoZSBwbGF5ZXIgd2lsbAorICAg ICAgICBoYW5kbGUgbWlzc2luZy1wbHVnaW5zIG1lc3NhZ2VzIGFuZCB1c2UgdGhlIHBidXRpbHMg Y29kZWMKKyAgICAgICAgaW5zdGFsbGVyIGZhY2lsaXRpZXMgdG8gaW5zdGFsbCB0aGUgbWlzc2lu ZyBHU3RyZWFtZXIKKyAgICAgICAgcGx1Z2lucy4gT25jZSB0aGUgcGx1Z2lucyBhcmUgaW5zdGFs bGVkIHJlc2V0IHRoZSBwaXBlbGluZSBzdGF0ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6bWVkaWFQbGF5ZXJQcml2YXRlUGx1Z2luSW5zdGFsbGVyUmVzdWx0RnVuY3Rpb24p OiBUaGlzCisgICAgICAgIG1ldGhvZCBpcyB1c2VkIHRvIG5vdGlmeSB0aGUgcGxheWVyIHRoYXQg dGhlIG1pc3NpbmcgcGx1Z2lucyB3ZXJlIGluc3RhbGxlZC4KKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlKTogSWdub3JlCisgICAgICAgIGVycm9ycyB3aGlsZSBp bnN0YWxsaW5nIHBsdWdpbnMgYW5kIGhhbmRsZSB0aGUgbWlzc2luZy1wbHVnaW4gbWVzc2FnZS4K KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlUGx1 Z2luSW5zdGFsbGVyUmVzdWx0KToKKyAgICAgICAgVGhpcyBtZXRob2QgaXMgaW52b2tlZCBhZnRl ciB0aGUgaW5zdGFsbGVyIGZpbmlzaGVkIGl0cyB0YXNrLgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaDoKKyAgICAgICAg KE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcik6CisKIDIwMTMtMDMtMjggIFBoaWxpcHBlIE5v cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIHBsYXli YWNrIGdldHMgYnVtcHkgc29tZXRpbWVzIHdoZW4gb24tZGlzayBidWZmZXJpbmcgaXMgc2xvdwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBk NDNmYzEwLi40MGY5MjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcApAQCAtNDcsNiArNDcsOCBAQAogI2luY2x1ZGUgPGdzdC9pbnRlcmZhY2Vz L3N0cmVhbXZvbHVtZS5oPgogI2VuZGlmCiAKKyNpbmNsdWRlIDxnc3QvcGJ1dGlscy9taXNzaW5n LXBsdWdpbnMuaD4KKwogLy8gR3N0UGxheUZsYWdzIGZsYWdzIGZyb20gcGxheWJpbjIuIEl0IGlz IHRoZSBwb2xpY3kgb2YgR1N0cmVhbWVyIHRvCiAvLyBub3QgcHVibGljbHkgZXhwb3NlIGVsZW1l bnQtc3BlY2lmaWMgZW51bXMuIFRoYXQncyB3aHkgdGhpcwogLy8gR3N0UGxheUZsYWdzIGVudW0g aGFzIGJlZW4gY29waWVkIGhlcmUuCkBAIC0xMzEsNiArMTMzLDEyIEBAIHN0YXRpYyBnYm9vbGVh biBtZWRpYVBsYXllclByaXZhdGVWaWRlb0NoYW5nZVRpbWVvdXRDYWxsYmFjayhNZWRpYVBsYXll clByaXZhdGVHCiAgICAgcmV0dXJuIEZBTFNFOwogfQogCitzdGF0aWMgdm9pZCBtZWRpYVBsYXll clByaXZhdGVQbHVnaW5JbnN0YWxsZXJSZXN1bHRGdW5jdGlvbihHc3RJbnN0YWxsUGx1Z2luc1Jl dHVybiByZXN1bHQsIGdwb2ludGVyIHVzZXJEYXRhKQoreworICAgIE1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lciogcGxheWVyID0gcmVpbnRlcnByZXRfY2FzdDxNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIqPih1c2VyRGF0YSk7CisgICAgcGxheWVyLT5oYW5kbGVQbHVnaW5JbnN0YWxsZXJS ZXN1bHQocmVzdWx0KTsKK30KKwogdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnNl dEF1ZGlvU3RyZWFtUHJvcGVydGllcyhHT2JqZWN0KiBvYmplY3QpCiB7CiAgICAgaWYgKGdfc3Ry Y21wMChHX09CSkVDVF9UWVBFX05BTUUob2JqZWN0KSwgIkdzdFB1bHNlU2luayIpKQpAQCAtMjEy LDYgKzIyMCw3IEBAIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6TWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyKE1lZGlhUGxheWVyKiBwbGF5ZXIpCiAgICAgLCBtX29yaWdpbmFsUHJlbG9h ZFdhc0F1dG9BbmRXYXNPdmVycmlkZGVuKGZhbHNlKQogICAgICwgbV9wcmVzZXJ2ZXNQaXRjaChm YWxzZSkKICAgICAsIG1fcmVxdWVzdGVkU3RhdGUoR1NUX1NUQVRFX1ZPSURfUEVORElORykKKyAg ICAsIG1fbWlzc2luZ1BsdWdpbnMoZmFsc2UpCiB7CiB9CiAKQEAgLTY4Niw2ICs2OTUsOCBAQCBn Ym9vbGVhbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmhhbmRsZU1lc3NhZ2UoR3N0TWVz c2FnZSogbWVzc2FnZSkKICAgICBjYXNlIEdTVF9NRVNTQUdFX0VSUk9SOgogICAgICAgICBpZiAo bV9yZXNldFBpcGVsaW5lKQogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGlmIChtX21pc3Np bmdQbHVnaW5zKQorICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGdzdF9tZXNzYWdlX3BhcnNl X2Vycm9yKG1lc3NhZ2UsICZlcnIub3V0UHRyKCksICZkZWJ1Zy5vdXRQdHIoKSk7CiAgICAgICAg IExPR19NRURJQV9NRVNTQUdFKCJFcnJvciAlZDogJXMgKHVybD0lcykiLCBlcnItPmNvZGUsIGVy ci0+bWVzc2FnZSwgbV91cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CiAKQEAgLTc2NSw2ICs3 NzYsMTMgQEAgZ2Jvb2xlYW4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVNZXNz YWdlKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAgICAgICAgICAgICBjaGFuZ2VQaXBlbGluZVN0YXRl KHJlcXVlc3RlZFN0YXRlKTsKICAgICAgICAgfQogICAgICAgICBicmVhazsKKyAgICBjYXNlIEdT VF9NRVNTQUdFX0VMRU1FTlQ6CisgICAgICAgIGlmIChnc3RfaXNfbWlzc2luZ19wbHVnaW5fbWVz c2FnZShtZXNzYWdlKSkgeworICAgICAgICAgICAgY2hhciogZGV0YWlsID0gZ3N0X21pc3Npbmdf cGx1Z2luX21lc3NhZ2VfZ2V0X2luc3RhbGxlcl9kZXRhaWwobWVzc2FnZSk7CisgICAgICAgICAg ICBHc3RJbnN0YWxsUGx1Z2luc1JldHVybiByZXN1bHQgPSBnc3RfaW5zdGFsbF9wbHVnaW5zX2Fz eW5jKCZkZXRhaWwsIDAsIG1lZGlhUGxheWVyUHJpdmF0ZVBsdWdpbkluc3RhbGxlclJlc3VsdEZ1 bmN0aW9uLCByZWludGVycHJldF9jYXN0PGdwb2ludGVyPih0aGlzKSk7CisgICAgICAgICAgICBt X21pc3NpbmdQbHVnaW5zID0gcmVzdWx0ID09IEdTVF9JTlNUQUxMX1BMVUdJTlNfU1RBUlRFRF9P SzsKKyAgICAgICAgfQorICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICBMT0df TUVESUFfTUVTU0FHRSgiVW5oYW5kbGVkIEdTdHJlYW1lciBtZXNzYWdlIHR5cGU6ICVzIiwKICAg ICAgICAgICAgICAgICAgICAgR1NUX01FU1NBR0VfVFlQRV9OQU1FKG1lc3NhZ2UpKTsKQEAgLTc3 Myw2ICs3OTEsMTUgQEAgZ2Jvb2xlYW4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5k bGVNZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKK3Zv aWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVQbHVnaW5JbnN0YWxsZXJSZXN1 bHQoR3N0SW5zdGFsbFBsdWdpbnNSZXR1cm4gcmVzdWx0KQoreworICAgIG1fbWlzc2luZ1BsdWdp bnMgPSBmYWxzZTsKKyAgICBpZiAocmVzdWx0ID09IEdTVF9JTlNUQUxMX1BMVUdJTlNfU1VDQ0VT UykgeworICAgICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUobV9wbGF5QmluLmdldCgpLCBHU1Rf U1RBVEVfUkVBRFkpOworICAgICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUobV9wbGF5QmluLmdl dCgpLCBHU1RfU1RBVEVfUEFVU0VEKTsKKyAgICB9Cit9CisKIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyOjpwcm9jZXNzQnVmZmVyaW5nU3RhdHMoR3N0TWVzc2FnZSogbWVzc2FnZSkK IHsKICAgICAvLyBUaGlzIGlzIHRoZSBpbW1lZGlhdGUgYnVmZmVyaW5nIHRoYXQgbmVlZHMgdG8g aGFwcGVuIHNvIHdlIGhhdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuaAppbmRleCA2Y2U2NjZmLi5iNmFkMjgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0zMiw2ICszMiw4IEBACiAjaW5jbHVkZSA8Z3N0 L2dzdC5oPgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAKKyNpbmNsdWRlIDxnc3QvcGJ1dGls cy9pbnN0YWxsLXBsdWdpbnMuaD4KKwogdHlwZWRlZiBzdHJ1Y3QgX0dzdEJ1ZmZlciBHc3RCdWZm ZXI7CiB0eXBlZGVmIHN0cnVjdCBfR3N0TWVzc2FnZSBHc3RNZXNzYWdlOwogdHlwZWRlZiBzdHJ1 Y3QgX0dzdEVsZW1lbnQgR3N0RWxlbWVudDsKQEAgLTQzLDYgKzQ1LDcgQEAgcHVibGljOgogICAg IH5NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIoKTsKICAgICBzdGF0aWMgdm9pZCByZWdpc3Rl ck1lZGlhRW5naW5lKE1lZGlhRW5naW5lUmVnaXN0cmFyKTsKICAgICBnYm9vbGVhbiBoYW5kbGVN ZXNzYWdlKEdzdE1lc3NhZ2UqKTsKKyAgICB2b2lkIGhhbmRsZVBsdWdpbkluc3RhbGxlclJlc3Vs dChHc3RJbnN0YWxsUGx1Z2luc1JldHVybik7CiAKICAgICBib29sIGhhc1ZpZGVvKCkgY29uc3Qg eyByZXR1cm4gbV9oYXNWaWRlbzsgfQogICAgIGJvb2wgaGFzQXVkaW8oKSBjb25zdCB7IHJldHVy biBtX2hhc0F1ZGlvOyB9CkBAIC0xNjIsNiArMTY1LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1f cHJlc2VydmVzUGl0Y2g7CiAgICAgR3N0U3RhdGUgbV9yZXF1ZXN0ZWRTdGF0ZTsKICAgICBHUmVm UHRyPEdzdEVsZW1lbnQ+IG1fYXV0b0F1ZGlvU2luazsKKyAgICBib29sIG1fbWlzc2luZ1BsdWdp bnM7CiB9OwogfQogCi0tIAoxLjguMi5yYzM=