34068 2010-01-24 22:48:55 -0800 [Win] Add modifiers parameter support to Windows DumpRenderTree 2010-01-26 20:09:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 1 tkent webkit-unassigned aroben bweinstein eric oldest_to_newest 184167 0 tkent 2010-01-24 22:48:55 -0800 This is a similar change as http://trac.webkit.org/changeset/53498 for Mac. 184168 1 47313 tkent 2010-01-24 23:01:11 -0800 Created attachment 47313 Proposed Patch 184773 2 47313 eric 2010-01-26 14:59:56 -0800 Comment on attachment 47313 Proposed Patch Looks sane to me. 184902 3 47313 tkent 2010-01-26 19:33:27 -0800 Comment on attachment 47313 Proposed Patch I'll commit manually because CQ is busy. 184912 4 tkent 2010-01-26 20:09:35 -0800 Committed r53889: <http://trac.webkit.org/changeset/53889> 47313 2010-01-24 23:01:11 -0800 2010-01-26 19:33:27 -0800 Proposed Patch 0001-foo.patch text/plain 7607 tkent RnJvbSBlNGJjMDY3MmFjYWIzNGI5YTFiZGZlNzljM2ZmOWYyM2YyN2Q5MmZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl OiBNb24sIDI1IEphbiAyMDEwIDE1OjU5OjM0ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZm9vCgot LS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0 ICsrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkICAgICAgICAgICAgICAg fCAgICAyIC0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDE4ICsrKysrKysrKysKIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9FdmVudFNl bmRlci5jcHAgfCAgIDQ0ICsrKysrKysrKysrKysrKysrKysrLS0tCiA0IGZpbGVzIGNoYW5nZWQs IDcwIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDEzMmU1ZTcuLjZjOWVl MmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMS0yNCAgS2VudCBUYW11cmEgIDx0a2Vu dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1dpbl0gQWRkIG1vZGlmaWVycyBwYXJhbWV0ZXIgc3VwcG9ydCB0byBXaW5kb3dz IER1bXBSZW5kZXJUcmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNDA2OAorCisgICAgICAgIFJlbW92ZSBsaXN0Ym94LWRlc2VsZWN0LXNjcm9sbC5o dG1sIGFuZCBsaXN0Ym94LXNlbGVjdGlvLTIuaHRtbAorICAgICAgICBmcm9tIFNraXBwZWQuIFdl IGltcHJvdmVkIHRoZWlyIHBvcnRhYmlsaXR5IGFuZCBXaW5kb3dzIERSVCBub3cKKyAgICAgICAg aGF2cyBtb2RpZmllcnMgcGFyYW1ldGVyIG9mIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpIGFuZAor ICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4v U2tpcHBlZDoKKwogMjAxMC0wMS0yNSAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2luL1NraXBwZWQKaW5kZXggMzhiMzZkYy4uNmMwMTM1MCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vd2luL1NraXBwZWQKQEAgLTQ0OSwxMCArNDQ5LDggQEAgZmFzdC9mb3Jtcy9kaXNhYmxlZC1z ZWxlY3QtY2hhbmdlLWluZGV4Lmh0bWwKIGZhc3QvZm9ybXMvZm9ybS1lbGVtZW50LWdlb21ldHJ5 Lmh0bWwKIGZhc3QvZm9ybXMvaGlkZGVuLWxpc3Rib3guaHRtbAogZmFzdC9mb3Jtcy9sZWdlbmQt YWNjZXNzLWtleS5odG1sCi1mYXN0L2Zvcm1zL2xpc3Rib3gtZGVzZWxlY3Qtc2Nyb2xsLmh0bWwK IGZhc3QvZm9ybXMvbGlzdGJveC1oaXQtdGVzdC16b29tZWQuaHRtbAogZmFzdC9mb3Jtcy9saXN0 Ym94LXNjcm9sbGJhci1pbmNyZW1lbnRhbC1sb2FkLmh0bWwKLWZhc3QvZm9ybXMvbGlzdGJveC1z ZWxlY3Rpb24tMi5odG1sCiBmYXN0L2Zvcm1zL2xpc3Rib3gtd2lkdGgtY2hhbmdlLmh0bWwKIGZh c3QvZm9ybXMvb3B0aW9uLXN0cmlwLXdoaXRlc3BhY2UuaHRtbAogZmFzdC9mb3Jtcy9zZWFyY2gt em9vbWVkLmh0bWwKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRv b2xzL0NoYW5nZUxvZwppbmRleCBjNDlkMzE3Li4wZjNkZDY0IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTAtMDEtMjQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXaW5dIEFkZCBtb2Rp ZmllcnMgcGFyYW1ldGVyIHN1cHBvcnQgdG8gV2luZG93cyBEdW1wUmVuZGVyVHJlZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQwNjgKKworICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgZnVuY3Rpb25hbCBuYW1lIG1vZGlmaWVyczsgImFkZFNlbGVjdGlv bktleSIgYW5kCisgICAgICAgICJyYW5nZVNlbGVjdGlvbktleSIsIGFuZCBtb2RpZmllcnMgcGFy YW1ldGVyIHRvIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpCisgICAgICAgIGFuZCBldmVudFNlbmRl ci5tb3VzZVVwKCkuCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIHNpbWlsYXIgdG8gcjUzNDk4IGZv ciBNYWMuCisgICAgICAgIAorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9FdmVudFNlbmRl ci5jcHA6CisgICAgICAgIChidWlsZE1vZGlmaWVyRmxhZ3MpOiBOZXcgZnVuY3Rpb24gdG8gc2V0 IE1LX0NPTlRST0wgb3IgTUtfU0hJRlQgdG8gV1BBUkFNLgorICAgICAgICAobW91c2VEb3duQ2Fs bGJhY2spOiBDYWxsIGJ1aWRsTW9kaWZpZXJzRmxhZ3MoKS4KKyAgICAgICAgKG1vdXNlVXBDYWxs YmFjayk6IGRpdHRvLgorICAgICAgICAoa2V5RG93bkNhbGxiYWNrKTogQWRkIHN1cHBvcnQgZm9y ICJhZGRTZWxlY3Rpb25rZXkiIGFuZCAicmFuZ2VTZWxlY3Rpb25LZXkiLgorCiAyMDEwLTAxLTI0 ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIHJv bGxpbmcgb3V0IHI1Mzc2My4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L3dpbi9FdmVudFNlbmRlci5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRXZl bnRTZW5kZXIuY3BwCmluZGV4IGRkNWJmOWQuLjVhNDJiMDAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9FdmVudFNlbmRlci5jcHAKKysrIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvd2luL0V2ZW50U2VuZGVyLmNwcApAQCAtMTQ0LDYgKzE0NCwzMCBAQCBz dGF0aWMgSlNWYWx1ZVJlZiBjb250ZXh0Q2xpY2tDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4 dCwgSlNPYmplY3RSZWYgZnVuY3RpbwogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChj b250ZXh0KTsKIH0KIAorc3RhdGljIFdQQVJBTSBidWlsZE1vZGlmaWVyRmxhZ3MoSlNDb250ZXh0 UmVmIGNvbnRleHQsIGNvbnN0IEpTVmFsdWVSZWYgbW9kaWZpZXJzKQoreworICAgIEpTT2JqZWN0 UmVmIG1vZGlmaWVyc0FycmF5ID0gSlNWYWx1ZVRvT2JqZWN0KGNvbnRleHQsIG1vZGlmaWVycywg MCk7CisgICAgaWYgKCFtb2RpZmllcnNBcnJheSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBX UEFSQU0gZmxhZ3MgPSAwOworICAgIGludCBtb2RpZmllcnNDb3VudCA9IEpTVmFsdWVUb051bWJl cihjb250ZXh0LCBKU09iamVjdEdldFByb3BlcnR5KGNvbnRleHQsIG1vZGlmaWVyc0FycmF5LCBK U1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygibGVuZ3RoIiksIDApLCAwKTsKKyAgICBmb3Ig KGludCBpID0gMDsgaSA8IG1vZGlmaWVyc0NvdW50OyArK2kpIHsKKyAgICAgICAgSlNWYWx1ZVJl ZiB2YWx1ZSA9IEpTT2JqZWN0R2V0UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIG1vZGlmaWVyc0Fy cmF5LCBpLCAwKTsKKyAgICAgICAgSlNTdHJpbmdSZWYgc3RyaW5nID0gSlNWYWx1ZVRvU3RyaW5n Q29weShjb250ZXh0LCB2YWx1ZSwgMCk7CisgICAgICAgIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VU RjhDU3RyaW5nKHN0cmluZywgImN0cmxLZXkiKQorICAgICAgICAgICAgfHwgSlNTdHJpbmdJc0Vx dWFsVG9VVEY4Q1N0cmluZyhzdHJpbmcsICJhZGRTZWxlY3Rpb25LZXkiKSkKKyAgICAgICAgICAg IGZsYWdzIHw9IE1LX0NPTlRST0w7CisgICAgICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRv VVRGOENTdHJpbmcoc3RyaW5nLCAic2hpZnRLZXkiKQorICAgICAgICAgICAgICAgICB8fCBKU1N0 cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgInJhbmdlU2VsZWN0aW9uS2V5IikpCisg ICAgICAgICAgICBmbGFncyB8PSBNS19TSElGVDsKKyAgICAgICAgLy8gTm8gd2F5IHRvIHNwZWNp Zml5IGFsdEtleSBpbiBhIE1TRy4KKworICAgICAgICBKU1N0cmluZ1JlbGVhc2Uoc3RyaW5nKTsK KyAgICB9CisgICAgcmV0dXJuIGZsYWdzOworfQorCiBzdGF0aWMgSlNWYWx1ZVJlZiBtb3VzZURv d25DYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24sIEpT T2JqZWN0UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50LCBjb25zdCBKU1ZhbHVl UmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCiB7CiAgICAgQ09NUHRyPElX ZWJGcmFtZVByaXZhdGU+IGZyYW1lUHJpdmF0ZTsKQEAgLTE1Miw3ICsxNzYsNyBAQCBzdGF0aWMg SlNWYWx1ZVJlZiBtb3VzZURvd25DYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmpl Y3RSZWYgZnVuY3Rpb24sCiAKICAgICBkb3duID0gdHJ1ZTsKICAgICBpbnQgbW91c2VUeXBlID0g V01fTEJVVFRPTkRPV047Ci0gICAgaWYgKGFyZ3VtZW50Q291bnQgPT0gMSkgeworICAgIGlmIChh cmd1bWVudENvdW50ID49IDEpIHsKICAgICAgICAgaW50IG1vdXNlTnVtYmVyID0gSlNWYWx1ZVRv TnVtYmVyKGNvbnRleHQsIGFyZ3VtZW50c1swXSwgZXhjZXB0aW9uKTsKICAgICAgICAgc3dpdGNo IChtb3VzZU51bWJlcikgewogICAgICAgICBjYXNlIDA6CkBAIC0xNzMsOCArMTk3LDEyIEBAIHN0 YXRpYyBKU1ZhbHVlUmVmIG1vdXNlRG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBK U09iamVjdFJlZiBmdW5jdGlvbiwKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAg fQorCisgICAgV1BBUkFNIHdwYXJhbSA9IDA7CisgICAgaWYgKGFyZ3VtZW50Q291bnQgPj0gMikK KyAgICAgICAgd3BhcmFtIHw9IGJ1aWxkTW9kaWZpZXJGbGFncyhjb250ZXh0LCBhcmd1bWVudHNb MV0pOwogICAgICAgICAKLSAgICBNU0cgbXNnID0gbWFrZU1zZyh3ZWJWaWV3V2luZG93LCBtb3Vz ZVR5cGUsIDAsIE1BS0VMUEFSQU0obGFzdE1vdXNlUG9zaXRpb24ueCwgbGFzdE1vdXNlUG9zaXRp b24ueSkpOworICAgIE1TRyBtc2cgPSBtYWtlTXNnKHdlYlZpZXdXaW5kb3csIG1vdXNlVHlwZSwg d3BhcmFtLCBNQUtFTFBBUkFNKGxhc3RNb3VzZVBvc2l0aW9uLngsIGxhc3RNb3VzZVBvc2l0aW9u LnkpKTsKICAgICBpZiAoIW1zZ1F1ZXVlW2VuZE9mUXVldWVdLmRlbGF5KQogICAgICAgICBkaXNw YXRjaE1lc3NhZ2UoJm1zZyk7CiAgICAgZWxzZSB7CkBAIC0yMzQsNyArMjYyLDcgQEAgc3RhdGlj IHZvaWQgZG9Nb3VzZVVwKE1TRyBtc2csIEhSRVNVTFQqIG9sZURyYWdBbmREcm9wUmV0dXJuVmFs dWUgPSAwKQogc3RhdGljIEpTVmFsdWVSZWYgbW91c2VVcENhbGxiYWNrKEpTQ29udGV4dFJlZiBj b250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6 ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVS ZWYqIGV4Y2VwdGlvbikKIHsKICAgICBpbnQgbW91c2VUeXBlID0gV01fTEJVVFRPTlVQOwotICAg IGlmIChhcmd1bWVudENvdW50ID09IDEpIHsKKyAgICBpZiAoYXJndW1lbnRDb3VudCA+PSAxKSB7 CiAgICAgICAgIGludCBtb3VzZU51bWJlciA9IEpTVmFsdWVUb051bWJlcihjb250ZXh0LCBhcmd1 bWVudHNbMF0sIGV4Y2VwdGlvbik7CiAgICAgICAgIHN3aXRjaCAobW91c2VOdW1iZXIpIHsKICAg ICAgICAgY2FzZSAwOgpAQCAtMjU2LDcgKzI4NCwxMSBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtb3Vz ZVVwQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBK UwogICAgICAgICB9CiAgICAgfQogCi0gICAgTVNHIG1zZyA9IG1ha2VNc2cod2ViVmlld1dpbmRv dywgbW91c2VUeXBlLCAwLCBNQUtFTFBBUkFNKGxhc3RNb3VzZVBvc2l0aW9uLngsIGxhc3RNb3Vz ZVBvc2l0aW9uLnkpKTsKKyAgICBXUEFSQU0gd3BhcmFtID0gMDsKKyAgICBpZiAoYXJndW1lbnRD b3VudCA+PSAyKQorICAgICAgICB3cGFyYW0gfD0gYnVpbGRNb2RpZmllckZsYWdzKGNvbnRleHQs IGFyZ3VtZW50c1sxXSk7CisKKyAgICBNU0cgbXNnID0gbWFrZU1zZyh3ZWJWaWV3V2luZG93LCBt b3VzZVR5cGUsIHdwYXJhbSwgTUFLRUxQQVJBTShsYXN0TW91c2VQb3NpdGlvbi54LCBsYXN0TW91 c2VQb3NpdGlvbi55KSk7CiAKICAgICBpZiAoKGRyYWdNb2RlICYmICFyZXBsYXlpbmdTYXZlZEV2 ZW50cykgfHwgbXNnUXVldWVbZW5kT2ZRdWV1ZV0uZGVsYXkpIHsKICAgICAgICAgbXNnUXVldWVb ZW5kT2ZRdWV1ZSsrXS5tc2cgPSBtc2c7CkBAIC00NjIsOSArNDk0LDkgQEAgc3RhdGljIEpTVmFs dWVSZWYga2V5RG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBm dW5jdGlvbiwgSlMKICAgICAgICAgICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1vZGlmaWVy c0NvdW50OyArK2kpIHsKICAgICAgICAgICAgICAgICAgICAgSlNWYWx1ZVJlZiB2YWx1ZSA9IEpT T2JqZWN0R2V0UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIG1vZGlmaWVyc0FycmF5LCBpLCAwKTsK ICAgICAgICAgICAgICAgICAgICAgSlNTdHJpbmdSZWYgc3RyaW5nID0gSlNWYWx1ZVRvU3RyaW5n Q29weShjb250ZXh0LCB2YWx1ZSwgMCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChKU1N0cmlu Z0lzRXF1YWxUb1VURjhDU3RyaW5nKHN0cmluZywgImN0cmxLZXkiKSkKKyAgICAgICAgICAgICAg ICAgICAgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAiY3RybEtleSIp IHx8IEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAiYWRkU2VsZWN0aW9uS2V5 IikpCiAgICAgICAgICAgICAgICAgICAgICAgICBuZXdLZXlTdGF0ZVtWS19DT05UUk9MXSA9IDB4 ODA7Ci0gICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENT dHJpbmcoc3RyaW5nLCAic2hpZnRLZXkiKSkKKyAgICAgICAgICAgICAgICAgICAgZWxzZSBpZiAo SlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhzdHJpbmcsICJzaGlmdEtleSIpIHx8IEpTU3Ry aW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAicmFuZ2VTZWxlY3Rpb25LZXkiKSkKICAg ICAgICAgICAgICAgICAgICAgICAgIG5ld0tleVN0YXRlW1ZLX1NISUZUXSA9IDB4ODA7CiAgICAg ICAgICAgICAgICAgICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3Ry aW5nLCAiYWx0S2V5IikpCiAgICAgICAgICAgICAgICAgICAgICAgICBuZXdLZXlTdGF0ZVtWS19N RU5VXSA9IDB4ODA7Ci0tIAoxLjYuMS4yCgo=